Changes in rtc-sun6i.c

8c28c499 - rtc: use boolean values with device_init_wakeup()

Tue, 17 Dec 2024 07:13:26 +0000

rtc: use boolean values with device_init_wakeup()device_init_wakeup() second argument is a bool type. Use proper booleanvalues when calling it to match the type and to produce unambiguous codewhich is easier to understand.Signed-off-by: Wolfram Sang Reviewed-by: Charles Keepax Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

80bf13c0 - rtc: sun6i: disable automatic clock input switching

Tue, 30 Jul 2024 19:49:05 +0000

rtc: sun6i: disable automatic clock input switchingThe V3(s) will detect a valid external low frequency clock and if it isnot present will automatically switch to the internal one. This mighthide bugs and (hardware) configuration errors. It's even worse becausethe internal RTC runs significantly slower (32.000Hz vs 32.768Hz).Fortunately for us, the V3(s) has an (undocumented) bypass of thisswitching and the driver already supports it by setting the.has_auto_swt flag.Signed-off-by: Michael Walle Acked-by: Chen-Yu Tsai Link: https://lore.kernel.org/r/20240730194905.2587202-1-mwalle@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

94ec1f06 - rtc: sun6i: remove unnecessary message

Sun, 27 Aug 2023 22:16:40 +0000

rtc: sun6i: remove unnecessary messageThe core already print a message once the rtc is successfully registered,it is not necessary to print an other one.Acked-by: Jernej Skrabec Link: https://lore.kernel.org/r/20230827221643.544259-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

48144c28 - rtc: Explicitly include correct DT includes

Mon, 24 Jul 2023 20:54:54 +0000

rtc: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230724205456.767430-1-robh@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

bd0a601f - rtc: sun6i: Add a determine_rate hook

Fri, 05 May 2023 11:25:47 +0000

rtc: sun6i: Add a determine_rate hookThe Allwinner sun6i RTC clock implements a mux with a set_parent hook,but doesn't provide a determine_rate implementation.This is a bit odd, since set_parent() is there to, as its name implies,change the parent of a clock. However, the most likely candidates totrigger that parent change are either the assigned-clock-parents devicetree property or a call to clk_set_rate(), with determine_rate()figuring out which parent is the best suited for a given rate.The other trigger would be a call to clk_set_parent(), but it's far lessused, and it doesn't look like there's any obvious user for that clock.Similarly, it doesn't look like the device tree using that clock driveruses any of the assigned-clock properties on that clock.So, the set_parent hook is effectively unused, possibly because of anoversight. However, it could also be an explicit decision by theoriginal author to avoid any reparenting but through an explicit call toclk_set_parent().The latter case would be equivalent to setting the determine_rateimplementation to clk_hw_determine_rate_no_reparent(). Indeed, if nodetermine_rate implementation is provided, clk_round_rate() (throughclk_core_round_rate_nolock()) will call itself on the parent ifCLK_SET_RATE_PARENT is set, and will not change the clock rateotherwise.And if it was an oversight, then we are at least explicit about ourbehavior now and it can be further refined down the line.Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: Chen-Yu Tsai Cc: Jernej Skrabec Cc: Samuel Holland Cc: linux-arm-kernel@lists.infradead.orgCc: linux-rtc@vger.kernel.orgCc: linux-sunxi@lists.linux.devSigned-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20221018-clk-range-checks-fixes-v4-45-971d5077e7d2@cerno.techAcked-by: Jernej Skrabec Signed-off-by: Stephen Boyd List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

4d9890ac - rtc: sun6i: Use of_property_present() for testing DT property presence

Fri, 10 Mar 2023 14:47:36 +0000

rtc: sun6i: Use of_property_present() for testing DT property presenceIt is preferred to use typed property access functions (i.e.of_property_read_ functions) rather than low-levelof_get_property/of_find_property functions for reading properties. Aspart of this, convert of_get_property/of_find_property calls to therecently added of_property_present() helper when we just want to testfor presence of a property and nothing more.Signed-off-by: Rob Herring Reviewed-by: Jernej Skrabec Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20230310144736.1547041-1-robh@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

344f4030 - rtc: sun6i: Always export the internal oscillator

Thu, 29 Dec 2022 21:53:19 +0000

rtc: sun6i: Always export the internal oscillatorOn all variants of the hardware, the internal oscillator is one possibleparent for the AR100 clock. It needs to be exported so we can model thatrelationship correctly in the devicetree.Fixes: c56afc1844d6 ("rtc: sun6i: Expose internal oscillator through device tree")Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Link: https://lore.kernel.org/r/20221229215319.14145-1-samuel@sholland.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

b9d98238 - rtc: sun6i: add support for R329 RTC

Sun, 26 Jun 2022 04:27:56 +0000

rtc: sun6i: add support for R329 RTCAllwinner R329 has a RTC with a similar time storage with H616 but aslightly different clock part.As we have already handled the R329 RTC clocks in the CCU driver, add acompatible string to RTC driver to allow probing of the RTC.Signed-off-by: Icenowy Zheng Signed-off-by: Samuel Holland Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner Reviewed-by: Jernej Skrabec Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220626042756.58961-1-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

581d6d8f - rtc: sun6i: Add NVMEM provider

Wed, 13 Apr 2022 23:17:30 +0000

rtc: sun6i: Add NVMEM providerThe sun6i RTC provides 32 bytes of general-purpose data registers.They can be used to save data in the always-on RTC power domain.The registers are writable via 32-bit MMIO accesses only.Expose them with a NVMEM provider so they can be used by other drivers.Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220413231731.56709-1-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

60d9f050 - Revert "clk: sunxi-ng: sun6i-rtc: Add support for H6"

Wed, 11 May 2022 20:02:06 +0000

Revert "clk: sunxi-ng: sun6i-rtc: Add support for H6"This reverts commit 1738890a3165ccd0da98ebd3e2d5f9b230d5afa8.Commit 1738890a3165 ("clk: sunxi-ng: sun6i-rtc: Add support for H6")breaks HDMI output on Tanix TX6 mini board. Exact reason isn't known,but because that commit doesn't actually improve anything, let's justrevert it.Cc: stable@vger.kernel.orgSigned-off-by: Jernej Skrabec Link: https://lore.kernel.org/r/20220511200206.2458274-1-jernej.skrabec@gmail.comSigned-off-by: Stephen Boyd List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

1738890a - clk: sunxi-ng: sun6i-rtc: Add support for H6

Thu, 03 Feb 2022 02:17:36 +0000

clk: sunxi-ng: sun6i-rtc: Add support for H6H6 supports IOSC calibration and an ext-osc32k input. Unlike newer SoCs,it has a single parent for its fanout clock.Add support for H6 in the CCU driver, replacing the support in theexisting early OF clock provider.Signed-off-by: Samuel Holland Acked-by: Stephen Boyd Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220203021736.13434-7-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

d91612d7 - clk: sunxi-ng: Add support for the sun6i RTC clocks

Thu, 03 Feb 2022 02:17:35 +0000

clk: sunxi-ng: Add support for the sun6i RTC clocksThe RTC power domain in sun6i and newer SoCs manages the 16 MHz RCoscillator (called "IOSC" or "osc16M") and the optional 32 kHz crystaloscillator (called "LOSC" or "osc32k"). Starting with the H6, this powerdomain also handles the 24 MHz DCXO (called variously "HOSC", "dcxo24M",or "osc24M") as well. The H6 also adds a calibration circuit for IOSC.Later SoCs introduce further variations on the design: - H616 adds an additional mux for the 32 kHz fanout source. - R329 adds an additional mux for the RTC timekeeping clock, a clock for the SPI bus between power domains inside the RTC, and removes the IOSC calibration functionality.Take advantage of the CCU framework to handle this increased complexity.This driver is intended to be a drop-in replacement for the existing RTCclock provider. So some runtime adjustment of the clock parents isneeded, both to handle hardware differences, and to support the oldbinding which omitted some of the input clocks.Signed-off-by: Samuel Holland Acked-by: Stephen Boyd Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220203021736.13434-6-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

8a937203 - rtc: sun6i: Add Allwinner H616 support

Fri, 11 Feb 2022 12:26:31 +0000

rtc: sun6i: Add Allwinner H616 supportThe H616 RTC changes its day storage to the newly introduced linear dayscheme, so pair the new compatible string with this feature flag.The RTC clock parts are handled in a separate driver now, so we skipthe clock parts in this driver completely.Signed-off-by: Andre Przywara Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220211122643.1343315-7-andre.przywara@arm.com List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

7878fec4 - rtc: sun6i: Add support for broken-down alarm registers

Fri, 11 Feb 2022 12:26:30 +0000

rtc: sun6i: Add support for broken-down alarm registersNewer versions of the Allwinner RTC, for instance as found in the H616SoC, not only store the current day as a linear number, but also changethe way the alarm is handled: There are now two registers, thatexplicitly store the wakeup time, in the same format as the currenttime.Add support for that variant by writing the requested wakeup timedirectly into the registers, instead of programming the seconds left, asthe old SoCs required.Reviewed by: Jernej Skrabec Signed-off-by: Andre Przywara Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220211122643.1343315-6-andre.przywara@arm.com List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

648c151a - rtc: sun6i: Add support for linear day storage

Fri, 11 Feb 2022 12:26:29 +0000

rtc: sun6i: Add support for linear day storageNewer versions of the Allwinner RTC, as for instance found in the H616SoC, no longer store a broken-down day/month/year representation in theRTC_DAY_REG, but just a linear day number.The user manual does not give any indication about the expected epochtime of this day count, but the BSP kernel uses the UNIX epoch, whichallows easy support due to existing conversion functions in the kernel.Allow tagging a compatible string with a flag, and use that to markthose new RTCs. Then convert between a UNIX day number (converted intoseconds) and the broken-down day representation using mktime64() andtime64_to_tm() in the set_time/get_time functions.That enables support for the RTC in those new chips.Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220211122643.1343315-5-andre.przywara@arm.com List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

9f6cd82e - rtc: sun6i: Fix time overflow handling

Fri, 11 Feb 2022 12:26:28 +0000

rtc: sun6i: Fix time overflow handlingUsing "unsigned long" for UNIX timestamps is never a good idea, andcomparing the value of such a variable against U32_MAX does not doanything useful on 32-bit systems.Use the proper time64_t type when dealing with timestamps, and avoidcutting down the time range unnecessarily. This also fixes the flawedcheck for the alarm time being too far into the future.The check for this condition is actually somewhat theoretical, as theRTC counts till 2033 only anyways, and 2^32 seconds from now is notbefore the year 2157 - at which point I hope nobody will be using thishardware anymore.Signed-off-by: Andre Przywara Reviewed-by: Jernej Skrabec Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220211122643.1343315-4-andre.przywara@arm.com List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

2ca03e29 - rtc: sun6i: Enable the bus clock when provided

Thu, 03 Feb 2022 02:17:33 +0000

rtc: sun6i: Enable the bus clock when providedH6 and newer variants of the RTC hardware have a bus clock gate in thePRCM CCU. This was not known at the time H6 support was added, so it wasnot included in the H6 RTC binding, nor in the H6 PRCM CCU driver. Nowthat this clock gate is documented, it is included in the A100 and D1PRCM CCU drivers. Therefore, the RTC driver needs to have a consumer forthe clock gate to prevent Linux from disabling it.Patch-changes: 3 - New patch for compatibility with new CCU driversSigned-off-by: Samuel Holland Reviewed-by: Maxime Ripard Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220203021736.13434-4-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

814691c7 - rtc: sun6i: Allow probing without an early clock provider

Tue, 28 Sep 2021 08:03:32 +0000

rtc: sun6i: Allow probing without an early clock providerSome SoCs have an RTC supported by this RTC driver, but do not have anearly clock provider declared here. Currently, this prevents the RTCdriver from probing, because it expects a global struct to already beallocated. Fix probing the driver by copying the missing pieces from theclock provider setup function, replacing them with the devm variants.Signed-off-by: Samuel Holland Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210928080335.36706-7-samuel@sholland.org List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c

28d21191 - rtc: sun6i: Fix memleak in sun6i_rtc_clk_init

Tue, 20 Oct 2020 06:12:26 +0000

rtc: sun6i: Fix memleak in sun6i_rtc_clk_initWhen clk_hw_register_fixed_rate_with_accuracy() fails,clk_data should be freed. It's the same for the subsequenttwo error paths, but we should also unregister the alreadyregistered clocks in them.Signed-off-by: Dinghao Liu Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201020061226.6572-1-dinghao.liu@zju.edu.cn List of files: /linux-6.15/drivers/rtc/rtc-sun6i.c