Changes in rtc-r9701.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

35331b50 - rtc: r9701: set range

Thu, 15 Oct 2020 19:11:35 +0000

rtc: r9701: set rangeSet range and remove the set_time check. This is a classic BCD RTC.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-6-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

dfe13cf2 - rtc: r9701: convert to devm_rtc_allocate_device

Thu, 15 Oct 2020 19:11:34 +0000

rtc: r9701: convert to devm_rtc_allocate_deviceThis allows further improvement of the driver.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-5-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

8b341349 - rtc: r9701: stop setting RWKCNT

Thu, 15 Oct 2020 19:11:33 +0000

rtc: r9701: stop setting RWKCNTtm_wday is never checked for validity and it is not read back inr9701_get_datetime. Avoid setting it to stop tripping static checkers: drivers/rtc/rtc-r9701.c:109 r9701_set_datetime() error: undefined (user controlled) shift '1 << dt->tm_wday'Reported-by: Dan Carpenter Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

2a8f3380 - rtc: r9701: remove useless memset

Thu, 15 Oct 2020 19:11:32 +0000

rtc: r9701: remove useless memsetThe RTC core already sets to zero the struct rtc_tie it passes to thedriver, avoid doing it a second time.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-3-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

7390bec4 - rtc: r9701: stop setting a default time

Thu, 15 Oct 2020 19:11:31 +0000

rtc: r9701: stop setting a default timeIt doesn't make sense to set the RTC to a default value at probe time. Letthe core handle invalid date and time.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-2-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

92c6dcfb - rtc: r9701: remove leftover comment

Thu, 15 Oct 2020 19:11:30 +0000

rtc: r9701: remove leftover commentCommit 22652ba72453 ("rtc: stop validating rtc_time in .read_time") removedthe code but not the associated comment.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201015191135.471249-1-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

22652ba7 - rtc: stop validating rtc_time in .read_time

Mon, 19 Feb 2018 15:23:56 +0000

rtc: stop validating rtc_time in .read_timeThe RTC core is always calling rtc_valid_tm after the read_time callback.It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

5c6e5eca - rtc: r9701: Remove r9701_remove function

Sat, 18 Nov 2017 02:03:10 +0000

rtc: r9701: Remove r9701_remove functionr9701_remove function is now empty, remove it.Signed-off-by: Nobuhiro Iwamatsu Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

3821a065 - spi: Drop owner assignment from spi_drivers

Fri, 23 Oct 2015 13:59:11 +0000

spi: Drop owner assignment from spi_driversAn spi_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Andrew F. Davis Acked-by: Jonathan Cameron Signed-off-by: Mark Brown List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

fbf52c0d - rtc: rtc-r9701: use spi_set_drvdata()

Mon, 29 Apr 2013 23:20:19 +0000

rtc: rtc-r9701: use spi_set_drvdata()Use the wrapper functions for getting and setting the driver data usingspi_device instead of using dev_{get|set}_drvdata with &spi->dev, so wecan directly pass a struct spi_device.Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

9b6d955a - rtc: rtc-r9701: use devm_rtc_device_register()

Mon, 29 Apr 2013 23:19:45 +0000

rtc: rtc-r9701: use devm_rtc_device_register()devm_rtc_device_register() is device managed and makes cleanup pathssimpler.Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

5a167f45 - Drivers: rtc: remove __dev* attributes.

Fri, 21 Dec 2012 21:09:38 +0000

Drivers: rtc: remove __dev* attributes.CONFIG_HOTPLUG is going away as an option. As a result, the __dev*markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by mein order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton Cc: Alessandro Zummo Cc: Srinidhi Kasagar Cc: Linus Walleij Cc: Mike Frysinger Cc: Wan ZongShun Cc: Guan Xuetao Cc: Mark Brown Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

8e74b6ed - drivers/rtc/rtc-r9701.c: check that r9701_set_datetime() succeeded

Mon, 30 Jul 2012 21:41:47 +0000

drivers/rtc/rtc-r9701.c: check that r9701_set_datetime() succeededWhen the driver detects that the clock time is invalid, it attempts towrite a sane time into the hardware. We curently assume that everythingis OK if those writes succeeded. But it is better to re-read the timefrom the hardware to ensure that the new settings got there OK.Cc: Devendra Naga Cc: Alessandro Zummo Cc: Anatolij Gustschin Cc: Andreas Dumberger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

aa11ec59 - drivers/rtc/rtc-r9701.c: avoid second call to rtc_valid_tm()

Mon, 30 Jul 2012 21:41:45 +0000

drivers/rtc/rtc-r9701.c: avoid second call to rtc_valid_tm()r9701_get_datetime() calls rtc_valid_tm() and returns the value returnedby rtc_valid_tm(), which can be used in the `if', so callingrtc_valid_tm() a second time is not required.Signed-off-by: Devendra Naga Cc: Alessandro Zummo Cc: Anatolij Gustschin Cc: Andreas Dumberger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

bb58da08 - drivers/rtc/rtc-r9701.c: reset registers if invalid values are detected

Thu, 12 Apr 2012 19:49:12 +0000

drivers/rtc/rtc-r9701.c: reset registers if invalid values are detectedhwclock refuses to set date/time if RTC registers contain invalidvalues. Check the date/time register values at probe time andinitialize them to make hwclock happy.Signed-off-by: Andreas Dumberger Signed-off-by: Anatolij Gustschin Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

109e9418 - rtc: convert rtc spi drivers to module_spi_driver

Fri, 23 Mar 2012 22:02:30 +0000

rtc: convert rtc spi drivers to module_spi_driverFactor out some boilerplate code for spi driver registration intomodule_spi_driver.Signed-off-by: Axel Lin Cc: Mark Jackson Cc: Dennis Aberilla Cc: Nikolaus Voss Cc: "Kim B. Heino" Cc: Raphael Assenat Cc: Chris Verges Cc: Magnus Damm Cc: Atsushi Nemoto Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

73737b87 - drivers/rtc/rtc-r9701.c: fix crash in r9701_remove()

Mon, 05 Mar 2012 22:59:16 +0000

drivers/rtc/rtc-r9701.c: fix crash in r9701_remove()If probing the RTC didn't succeed due to failed RTC register access, theRTC device will be unregistered. Then, when removing the moduler9701_remove() causes a kernel crash while trying to unregister a notregistered RTC device. Fix this by doing RTC register access test beforeRTC device registration.Signed-off-by: Anatolij Gustschin Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c

e0626e38 - spi: prefix modalias with "spi:"

Tue, 22 Sep 2009 23:46:08 +0000

spi: prefix modalias with "spi:"This makes it consistent with other buses (platform, i2c, vio, ...). I'mnot sure why we use the prefixes, but there must be a reason.This was easy enough to do it, and I did it.Signed-off-by: Anton Vorontsov Cc: David Brownell Cc: David Woodhouse Cc: Grant Likely Cc: Jean Delvare Cc: Ben Dooks Cc: Benjamin Herrenschmidt Cc: Dmitry Torokhov Cc: Samuel Ortiz Cc: "John W. Linville" Acked-by: Mike Frysinger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-r9701.c