Changes in rtc-pcf2127.c

97274527 - rtc: pcf2127: add BSM support

Mon, 27 Jan 2025 16:27:28 +0000

rtc: pcf2127: add BSM supportThe pcf2127 encodes BSM, BLD and power fail detection in the same set ofbits so it is necessary to do some calculation when changing BSM to keepthe rest of the configuration as-is. However, when BSM is disabled, thereis no configuration with BLD enabled so this will be lost when coming backto a mode with BSM enabled.Link: https://lore.kernel.org/r/20250127162728.86234-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

eeeb7771 - rtc: pcf2127: remove useless check

Sun, 27 Aug 2023 21:46:49 +0000

rtc: pcf2127: remove useless checkThis check is only useful when introducing support for a new RTC in thedriver. Cut down the number of strings in th driver.Link: https://lore.kernel.org/r/20230827214649.537095-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

58dffa96 - rtc: pcf2127: remove unused function argument

Tue, 01 Aug 2023 19:04:32 +0000

rtc: pcf2127: remove unused function argumentFixes the following W=1 kernel build warning(s):drivers/rtc/rtc-pcf2127.c: In function ‘pcf2127_probe’:drivers/rtc/rtc-pcf2127.c:635:32: warning: unused parameter ‘name’ [-Wunused-parameter] 635 | int alarm_irq, const char *name, bool is_pcf2127) | ~~~~~~~~~~~~^~~~Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230801190432.3340545-1-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

e4163fc5 - rtc: pcf2127: add error checking when disabling POR0

Fri, 28 Jul 2023 17:12:12 +0000

rtc: pcf2127: add error checking when disabling POR0If PCF2127 device is absent from the I2C bus, or if there is acommunication problem, disabling POR0 may fail silently and westill continue with probing the device. In that case, abort probeoperation.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230728171211.3016019-1-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

4e5eb7ef - rtc: pcf2127: fix error code in pcf2127_enable_ts()

Mon, 31 Jul 2023 14:09:30 +0000

rtc: pcf2127: fix error code in pcf2127_enable_ts()This error path accidentally returns success. Return -EINVAL instead.Fixes: 420cc9e850db ("rtc: pcf2127: add support for multiple TS functions")Signed-off-by: Dan Carpenter Reviewed-by: Bruno Thomsen Reviewed-by: Hugo Villeneuve Reviewed-by: Hugo Villeneuve Link: https://lore.kernel.org/r/55b9c84b-9d21-444f-b91a-cf9316b65833@moroto.mountainSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

e9a5a1b4 - rtc: pcf2127: add UIE support for PCF2131

Thu, 22 Jun 2023 14:57:59 +0000

rtc: pcf2127: add UIE support for PCF2131The PCF2127/29 do NOT support alarms with a 1 second resolution, butthe PCF2131 does.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-17-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

081602a1 - rtc: pcf2127: add flag for watchdog register value read support

Thu, 22 Jun 2023 14:57:58 +0000

rtc: pcf2127: add flag for watchdog register value read supportThe watchdog value register cannot be read on the PCF2131 after beingset.Add a new flag to identify which variant has read access to thisregister, and use this flag to selectively test if watchdog timer wasstarted by bootloader.Signed-off-by: Hugo Villeneuve Reviewed-by: Bruno Thomsen Link: https://lore.kernel.org/r/20230622145800.2442116-16-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

adb9675d - rtc: pcf2127: support generic watchdog timing configuration

Thu, 22 Jun 2023 14:57:57 +0000

rtc: pcf2127: support generic watchdog timing configurationIntroduce in the configuration structure two new values to hold thewatchdog clock source and the min_hw_heartbeat_ms value.The minimum and maximum timeout values are automatically computed fromthe watchdog clock source value for each variant.The PCF2131 has no 1Hz watchdog clock source, as is the case forPCF2127/29.The next best choice is using a 1/4Hz clock, giving a watchdog timeoutrange between 4 and 1016s. By using the same register configuration asfor the PCF2127/29, the 1/4Hz clock source is selected.Note: the PCF2127 datasheet gives a min/max range between 1 and 255s,but it should be between 2 and 254s, because the watchdog is triggeredwhen the timer value reaches 1, not 0.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-15-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

3d715eba - rtc: pcf2127: adapt time/date registers write sequence for PCF2131

Thu, 22 Jun 2023 14:57:56 +0000

rtc: pcf2127: adapt time/date registers write sequence for PCF2131The sequence for updating the time/date registers is slightlydifferent between PCF2127/29 and PCF2131.For PCF2127/29, during write operations, the time countingcircuits (memory locations 03h through 09h) are automatically blocked.For PCF2131, time/date registers write access requires setting theSTOP bit and sending the clear prescaler instruction (CPR). STOP thenneeds to be released once write operation is completed.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-14-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

e1849b8f - rtc: pcf2127: add support for PCF2131 interrupts on output INT_A

Thu, 22 Jun 2023 14:57:55 +0000

rtc: pcf2127: add support for PCF2131 interrupts on output INT_AThe PCF2127 and PCF2129 have one output interrupt pin. The PCF2131 hastwo, named INT_A and INT_B. The hardware support that any interruptsource can be routed to either one or both of them.Force all interrupt sources to go to the INT A pin.Support to route any interrupt source to INT A/B pins is not supportedby this driver at the moment.Signed-off-by: Hugo Villeneuve Reviewed-by: Bruno Thomsen Link: https://lore.kernel.org/r/20230622145800.2442116-13-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

afc505bf - rtc: pcf2127: add support for PCF2131 RTC

Thu, 22 Jun 2023 14:57:54 +0000

rtc: pcf2127: add support for PCF2131 RTCThis RTC is very similar in functionality to the PCF2127/29.Basically it: -supports two new control registers at offsets 4 and 5 -supports a new reset register (not implemented in this driver) -supports 4 tamper detection functions instead of 1 -has no nvmem (like the PCF2129) -has two output interrupt pinsBecause of that, most of the register addresses are very different,although they still follow the same layout. For example, the tamperregisters have a different base address, but the offsets are all the same.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-12-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

420cc9e8 - rtc: pcf2127: add support for multiple TS functions

Thu, 22 Jun 2023 14:57:53 +0000

rtc: pcf2127: add support for multiple TS functionsThis will simplify the implementation of new variants into this driver.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-11-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

fc16599e - rtc: pcf2127: adapt for CLKOUT register at any offset

Thu, 22 Jun 2023 14:57:52 +0000

rtc: pcf2127: adapt for CLKOUT register at any offsetThis will simplify the implementation of new variants into this driver.Signed-off-by: Hugo Villeneuve Reviewed-by: Bruno Thomsen Link: https://lore.kernel.org/r/20230622145800.2442116-10-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

6b57ec29 - rtc: pcf2127: adapt for WD registers at any offset

Thu, 22 Jun 2023 14:57:51 +0000

rtc: pcf2127: adapt for WD registers at any offsetThis will simplify the implementation of new variants into this driver.Signed-off-by: Hugo Villeneuve Reviewed-by: Bruno Thomsen Tested-by: Bruno Thomsen Link: https://lore.kernel.org/r/20230622145800.2442116-9-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

7c6f0db4 - rtc: pcf2127: adapt for alarm registers at any offset

Thu, 22 Jun 2023 14:57:50 +0000

rtc: pcf2127: adapt for alarm registers at any offsetThis will simplify the implementation of new variants into this driver.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-8-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

6211acee - rtc: pcf2127: adapt for time/date registers at any offset

Thu, 22 Jun 2023 14:57:49 +0000

rtc: pcf2127: adapt for time/date registers at any offsetThis will simplify the implementation of new variants into this driver.Some variants (PCF2131) have a 100th seconds register. This register iscurrently not supported in this driver.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-7-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

fd28ceb4 - rtc: pcf2127: add variant-specific configuration structure

Thu, 22 Jun 2023 14:57:48 +0000

rtc: pcf2127: add variant-specific configuration structureCreate variant-specific configuration structures to simplify theimplementation of new variants into this driver. It will also avoidto have too many tests for a specific variant, or a list of variantsfor new devices, inside the code itself.Add configuration options for the support of the NVMEM, bit CD0 inregister WD_CTL as well as the maximum number of registers for eachvariant, instead of hardcoding the variant (PCF2127) inside thei2c_device_id and spi_device_id structures.Also specify a different maximum number of registers (max_register)for the PCF2129.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-6-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

0476b6c8 - rtc: pcf2127: remove superfluous comments

Thu, 22 Jun 2023 14:57:47 +0000

rtc: pcf2127: remove superfluous commentsNoted while reviewing new PCF2131 driver.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-5-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

3d740c64 - rtc: pcf2127: lower message severity if setting time fails

Thu, 22 Jun 2023 14:57:46 +0000

rtc: pcf2127: lower message severity if setting time failsNoted while reviewing new PCF2131 driver.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-4-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c

720fb4b8 - rtc: pcf2127: improve timestamp reading performance

Thu, 22 Jun 2023 14:57:45 +0000

rtc: pcf2127: improve timestamp reading performanceReading the 7 timetamp registers currently involves reading 25 registerssolely to be able to print the content of the three control registers,in addition to the 7 timestamp registers. This print never occurs,unless the user enables dynamic debug in this driver or setCONFIG_RTC_DEBUG.Reading the timestamp registers should consist of reading 7consecutive timestamp registers.This patch optimize the performance of reading the timestamp registersby reading 7 consecutive registers instead of 25, and dropping theprint of the control registers.Signed-off-by: Hugo Villeneuve Link: https://lore.kernel.org/r/20230622145800.2442116-3-hugo@hugovil.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2127.c