Changes in rtc-pcf2123.c

5434a4e4 - rtc: pcf2123: use IRQ flags obtained from fwnode

Mon, 23 Jan 2023 20:02:10 +0000

rtc: pcf2123: use IRQ flags obtained from fwnodeAllow the IRQ type to be passed from the device tree if available as theremay be components changing the trigger type of the interrupt between theRTC and the IRQ controller.Link: https://lore.kernel.org/r/20230123200217.1236011-5-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

c7e91f7c - rtc: pcf2123: set RTC_FEATURE_ALARM_RES_MINUTE

Wed, 09 Mar 2022 16:22:40 +0000

rtc: pcf2123: set RTC_FEATURE_ALARM_RES_MINUTEAlarms have a resolution of a minute.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220309162301.61679-9-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

fff36f79 - rtc: pcf2123: switch to RTC_FEATURE_UPDATE_INTERRUPT

Wed, 09 Mar 2022 16:22:39 +0000

rtc: pcf2123: switch to RTC_FEATURE_UPDATE_INTERRUPTStop using uie_unsupported and clear RTC_FEATURE_UPDATE_INTERRUPT instead.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220309162301.61679-8-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

5f84478e - rtc: pcf2123: Add SPI ID table

Thu, 23 Sep 2021 19:49:22 +0000

rtc: pcf2123: Add SPI ID tableCurrently autoloading for SPI devices does not use the DT ID table, it usesSPI modalises. Supporting OF modalises is going to be difficult if notimpractical, an attempt was made but has been reverted, so ensure thatmodule autoloading works for this driver by adding an id_table listing theSPI IDs for everything.Fixes: 96c8395e2166 ("spi: Revert modalias changes")Signed-off-by: Mark Brown Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210923194922.53386-4-broonie@kernel.org List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

a82430fd - rtc: pcf2123: use rtc_lock/rtc_unlock

Tue, 19 Jan 2021 22:06:48 +0000

rtc: pcf2123: use rtc_lock/rtc_unlockAvoid accessing directly rtc->ops_lock and use the RTC core helpers.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210119220653.677750-10-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

cb36cf80 - rtc: pcf2123: add proper compatible string

Mon, 19 Aug 2019 18:26:56 +0000

rtc: pcf2123: add proper compatible stringnxp,rtc-pcf2123 is not a proper compatible strong for this RTC. The partname is only pcf2123 and is less confusing.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-9-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

d5b626e1 - rtc: pcf2123: let the core handle range offsetting

Mon, 19 Aug 2019 18:26:55 +0000

rtc: pcf2123: let the core handle range offsettingSet the RTC range properly and use the core windowing and offsetting to(unfortunately) map back to a 1970-2069 range.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-8-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

935a7f45 - rtc: pcf2123: convert to devm_rtc_allocate_device

Mon, 19 Aug 2019 18:26:54 +0000

rtc: pcf2123: convert to devm_rtc_allocate_deviceThis allows further improvement of the driver. Also remove the unecessaryerror string as the core will already display error messages.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-7-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

9a5aeaad - rtc: pcf2123: remove useless error path goto

Mon, 19 Aug 2019 18:26:53 +0000

rtc: pcf2123: remove useless error path gotokfree_exit only returns ret, remove it. This also fixes thedevm_regmap_init_spi error case where the probe wouldn't actually failbecause ret is initialized to 0.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-6-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

9126a2b1 - rtc: pcf2123: rename struct and variables

Mon, 19 Aug 2019 18:26:52 +0000

rtc: pcf2123: rename struct and variablesRename struct pcf2123_plat_data to struct pcf2123_data and pdata topcf2123 to make the driver use a more common subsystem style.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-5-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

d3bad602 - rtc: pcf2123: stop using dev.platform_data

Mon, 19 Aug 2019 18:26:51 +0000

rtc: pcf2123: stop using dev.platform_dataplatform_data is for platform specific data, use driver_data instead.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-4-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

577f6482 - rtc: pcf2123: implement .alarm_irq_enable

Mon, 19 Aug 2019 18:26:50 +0000

rtc: pcf2123: implement .alarm_irq_enableImplement .alarm_irq_enable so it is possible to use RTC_ALM_SET,RTC_AIE_ON and RTC_AIE_OFF.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-3-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

d0ce6ef7 - rtc; pcf2123: fix possible alarm race condition

Mon, 19 Aug 2019 18:26:49 +0000

rtc; pcf2123: fix possible alarm race conditionClear the flag after disabling the alarm to ensure the alarm doesn't firebetween clearing the flag and disabling the alarm.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-2-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

5bdf40da - rtc: pcf2123: don't use weekday alarm

Mon, 19 Aug 2019 18:26:48 +0000

rtc: pcf2123: don't use weekday alarmThe week day may not be set properly by userspace. This would result ismissed alarms. Disable alarm matching on weekday.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20190819182656.29744-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

fedc459a - rtc: pcf2123: fix negative offset rounding

Wed, 19 Jun 2019 13:17:53 +0000

rtc: pcf2123: fix negative offset roundingUsing result = (value + divisor/2) / divisor is rounding values up and onlyworks well for positive values. Instead use DIV_ROUND_CLOSEST which doesthe correct thing.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

e32e60a2 - rtc: pcf2123: add alarm support

Fri, 03 May 2019 19:52:12 +0000

rtc: pcf2123: add alarm supportAllows alarm to be controlled using, e.g., the RTC_WKALM_SET ioctl.Signed-off-by: Dylan Howey Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

c33850bb - rtc: pcf2123: use %ptR

Fri, 03 May 2019 19:52:12 +0000

rtc: pcf2123: use %ptRUse %ptR to print date in human readable format.Signed-off-by: Dylan Howey Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c

790d0339 - rtc: pcf2123: port to regmap

Fri, 03 May 2019 19:52:10 +0000

rtc: pcf2123: port to regmapAlso remove pcf2123_delay_trec. This claimed to add a 30ns delay to SPIwrites, but I could not see any reference to this requirement in thedatasheet. Closest thing I could find to a requirement are timings for theSPI chip enable line, which cannot be controlled by this driver (the ndelaycame after the call to spi_write_then_read, which means it would sleepafter CE has already gone inactive). Things seem to work fine without it.Signed-off-by: Dylan Howey Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-pcf2123.c