Changes in rtc-mpc5121.c

8c28c499 - rtc: use boolean values with device_init_wakeup()

Tue, 17 Dec 2024 07:13:26 +0000

rtc: use boolean values with device_init_wakeup()device_init_wakeup() second argument is a bool type. Use proper booleanvalues when calling it to match the type and to produce unambiguous codewhich is easier to understand.Signed-off-by: Wolfram Sang Reviewed-by: Charles Keepax Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

e5eab1ae - rtc: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:03 +0000

rtc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/rtc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20241007205803.444994-6-u.kleine-koenig@baylibre.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

86e9b508 - rtc: add missing MODULE_DESCRIPTION() macro

Sun, 09 Jun 2024 05:52:03 +0000

rtc: add missing MODULE_DESCRIPTION() macroOn x86, make allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/lib_test.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/rtc-goldfish.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/rtc-omap.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/rtc-rc5t583.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/rtc-tps65910.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/rtc/rtc-twl.oAdd the missing invocation of the MODULE_DESCRIPTION() macro to allfiles which have a MODULE_LICENSE(). This includes rtc-mpc5121.c,which does not produce a warning with the x86 allmodconfig since it isnot built for x86, but it may cause this warning with Freescale PPCconfigurations.Signed-off-by: Jeff Johnson Link: https://lore.kernel.org/r/20240608-md-drivers-rtc-v1-1-5f44222adfae@quicinc.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

48144c28 - rtc: Explicitly include correct DT includes

Mon, 24 Jul 2023 20:54:54 +0000

rtc: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230724205456.767430-1-robh@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

22edbc10 - rtc: mpc5121: Convert to platform remove callback returning void

Sat, 04 Mar 2023 13:30:04 +0000

rtc: mpc5121: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230304133028.2135435-18-u.kleine-koenig@pengutronix.deSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

14e6fc13 - rtc: mpc5121: switch to RTC_FEATURE_UPDATE_INTERRUPT

Wed, 09 Mar 2022 16:22:36 +0000

rtc: mpc5121: switch to RTC_FEATURE_UPDATE_INTERRUPTStop using uie_unsupported and clear RTC_FEATURE_UPDATE_INTERRUPT instead.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220309162301.61679-5-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

9597f8cc - rtc: mpc5121: let the core handle the alarm resolution

Wed, 09 Mar 2022 16:22:35 +0000

rtc: mpc5121: let the core handle the alarm resolutionSet RTC_FEATURE_ALARM_RES_MINUTE, so the core knows alarms have aresolution of a minute. Also, the core will properly round down the alarminstead of up.Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220309162301.61679-4-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

710e4a82 - rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()

Mon, 25 May 2020 01:39:48 +0000

rtc: mpc5121: Use correct return value for mpc5121_rtc_probe()When call function devm_platform_ioremap_resource(), we should use IS_ERR()to check the return value and return PTR_ERR() if failed.Signed-off-by: Tiezhu Yang Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/1590370788-15136-2-git-send-email-yangtiezhu@loongson.cn List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

3d5a4954 - rtc: mpc5121: switch to rtc_time64_to_tm/rtc_tm_to_time64

Fri, 06 Mar 2020 07:44:03 +0000

rtc: mpc5121: switch to rtc_time64_to_tm/rtc_tm_to_time64Call the 64bit versions of rtc_tm time conversion.Link: https://lore.kernel.org/r/20200306074404.58909-4-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

3905d1c0 - rtc: mpc5121: set range

Fri, 06 Mar 2020 07:44:02 +0000

rtc: mpc5121: set rangeThe datasheet states that 4052 is the maximum value for year. However, thempc5121 read_time and set_time function abuse the target time registerinstead of using the broken down time so it is limited to 2106.Link: https://lore.kernel.org/r/20200306074404.58909-3-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

fffbe10e - rtc: mpc5121: convert to devm_rtc_allocate_device

Fri, 06 Mar 2020 07:44:01 +0000

rtc: mpc5121: convert to devm_rtc_allocate_deviceThis simplifies the path for the rtc_ops selection.Link: https://lore.kernel.org/r/20200306074404.58909-2-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

d53d4ae9 - rtc: mpc5121: simplify probe

Fri, 06 Mar 2020 07:44:00 +0000

rtc: mpc5121: simplify probeUse devm managed function to simplify probe and remove.Link: https://lore.kernel.org/r/20200306074404.58909-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

ab62670e - rtc: stop validating rtc_time after rtc_time_to_tm

Mon, 19 Feb 2018 15:23:55 +0000

rtc: stop validating rtc_time after rtc_time_to_tmrtc_time_to_tm never generates an invalid tm. It is not necessary tovalidate it.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

73798d5c - rtc: Fix module autoload for OF platform drivers

Thu, 27 Aug 2015 11:52:02 +0000

rtc: Fix module autoload for OF platform driversThese platform drivers have a OF device ID table but the OF modulealias information is not created so module autoloading won't work.Signed-off-by: Javier Martinez Canillas Acked-by: Andrew Lunn Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

0929ae37 - rtc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:21:31 +0000

rtc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

a28885bc - rtc: make of_device_ids const

Mon, 13 Oct 2014 22:52:39 +0000

rtc: make of_device_ids constof_device_ids (i.e. compatible strings and the respective data) are notsupposed to change at runtime. All functions working with of_device_idsprovided by work with const of_device_ids. This allows tomark all struct of_device_id below drivers/rtc const, too.Signed-off-by: Uwe Kleine-König Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

5af50730 - drivers: clean-up prom.h implicit includes

Tue, 17 Sep 2013 19:28:33 +0000

drivers: clean-up prom.h implicit includesPowerpc is a mess of implicit includes by prom.h. Add the necessaryexplicit includes to drivers in preparation of prom.h cleanup.Signed-off-by: Rob Herring Acked-by: Grant Likely List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c

ad87a766 - drivers/rtc/rtc-mpc5121.c: use platform_{get,set}_drvdata()

Wed, 03 Jul 2013 22:07:47 +0000

drivers/rtc/rtc-mpc5121.c: use platform_{get,set}_drvdata()Use the wrapper functions for getting and setting the driver data usingplatform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,so we can directly pass a struct platform_device.Signed-off-by: Jingoo Han Cc: Grant Likely Cc: Rob Herring Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-mpc5121.c