Changes in rtc-meson-vrtc.c

38c7aaea - rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc member

Tue, 04 Mar 2025 17:05:37 +0000

rtc: meson-vrtc: drop needless struct meson_vrtc_data::rtc memberThe memory pointed to by the ::rtc member is managed via devres, andno code in this driver uses it past _probe().We can drop it from the structure and just use a local temporaryvariable, reducing runtime memory consumption by a few bytes.Signed-off-by: André Draszik Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-9-d4689a71668c@linaro.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

8c28c499 - rtc: use boolean values with device_init_wakeup()

Tue, 17 Dec 2024 07:13:26 +0000

rtc: use boolean values with device_init_wakeup()device_init_wakeup() second argument is a bool type. Use proper booleanvalues when calling it to match the type and to produce unambiguous codewhich is easier to understand.Signed-off-by: Wolfram Sang Reviewed-by: Charles Keepax Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

0e6255fa - rtc: meson-vrtc: Use ktime_get_real_ts64() to get the current time

Mon, 20 Mar 2023 21:21:42 +0000

rtc: meson-vrtc: Use ktime_get_real_ts64() to get the current timeThe VRTC alarm register can be programmed with an amount of secondsafter which the SoC will be woken up by the VRTC timer again. We arealready converting the alarm time from meson_vrtc_set_alarm() to"seconds since 1970". This means we also need to use "seconds since1970" for the current time.This fixes a problem where setting the alarm to one minute in the futureresults in the firmware (which handles wakeup) to output (on the serialconsole) that the system will be woken up in billions of seconds.ktime_get_raw_ts64() returns the time since boot, not since 1970. Switchto ktime_get_real_ts64() to fix the calculation of the alarm time and tomake the SoC wake up at the specified date/time. Also the firmware(which manages suspend) now prints either 59 or 60 seconds until wakeup(depending on how long it takes for the system to enter suspend).Fixes: 6ef35398e827 ("rtc: Add Amlogic Virtual Wake RTC")Signed-off-by: Martin Blumenstingl Reviewed-by: Neil Armstrong Reviewed-by: Kevin Hilman Link: https://lore.kernel.org/r/20230320212142.2355062-1-martin.blumenstingl@googlemail.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

9ce42e8e - rtc: meson: simplify the return expression of meson_vrtc_probe

Sat, 19 Sep 2020 10:08:56 +0000

rtc: meson: simplify the return expression of meson_vrtc_probeSimplify the return expression.Signed-off-by: Liu Shixin Signed-off-by: Alexandre Belloni Acked-by: Kevin Hilman Link: https://lore.kernel.org/r/20200919100856.1639319-1-liushixin2@huawei.com List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

b99a3120 - rtc: meson: mark PM functions as __maybe_unused

Fri, 06 Sep 2019 15:24:29 +0000

rtc: meson: mark PM functions as __maybe_unusedThe meson_vrtc_set_wakeup_time() function is only used bythe PM functions and causes a warning when they are disabled:drivers/rtc/rtc-meson-vrtc.c:32:13: error: unused function 'meson_vrtc_set_wakeup_time' [-Werror,-Wunused-function]Remove the #ifdef around the callers and add a __maybe_unusedannotation as a more reliable way to avoid these warnings.Signed-off-by: Arnd Bergmann Reviewed-by: Kevin Hilman Link: https://lore.kernel.org/r/20190906152438.1533833-1-arnd@arndb.deSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c

6ef35398 - rtc: Add Amlogic Virtual Wake RTC

Mon, 12 Aug 2019 23:28:50 +0000

rtc: Add Amlogic Virtual Wake RTCThe Amlogic Meson GX SoCs uses a special register to store thetime in seconds to wakeup after a system suspend.In order to be able to reuse the RTC wakealarm feature, thisdriver implements a fake RTC device which uses the system timeto deduce a suspend delay.Signed-off-by: Neil Armstrong [khilman: rebase to v5.3-rc, rework and modernization]Signed-off-by: Kevin Hilman Link: https://lore.kernel.org/r/20190812232850.8016-3-khilman@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-meson-vrtc.c