Changes in rtc-ds1343.c

5ad218f1 - rtc: ds1343: Use devm_pm_set_wake_irq

Wed, 05 Feb 2025 00:58:21 +0000

rtc: ds1343: Use devm_pm_set_wake_irqUse devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up.Signed-off-by: Peng Fan Link: https://lore.kernel.org/r/20250205-rtc-cleanup-v1-3-66165678e089@nxp.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

a0386bba - spi: make remove callback a void function

Sun, 23 Jan 2022 17:52:01 +0000

spi: make remove callback a void functionThe value returned by an spi driver's remove function is mostly ignored.(Only an error message is printed if the value is non-zero that theerror is ignored.)So change the prototype of the remove function to return no value. Thisway driver authors are not tempted to assume that passing an error tothe upper layer is a good idea. All drivers are adapted accordingly.There is no intended change of behaviour, all callbacks were prepared toreturn 0 before.Signed-off-by: Uwe Kleine-König Acked-by: Marc Kleine-Budde Acked-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Acked-by: Jérôme Pouiller Acked-by: Miquel Raynal Acked-by: Jonathan Cameron Acked-by: Claudius Heine Acked-by: Stefan Schmidt Acked-by: Alexandre Belloni Acked-by: Ulf Hansson # For MMCAcked-by: Marcus Folkesson Acked-by: Łukasz Stelmach Acked-by: Lee Jones Link: https://lore.kernel.org/r/20220123175201.34839-6-u.kleine-koenig@pengutronix.deSigned-off-by: Mark Brown List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

3a905c2d - rtc: add devm_ prefix to rtc_nvmem_register()

Mon, 09 Nov 2020 16:34:06 +0000

rtc: add devm_ prefix to rtc_nvmem_register()rtc_nvmem_register() is a managed interface. It doesn't require anyrelease function to be called at driver detach. To avoid confusingdriver authors, let's rename it to devm_rtc_nvmem_register() and add itto the list of managed interfaces in Documentation/.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-6-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

25ece305 - rtc: nvmem: remove nvram ABI

Mon, 09 Nov 2020 16:34:05 +0000

rtc: nvmem: remove nvram ABIThe nvram sysfs attributes have been deprecated at least since v4.13, morethan 3 years ago and nobody ever complained about the deprecation warning.Remove the sysfs attributes now.[Bartosz: remove the declaration of rtc_nvmem_unregister()]Signed-off-by: Alexandre Belloni Signed-off-by: Bartosz Golaszewski Link: https://lore.kernel.org/r/20201109163409.24301-5-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

d6e62e7f - rtc: ds1343: Remove unused struct spi_device in struct ds1343_priv

Wed, 18 Dec 2019 08:19:17 +0000

rtc: ds1343: Remove unused struct spi_device in struct ds1343_privstruct spi_device in struct ds1343_priv is not used, remove it.CC: Alessandro Zummo CC: Alexandre Belloni CC: Raghavendra Chandra Ganiga CC: Ankur Srivastava Signed-off-by: Nobuhiro Iwamatsu Link: https://lore.kernel.org/r/20191218081917.3308211-1-iwamatsu@nigauri.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

3b52093d - rtc: ds1343: Do not hardcode SPI mode flags

Wed, 04 Dec 2019 22:57:31 +0000

rtc: ds1343: Do not hardcode SPI mode flagsThe current use of mode flags to us SPI_MODE_3 andSPI_CS_HIGH is fragile: it overwrites anything alreadyassigned by the SPI core. Change it thusly:- Just |= the SPI_MODE_3 so we keep other flags- Assign ^= SPI_CS_HIGH since we might be active high already, and that is usually the case with GPIOs used for chip select, even if they are in practice active low.Add a comment clarifying why ^= SPI_CS_HIGH is the rightchoice here.Reported-by: Mark Brown Signed-off-by: Linus Walleij Link: https://lore.kernel.org/r/20191204225731.20306-1-linus.walleij@linaro.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

05df5572 - rtc: ds1343: cleanup .remove

Sat, 19 Oct 2019 20:49:41 +0000

rtc: ds1343: cleanup .removeIt is not necessary to call device_init_wakeup(dev, false) in .remove asdevice_del will take care of that. It is also not necessary todevm_free_irq. Finally, dev_pm_clear_wake_irq can be calledunconditionally.Link: https://lore.kernel.org/r/20191019204941.6203-9-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

0680a6cd - rtc: ds1343: rework interrupt handling

Sat, 19 Oct 2019 20:49:40 +0000

rtc: ds1343: rework interrupt handlingRework the interrupt handling to avoid caching the values as the core isalready doing that. The core also always ensures the rtc_time passed forthe alarm is fully populated.The only trick is in read_alarm where status needs to be read before thealarm registers to ensure the potential irq is not cleared.Link: https://lore.kernel.org/r/20191019204941.6203-8-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

a9864290 - rtc: ds1343: remove unnecessary mutex

Sat, 19 Oct 2019 20:49:39 +0000

rtc: ds1343: remove unnecessary mutexUse rtc_lock and rtc_unlock to lock the rtc from the interrupt handler.This removes the need for a driver specific lock.Link: https://lore.kernel.org/r/20191019204941.6203-7-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

ce0fd9db - rtc: ds1343: check regmap_read return value

Sat, 19 Oct 2019 20:49:38 +0000

rtc: ds1343: check regmap_read return valueCheck whether regmap_read fails before continuing in the sysfs .showcallbacks.Link: https://lore.kernel.org/r/20191019204941.6203-6-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

ac08888b - rtc: ds1343: use regmap_update_bits for glitch filter

Sat, 19 Oct 2019 20:49:37 +0000

rtc: ds1343: use regmap_update_bits for glitch filterUse regmap_update_bits to update DS1343_CONTROL_REG in a race free mannerwhen setting the glitch filter.Link: https://lore.kernel.org/r/20191019204941.6203-5-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

580daaf4 - rtc: ds1343: use rtc_add_group

Sat, 19 Oct 2019 20:49:36 +0000

rtc: ds1343: use rtc_add_groupUse rtc_add_group to add the sysfs group in a race free manner.This has the side effect of moving the files to their proper location.Link: https://lore.kernel.org/r/20191019204941.6203-4-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

f308b682 - rtc: ds1343: use burst write to set time

Sat, 19 Oct 2019 20:49:35 +0000

rtc: ds1343: use burst write to set timeTo avoid possible race condition, use regmap_bulk_write to write all thedate/time registers at once instead of sequentially.Link: https://lore.kernel.org/r/20191019204941.6203-3-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

8c9a88fa - rtc: ds1343: remove dead code

Sat, 19 Oct 2019 20:49:34 +0000

rtc: ds1343: remove dead codeRTC_SET_CHARGE doesn't exist, the ioctl code is never used.Link: https://lore.kernel.org/r/20191019204941.6203-2-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

21783322 - rtc: ds1343: set range

Sat, 19 Oct 2019 20:49:33 +0000

rtc: ds1343: set rangeThis is a standard BCD rtc with a useless century bit (no leap yearcorrection after 2099).Link: https://lore.kernel.org/r/20191019204941.6203-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

22652ba7 - rtc: stop validating rtc_time in .read_time

Mon, 19 Feb 2018 15:23:56 +0000

rtc: stop validating rtc_time in .read_timeThe RTC core is always calling rtc_valid_tm after the read_time callback.It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

d7501f70 - rtc: ds1343: use generic nvmem

Mon, 12 Feb 2018 22:47:38 +0000

rtc: ds1343: use generic nvmemInstead of adding a binary sysfs attribute from the driver (which suffersfrom a race condition as the attribute appears after the device), use thecore to register an nvmem device.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c

ab392864 - rtc: ds1343: remove undocumented and useless sysfs files

Mon, 12 Feb 2018 22:47:37 +0000

rtc: ds1343: remove undocumented and useless sysfs filesA documented ABI already exists to get information about the alarm. It isthe only one that is used.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1343.c