Changes in rtc-ds1286.c

09ef18bc - rtc: use devm_platform_ioremap_resource() to simplify code

Sun, 06 Oct 2019 10:29:20 +0000

rtc: use devm_platform_ioremap_resource() to simplify codeUse devm_platform_ioremap_resource() to simplify the code a bit.This is detected by coccinelle.Signed-off-by: YueHaibing Link: https://lore.kernel.org/r/20191006102953.57536-2-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-3-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-4-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-5-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-6-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-7-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-8-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-9-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-10-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-11-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-12-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-13-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-14-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-15-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-16-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-17-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-18-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-19-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-20-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-21-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-22-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-23-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-24-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-25-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-26-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-27-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-28-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-29-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-30-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-31-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-32-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-33-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-34-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-35-yuehaibing@huawei.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

2874c5fd - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

Mon, 27 May 2019 06:55:01 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later versionextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 3029 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

22652ba7 - rtc: stop validating rtc_time in .read_time

Mon, 19 Feb 2018 15:23:56 +0000

rtc: stop validating rtc_time in .read_timeThe RTC core is always calling rtc_valid_tm after the read_time callback.It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

d4a5f6d7 - rtc: ds1286: move header to linux/rtc

Sun, 26 Jun 2016 22:03:00 +0000

rtc: ds1286: move header to linux/rtcMove ds1286.h to rtc specific folder.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

fa569113 - rtc: remove useless DRV_VERSION

Thu, 31 Mar 2016 13:07:26 +0000

rtc: remove useless DRV_VERSIONMany drivers are defining a DRV_VERSION. This is often only used forMODULE_VERSION and sometimes to print an info message at probe time. Thisis kind of pointless as they are all versionned with the kernel anyway.Also the core will print a message when a new rtc is found.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

e044253b - rtc: simplify use of devm_ioremap_resource

Wed, 14 Aug 2013 09:11:21 +0000

rtc: simplify use of devm_ioremap_resourceRemove unneeded error handling on the result of a call toplatform_get_resource when the value is passed to devm_ioremap_resource.Move the call to platform_get_resource adjacent to the call todevm_ioremap_resource to make the connection between them more clear.A simplified version of the semantic patch that makes this change is asfollows: (http://coccinelle.lip6.fr/)// @@expression pdev,res,n,e,e1;expression ret != 0;identifier l;@@- res = platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res- if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res+ res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res);// Signed-off-by: Julia Lawall [viresh.kumar@linaro.org: acked rtc-spear]Acked-by: Viresh Kumar Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

0929ae37 - rtc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:21:31 +0000

rtc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

b943abd3 - drivers/rtc/rtc-ds1286.c: remove empty function

Wed, 03 Jul 2013 22:07:16 +0000

drivers/rtc/rtc-ds1286.c: remove empty functionAfter the switch to devm_* functions and the removal ofrtc_device_unregister(), the 'remove' function does not do anything.Delete it.Signed-off-by: Sachin Kamat Cc: Thomas Bogendoerfer Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

061d698e - rtc: rtc-ds1286: use devm_*() functions

Mon, 29 Apr 2013 23:20:38 +0000

rtc: rtc-ds1286: use devm_*() functionsUse devm_*() functions to make cleanup paths simpler.Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

cb72f60c - drivers/rtc/rtc-ds1286.c: fix compiler warning while doing make W=1

Mon, 29 Apr 2013 23:19:20 +0000

drivers/rtc/rtc-ds1286.c: fix compiler warning while doing make W=1below is the warning reported with the gcc (gcc (GCC) 4.7.2 20121109(Red Hat 4.7.2-8)) with make W=1: drivers/rtc/rtc-ds1286.c: In function `ds1286_read_alarm': drivers/rtc/rtc-ds1286.c:273:16: warning: variable `cmd' set but not used [-Wunused-but-set-variable]fixed by removing the variableSigned-off-by: Devendra Naga Cc: Thomas Bogendoerfer Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

5a167f45 - Drivers: rtc: remove __dev* attributes.

Fri, 21 Dec 2012 21:09:38 +0000

Drivers: rtc: remove __dev* attributes.CONFIG_HOTPLUG is going away as an option. As a result, the __dev*markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by mein order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton Cc: Alessandro Zummo Cc: Srinidhi Kasagar Cc: Linus Walleij Cc: Mike Frysinger Cc: Wan ZongShun Cc: Guan Xuetao Cc: Mark Brown Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

0c4eae66 - rtc: convert drivers/rtc/* to use module_platform_driver()

Tue, 10 Jan 2012 23:10:48 +0000

rtc: convert drivers/rtc/* to use module_platform_driver()This patch converts the drivers in drivers/rtc/* to use themodule_platform_driver() macro which makes the code smaller and a bitsimpler.Signed-off-by: Axel Lin Acked-by: Mark Brown Acked-by: Mike Frysinger Acked-by: Guan Xuetao Acked-by: Linus Walleij Acked-by: Haojian Zhuang Cc: Alessandro Zummo Cc: Srinidhi Kasagar Cc: Lars-Peter Clausen Cc: Ben Dooks Cc: John Stultz Acked-by: Jean-Christophe PLAGNIOL-VILLARD Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

28f65c11 - treewide: Convert uses of struct resource to resource_size(ptr)

Thu, 09 Jun 2011 16:13:32 +0000

treewide: Convert uses of struct resource to resource_size(ptr)Several fixes as well where the +1 was missing.Done via coccinelle scripts like:@@struct resource *ptr;@@- ptr->end - ptr->start + 1+ resource_size(ptr)and some grep and typing.Mostly uncompiled, no cross-compilers.Signed-off-by: Joe Perches Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

9a281a67 - rtc: ds1286: Initialize drvdata before registering device

Sat, 07 May 2011 00:21:12 +0000

rtc: ds1286: Initialize drvdata before registering deviceCommit f44f7f96a20 ("RTC: Initialize kernel state from RTC") uncoveredan issue in a number of RTC drivers, where the drivers callrtc_device_register before initializing the device or platform drvdata.This frequently results in null pointer dereferences when thertc_device_register immediately makes use of the rtc device, callingrtc_read_alarm.The solution is to ensure the drvdata is initialized prior to registeringthe rtc device.CC: Wolfram Sang CC: Alessandro Zummo CC: Thomas Gleixner CC: rtc-linux@googlegroups.comSigned-off-by: John Stultz List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

16380c15 - RTC: Convert rtc drivers to use the alarm_irq_enable method

Thu, 03 Feb 2011 01:02:41 +0000

RTC: Convert rtc drivers to use the alarm_irq_enable methodSome rtc drivers use the ioctl method instead of the alarm_irq_enablemethod for enabling alarm interupts. With the new virtualized RTCrework, its important for drivers to use the alarm_irq_enable instead.This patch converts the drivers that use the AIE ioctl method touse the alarm_irq_enable method. Other ioctl cmds are left untouched.I have not been able to test or even compile most of these drivers.Any help to make sure this change is correct would be appreciated!CC: Alessandro Zummo CC: Thomas Gleixner CC: Marcelo Roberto Jimenez Reported-by: Marcelo Roberto Jimenez Tested-by: Marcelo Roberto Jimenez Signed-off-by: John Stultz List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

d7a6119f - rtc: rtc-ds1286 and rtc-m48t35 need

Thu, 16 Oct 2008 07:28:47 +0000

rtc: rtc-ds1286 and rtc-m48t35 need With m68k allmodconfig, I get:| drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_read':| drivers/rtc/rtc-ds1286.c:33: error: implicit declaration of function '__raw_readl'| drivers/rtc/rtc-ds1286.c: In function 'ds1286_rtc_write':| drivers/rtc/rtc-ds1286.c:38: error: implicit declaration of function '__raw_writel'| drivers/rtc/rtc-ds1286.c: In function 'ds1286_probe':| drivers/rtc/rtc-ds1286.c:345: error: implicit declaration of function 'ioremap'| drivers/rtc/rtc-ds1286.c:345: warning: assignment makes pointer from integer without a cast| drivers/rtc/rtc-ds1286.c:365: error: implicit declaration of function 'iounmap'and| drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':| drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'| drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'| drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':| drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'| drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast| drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'Include to get access to the I/O API.Signed-off-by: Geert Uytterhoeven Acked-by: Thomas Bogendoerfer Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c

5f119f29 - MIPS: DS1286: New RTC driver

Tue, 14 Oct 2008 15:16:59 +0000

MIPS: DS1286: New RTC driverThis driver replaces the broken DS1286 driver in drivers/char and gives backRTC support for SGI IP22 and IP28 machines.Signed-off-by: Thomas Bogendoerfer Acked-by: Alessandro Zummo Signed-off-by: Ralf Baechle List of files: /linux-6.15/drivers/rtc/rtc-ds1286.c