Changes in rtc-ds1216.c

09ef18bc - rtc: use devm_platform_ioremap_resource() to simplify code

Sun, 06 Oct 2019 10:29:20 +0000

rtc: use devm_platform_ioremap_resource() to simplify codeUse devm_platform_ioremap_resource() to simplify the code a bit.This is detected by coccinelle.Signed-off-by: YueHaibing Link: https://lore.kernel.org/r/20191006102953.57536-2-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-3-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-4-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-5-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-6-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-7-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-8-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-9-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-10-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-11-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-12-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-13-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-14-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-15-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-16-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-17-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-18-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-19-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-20-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-21-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-22-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-23-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-24-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-25-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-26-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-27-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-28-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-29-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-30-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-31-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-32-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-33-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-34-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-35-yuehaibing@huawei.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

09c434b8 - treewide: Add SPDX license identifier for more missed files

Sun, 19 May 2019 12:08:20 +0000

treewide: Add SPDX license identifier for more missed filesAdd SPDX license identifiers to all files which: - Have no license information of any form - Have MODULE_LICENCE("GPL*") inside which was used in the initial scan/conversion to ignore the fileThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

85368bb9 - rtc: simplify getting .drvdata

Thu, 19 Apr 2018 14:06:14 +0000

rtc: simplify getting .drvdataWe should get drvdata from struct device directly. Going viaplatform_device is an unneeded step back and forth.Signed-off-by: Wolfram Sang Acked-by: Michal Simek (for zynqmp)Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

22652ba7 - rtc: stop validating rtc_time in .read_time

Mon, 19 Feb 2018 15:23:56 +0000

rtc: stop validating rtc_time in .read_timeThe RTC core is always calling rtc_valid_tm after the read_time callback.It is not necessary to call it just before returning from the callback.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

fa569113 - rtc: remove useless DRV_VERSION

Thu, 31 Mar 2016 13:07:26 +0000

rtc: remove useless DRV_VERSIONMany drivers are defining a DRV_VERSION. This is often only used forMODULE_VERSION and sometimes to print an info message at probe time. Thisis kind of pointless as they are all versionned with the kernel anyway.Also the core will print a message when a new rtc is found.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

e044253b - rtc: simplify use of devm_ioremap_resource

Wed, 14 Aug 2013 09:11:21 +0000

rtc: simplify use of devm_ioremap_resourceRemove unneeded error handling on the result of a call toplatform_get_resource when the value is passed to devm_ioremap_resource.Move the call to platform_get_resource adjacent to the call todevm_ioremap_resource to make the connection between them more clear.A simplified version of the semantic patch that makes this change is asfollows: (http://coccinelle.lip6.fr/)// @@expression pdev,res,n,e,e1;expression ret != 0;identifier l;@@- res = platform_get_resource(pdev, IORESOURCE_MEM, n); ... when != res- if (res == NULL) { ... \(goto l;\|return ret;\) } ... when != res+ res = platform_get_resource(pdev, IORESOURCE_MEM, n); e = devm_ioremap_resource(e1, res);// Signed-off-by: Julia Lawall [viresh.kumar@linaro.org: acked rtc-spear]Acked-by: Viresh Kumar Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

0929ae37 - rtc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:21:31 +0000

rtc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

061d2a3e - drivers/rtc/rtc-ds1216.c: use module_platform_driver_probe()

Wed, 03 Jul 2013 22:08:03 +0000

drivers/rtc/rtc-ds1216.c: use module_platform_driver_probe()Use module_platform_driver_probe() macro which makes the code smaller andsimpler.Signed-off-by: Fabio Porcedda Cc: Alessandro Zummo Cc: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

0df2c54e - drivers/rtc/rtc-ds1216.c: remove empty function

Wed, 03 Jul 2013 22:07:15 +0000

drivers/rtc/rtc-ds1216.c: remove empty functionAfter the switch to devm_* functions and the removal ofrtc_device_unregister(), the 'remove' function does not do anything.Delete it.Signed-off-by: Sachin Kamat Cc: Thomas Bogendoerfer Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

15c1567a - rtc: rtc-ds1216: use devm_*() functions

Mon, 29 Apr 2013 23:20:37 +0000

rtc: rtc-ds1216: use devm_*() functionsUse devm_*() functions to make cleanup paths simpler.Signed-off-by: Jingoo Han Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

97a1f953 - rtc: rtc-ds1216 fixes

Tue, 06 Jan 2009 22:42:23 +0000

rtc: rtc-ds1216 fixesFixes a few issues with the rtc-ds1216 driver- use rtc_valid_tm- use platform_driver_probe- fix init sequence - it was using rtc_unregister_driver where not needed. I also added resource_size and removed an useless pointer assignment.Signed-off-by: Alessandro Zummo Tested-by: Thomas Bogendoerfer Cc: David Brownell Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

fe20ba70 - drivers/rtc/: use bcd2bin/bin2bcd

Sun, 19 Oct 2008 03:28:41 +0000

drivers/rtc/: use bcd2bin/bin2bcdChange drivers/rtc/ to use the new bcd2bin/bin2bcd functions instead ofthe obsolete BCD_TO_BIN/BIN_TO_BCD/BCD2BIN/BIN2BCD macros.Signed-off-by: Adrian Bunk Acked-by: Alessandro Zummo Cc: David Brownell Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

ad28a07b - rtc: fix platform driver hotplug/coldplug

Fri, 11 Apr 2008 04:29:25 +0000

rtc: fix platform driver hotplug/coldplugSince 43cc71eed1250755986da4c0f9898f9a635cb3bf, the platform modalias isprefixed with "platform:". Add MODULE_ALIAS() to the hotpluggable RTCplatform drivers, to re-enable module auto loading.[dbrownell@users.sourceforge.net: more drivers, minor fix]Signed-off-by: Kay Sievers Signed-off-by: David Brownell Cc: Greg KH Cc: Alessandro Zummo Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c

537739de - RTC driver for DS1216 chips

Tue, 17 Jul 2007 11:05:06 +0000

RTC driver for DS1216 chipsRTC driver for Dallas/Maxim DS126 chips used in SNI RM200/RM400[akpm@linux-foundation.org: cleanups]Signed-off-by: Thomas Bogendoerfer Acked-by: Alessandro Zummo Cc: David Brownell Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ds1216.c