Changes in rtc-cros-ec.c

01761882 - rtc: cros-ec: Avoid a couple of -Wflex-array-member-not-at-end warnings

Fri, 14 Mar 2025 08:30:54 +0000

rtc: cros-ec: Avoid a couple of -Wflex-array-member-not-at-end warningsUse the `DEFINE_RAW_FLEX()` helper for an on-stack definition ofa flexible structure where the size of the flexible-array memberis known at compile-time, and refactor the rest of the code,accordingly.So, with these changes, fix the following warning:drivers/rtc/rtc-cros-ec.c:62:40: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]drivers/rtc/rtc-cros-ec.c:40:40: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]Signed-off-by: Gustavo A. R. Silva Reviewed-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/Z9PpPg06OK8ghNvm@ksppSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

8c28c499 - rtc: use boolean values with device_init_wakeup()

Tue, 17 Dec 2024 07:13:26 +0000

rtc: use boolean values with device_init_wakeup()device_init_wakeup() second argument is a bool type. Use proper booleanvalues when calling it to match the type and to produce unambiguous codewhich is easier to understand.Signed-off-by: Wolfram Sang Reviewed-by: Charles Keepax Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

e5eab1ae - rtc: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:03 +0000

rtc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/rtc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20241007205803.444994-6-u.kleine-koenig@baylibre.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

61c86d14 - rtc: cros-ec: provide ID table for avoiding fallback match

Fri, 29 Mar 2024 07:56:15 +0000

rtc: cros-ec: provide ID table for avoiding fallback matchInstead of using fallback driver name match, provide ID table[1] for theprimary match.[1]: https://elixir.bootlin.com/linux/v6.8/source/drivers/base/platform.c#L1353Signed-off-by: Tzung-Bi Shih Reviewed-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20240329075630.2069474-4-tzungbi@kernel.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

00c3092d - rtc: cros-ec: Detect and report supported alarm window size

Thu, 17 Aug 2023 22:55:33 +0000

rtc: cros-ec: Detect and report supported alarm window sizeThe RTC on some older Chromebooks can only handle alarms less than24 hours in the future. The only way to find out is to try to setan alarm further in the future. If that fails, assume that the RTCconnected to the EC can only handle less than 24 hours of alarmwindow, and report that value to the RTC core.After that change, it is no longer necessary to limit the alarm timewhen setting it. Report any excessive alarms to the caller instead.Cc: Brian Norris Signed-off-by: Guenter Roeck Link: https://lore.kernel.org/r/20230817225537.4053865-4-linux@roeck-us.netSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

0d8742e6 - rtc: cros-ec: Convert to platform remove callback returning void

Sat, 04 Mar 2023 13:29:57 +0000

rtc: cros-ec: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Reviewed-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20230304133028.2135435-11-u.kleine-koenig@pengutronix.deSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

f27efee6 - rtc: cros-ec: Limit RTC alarm range if needed

Sat, 29 Oct 2022 00:54:00 +0000

rtc: cros-ec: Limit RTC alarm range if neededRTC chips on some older Chromebooks can only handle alarms less than 24hours in the future. Attempts to set an alarm beyond that range fails.The most severe impact of this limitation is that suspend requests failif alarmtimer_suspend() tries to set an alarm for more than 24 hoursin the future.Try to set the real-time alarm to just below 24 hours if setting it toa larger value fails to work around the problem. While not perfect, itis better than just failing the call. A similar workaround is alreadyimplemented in the rtc-tps6586x driver.Drop error messages in cros_ec_rtc_get() and cros_ec_rtc_set() since thecalling code also logs an error and to avoid spurious error messages ifsetting the alarm ultimately succeeds.Cc: Brian Norris Signed-off-by: Guenter Roeck Commit: Guenter Roeck Reviewed-by: Tzung-Bi Shih Reviewed-by: Brian Norris Tested-by: Brian Norris Link: https://lore.kernel.org/r/20221029005400.2712577-1-linux@roeck-us.netSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

5c9f4144 - rtc: cros-ec: Only warn once in .remove() about notifier_chain problems

Thu, 07 Jul 2022 15:31:56 +0000

rtc: cros-ec: Only warn once in .remove() about notifier_chain problemsWhen a remove platform device callback returns an error code, the drivercore emits an error message ("remove callback returned a non-zero value.This will be ignored.\n") and still removes the device. As the driveralready emits a more specific error message, return 0 to suppress thecore's error message.This is a preparation for making platform remove callbacks return void.Signed-off-by: Uwe Kleine-König Acked-by: Tzung-Bi Shih Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20220707153156.214841-1-u.kleine-koenig@pengutronix.de List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

11f1eabe - cros_ec: treewide: Remove 'include/linux/mfd/cros_ec.h'

Tue, 03 Dec 2019 14:50:18 +0000

cros_ec: treewide: Remove 'include/linux/mfd/cros_ec.h'This header file now only includes the cros_ec_dev struct, however, is the'include/linux/platform_data/cros_ec_proto.h' who contains the definition ofall the Chrome OS EC related structs. There is no reason to have aseparate include for this struct so move to the place where otherstructs are defined. That way, we can remove the include itself, but alsosimplify the common pattern #include #include for a single include #include The changes to remove the cros_ec.h include were generated with thefollowing shell script: git grep -l "" | xargs sed -i '//d'Signed-off-by: Enric Balletbo i Serra Acked-by: Lee Jones Acked-by: Alexandre Belloni Acked-by: Jonathan Cameron Acked-by: Sebastian Reichel Acked-by: Hans Verkuil List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

0e843137 - rtc: cros-ec: let the core handle rtc range

Wed, 16 Oct 2019 20:14:14 +0000

rtc: cros-ec: let the core handle rtc rangeLet the rtc core check the date/time against the RTC range.Reviewed-by: Enric Balletbo i Serra Link: https://lore.kernel.org/r/20191016201414.30934-2-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

4fc0d13f - rtc: cros-ec: remove superfluous error message

Wed, 16 Oct 2019 20:14:13 +0000

rtc: cros-ec: remove superfluous error messageThe RTC core now has error messages in case of registration failure, thereis no need to have other messages in the drivers.Reviewed-by: Enric Balletbo i Serra Link: https://lore.kernel.org/r/20191016201414.30934-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

840d9f13 - mfd / platform: cros_ec: Reorganize platform and mfd includes

Mon, 02 Sep 2019 09:53:05 +0000

mfd / platform: cros_ec: Reorganize platform and mfd includesThere is a bit of mess between cros-ec mfd includes and platformincludes. For example, we have a linux/mfd/cros_ec.h include thatexports the interface implemented in platform/chrome/cros_ec_proto.c. Orwe have a linux/mfd/cros_ec_commands.h file that is non related to themultifunction device (in the sense that is not exporting any function ofthe mfd device). This causes crossed includes between mfd andplatform/chrome subsystems and makes the code difficult to read, apartfrom creating 'curious' situations where a platform/chrome driver includesa linux/mfd/cros_ec.h file just to get the exported functions that areimplemented in another platform/chrome driver.In order to have a better separation on what the cros-ec multifunctiondriver does and what the cros-ec core provides move and rework theaffected includes doing: - Move cros_ec_commands.h to include/linux/platform_data/cros_ec_commands.h - Get rid of the parts that are implemented in the platform/chrome/cros_ec_proto.c driver from include/linux/mfd/cros_ec.h to a new file include/linux/platform_data/cros_ec_proto.h - Update all the drivers with the new includes, so - Drivers that only need to know about the protocol include - linux/platform_data/cros_ec_proto.h - linux/platform_data/cros_ec_commands.h - Drivers that need to know about the cros-ec mfd device also include - linux/mfd/cros_ec.hSigned-off-by: Enric Balletbo i Serra Acked-by: Andy Shevchenko Acked-by: Mark Brown Acked-by: Wolfram Sang Acked-by: Neil Armstrong Acked-by: Alexandre Belloni Acked-by: Jonathan Cameron Acked-by: Benjamin Tissoires Acked-by: Dmitry Torokhov Acked-by: Sebastian Reichel Acked-by: Chanwoo Choi Reviewed-by: Gwendal Grignou Tested-by: Gwendal Grignou Series changes: 3- Fix dereferencing pointer to incomplete type 'struct cros_ec_dev' (lkp)Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

d6752e18 - rtc: cros-ec: Fail suspend/resume if wake IRQ can't be configured

Fri, 15 Mar 2019 18:51:12 +0000

rtc: cros-ec: Fail suspend/resume if wake IRQ can't be configuredIf we encounter a failure during suspend where this RTC was programmedto wakeup the system from suspend, but that wakeup couldn't beconfigured because the system didn't support wakeup interrupts, we'llrun into the following warning: Unbalanced IRQ 166 wake disable WARNING: CPU: 7 PID: 3071 at kernel/irq/manage.c:669 irq_set_irq_wake+0x108/0x278This happens because the suspend process isn't aborted when the RTCfails to configure the wakeup IRQ. Instead, we continue suspending thesystem and then another suspend callback fails the suspend process and"unwinds" the previously suspended drivers by calling their resumecallbacks. When we get back to resuming this RTC driver, we'll calldisable_irq_wake() on an IRQ that hasn't been configured for wake.Let's just fail suspend/resume here if we can't configure the system towake and the user has chosen to wakeup with this device. This fixes thiswarning and makes the code more robust in case there are systems outthere that can't wakeup from suspend on this line but the user haschosen to do so.Cc: Enric Balletbo i Serra Cc: Evan Green Cc: Benson Leung Cc: Guenter Roeck Signed-off-by: Stephen Boyd Acked-By: Benson Leung Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

8ee4aee5 - rtc: cros-ec: Switch to SPDX identifier.

Wed, 06 Jun 2018 15:08:54 +0000

rtc: cros-ec: Switch to SPDX identifier.Adopt the SPDX license identifier headers to ease license compliancemanagement.Signed-off-by: Enric Balletbo i Serra Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

e6988d23 - rtc: cros-ec: Make license text and module license match.

Wed, 06 Jun 2018 15:08:53 +0000

rtc: cros-ec: Make license text and module license match.The license text is specifying "GPLv2" but the MODULE_LICENSE is set toGPL which means GNU Public License v2 or later. When MODULE_LICENSE andboiler plate does not match, go for boiler plate license.Signed-off-by: Enric Balletbo i Serra Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

72dd71f0 - rtc: cros-ec: return -ETIME when refused to set alarms in the past

Tue, 27 Feb 2018 02:50:03 +0000

rtc: cros-ec: return -ETIME when refused to set alarms in the pastSince accessing a Chrome OS EC based rtc is a slow operation, there is arace window where if the alarm is set for the next second and the secondticks over right before calculating the alarm offset.In this case the current driver is setting a 0-second alarm, which wouldbe considered as disabling alarms by the EC(EC_RTC_ALARM_CLEAR).This breaks, e.g., hwclock which relies on RTC_UIE_ON ->rtc_update_irq_enable(), which sets a 1-second alarm and expects it tofire an interrupt.So return -ETIME when the alarm is in the past, follow __rtc_set_alarm().Signed-off-by: Jeffy Chen Reviewed-by: Brian Norris Tested-by: Brian Norris Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c

6f2a71a3 - rtc: cros-ec: add cros-ec-rtc driver.

Fri, 10 Nov 2017 21:55:53 +0000

rtc: cros-ec: add cros-ec-rtc driver.On platforms with a Chrome OS EC, the EC can function as a simple RTC.Add a basic driver with this functionality.Signed-off-by: Stephen Barber Signed-off-by: Enric Balletbo i Serra Acked-by: Alexandre Belloni Acked-by: Benson Leung Reviewed-by: Brian Norris Tested-by: Brian Norris Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-cros-ec.c