Changes in rtc-at91sam9.c

8c28c499 - rtc: use boolean values with device_init_wakeup()

Tue, 17 Dec 2024 07:13:26 +0000

rtc: use boolean values with device_init_wakeup()device_init_wakeup() second argument is a bool type. Use proper booleanvalues when calling it to match the type and to produce unambiguous codewhich is easier to understand.Signed-off-by: Wolfram Sang Reviewed-by: Charles Keepax Reviewed-by: Andre Przywara Link: https://lore.kernel.org/r/20241217071331.3607-2-wsa+renesas@sang-engineering.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

e5eab1ae - rtc: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:03 +0000

rtc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/rtc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20241007205803.444994-6-u.kleine-koenig@baylibre.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

73580e2e - rtc: at91sam9: fix OF node leak in probe() error path

Sun, 25 Aug 2024 18:31:03 +0000

rtc: at91sam9: fix OF node leak in probe() error pathDriver is leaking an OF node reference obtained fromof_parse_phandle_with_fixed_args().Fixes: 43e112bb3dea ("rtc: at91sam9: make use of syscon/regmap to access GPBR registers")Cc: stable@vger.kernel.orgSigned-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20240825183103.102904-1-krzysztof.kozlowski@linaro.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

4f3688dc - rtc: remove redundant of_match_ptr()

Tue, 08 Aug 2023 11:52:09 +0000

rtc: remove redundant of_match_ptr()Signed-off-by: Zhu Wang Link: https://lore.kernel.org/r/20230808115213.154377-2-wangzhu9@huawei.comLink: https://lore.kernel.org/r/20230808115213.154377-3-wangzhu9@huawei.comLink: https://lore.kernel.org/r/20230808115213.154377-4-wangzhu9@huawei.comLink: https://lore.kernel.org/r/20230808115213.154377-5-wangzhu9@huawei.comLink: https://lore.kernel.org/r/20230808115213.154377-6-wangzhu9@huawei.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

06e5e4a5 - rtc: at91sam9: Convert to platform remove callback returning void

Sat, 04 Mar 2023 13:29:53 +0000

rtc: at91sam9: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Reviewed-by: Claudiu Beznea Link: https://lore.kernel.org/r/20230304133028.2135435-7-u.kleine-koenig@pengutronix.deSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

37aadf9b - rtc: at91sam9: Remove unnecessary offset variable checks

Thu, 08 Jul 2021 05:13:40 +0000

rtc: at91sam9: Remove unnecessary offset variable checksThe offset variable is checked by at91_rtc_readalarm(), but this checkis unnecessary because the previous check knew that the value of thisvariable was not 0.This removes that unnecessary offset variable checks.Cc: Nicolas Ferre Cc: Ludovic Desroches Signed-off-by: Nobuhiro Iwamatsu Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20210708051340.341345-1-nobuhiro1.iwamatsu@toshiba.co.jp List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

09ef18bc - rtc: use devm_platform_ioremap_resource() to simplify code

Sun, 06 Oct 2019 10:29:20 +0000

rtc: use devm_platform_ioremap_resource() to simplify codeUse devm_platform_ioremap_resource() to simplify the code a bit.This is detected by coccinelle.Signed-off-by: YueHaibing Link: https://lore.kernel.org/r/20191006102953.57536-2-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-3-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-4-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-5-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-6-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-7-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-8-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-9-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-10-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-11-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-12-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-13-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-14-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-15-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-16-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-17-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-18-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-19-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-20-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-21-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-22-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-23-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-24-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-25-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-26-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-27-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-28-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-29-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-30-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-31-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-32-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-33-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-34-yuehaibing@huawei.comLink: https://lore.kernel.org/r/20191006102953.57536-35-yuehaibing@huawei.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

faac9102 - rtc: Remove dev_err() usage after platform_get_irq()

Tue, 30 Jul 2019 18:15:39 +0000

rtc: Remove dev_err() usage after platform_get_irq()We don't need dev_err() messages when platform_get_irq() fails now thatplatform_get_irq() prints an error message itself when something goeswrong. Let's remove these prints with a simple semantic patch.// @@expression ret;struct platform_device *E;@@ret =(platform_get_irq(E, ...)|platform_get_irq_byname(E, ...));if ( \( ret < 0 \| ret <= 0 \) ){(-if (ret != -EPROBE_DEFER)-{ ...-dev_err(...);-... }|...-dev_err(...);)...}// While we're here, remove braces on if statements that only have onestatement (manually).Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.orgCc: Greg Kroah-Hartman Signed-off-by: Stephen Boyd Link: https://lore.kernel.org/r/20190730181557.90391-40-swboyd@chromium.orgSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

be8bf986 - rtc: at91sam9: correct trivial checkpatch warnings

Wed, 20 Mar 2019 12:40:42 +0000

rtc: at91sam9: correct trivial checkpatch warningsCorrect trivial checkpatch warnings, mostly whitespace issues andunbalanced braces.Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

bc40072d - rtc: at91sam9: convert to SPDX identifier

Wed, 20 Mar 2019 12:40:41 +0000

rtc: at91sam9: convert to SPDX identifierUse SPDX-License-Identifier instead of a verbose license textAcked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

8af760a3 - rtc: at91sam9: switch to rtc_time64_to_tm/rtc_tm_to_time64

Wed, 20 Mar 2019 12:40:40 +0000

rtc: at91sam9: switch to rtc_time64_to_tm/rtc_tm_to_time64Call the 64bit versions of rtc_tm time conversion as the range is enforcedby the core.Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

255c43ca - rtc: at91sam9: set range

Wed, 20 Mar 2019 12:40:39 +0000

rtc: at91sam9: set rangeThe AT91 RTT is a 32bit second counter that is saved in a 32bit globalpurpose register.Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

6c7293e7 - rtc: at91sam9: convert to devm_rtc_allocate_device

Wed, 20 Mar 2019 12:40:38 +0000

rtc: at91sam9: convert to devm_rtc_allocate_deviceThis allows further improvement of the driver.Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

1a76a77c - rtc: at91sam9: drop platform_data support

Wed, 20 Mar 2019 12:40:37 +0000

rtc: at91sam9: drop platform_data supportARCH_AT91 is DT only for a while, drop platform data support.Acked-by: Nicolas Ferre Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

285166cb - rtc: at91sam9: Switch to use %ptR

Tue, 04 Dec 2018 21:23:14 +0000

rtc: at91sam9: Switch to use %ptRUse %ptR instead of open coded variant to print content ofstruct rtc_time in human readable format.Signed-off-by: Andy Shevchenko Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

65d211b3 - rtc: at91sam9: Set name of regmap_config

Mon, 12 Mar 2018 09:51:40 +0000

rtc: at91sam9: Set name of regmap_configWe are now allowing to register debugfs without a valid device, and nothaving a valid name will end up using "dummy*" to create debugfs dir.Signed-off-by: Jeffy Chen Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

b7b17633 - rtc: at91sam9: Fix missing spin_lock_init()

Mon, 25 Jul 2016 07:05:11 +0000

rtc: at91sam9: Fix missing spin_lock_init()The driver allocates the spinlock but not initialize it.Use spin_lock_init() on it to initialize it correctly.This is detected by Coccinelle semantic patch.Signed-off-by: Wei Yongjun Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

df2d741f - rtc: at91sam9: remove duplicate assignment of variable mr

Mon, 28 Mar 2016 11:24:00 +0000

rtc: at91sam9: remove duplicate assignment of variable mrmr is written twice with the same value, remove one of theredundant assignments to mr.Signed-off-by: Colin Ian King Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c

80e274e9 - rtc: at91sam9: remove useless include

Mon, 10 Aug 2015 14:33:40 +0000

rtc: at91sam9: remove useless includeDefinitions from linux/platform_data/atmel.h are not used, remove theinclude.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-at91sam9.c