Changes in rtc-ab8500.c

ca36c930 - rtc: ab8500: Use resource managed API to simplify code

Wed, 05 Feb 2025 00:58:23 +0000

rtc: ab8500: Use resource managed API to simplify codeUse devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup theerror handling code and 'driver.remove()' hook.Reviewed-by: Linus Walleij Signed-off-by: Peng Fan Link: https://lore.kernel.org/r/20250205-rtc-cleanup-v1-5-66165678e089@nxp.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

e5eab1ae - rtc: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:03 +0000

rtc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/rtc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20241007205803.444994-6-u.kleine-koenig@baylibre.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

8a700af1 - rtc: ab8500: Convert to platform remove callback returning void

Sat, 04 Mar 2023 13:29:50 +0000

rtc: ab8500: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Acked-by: Linus Walleij Link: https://lore.kernel.org/r/20230304133028.2135435-4-u.kleine-koenig@pengutronix.deSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

a5f82803 - rtc: ab8500: let the core handle the alarm resolution

Sun, 07 Nov 2021 22:54:51 +0000

rtc: ab8500: let the core handle the alarm resolutionTell the RTC core UIE are not supported because the resolution of the alarmis a minute.Note that this is in fact also fixing how the resolution is reported as theprevious test was simply ensuring the alarm was more than a minute in thefuture while the register has a minute resolution.This would be ok if the alarm was a countdown but ab8500_rtc_read_alarmsuggests otherwise and the AB8500 datasheet states that the RTCdocumentation is not public.Finally, the comment is wrong and what makes the UIE emulation work isuie_unsupported being set.Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij Link: https://lore.kernel.org/r/20211107225458.111068-6-alexandre.belloni@bootlin.com List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

fdcfd854 - rtc: rework rtc_register_device() resource management

Mon, 09 Nov 2020 16:34:08 +0000

rtc: rework rtc_register_device() resource managementrtc_register_device() is a managed interface but it doesn't use devresby itself - instead it marks an rtc_device as "registered" and the devrescallback for devm_rtc_allocate_device() takes care of resource release.This doesn't correspond with the design behind devres where managedstructures should not be aware of being managed. The correct solutionhere is to register a separate devres callback for unregistering thedevice.While at it: rename rtc_register_device() to devm_rtc_register_device()and add it to the list of managed interfaces in devres.rst. This way wecan avoid any potential confusion of driver developers who may expectthere to exist a corresponding unregister function.Signed-off-by: Bartosz Golaszewski Signed-off-by: Alexandre Belloni Link: https://lore.kernel.org/r/20201109163409.24301-8-brgl@bgdev.pl List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

a5965a31 - rtc: ab8500: switch to rtc_time64_to_tm/rtc_tm_to_time64

Fri, 06 Mar 2020 01:01:01 +0000

rtc: ab8500: switch to rtc_time64_to_tm/rtc_tm_to_time64Call the 64bit versions of rtc_tm time conversion.Acked-by: Linus Walleij Link: https://lore.kernel.org/r/20200306010101.39517-1-alexandre.belloni@bootlin.comSigned-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

af873fce - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194

Tue, 28 May 2019 16:57:21 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194Based on 1 normalized pattern(s): license terms gnu general public license gpl version 2extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 161 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Reviewed-by: Steve Winslow Reviewed-by: Richard Fontana Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190528170027.447718015@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

9a90a5bc - rtc: ab8500: remove useless check

Mon, 24 Sep 2018 14:49:02 +0000

rtc: ab8500: remove useless checkrtc_time_to_tm always rturns a valid tm, there is no need to validate it.Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

38ab97ae - rtc: ab8500: let the core handle range

Mon, 24 Sep 2018 14:49:01 +0000

rtc: ab8500: let the core handle rangeLet the core handle offsetting and windowing the RTC range.The RTC has a 24 bit counter for minutes plus a seconds counter.Keep the epoch at the beginning of 2000.Signed-off-by: Alexandre Belloni Acked-by: Linus Walleij Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

b56295dd - rtc: ab8500: use rtc_add_group

Mon, 24 Sep 2018 14:49:00 +0000

rtc: ab8500: use rtc_add_groupUse rtc_add_group to add the sysfs group in a race free manner.Signed-off-by: Alexandre Belloni Reviewed-by: Linus Walleij Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

7bbd523c - rtc: ab8500: Drop AB8540 support

Thu, 22 Mar 2018 10:18:30 +0000

rtc: ab8500: Drop AB8540 supportThe AB8540 was an evolved version of the AB8500, but it was nevermass produced or put into products, only reference designs exist.The upstream support was never completed and it is unlikely thatthis will happen so drop the support for now to simplifymaintenance of the AB8500.Cc: Loic Pallardy Signed-off-by: Linus Walleij Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

ab62670e - rtc: stop validating rtc_time after rtc_time_to_tm

Mon, 19 Feb 2018 15:23:55 +0000

rtc: stop validating rtc_time after rtc_time_to_tmrtc_time_to_tm never generates an invalid tm. It is not necessary tovalidate it.Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

93a6f916 - rtc: ab8500: remove misuse of IRQF_NO_SUSPEND flag

Mon, 21 Sep 2015 15:46:58 +0000

rtc: ab8500: remove misuse of IRQF_NO_SUSPEND flagThe IRQF_NO_SUSPEND flag is used to identify the interrupts that shouldbe left enabled so as to allow them to work as expected during thesuspend-resume cycle, but doesn't guarantee that it will wake the systemfrom a suspended state, enable_irq_wake is recommended to be used forthe wakeup.This patch removes the use of IRQF_NO_SUSPEND flags and uses newlyintroduce PM wakeup APIs dev_pm_{set,clear}_wake_irq.Cc: Linus Walleij Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: rtc-linux@googlegroups.comSigned-off-by: Sudeep Holla Acked-by: Linus Walleij Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

8a67e931 - rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[]

Fri, 04 Sep 2015 11:58:05 +0000

rtc: ab8500: Add a sentinel to ab85xx_rtc_ids[]Add a sentinel to ab85xx_rtc_ids[] in order to fix the following error:drivers/rtc/rtc-ab8500: struct platform_device_id is 24 bytes. The last of 2 is:0x61 0x62 0x38 0x35 0x34 0x30 0x2d 0x72 0x74 0x63 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x8cFATAL: drivers/rtc/rtc-ab8500: struct platform_device_id is not terminated with a NULL entry!Reported-by: Andrey Ryabinin Reported-by: Olof's autobuilder Signed-off-by: Fabio Estevam Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

63074cc3 - rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers

Thu, 27 Aug 2015 10:34:32 +0000

rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} driversThese platform drivers have a platform device ID table but the modulealias information is not created so module autoloading will not work.Signed-off-by: Javier Martinez Canillas Reviewed-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

9a72f410 - rtc: ab8500: Constify platform_device_id

Fri, 01 May 2015 15:44:35 +0000

rtc: ab8500: Constify platform_device_idThe platform_device_id is not modified by the driver and core uses it asconst.Signed-off-by: Krzysztof Kozlowski Signed-off-by: Alexandre Belloni List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

c594d678 - rtc/ab8500: set uie_unsupported flag

Wed, 10 Dec 2014 23:54:23 +0000

rtc/ab8500: set uie_unsupported flagCurrently, ab8500 doesn't set uie_unsupported of rtc_device, while itdoesn't support UIE, see ab8500_rtc_set_alarm().Thus, when going through rtc_update_irq_enable()->rtc_timer_enqueue(),there's a chance it has an alarm timer1 queued before which is going tofired, so this update timer2 will be queued because it isn't the leftmostone, which means rtc_timer_enqueue() will return 0.This will result in two problems:1) UIE EMUL will not be used.2) When the alarm timer1 is fired, in rtc_timer_do_work() timer2 will fail to set the alarm time, so this rtc will disfunctional due to timer2 with the earliest expires in the timerqueue.So, rtc drivers must set this flag if they don't support UIE.Signed-off-by: Xunlei Pang Cc: Alessandro Zummo Cc: John Stultz Cc: Arnd Bergmann Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

0929ae37 - rtc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:21:31 +0000

rtc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

25d053cf - drivers/rtc/rtc-ab8500.c: add second resolution to rtc driver

Wed, 03 Jul 2013 22:07:45 +0000

drivers/rtc/rtc-ab8500.c: add second resolution to rtc driverAndroid expects the RTC to have second resolution. On ab8540 cut2 RTCblock has a new register which allows setting seconds for wakeup alarms.Existing registers (minutes hi, mid and low) have seen their offsetschanged. Here is the new mapping: * AlarmSec (A) 0x22 * AlarmMinLow (M) from 0x8 to 0x23 * AlarmMinMid (M) from 0x9 to 0x24 * AlarmMinHigh (M) from 0xA to 0x25Signed-off-by: Julien Delacou Signed-off-by: Alexandre Torgue Acked-by: Lee Jones Acked-by: Linus Walleij Cc: Samuel Ortiz Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c

431296a4 - rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()

Wed, 03 Jul 2013 22:06:10 +0000

rtc: rtc-ab8500: remove unnecessary platform_set_drvdata()The driver core clears the driver data to NULL after device_release oron probe failure, since commit 0998d063100 ("device-core: Ensure drvdata= NULL when no driver is bound"). Thus, it is not needed to manuallyclear the device driver data to NULL.Signed-off-by: Jingoo Han Cc: Srinidhi Kasagar Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rtc/rtc-ab8500.c