Changes in qcom_smd.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

181563be - rpmsg: qcom_smd: Use qcom_smem_is_available()

Thu, 15 Jun 2023 16:50:41 +0000

rpmsg: qcom_smd: Use qcom_smem_is_available()Rather than looking up a dummy item from SMEM, use the newqcom_smem_is_available() function to make the code more clear(and reduce the overhead slightly).Add the same check to qcom_smd_register_edge() as well to ensure thatit only succeeds if SMEM is already available - if a driver calls thefunction and SMEM is not available yet then the initial state will beread incorrectly and the RPMSG devices might never become available.Reviewed-by: Konrad Dybcio Signed-off-by: Stephan Gerhold Link: https://lore.kernel.org/r/20230531-rpm-rproc-v3-8-a07dcdefd918@gerhold.netSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

38be8951 - rpmsg: qcom_smd: Convert to platform remove callback returning void

Tue, 21 Mar 2023 15:40:39 +0000

rpmsg: qcom_smd: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.qcom_smd_remove() always returned zero, though that isn't completelytrivial to see. So explain that in a comment and convert to.remove_new().Signed-off-by: Uwe Kleine-König Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20230321154039.355098-4-u.kleine-koenig@pengutronix.de List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

810c03d9 - rpmsg: qcom_smd: Make qcom_smd_unregister_edge() return void

Tue, 21 Mar 2023 15:40:37 +0000

rpmsg: qcom_smd: Make qcom_smd_unregister_edge() return voidThis function returned zero unconditionally. Convert it to return novalue instead. This makes it more obvious what happens in the callers.One caller is converted to return zero explicitly. The only other caller(smd_subdev_stop() in drivers/remoteproc/qcom_common.c) already ignoredthe return value before.Signed-off-by: Uwe Kleine-König Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20230321154039.355098-2-u.kleine-koenig@pengutronix.de List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

65382585 - rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge

Wed, 11 May 2022 12:07:37 +0000

rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edgeof_parse_phandle() returns a node pointer with refcountincremented, we should use of_node_put() on it when done.Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")Signed-off-by: Miaoqian Lin Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220511120737.57374-1-linmq006@gmail.com List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

101042f4 - rpmsg: qcom: correct kerneldoc

Thu, 19 May 2022 07:33:30 +0000

rpmsg: qcom: correct kerneldocCorrect kerneldoc warnings like: drivers/rpmsg/qcom_glink_ssr.c:45: warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() insteadAlso fix meaning of 'flag' argument.Signed-off-by: Krzysztof Kozlowski Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220519073330.7187-3-krzysztof.kozlowski@linaro.org List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

766279a8 - rpmsg: qcom: glink: replace strncpy() with strscpy_pad()

Thu, 19 May 2022 07:33:28 +0000

rpmsg: qcom: glink: replace strncpy() with strscpy_pad()The use of strncpy() is considered deprecated for NUL-terminatedstrings[1]. Replace strncpy() with strscpy_pad(), to keep existingpad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg:glink: Replace strncpy() with strscpy_pad()"). This fixes W=1 warning: In function ‘qcom_glink_rx_close’, inlined from ‘qcom_glink_work’ at ../drivers/rpmsg/qcom_glink_native.c:1638:4: drivers/rpmsg/qcom_glink_native.c:1549:17: warning: ‘strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] 1549 | strncpy(chinfo.name, channel->name, sizeof(chinfo.name));[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-stringsSigned-off-by: Krzysztof Kozlowski Reviewed-by: Stephen Boyd Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220519073330.7187-1-krzysztof.kozlowski@linaro.org List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

59d6f72f - rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() fails

Sat, 23 Apr 2022 09:39:32 +0000

rpmsg: qcom_smd: Fix returning 0 if irq_of_parse_and_map() failsirq_of_parse_and_map() returns 0 on failure, so this should not bepassed further as error return code.Fixes: 1a358d350664 ("rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value")Signed-off-by: Krzysztof Kozlowski Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220423093932.32136-1-krzysztof.kozlowski@linaro.org List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

1a358d35 - rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value

Fri, 22 Apr 2022 10:53:26 +0000

rpmsg: qcom_smd: Fix irq_of_parse_and_map() return valueThe irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO.Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")Signed-off-by: Krzysztof Kozlowski Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220422105326.78713-1-krzysztof.kozlowski@linaro.org List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

472f84ee - rpmsg: Update rpmsg_chrdev_register_device function

Mon, 24 Jan 2022 10:25:20 +0000

rpmsg: Update rpmsg_chrdev_register_device functionThe rpmsg_chrdev driver has been replaced by the rpmsg_ctrl driverfor the /dev/rpmsg_ctrlX devices management. The reference for thedriver override is now the rpmsg_ctrl.Update the rpmsg_chrdev_register_device function to reflect the update,and rename the function to use the rpmsg_ctrldev prefix.The platform drivers are updated accordingly.Signed-off-by: Arnaud Pouliquen Reviewed-by: Mathieu Poirier Reviewed-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220124102524.295783-8-arnaud.pouliquen@foss.st.com List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

db64e7e7 - rpmsg: qcom_smd: Fix redundant channel->registered assignment

Fri, 14 Jan 2022 13:32:59 +0000

rpmsg: qcom_smd: Fix redundant channel->registered assignmentIn qcom_channel_state_worker(), we are setting channel->registeredto true when registering a channel, but this is getting repeated bothbefore and after re-locking the channels_lock spinlock, which isobviously a typo.Remove the assignment done out of the spinlock to fix this redundancy.Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")Signed-off-by: AngeloGioacchino Del Regno Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220114133259.247726-1-angelogioacchino.delregno@collabora.com List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

a8f8cc6b - rpmsg: smd: allow opening rpm_requests even if already opened

Sun, 20 Feb 2022 20:18:58 +0000

rpmsg: smd: allow opening rpm_requests even if already openedOn msm8953 the channel seems to be already opened when booting Linux butwe still need to open it for communication with regulators etc.Signed-off-by: Luca Weiss Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20220220201909.445468-6-luca@z3ntu.xyz List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

9d85fb73 - rpmsg: qcom_smd: Promote to arch_initcall

Thu, 30 Dec 2021 02:32:53 +0000

rpmsg: qcom_smd: Promote to arch_initcallqcom_smd's only child, smd-rpm uses arch_initcall and both have to be upbefore almost anything else to ensure the MSM SoCs will work fine andnothing will have to resort to probe defering, as this is the main pillarof all things DVFS on these machines. Promote it to arch_initcall to avoidsuch issues.Signed-off-by: Konrad Dybcio Signed-off-by: Bjorn Andersson Link: https://lore.kernel.org/r/20211230023253.1123142-1-konrad.dybcio@somainline.org List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

631af6e0 - rpmsg: Fix documentation return formatting

Mon, 08 Nov 2021 14:01:26 +0000

rpmsg: Fix documentation return formattingkernel documentation specification:"The return value, if any, should be described in a dedicated sectionnamed Return."Signed-off-by: Arnaud Pouliquen Link: https://lore.kernel.org/r/20211108140126.3530-1-arnaud.pouliquen@foss.st.comSigned-off-by: Mathieu Poirier List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

b4ce7e2e - rpmsg: char: Use rpmsg_sendto to specify the message destination address

Thu, 11 Mar 2021 14:04:11 +0000

rpmsg: char: Use rpmsg_sendto to specify the message destination addressWhen the endpoint device is created by the application, a destinationaddress is specified in the rpmsg_channel_info structure. Since therpmsg_endpoint structure does not store the destination address,this destination address must be specified when sending a message.Replaces rpmsg_send with rpmsg_sendto to allow to specify thedestination address. This implementation is requested for compatibly withsome rpmsg backends like the virtio backend.For this, the GLINK an SMD drivers have been updated to support therpmsg_sendto, even if the destination address is ignored for thesebackends. For these drivers, the rpmsg_send and rpmsg_trysend ops arepreserved to avoid breaking the legacy.Signed-off-by: Arnaud Pouliquen Reviewed-by: Bjorn Andersson Reviewed-by: Mathieu Poirier Link: https://lore.kernel.org/r/20210311140413.31725-5-arnaud.pouliquen@foss.st.comSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

e69ee0cf - rpmsg: smd: Fix a kobj leak in in qcom_smd_parse_edge()

Tue, 08 Sep 2020 07:18:41 +0000

rpmsg: smd: Fix a kobj leak in in qcom_smd_parse_edge()We need to call of_node_put(node) on the error paths for this function.Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200908071841.GA294938@mwandaSigned-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

940c620d - rpmsg: smd: fix memory leak on channel create

Thu, 27 Sep 2018 21:36:27 +0000

rpmsg: smd: fix memory leak on channel createCurrently a failed allocation of channel->name leads to animmediate return without freeing channel. Fix this by settingret to -ENOMEM and jumping to an exit path that kfree's channel.Detected by CoverityScan, CID#1473692 ("Resource Leak")Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")Cc: stable@vger.kernel.orgSigned-off-by: Colin Ian King Signed-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

c8a54c0c - rpmsg: Convert to using %pOFn instead of device_node.name

Tue, 28 Aug 2018 01:52:43 +0000

rpmsg: Convert to using %pOFn instead of device_node.nameIn preparation to remove the node name pointer from struct device_node,convert printf users to use the %pOFn format specifier.Cc: Ohad Ben-Cohen Cc: Bjorn Andersson Cc: linux-remoteproc@vger.kernel.orgSigned-off-by: Rob Herring Signed-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

82eca590 - rpmsg: smd: fix kerneldoc warnings

Mon, 18 Jun 2018 12:33:39 +0000

rpmsg: smd: fix kerneldoc warningsThis patch fixes below kerneldoc warningsqcom_smd.c:141: warning: Function parameter or member 'dev' not described in 'qcom_smd_edge'qcom_smd.c:141: warning: Function parameter or member 'name' not described in 'qcom_smd_edge'qcom_smd.c:141: warning: Function parameter or member 'new_channel_event' not described in 'qcom_smd_edge'qcom_smd.c:222: warning: Function parameter or member 'qsept' not described in 'qcom_smd_channel'qcom_smd.c:222: warning: Function parameter or member 'registered' not described in 'qcom_smd_channel'qcom_smd.c:222: warning: Function parameter or member 'state_change_event' not described in 'qcom_smd_channel'qcom_smd.c:222: warning: Function parameter or member 'drvdata' not described in 'qcom_smd_channel'qcom_smd.c:737: warning: Function parameter or member 'wait' not described in '__qcom_smd_send'Signed-off-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c

67cd0eec - rpmsg: smd: Add missing include of sizes.h

Fri, 29 Jun 2018 17:01:01 +0000

rpmsg: smd: Add missing include of sizes.hAdd missing include of sizes.h.drivers/rpmsg/qcom_smd.c: In function ‘qcom_smd_channel_open’:drivers/rpmsg/qcom_smd.c:809:36: error: ‘SZ_4K’ undeclared (first use in this function) bb_size = min(channel->fifo_size, SZ_4K); ^~~~~Signed-off-by: Niklas Cassel Signed-off-by: Bjorn Andersson List of files: /linux-6.15/drivers/rpmsg/qcom_smd.c