Changes in pinctrl-single.c

ffb74749 - pinctrl: single: add marvell,pxa1908-padconf compatible

Mon, 04 Nov 2024 16:37:05 +0000

pinctrl: single: add marvell,pxa1908-padconf compatibleAdd the "marvell,pxa1908-padconf" compatible to allow migrating to aseparate pinctrl driver later.Acked-by: Linus Walleij Signed-off-by: Duje Mihanović Link: https://lore.kernel.org/20241104-pxa1908-lkml-v13-3-e050609b8d6c@skole.hrSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

1a075b1d - pinctrl: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:05 +0000

pinctrl: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/pinctrl to use .remove(),with the eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/20241007205803.444994-8-u.kleine-koenig@baylibre.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

cacd8cf7 - pinctrl: single: fix missing error code in pcs_probe()

Mon, 19 Aug 2024 02:46:25 +0000

pinctrl: single: fix missing error code in pcs_probe()If pinctrl_enable() fails in pcs_probe(), it should return the error code.Fixes: 8f773bfbdd42 ("pinctrl: single: fix possible memory leak when pinctrl_enable() fails")Signed-off-by: Yang Yingliang Link: https://lore.kernel.org/20240819024625.154441-1-yangyingliang@huaweicloud.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

1c38a62f - pinctrl: single: fix potential NULL dereference in pcs_get_function()

Thu, 08 Aug 2024 04:13:55 +0000

pinctrl: single: fix potential NULL dereference in pcs_get_function()pinmux_generic_get_function() can return NULL and the pointer 'function'was dereferenced without checking against NULL. Add checking of pointer'function' in pcs_get_function().Found by code review.Cc: stable@vger.kernel.orgFixes: 571aec4df5b7 ("pinctrl: single: Use generic pinmux helpers for managing functions")Signed-off-by: Ma Ke Link: https://lore.kernel.org/20240808041355.2766009-1-make24@iscas.ac.cnSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

8f773bfb - pinctrl: single: fix possible memory leak when pinctrl_enable() fails

Thu, 06 Jun 2024 02:37:03 +0000

pinctrl: single: fix possible memory leak when pinctrl_enable() failsThis driver calls pinctrl_register_and_init() which is notdevm_ managed, it will leads memory leak if pinctrl_enable()fails. Replace it with devm_pinctrl_register_and_init().And call pcs_free_resources() if pinctrl_enable() fails.Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()")Signed-off-by: Yang Yingliang Reviewed-by: Dan Carpenter Link: https://lore.kernel.org/r/20240606023704.3931561-3-yangyingliang@huawei.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

b5fe46ef - pinctrl: single: Fix PIN_CONFIG_BIAS_DISABLE handling

Tue, 19 Mar 2024 11:06:34 +0000

pinctrl: single: Fix PIN_CONFIG_BIAS_DISABLE handlingThe pinctrl-single driver handles pin_config_set by looking up therequested setting in a DT-defined lookup table, which defines what bitscorrespond to each setting. There is no way to addPIN_CONFIG_BIAS_DISABLE entries to the table, since there is insteadcode to disable the bias by applying the disable values of both thepullup and pulldown entries in the table.However, this code is inside the table-lookup loop, so it would onlyexecute if there is an entry for PIN_CONFIG_BIAS_DISABLE in the table,which can never exist, so this code never runs.This commit lifts the offending code out of the loop, so it justexecutes directly whenever PIN_CONFIG_BIAS_DISABLE is requested,skippipng the table lookup loop.This also introduces a new `param` variable to make the code slightlymore readable.This bug seems to have existed when this code was first merged in commit9dddb4df90d13 ("pinctrl: single: support generic pinconf"). Earlierversions of this patch did have an entry for PIN_CONFIG_BIAS_DISABLE inthe lookup table, but that was removed, which is probably how this bugwas introduced.Signed-off-by: Matthijs Kooijman Reviewed-by: Haojian Zhuang Reviewed-by: Tony Lindgren Message-ID: <20240319110633.230329-1-matthijs@stdin.nl>Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

a95e2bc8 - pinctrl: pinctrl-single: Remove some unused fields in struct pcs_function

Mon, 01 Apr 2024 20:48:55 +0000

pinctrl: pinctrl-single: Remove some unused fields in struct pcs_functionIn "struct pcs_function", the 'pgnames' and 'npgnames' fields are unused.This is a left-over from commit 571aec4df5b7 ("pinctrl: single: Use genericpinmux helpers for managing functions");Remove them.Found with cppcheck, unusedStructMember.Signed-off-by: Christophe JAILLET Message-ID: Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

85dfe458 - pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirq

Mon, 04 Mar 2024 15:35:45 +0000

pinctrl: pinctrl-single: move suspend()/resume() callbacks to noirqThe goal is to extend the active period of pinctrl.Some devices may need active pinctrl after suspend() and/or beforeresume().So move suspend()/resume() to suspend_noirq()/resume_noirq() in order tohave active pinctrl until suspend_noirq() (included), and fromresume_noirq() (included).The deprecated API has been removed to use the new one (dev_pm_ops struct).No need to check the pointer returned by dev_get_drvdata(), asplatform_set_drvdata() is called during the probe.Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko Signed-off-by: Thomas Richard Reviewed-by: Tony Lindgren Reviewed-by: Dhruva Gole Message-ID: <20240102-j7200-pcie-s2r-v4-2-6f1f53390c85@bootlin.com>Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

e24b623d - pinctrl: pinctrl-single: add ti,j7200-padconf compatible

Tue, 28 Nov 2023 15:35:00 +0000

pinctrl: pinctrl-single: add ti,j7200-padconf compatibleOn j7200, during suspend to ram pinctrl contexts are lost. To save andrestore contexts during suspend/resume, the flag PCS_CONTEXT_LOSS_OFFshall be set.Signed-off-by: Thomas Richard Reviewed-by: Tony Lindgren Link: https://lore.kernel.org/r/20231128-j7200-pinctrl-s2r-v1-2-704e7dc24460@bootlin.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

a6992a0d - pinctrl: single: Convert to platform remove callback returning void

Mon, 09 Oct 2023 08:38:48 +0000

pinctrl: single: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231009083856.222030-13-u.kleine-koenig@pengutronix.deSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

71e67026 - pinctrl: single: Drop if block with always false condition

Mon, 09 Oct 2023 08:38:38 +0000

pinctrl: single: Drop if block with always false conditionpcs_remove() is only called after pcs_probe() completed successfully. Inthis case platform_set_drvdata() was called with a non-NULL argument andso platform_get_drvdata() won't return NULL.Simplify by removing the if block with the always false condition.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231009083856.222030-3-u.kleine-koenig@pengutronix.deSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

af68c2af - pinctrl: single: remove get rid of __maybe_unused

Thu, 24 Aug 2023 06:45:08 +0000

pinctrl: single: remove get rid of __maybe_unusedThese are always used in pcs_probe().While I was here, I also changed 'unsigned' in the same line to'unsigned int' to address the checkpatch warnings: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'Signed-off-by: Masahiro Yamada Link: https://lore.kernel.org/r/20230824064508.968142-1-masahiroy@kernel.orgSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

0cec950d - pinctrl: single: Add compatible for ti,am654-padconf

Tue, 08 Aug 2023 10:22:08 +0000

pinctrl: single: Add compatible for ti,am654-padconfUse the "ti,am654-padconf" compatible to enable the use of wake-up enableand event bits on K3 SOCs that support the daisychain featureSigned-off-by: Tony Lindgren Signed-off-by: Dhruva Gole Link: https://lore.kernel.org/r/20230808102207.130177-3-d-gole@ti.com[Alphabetized the compatible list]Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

060f03e9 - pinctrl: Explicitly include correct DT includes

Fri, 14 Jul 2023 17:48:54 +0000

pinctrl: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Reviewed-by: Damien Le Moal Acked-by: Emil Renner Berthing Acked-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20230714174901.4062397-1-robh@kernel.orgSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

e0e8fbf8 - pinctrl: Use of_property_present() for testing DT property presence

Fri, 10 Mar 2023 14:47:20 +0000

pinctrl: Use of_property_present() for testing DT property presenceIt is preferred to use typed property access functions (i.e.of_property_read_ functions) rather than low-levelof_get_property/of_find_property functions for reading properties. Aspart of this, convert of_get_property/of_find_property calls to therecently added of_property_present() helper when we just want to testfor presence of a property and nothing more.Signed-off-by: Rob Herring Reviewed-by: Geert Uytterhoeven Reviewed-by: Jernej Skrabec Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/20230310144721.1544669-1-robh@kernel.org[Dropped hunk hitting drivers/pinctrl/renesas/pinctrl.c]Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

d2d73e6d - pinctrl: single: fix potential NULL dereference

Fri, 18 Nov 2022 10:43:32 +0000

pinctrl: single: fix potential NULL dereferenceAdded checking of pointer "function" in pcs_set_mux().pinmux_generic_get_function() can return NULL and the pointer"function" was dereferenced without checking against NULL.Found by Linux Verification Center (linuxtesting.org) with SVACE.Fixes: 571aec4df5b7 ("pinctrl: single: Use generic pinmux helpers for managing functions")Signed-off-by: Maxim Korotkov Reviewed-by: Tony Lindgren Link: https://lore.kernel.org/r/20221118104332.943-1-korotkov.maxim.s@gmail.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

64c15033 - pinctrl: single: Fix potential division by zero

Thu, 17 Nov 2022 12:30:34 +0000

pinctrl: single: Fix potential division by zeroThere is a possibility of dividing by zero due to the pcs->bits_per_pinif pcs->fmask() also has a value of zero and called flsfrom asm-generic/bitops/builtin-fls.h or arch/x86/include/asm/bitops.h.The function pcs_probe() has the branch that assigned to fmask 0 beforepcs_allocate_pin_table() was calledFound by Linux Verification Center (linuxtesting.org) with SVACE.Fixes: 4e7e8017a80e ("pinctrl: pinctrl-single: enhance to configure multiple pins of different modules")Signed-off-by: Maxim Korotkov Reviewed-by: Tony Lindgren Link: https://lore.kernel.org/r/20221117123034.27383-1-korotkov.maxim.s@gmail.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

486e0d87 - pinctrl: single: Add missing header(s)

Fri, 07 Oct 2022 13:44:44 +0000

pinctrl: single: Add missing header(s)Do not imply that some of the generic headers may be always included.Instead, include explicitly what we are direct user of.While at it, sort headers alphabetically.Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

a9cb09b7 - pinctrl: Bulk conversion to generic_handle_domain_irq()

Tue, 04 May 2021 16:42:18 +0000

pinctrl: Bulk conversion to generic_handle_domain_irq()Wherever possible, replace constructs that match eithergeneric_handle_irq(irq_find_mapping()) orgeneric_handle_irq(irq_linear_revmap()) to a single call togeneric_handle_domain_irq().Acked-by: Krzysztof Kozlowski Acked-by: Linus Walleij Signed-off-by: Marc Zyngier List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c

2ac48d0d - pinctrl: single: Move test PCS_HAS_PINCONF in pcs_parse_bits_in_pinctrl_entry() to the beginning

Thu, 22 Jul 2021 03:39:30 +0000

pinctrl: single: Move test PCS_HAS_PINCONF in pcs_parse_bits_in_pinctrl_entry() to the beginningThe value of pcs->flags is not overwritten in functionpcs_parse_bits_in_pinctrl_entry() and its subfunctions, so moving thischeck to the beginning of the function eliminates unnecessary rollbackoperations.Signed-off-by: Zhen Lei Reviewed-by: Tony Lindgren Link: https://lore.kernel.org/r/20210722033930.4034-3-thunder.leizhen@huawei.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/pinctrl-single.c