Changes in pinctrl-cherryview.c

d795fb90 - pinctrl: cherryview: use devm_kmemdup_array()

Wed, 12 Feb 2025 06:25:08 +0000

pinctrl: cherryview: use devm_kmemdup_array()Convert to use devm_kmemdup_array() and while at it, use source sizeinstead of destination.Signed-off-by: Raag Jadav Reviewed-by: Linus Walleij Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

cdd30ebb - module: Convert symbol namespace to string literal

Mon, 02 Dec 2024 14:59:47 +0000

module: Convert symbol namespace to string literalClean up the existing export namespace code along the same lines ofcommit 33def8498fdd ("treewide: Convert macro and uses of __section(foo)to __section("foo")") and for the same reason, it is not desired for thenamespace argument to be a macro expansion itself.Scripted using git grep -l -e MODULE_IMPORT_NS -e EXPORT_SYMBOL_NS | while read file; do awk -i inplace ' /^#define EXPORT_SYMBOL_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /^#define MODULE_IMPORT_NS/ { gsub(/__stringify$ns$/, "ns"); print; next; } /MODULE_IMPORT_NS/ { $0 = gensub(/MODULE_IMPORT_NS$([^)]*)$/, "MODULE_IMPORT_NS(\"\\1\")", "g"); } /EXPORT_SYMBOL_NS/ { if ($0 ~ /(EXPORT_SYMBOL_NS[^(]*)$([^,]+),/) { if ($0 !~ /(EXPORT_SYMBOL_NS[^(]*)\(([^,]+), ([^)]+)$/ && $0 !~ /(EXPORT_SYMBOL_NS[^(]*)/ && $0 !~ /^my/) { getline line; gsub(/[[:space:]]*\\$/, ""); gsub(/[[:space:]]/, "", line); $0 = $0 " " line; } $0 = gensub(/(EXPORT_SYMBOL_NS[^(]*)$([^,]+), ([^)]+)$/, "\\1(\\2, \"\\3\")", "g"); } } { print }' $file; doneRequested-by: Masahiro Yamada Signed-off-by: Peter Zijlstra (Intel) Link: https://mail.google.com/mail/u/2/#inbox/FMfcgzQXKWgMmjdFwwdsfgxzKpVHWPlcAcked-by: Greg KH Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

1a075b1d - pinctrl: Switch back to struct platform_driver::remove()

Mon, 07 Oct 2024 20:58:05 +0000

pinctrl: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/pinctrl to use .remove(),with the eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/20241007205803.444994-8-u.kleine-koenig@baylibre.comSigned-off-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

b679d6c0 - treewide: rename pinctrl_gpio_direction_output_new()

Tue, 03 Oct 2023 09:59:51 +0000

treewide: rename pinctrl_gpio_direction_output_new()Now that pinctrl_gpio_direction_output() is no longer used, let's dropthe '_new' suffix from its improved variant.Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

315c46f9 - treewide: rename pinctrl_gpio_direction_input_new()

Tue, 03 Oct 2023 09:58:30 +0000

treewide: rename pinctrl_gpio_direction_input_new()Now that pinctrl_gpio_direction_input() is no longer used, let's drop the'_new' suffix from its improved variant.Signed-off-by: Bartosz Golaszewski Acked-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

588ad2b1 - pinctrl: cherryview: use new pinctrl GPIO helpers

Fri, 13 Oct 2023 11:54:10 +0000

pinctrl: cherryview: use new pinctrl GPIO helpersReplace the pinctrl helpers taking the global GPIO number as argumentwith the improved variants that instead take a pointer to the GPIO chipand the controller-relative offset.Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Acked-by: Mika Westerberg Acked-by: Linus Walleij List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

6fe13aa7 - pinctrl: cherryview: reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE case

Wed, 11 Oct 2023 06:45:33 +0000

pinctrl: cherryview: reduce scope of PIN_CONFIG_BIAS_HIGH_IMPEDANCE caseWe have a couple of pinconfig cases inside the braces which are meant forPIN_CONFIG_BIAS_HIGH_IMPEDANCE case. Although it is valid C, it makes thecode less readable and prone to misinterpretation. Limit the braces toPIN_CONFIG_BIAS_HIGH_IMPEDANCE case to avoid this.Signed-off-by: Raag Jadav Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

e0ba7366 - pinctrl: cherryview: Convert to platform remove callback returning void

Mon, 09 Oct 2023 08:38:41 +0000

pinctrl: cherryview: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

d59b099c - pinctrl: cherryview: Simplify code with cleanup helpers

Fri, 06 Oct 2023 09:40:33 +0000

pinctrl: cherryview: Simplify code with cleanup helpersUse macros defined in linux/cleanup.h to automate resource lifetimecontrol in the driver.Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

d3386552 - pinctrl: cherryview: Avoid duplicated I/O

Fri, 06 Oct 2023 09:40:32 +0000

pinctrl: cherryview: Avoid duplicated I/OIn some cases we already read the value from the register followedby a reading of it again for other purposes, but the both readsare under the lock and bits we are insterested in are not goingto change (they are not volatile from HW perspective). Hence, noneed to read the same register twice.Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

315ef5fc - pinctrl: cherryview: Replace kernel.h by what is actually being used

Tue, 03 Oct 2023 12:10:11 +0000

pinctrl: cherryview: Replace kernel.h by what is actually being usedThe kernel.h is a mess of unrelated things and we only used itas a proxy to array_size.h, hence switch from former to the latter.Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

d5301c90 - pinctrl: cherryview: fix address_space_handler() argument

Tue, 22 Aug 2023 07:23:40 +0000

pinctrl: cherryview: fix address_space_handler() argumentFirst argument of acpi_*_address_space_handler() APIs is acpi_handle ofthe device, which is incorrectly passed in driver ->remove() path here.Fix it by passing the appropriate argument and while at it, make bothAPI calls consistent using ACPI_HANDLE().Fixes: a0b028597d59 ("pinctrl: cherryview: Add support for GMMR GPIO opregion")Cc: stable@vger.kernel.orgSigned-off-by: Raag Jadav Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

e5f32bf0 - pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper

Mon, 17 Jul 2023 17:28:14 +0000

pinctrl: cherryview: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helperSince pm.h provides a helper for system no-IRQ PM callbacks,switch the driver to use it instead of open coded variant.Reviewed-by: Jonathan Cameron Link: https://lore.kernel.org/r/20230717172821.62827-4-andriy.shevchenko@linux.intel.comSigned-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

a2118ceb - pinctrl: cherryview: reuse common functions from pinctrl-intel

Mon, 14 Aug 2023 06:03:10 +0000

pinctrl: cherryview: reuse common functions from pinctrl-intelReuse common functions from pinctrl-intel driver.Signed-off-by: Raag Jadav Acked-by: Mika Westerberg Link: https://lore.kernel.org/r/20230814060311.15945-4-raag.jadav@intel.comSigned-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

9314d053 - pinctrl: cherryview: Drop goto label

Mon, 19 Jun 2023 13:20:12 +0000

pinctrl: cherryview: Drop goto labelWe do not use goto labels in the Intel pin control drivers,so drop the only one in the entire folder.Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

5835196a - pinctrl: cherryview: Return correct value if pin in push-pull mode

Mon, 05 Jun 2023 14:37:34 +0000

pinctrl: cherryview: Return correct value if pin in push-pull modeCurrently the getter returns ENOTSUPP on pin configured inthe push-pull mode. Fix this by adding the missed switch case.Fixes: ccdf81d08dbe ("pinctrl: cherryview: add option to set open-drain pin config")Fixes: 6e08d6bbebeb ("pinctrl: Add Intel Cherryview/Braswell pin controller support")Acked-by: Mika Westerberg Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

0633dc4a - pinctrl: cherryview: Don't use IRQ core constanst for invalid IRQ

Fri, 02 Jun 2023 16:46:55 +0000

pinctrl: cherryview: Don't use IRQ core constanst for invalid IRQThe semantics of INVALID_HWIRQ is rather localized to IPI usage.Let's keep it that way.Signed-off-by: Andy Shevchenko List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

3899707a - pinctrl: cherryview: Convert to use new memeber in struct intel_function

Mon, 19 Dec 2022 12:42:36 +0000

pinctrl: cherryview: Convert to use new memeber in struct intel_functionConvert driver to use generic data type and hence a new member inthe struct intel_function. No functional change intended.Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

414fb9f2 - pinctrl: cherryview: Add missing header(s)

Fri, 07 Oct 2022 13:44:44 +0000

pinctrl: cherryview: Add missing header(s)Do not imply that some of the generic headers may be always included.Instead, include explicitly what we are direct user of.While at it, sort headers alphabetically.Signed-off-by: Andy Shevchenko Reviewed-by: Mika Westerberg List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c

2c292a78 - pinctrl: cherryview: Switch to to embedded struct pingroup

Mon, 20 Jun 2022 11:28:48 +0000

pinctrl: cherryview: Switch to to embedded struct pingroupSince struct intel_pingroup got a new member, switch the driver to use it.Signed-off-by: Andy Shevchenko Acked-by: Mika Westerberg List of files: /linux-6.15/drivers/pinctrl/intel/pinctrl-cherryview.c