Changes in arm_pmu_platform.c

48b03512 - perf: arm_pmu: Use of_property_present()

Wed, 31 Jul 2024 19:12:53 +0000

perf: arm_pmu: Use of_property_present()Use of_property_present() to test for property presence rather thanof_find_property(). This is part of a larger effort to remove callersof of_find_property() and similar functions. of_find_property() leaksthe DT struct property and data pointers which is a problem fordynamically allocated nodes which may be freed.Signed-off-by: Rob Herring (Arm) Acked-by: Mark Rutland Reviewed-by: Anshuman Khandual Link: https://lore.kernel.org/r/20240731191312.1710417-15-robh@kernel.orgSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

7bf75431 - perf/arm_pmu: Assign parents for event_source devices

Fri, 12 Apr 2024 16:10:43 +0000

perf/arm_pmu: Assign parents for event_source devicesCurrently the PMU device appears directly under /sys/devices/Only root busses should appear there, so instead assign the pmu->devparent to be the platform device.Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/Signed-off-by: Jonathan Cameron Reviewed-by: Suzuki K Poulose Link: https://lore.kernel.org/r/20240412161057.14099-17-Jonathan.Cameron@huawei.comSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

918dc87b - drivers/perf: Explicitly include correct DT includes

Fri, 14 Jul 2023 17:48:31 +0000

drivers/perf: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230714174832.4061752-1-robh@kernel.orgSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

6bb0d64c - perf/arm_pmu_platform: fix tests for platform_get_irq() failure

Thu, 25 Aug 2022 01:18:44 +0000

perf/arm_pmu_platform: fix tests for platform_get_irq() failureThe platform_get_irq() returns negative error codes. It can't actuallyreturn zero.Signed-off-by: Yu Zhe Link: https://lore.kernel.org/r/20220825011844.8536-1-yuzhe@nfschina.comSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

e20ac6c5 - perf/arm_pmu_platform: Clean up with dev_printk

Fri, 26 Mar 2021 16:02:42 +0000

perf/arm_pmu_platform: Clean up with dev_printkNearly all of the messages we can log from the platform device coderelate to the specific PMU device and the properties we're parsing fromits DT node. In some cases we use %pOF to point at where something waswrong, but even that is inconsistent. Let's convert these logs to theappropriate dev_printk variants, so that every issue specific to thedevice and/or its DT description is clearly and instantly attributable,particularly if there is more than one PMU node present in the DT.The local refactoring in a couple of functions invites some extracleanup in the process - the init_fn matching can be streamlined, andthe PMU registration failure message moved to the appropriate place andlog level.CC: Tian Tao Signed-off-by: Robin Murphy Link: https://lore.kernel.org/r/10a4aacdf071d0c03d061c408a5899e5b32cc0a6.1616774562.git.robin.murphy@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

e338cb6b - perf/arm_pmu_platform: Fix error handling

Fri, 26 Mar 2021 16:02:41 +0000

perf/arm_pmu_platform: Fix error handlingIf we're aborting after failing to register the PMU device,we probably don't want to leak the IRQs that we've claimed.Signed-off-by: Robin Murphy Link: https://lore.kernel.org/r/53031a607fc8412a60024bfb3bb8cd7141f998f5.1616774562.git.robin.murphy@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

11fa1dc8 - perf/arm_pmu_platform: Use dev_err_probe() for IRQ errors

Fri, 26 Mar 2021 16:02:40 +0000

perf/arm_pmu_platform: Use dev_err_probe() for IRQ errorsBy virtue of using platform_irq_get_optional() under the covers,platform_irq_count() needs the target interrupt controller to beavailable and may return -EPROBE_DEFER if it isn't. Let's usedev_err_probe() to avoid a spurious error log (and help debug anydeferral issues) in that case.Reported-by: Paul Menzel Signed-off-by: Robin Murphy Link: https://lore.kernel.org/r/073d5e0d3ed1f040592cb47ca6fe3759f40cc7d1.1616774562.git.robin.murphy@arm.comSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

03630b3b - perf: Convert to using %pOFn instead of device_node.name

Tue, 28 Aug 2018 01:52:39 +0000

perf: Convert to using %pOFn instead of device_node.nameIn preparation to remove the node name pointer from struct device_node,convert printf users to use the %pOFn format specifier.Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgAcked-by: Will Deacon Signed-off-by: Rob Herring Signed-off-by: Catalin Marinas List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

59b62e7a - drivers/perf: Initialise return value in armpmu_request_irqs()

Wed, 04 Jul 2018 10:50:50 +0000

drivers/perf: Initialise return value in armpmu_request_irqs()If a PMU doesn't have any IRQs, we should return 0 fromarmpmu_request_irqs(), rather than uninitialised stack.Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

65bd053f - drivers/perf: arm_pmu_platform: do not warn about affinity on uniprocessor

Thu, 01 Mar 2018 20:25:36 +0000

drivers/perf: arm_pmu_platform: do not warn about affinity on uniprocessorIf there is exactly one CPU present, there is no ambiguity: do not warnthat PMU setup would need to guess IRQ affinity.Cc: Mark Rutland Cc: Will Deacon Signed-off-by: Alexander Monakov Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

167e6143 - arm_pmu: acpi: request IRQs up-front

Mon, 09 Oct 2017 16:09:05 +0000

arm_pmu: acpi: request IRQs up-frontWe can't request IRQs in atomic context, so for ACPI systems we'll haveto request them up-front, and later associate them with CPUs.This patch reorganises the arm_pmu code to do so. As we no longer havethe arm_pmu structure at probe time, a number of prototypes need to beadjusted, requiring changes to the common arm_pmu code and arm_pmuplatform code.Signed-off-by: Mark Rutland Cc: Will Deacon Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

43fc9a2f - arm_pmu: acpi: check for mismatched PPIs

Mon, 05 Feb 2018 16:41:59 +0000

arm_pmu: acpi: check for mismatched PPIsThe arm_pmu platform code explicitly checks for mismatched PPIs at probetime, while the ACPI code leaves this to the core code. Futurerefactoring will make this difficult for the core code to check, solet's have the ACPI code check this explicitly.As before, upon a failure we'll continue on without an interrupt. Hohum.Signed-off-by: Mark Rutland Cc: Will Deacon Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

d3d5aac2 - arm_pmu: fold platform helpers into platform code

Mon, 05 Feb 2018 16:41:57 +0000

arm_pmu: fold platform helpers into platform codeThe armpmu_{request,free}_irqs() helpers are only used byarm_pmu_platform.c, so let's fold them in and make them static.Signed-off-by: Mark Rutland Cc: Will Deacon Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

66582787 - arm_pmu: Use of_cpu_node_to_id helper

Tue, 02 Jan 2018 11:25:31 +0000

arm_pmu: Use of_cpu_node_to_id helperUse the new generic helper, of_cpu_node_to_id(), to map aa phandle to the logical CPU number while parsing thePMU irq affinity.Cc: Will Deacon Acked-by: Mark Rutland Signed-off-by: Suzuki K Poulose Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

611479c7 - arm/arm64: pmu: Distinguish percpu irq and percpu_devid irq

Fri, 13 Oct 2017 11:26:45 +0000

arm/arm64: pmu: Distinguish percpu irq and percpu_devid irqarm_pmu interrupts are maked as PERCPU even when these are not localphysical interrupts to a single CPU. When using non-local interrupts,interrupts marked as PERCPU will not get freed not disabled properlyby the PMU driver.Check if interrupts are local to a single CPU with PERCPU_DEVID sincethis is what the PMU driver really needs to know.Acked-by: Mark Rutland Signed-off-by: Julien Thierry Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

5f4216f4 - perf: Convert to using %pOF instead of full_name

Tue, 18 Jul 2017 21:43:22 +0000

perf: Convert to using %pOF instead of full_nameNow that we have a custom printf format specifier, convert users offull_name to use %pOF instead. This is preparation to remove storingof the full path string for each node.Signed-off-by: Rob Herring Cc: Will Deacon Cc: Mark Rutland Cc: linux-arm-kernel@lists.infradead.orgSigned-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c

18bfcfe5 - drivers/perf: arm_pmu: split out platform device probe logic

Tue, 11 Apr 2017 08:39:53 +0000

drivers/perf: arm_pmu: split out platform device probe logicNow that we've split the pdev and DT probing logic from the runtimemanagement, let's move the former into its own file. We gain a few linesdue to the copyright header and includes, but this should keep the logicclearly separated, and paves the way for adding ACPI support in asimilar fashion.Signed-off-by: Mark Rutland Tested-by: Jeremy Linton [will: rename nr_irqs to avoid conflict with global variable]Signed-off-by: Will Deacon List of files: /linux-6.15/drivers/perf/arm_pmu_platform.c