Changes in Makefile

a71c5926 - PCI: Move TLP Log handling to its own file

Tue, 14 Jan 2025 17:08:34 +0000

PCI: Move TLP Log handling to its own fileTLP Log is a PCIe feature and is processed only by AER and DPC.Configwise, DPC depends AER being enabled. In lack of better place, the TLPLog handling code was initially placed into pci.c but it can be easilyplaced in a separate file.Move TLP Log handling code to its own file under pcie/ subdirectory andinclude it only when AER is enabled.Link: https://lore.kernel.org/r/20250114170840.1633-3-ilpo.jarvinen@linux.intel.comSigned-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam List of files: /linux-6.15/drivers/pci/pcie/Makefile

665745f2 - PCI/bwctrl: Re-add BW notification portdrv as PCIe BW controller

Fri, 18 Oct 2024 14:47:52 +0000

PCI/bwctrl: Re-add BW notification portdrv as PCIe BW controllerThis mostly reverts the commit b4c7d2076b4e ("PCI/LINK: Remove bandwidthnotification"). An upcoming commit extends this driver building PCIebandwidth controller on top of it.PCIe bandwidth notifications were first added in the commit e8303bb7a75c("PCI/LINK: Report degraded links via link bandwidth notification") butlater had to be removed. The significant changes compared with the oldbandwidth notification driver include:1) Don't print the notifications into kernel log, just keep the Link Speed cached in struct pci_bus updated. While somewhat unfortunate, the log spam was the source of complaints that eventually lead to the removal of the bandwidth notifications driver (see the links below for further information).2) Besides the Link Bandwidth Management Interrupt, also enable Link Autonomous Bandwidth Interrupt to cover the other source of bandwidth changes.3) Handle Link Speed updates robustly. Refresh the cached Link Speed when enabling Bandwidth Notification Interrupts, and solve the race between Link Speed read and LBMS/LABS update in pcie_bwnotif_irq_thread().4) Use concurrency safe LNKCTL RMW operations.5) The driver is now called PCIe bwctrl (bandwidth controller) instead of just bandwidth notifications because of increased scope and functionality within the driver.6) Coexist with the Target Link Speed quirk in pcie_failed_link_retrain(). Provide LBMS counting API for it.7) Tweaks to variable/functions names for consistency and length reasons.Bandwidth Notifications enable the cur_bus_speed in the struct pci_bus tokeep track PCIe Link Speed changes.[bhelgaas: This is based on previous work by Alexandru Gagniuc; see e8303bb7a75c ("PCI/LINK: Report degraded linksvia link bandwidth notification")]Link: https://lore.kernel.org/r/20241018144755.7875-7-ilpo.jarvinen@linux.intel.comLink: https://lore.kernel.org/all/20190429185611.121751-1-helgaas@kernel.org/Link: https://lore.kernel.org/linux-pci/20190501142942.26972-1-keith.busch@intel.com/Link: https://lore.kernel.org/linux-pci/20200115221008.GA191037@google.com/Suggested-by: Lukas Wunner # Building bwctrl on top of bwnotifSigned-off-by: Ilpo Järvinen [bhelgaas: squash fix to drop IRQF_ONESHOT and convert to hardirq handler:https://lore.kernel.org/r/20241115165717.15233-1-ilpo.jarvinen@linux.intel.com]Signed-off-by: Bjorn Helgaas Tested-by: Stefan Wahren Reviewed-by: Jonathan Cameron List of files: /linux-6.15/drivers/pci/pcie/Makefile

f3994bba - PCI/ASPM: Always build aspm.c

Fri, 23 Feb 2024 20:58:48 +0000

PCI/ASPM: Always build aspm.cSome ASPM-related tasks, such as save and restore of LTR and L1SScapabilities, still need to be performed when CONFIG_PCIEASPM is notenabled. To prepare for these changes, wrap the current code in aspm.cwith an #ifdef and always build the file.Link: https://lore.kernel.org/r/20240128233212.1139663-2-david.e.box@linux.intel.com[bhelgaas: split build change from function moves]Link: https://lore.kernel.org/r/20240223205851.114931-3-helgaas@kernel.orgSigned-off-by: David E. Box Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

a1ccd3d9 - PCI/portdrv: Squash into portdrv.c

Wed, 19 Oct 2022 20:41:25 +0000

PCI/portdrv: Squash into portdrv.cSquash portdrv_core.c and portdrv_pci.c into portdrv.c to make it easier tofind things. The whole thing is less than 1000 lines, and it's a pain tobounce back and forth between two files.Several portdrv_core.c functions were non-static because they werereferenced from portdrv_pci.c. Make them static since they're now all inportdrv.c.No functional change intended.Link: https://lore.kernel.org/r/20221019204127.44463-2-helgaas@kernel.orgSigned-off-by: Bjorn Helgaas Signed-off-by: Bjorn Helgaas Reviewed-by: Christoph Hellwig Reviewed-by: Keith Busch List of files: /linux-6.15/drivers/pci/pcie/Makefile

f9a6c8ad - PCI/ERR: Reduce compile time for CONFIG_PCIEAER=n

Sat, 31 Jul 2021 12:39:04 +0000

PCI/ERR: Reduce compile time for CONFIG_PCIEAER=nThe sole non-static function in err.c, pcie_do_recovery(), is onlycalled from:* aer.c (if CONFIG_PCIEAER=y)* dpc.c (if CONFIG_PCIE_DPC=y, which depends on CONFIG_PCIEAER)* edr.c (if CONFIG_PCIE_EDR=y, which depends on CONFIG_PCIE_DPC)Thus, err.c need not be compiled if CONFIG_PCIEAER=n.Also, pci_uevent_ers() and pcie_clear_device_status(), which are calledfrom err.c, can be #ifdef'ed away unless CONFIG_PCIEAER=y.Since x86_64_defconfig doesn't enable CONFIG_PCIEAER, this change mayslightly reduce compile time for anyone doing a test build with thatconfig.Link: https://lore.kernel.org/r/98f9041151268c1c035ab64cca320ad86803f64a.1627638184.git.lukas@wunner.deSigned-off-by: Lukas Wunner Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

b4c7d207 - PCI/LINK: Remove bandwidth notification

Tue, 02 Feb 2021 20:17:54 +0000

PCI/LINK: Remove bandwidth notificationThe PCIe Bandwidth Change Notification feature logs messages when the linkbandwidth changes. Some users have reported that these messages occuroften enough to significantly reduce NVMe performance. GPUs also seem togenerate these messages.We don't know why the link bandwidth changes, but in the reported casesthere's no indication that it's caused by hardware failures.Remove the bandwidth change notifications for now. Hopefully we can addthis back when we have a better understanding of why this happens and howwe can make the messages useful instead of overwhelming.Link: https://lore.kernel.org/r/20200115221008.GA191037@google.com/Link: https://lore.kernel.org/r/155605909349.3575.13433421148215616375.stgit@gimli.home/Link: https://bugzilla.kernel.org/show_bug.cgi?id=206197Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

90655631 - PCI/ERR: Cache RCEC EA Capability offset in pci_init_capabilities()

Sat, 21 Nov 2020 00:10:24 +0000

PCI/ERR: Cache RCEC EA Capability offset in pci_init_capabilities()Extend support for Root Complex Event Collectors by decoding and cachingthe RCEC Endpoint Association Extended Capabilities when enumerating. Usethat cached information for later error source reporting. See PCIe r5.0,sec 7.9.10.Co-developed-by: Qiuxu Zhuo Link: https://lore.kernel.org/r/20201121001036.8560-4-sean.v.kelley@intel.comTested-by: Jonathan Cameron # non-native/no RCECSigned-off-by: Qiuxu Zhuo Signed-off-by: Sean V Kelley Signed-off-by: Bjorn Helgaas Reviewed-by: Jonathan Cameron List of files: /linux-6.15/drivers/pci/pcie/Makefile

ac1c8e35 - PCI/DPC: Add Error Disconnect Recover (EDR) support

Tue, 24 Mar 2020 00:26:07 +0000

PCI/DPC: Add Error Disconnect Recover (EDR) supportError Disconnect Recover (EDR) is a feature that allows ACPI firmware tonotify OSPM that a device has been disconnected due to an error condition(ACPI v6.3, sec 5.6.6). OSPM advertises its support for EDR on PCI devicesvia _OSC (see [1], sec 4.5.1, table 4-4). The OSPM EDR notify handlershould invalidate software state associated with disconnected devices andmay attempt to recover them. OSPM communicates the status of recovery tothe firmware via _OST (sec 6.3.5.2).For PCIe, firmware may use Downstream Port Containment (DPC) to supportEDR. Per [1], sec 4.5.1, table 4-6, even if firmware has retained controlof DPC, OSPM may read/write DPC control and status registers during the EDRnotification processing window, i.e., from the time it receives an EDRnotification until it clears the DPC Trigger Status.Note that per [1], sec 4.5.1 and 4.5.2.4, 1. If the OS supports EDR, it should advertise that to firmware by setting OSC_PCI_EDR_SUPPORT in _OSC Support. 2. If the OS sets OSC_PCI_EXPRESS_DPC_CONTROL in _OSC Control to request control of the DPC capability, it must also set OSC_PCI_EDR_SUPPORT in _OSC Support.Add an EDR notify handler to attempt recovery.[1] Downstream Port Containment Related Enhancements ECN, Jan 28, 2019, affecting PCI Firmware Specification, Rev. 3.2 https://members.pcisig.com/wg/PCI-SIG/document/12888[bhelgaas: squash add/enable patches into one]Link: https://lore.kernel.org/r/90f91fe6d25c13f9d2255d2ce97ca15be307e1bb.1585000084.git.sathyanarayanan.kuppuswamy@linux.intel.comSigned-off-by: Kuppuswamy Sathyanarayanan Signed-off-by: Bjorn Helgaas Cc: "Rafael J. Wysocki" Cc: Len Brown List of files: /linux-6.15/drivers/pci/pcie/Makefile

2078e1e7 - PCI/LINK: Add Kconfig option (default off)

Wed, 01 May 2019 14:29:42 +0000

PCI/LINK: Add Kconfig option (default off)e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidthnotification") added dmesg logging whenever a link changes speed or widthto a state that is considered degraded. Unfortunately, it cannotdifferentiate signal integrity-related link changes from thoseintentionally initiated by an endpoint driver, including drivers that maylive in userspace or VMs when making use of vfio-pci. Some GPU driversactively manage the link state to save power, which generates a stream ofmessages like this: vfio-pci 0000:07:00.0: 32.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s x16 link at 0000:00:02.0 (capable of 64.000 Gb/s with 5 GT/s x16 link)Since we can't distinguish the intentional changes from the signalintegrity issues, leave the reporting turned off by default. Add a Kconfigoption to turn it on if desired.Fixes: e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidth notification")Link: https://lore.kernel.org/linux-pci/20190501142942.26972-1-keith.busch@intel.comSigned-off-by: Keith Busch Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

e8303bb7 - PCI/LINK: Report degraded links via link bandwidth notification

Wed, 27 Feb 2019 20:58:17 +0000

PCI/LINK: Report degraded links via link bandwidth notificationA warning is generated when a PCIe device is probed with a degraded link,but there was no similar mechanism to warn when the link becomes degradedafter probing. The Link Bandwidth Notification provides this mechanism.Use the Link Bandwidth Management Interrupt to detect bandwidth changes,and rescan the bandwidth, looking for the weakest point. This is the samelogic used in probe().Signed-off-by: Alexandru Gagniuc Signed-off-by: Bjorn Helgaas Reviewed-by: Lukas Wunner List of files: /linux-6.15/drivers/pci/pcie/Makefile

4696b828 - PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/

Fri, 08 Jun 2018 13:48:47 +0000

PCI/AER: Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/Hoist aerdrv.c, aer_inject.c up to drivers/pci/pcie/ so they're next toother PCIe service drivers. No functional change intended.Signed-off-by: Bjorn Helgaas Reviewed-by: Keith Busch List of files: /linux-6.15/drivers/pci/pcie/Makefile

2e28bc84 - PCI/AER: Factor out error reporting to drivers/pci/pcie/err.c

Thu, 17 May 2018 21:44:15 +0000

PCI/AER: Factor out error reporting to drivers/pci/pcie/err.cMove the error reporting callbacks from aerdrv_core.c to err.c, where theycan be used by DPC in addition to AER.As part of aerdrv_core.c, these callbacks were built under CONFIG_PCIEAER.Moving them to the new err.c means they will now be built underCONFIG_PCIEPORTBUS, so adjust the definition of pci_uevent_ers() to match.Signed-off-by: Oza Pawandeep [bhelgaas: in reset_link(), initialize "driver" even if CONFIG_PCIEAER isunset, update pci_uevent_ers() #ifdef wrapper]Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

e02602bd - PCI/DPC: Rename from pcie-dpc.c to dpc.c

Sat, 31 Mar 2018 22:48:57 +0000

PCI/DPC: Rename from pcie-dpc.c to dpc.cRename pcie-dpc.c to dpc.c. The path "drivers/pci/pcie/pcie-dpc.c" hasmore occurrences of "pci" than necessary.Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

02bfeb48 - PCI/portdrv: Simplify PCIe feature permission checking

Fri, 09 Mar 2018 17:21:25 +0000

PCI/portdrv: Simplify PCIe feature permission checkingSome PCIe features (AER, DPC, hotplug, PME) can be managed by either theplatform firmware or the OS, so the host bridge driver may have to requestpermission from the platform before using them. On ACPI systems, this isdone by negotiate_os_control() in acpi_pci_root_add().The PCIe port driver later uses pcie_port_platform_notify() andpcie_port_acpi_setup() to figure out whether it can use these features.But all we need is a single bit for each service, so these interfaces areneedlessly complicated.Simplify this by adding bits in the struct pci_host_bridge to show when theOS has permission to use each feature: + unsigned int native_aer:1; /* OS may use PCIe AER */ + unsigned int native_hotplug:1; /* OS may use PCIe hotplug */ + unsigned int native_pme:1; /* OS may use PCIe PME */These are set when we create a host bridge, and the host bridge driver canclear the bits corresponding to any feature the platform doesn't want us touse.Signed-off-by: Bjorn Helgaas Reviewed-by: Rafael J. Wysocki List of files: /linux-6.15/drivers/pci/pcie/Makefile

c6c889d9 - PCI/portdrv: Remove pcie_port_bus_type link order dependency

Fri, 09 Mar 2018 17:06:56 +0000

PCI/portdrv: Remove pcie_port_bus_type link order dependencyThe pcie_port_bus_type must be registered before drivers that depend on itcan be registered. Those drivers include: pcied_init() # PCIe native hotplug driver aer_service_init() # AER driver dpc_service_init() # DPC driver pcie_pme_service_init() # PME driverPreviously we registered pcie_port_bus_type from pcie_portdrv_init(), adevice_initcall. The callers of pcie_port_service_register() (above) arealso device_initcalls. This is fragile because the device_initcallordering depends on link order, which is not explicit.Register pcie_port_bus_type from pci_driver_init() along with pci_bus_type.This removes the link order dependency between portdrv and the pciehp, AER,DPC, and PCIe PME drivers.Signed-off-by: Bjorn Helgaas Reviewed-by: Rafael J. Wysocki Reviewed-by: Christoph Hellwig List of files: /linux-6.15/drivers/pci/pcie/Makefile

3133e6dd - PCI: Tidy Makefiles

Fri, 09 Mar 2018 19:09:29 +0000

PCI: Tidy MakefilesIndent things so they line up neatly and remove extra blank lines andsuperfluous comments. No functional change intended.Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/pci/pcie/Makefile

9bb04a0c - PCI: Add Precision Time Measurement (PTM) support

Sat, 11 Jun 2016 19:13:38 +0000

PCI: Add Precision Time Measurement (PTM) supportAdd Precision Time Measurement (PTM) support (see PCIe r3.1, sec 6.22).Enable PTM on PTM Root devices and switch ports. This does not enable PTMon endpoints.There currently are no PTM-capable devices on the market, but it isexpected to be supported by the Intel Apollo Lake platform.[bhelgaas: complete rework]Signed-off-by: Jonathan Yong Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/pcie/Makefile

26e51571 - PCI: Add Downstream Port Containment driver

Thu, 28 Apr 2016 22:24:48 +0000

PCI: Add Downstream Port Containment driverAdd driver for the PCI Express Downstream Port Containment extendedcapability. DPC is an optional capability to contain uncorrectable errorsbelow a port.For more information on DPC, please see PCI Express Base SpecificationRevision 4, section 7.31, or view the PCI-SIG DPC ECN here: https://pcisig.com/sites/default/files/specification_documents/ECN_DPC_2012-02-09_finalized.pdfWhen a DPC event is triggered, the hardware disables downstream links, sothe DPC driver schedules removal for all devices below this port. This mayhappen concurrently with a PCIe hotplug driver if enabled. When alldownstream devices are removed and the link state transitions to disabled,the DPC driver clears the DPC status and interrupt bits so the link mayretrain for a newly connected device.[bhelgaas: clear (not set) DPC_CTL bits on remove, whitespace cleanup]Signed-off-by: Keith Busch Signed-off-by: Bjorn Helgaas Cc: Lukas Wunner List of files: /linux-6.15/drivers/pci/pcie/Makefile

271fb719 - PCI: PCIe: Move PCIe PME code to the pcie directory

Fri, 20 Aug 2010 23:58:22 +0000

PCI: PCIe: Move PCIe PME code to the pcie directoryThe PCIe PME code only consists of one file, so it doesn't need tooccupy its own directory. Move it to drivers/pci/pcie/pme.c andremove the contents of drivers/pci/pcie/pme .Signed-off-by: Rafael J. Wysocki Signed-off-by: Jesse Barnes List of files: /linux-6.15/drivers/pci/pcie/Makefile