Changes in TODO

5d8491ae - PCI: shpchp: Remove hpc_ops

Tue, 23 Jul 2024 11:43:25 +0000

PCI: shpchp: Remove hpc_opsRemove the hpc_ops struct from shpchp. This struct is unnecessary and noother hotplug controller implements it. A similar thing has already beendone in pciehp with 82a9e79ef132 ("PCI: pciehp: remove hpc_ops").Link: https://lore.kernel.org/r/Zp-XXVW4hlcMASEc@archbtwSigned-off-by: ngn Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

b023c1c9 - PCI: hotplug: Remove obsolete sgi_hotplug TODO notes

Fri, 03 May 2024 19:23:22 +0000

PCI: hotplug: Remove obsolete sgi_hotplug TODO notesCommit c7532b601e77 ("PCI/hotplug: remove the sgi_hotplug driver") deletedthe driver.Remove the remaining TODO notes as well.Link: https://lore.kernel.org/r/26784ee39fbb3fbd0fe96508158d74419018e6ad.1714762038.git.namcao@linutronix.deSigned-off-by: Nam Cao Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

e6e9a9a4 - PCI: hotplug: Document unchecked return value of pci_hp_add_bridge()

Fri, 03 May 2024 19:23:21 +0000

PCI: hotplug: Document unchecked return value of pci_hp_add_bridge()Some hotplug drivers do not check the return value of pci_hp_add_bridge().This may be problematic if the driver proceeds after pci_hp_add_bridge()fails.Link: https://lore.kernel.org/r/16a2442ea6ee896987a44df3ed509e4cfde44475.1714762038.git.namcao@linutronix.deSigned-off-by: Nam Cao Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

9676f406 - PCI: shpchp: Remove unused get_mode1_ECC_cap callback

Sat, 12 Nov 2022 14:28:57 +0000

PCI: shpchp: Remove unused get_mode1_ECC_cap callbackThe ->get_mode1_ECC_cap callback in the shpchp_hpc_ops struct is nevercalled, so remove it.[bhelgaas: squash]Link: https://lore.kernel.org/r/20221112142859.319733-2-ian@linux.cowan.aeroLink: https://lore.kernel.org/r/20221112142859.319733-3-ian@linux.cowan.aeroLink: https://lore.kernel.org/r/20221112142859.319733-4-ian@linux.cowan.aeroSigned-off-by: Ian Cowan Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

e1a6333e - PCI: ibmphp: Remove commented-out functions

Thu, 09 Dec 2021 21:36:18 +0000

PCI: ibmphp: Remove commented-out functionsThe functions get_max_adapter_speed() and get_bus_name() in ibmphp_core.care commented-out and the fields .get_max_adapter_speed and.get_bus_name_status are removed from struct hotplug_slot_ops inpci_hotplug.h. Remove the commented-out functions.Link: https://lore.kernel.org/r/20211209213618.20522-1-makvihas@gmail.comSigned-off-by: Vihas Mak Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

faa2e05a - PCI: ibmphp: Fix double unmap of io_mem

Wed, 18 Aug 2021 16:57:51 +0000

PCI: ibmphp: Fix double unmap of io_memebda_rsrc_controller() calls iounmap(io_mem) on the error path. Its caller,ibmphp_access_ebda(), also calls iounmap(io_mem) on good and error paths.Remove the iounmap(io_mem) invocation from ebda_rsrc_controller().[bhelgaas: remove item from TODO]Link: https://lore.kernel.org/r/20210818165751.591185-1-os.vaslot@gmail.comSigned-off-by: Vishal Aslot Signed-off-by: Bjorn Helgaas List of files: /linux-6.15/drivers/pci/hotplug/TODO

a0d58937 - PCI: hotplug: Document TODOs

Sat, 08 Sep 2018 07:59:01 +0000

PCI: hotplug: Document TODOsWhile refactoring the PCI hotplug core's API, I noticed a significantamount of technical debt in some of the hotplug drivers. Document theissues that caught my eye for starters.I do not have hardware at my disposal that utilizes the listed driversand I think that's a prerequisite to work on them to ensure that noregressions sneak in. But some of this hardware is so old that it may behard to come by. Obviously, it is fine to support old hardware, but thedrivers need to be maintained.If noone steps up, perhaps we should consider sunsetting a few driversby moving them to staging. Based on my findings, ibmphp would be thefirst candidate. I've found it fairly difficult to apply my APIrefactorings to it and have listed some obvious bugs in the driver.cpqphp is also in need of a modernization and would be a secondcandidate for relegation to staging.shpchp was introduced in the same commit as pciehp but hasn't benefitedfrom the same amount of refactoring due to the decline of conventionalPCI's relevance. Yet hardware supporting it may be more prevalent thanfor the proprietary hotplug methods.Per Documentation/process/2.Process.rst, "a TODO file should be present"for drivers in staging. The file introduced by the present commit mayserve as a basis for this.Signed-off-by: Lukas Wunner Signed-off-by: Bjorn Helgaas Cc: Greg Kroah-Hartman Cc: Scott Murray Cc: Dan Zink Cc: Prarit Bhargava List of files: /linux-6.15/drivers/pci/hotplug/TODO