Changes in Makefile

eb38b952 - of: overlay: unittest: Add test for unresolved symbol

Fri, 28 Jul 2023 08:50:35 +0000

of: overlay: unittest: Add test for unresolved symbolAdd a test to exercise the error paths when trying to apply an overlaywith an unresolved symbol and cleaning up the resulting partial state.Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/580394587976975770c84411896fce9fbbcf25fa.1690533838.git.geert+renesas@glider.beSigned-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

26409dd0 - of: unittest: Add pci_dt_testdrv pci driver

Tue, 15 Aug 2023 17:20:00 +0000

of: unittest: Add pci_dt_testdrv pci driverpci_dt_testdrv is bound to QEMU PCI Test Device. It readsoverlay_pci_node fdt fragment and apply it to Test Device. Then itcalls of_platform_default_populate() to populate the platformdevices.Tested-by: Herve Codina Signed-off-by: Lizhi Hou Link: https://lore.kernel.org/r/1692120000-46900-6-git-send-email-lizhi.hou@amd.comSigned-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

e87cacad - of: overlay: rename overlay source files from .dts to .dtso

Mon, 24 Oct 2022 17:34:30 +0000

of: overlay: rename overlay source files from .dts to .dtsoIn drivers/of/unittest-data/: - Rename .dts overlay source files to use .dtso suffix.Modify driver/of/unitest.c to use .dtbo.o based symbols instead of .dtb.oSigned-off-by: Frank Rowand Signed-off-by: Andrew Davis Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Reviewed-by: Frank Rowand Tested-by: Frank Rowand Link: https://lore.kernel.org/r/20221024173434.32518-4-afd@ti.comSigned-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

992b0dc5 - of: overlay: unittest: add tests for overlay notifiers

Mon, 02 May 2022 18:17:41 +0000

of: overlay: unittest: add tests for overlay notifiersAdd tests for overlay apply and remove notifiers. Trigger errorsfor each of the notifier actions.These tests will reveal a memory leak problem when a notifier returnsan error for action OF_OVERLAY_POST_APPLY. The pr_err() message is: OF: ERROR: memory leak, expected refcount 1 instead of 3, of_node_get()/of_node_put() unbalanced - destroy cset entry: attach overlay node /testcase-data/overlay-node/test-bus/test-unittest17Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20220502181742.1402826-3-frowand.list@gmail.com List of files: /linux-6.15/drivers/of/unittest-data/Makefile

b68d0924 - of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warnings

Tue, 26 Oct 2021 22:45:59 +0000

of/unittest: Disable new dtc node_name_vs_property_name and interrupt_map warningsThe unittest dtbs have various intentional errors which cause warnings.With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disablesome new checks: node_name_vs_property_name and interrupt_map warnings.These warnings are also generated for static_base_1.dtb, so addDTC_FLAGS for it.Note that the interrupt_map warnings only appear once interrupt_providerwarning is re-enabled globally.drivers/of/unittest-data/tests-interrupts.dtsi:32.26-35.6: Warning (interrupt_map): /testcase-data/interrupts/intmap1: Missing '#address-cells' in interrupt-map providerFixes: c12632bfb611 ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")Reported-by: Stephen Rothwell Reviewed-by: Frank Rowand Tested-by: Frank Rowand Link: https://lore.kernel.org/r/20211028130423.4025578-1-robh@kernel.org/Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

3b2dccc6 - of: unittest: Statically apply overlays using fdtoverlay

Wed, 10 Mar 2021 05:35:33 +0000

of: unittest: Statically apply overlays using fdtoverlayNow that fdtoverlay is part of the kernel build, start using it to testthe unitest overlays we have by applying them statically. Create two newbase files static_base_1.dts and static_base_2.dts which includes other.dtsi files.Some unittest overlays deliberately contain errors that unittest checksfor. These overlays will cause fdtoverlay to fail, and are thus notincluded for static builds.Signed-off-by: Viresh Kumar Reviewed-by: Frank Rowand Tested-by: Frank Rowand Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/da6b4e6429aae2e7832a8be2ba2da473d449895b.1615354376.git.viresh.kumar@linaro.org List of files: /linux-6.15/drivers/of/unittest-data/Makefile

f4056e70 - of: unittest: add overlay gpio test to catch gpio hog problem

Thu, 20 Feb 2020 18:40:20 +0000

of: unittest: add overlay gpio test to catch gpio hog problemGeert reports that gpio hog nodes are not properly processed whenthe gpio hog node is added via an overlay reply and provides anRFC patch to fix the problem [1].Add a unittest that shows the problem. Unittest will report "1 failed"test before applying Geert's RFC patch and "0 failed" after applyingGeert's RFC patch.[1] https://lore.kernel.org/linux-devicetree/20191230133852.5890-1-geert+renesas@glider.be/Signed-off-by: Frank Rowand Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

2fe0e876 - of: overlay: check prevents multiple fragments touching same property

Fri, 05 Oct 2018 03:36:18 +0000

of: overlay: check prevents multiple fragments touching same propertyAdd test case of two fragments updating the same property. Afteradding the test case, the system hangs at end of boot, afterafter slub stack dumps from kfree() in crypto modprobe code.Multiple overlay fragments adding, modifying, or deleting the sameproperty is not supported. Add check to detect the attempt and failthe overlay apply.Before this patch, the first fragment error would terminateprocessing. Allow fragment checking to proceed and report allof the fragment errors before terminating the overlay apply. Thisis not a hot path, thus not a performance issue (the error is nottransient and requires fixing the overlay before attempting toapply it again).After applying this patch, the devicetree unittest messages willinclude: OF: overlay: ERROR: multiple fragments add, update, and/or delete property /testcase-data-2/substation@100/motor-1/rpm_avail ... ### dt-test ### end of unittest - 212 passed, 0 failedThe check to detect two fragments updating the same property isfolded into the patch that created the test case to maintainbisectability.Tested-by: Alan Tull Signed-off-by: Frank Rowand List of files: /linux-6.15/drivers/of/unittest-data/Makefile

a68238a1 - of: overlay: test case of two fragments adding same node

Fri, 05 Oct 2018 03:34:33 +0000

of: overlay: test case of two fragments adding same nodeMultiple overlay fragments adding or deleting the same node is notsupported. An attempt to do so results in an incorrect devicetree.The node name will be munged for the second add.After adding this patch, the unittest messages will show: Duplicate name in motor-1, renamed to "controller#1" OF: overlay: of_overlay_apply() err=0 ### dt-test ### of_overlay_fdt_apply() expected -22, ret=0, overlay_bad_add_dup_node ### dt-test ### FAIL of_unittest_overlay_high_level():2419 Adding overlay 'overlay_bad_add_dup_node' failed ... ### dt-test ### end of unittest - 210 passed, 1 failedThe incorrect (munged) node name "controller#1" can be seen in the/proc filesystem: $ pwd /proc/device-tree/testcase-data-2/substation@100/motor-1 $ ls compatible controller controller#1 name phandle spin $ ls controller power_bus $ ls controller#1 power_bus_emergencyTested-by: Alan Tull Signed-off-by: Frank Rowand List of files: /linux-6.15/drivers/of/unittest-data/Makefile

54a702f7 - kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS markers

Fri, 23 Mar 2018 13:04:39 +0000

kbuild: mark $(targets) as .SECONDARY and remove .PRECIOUS markersGNU Make automatically deletes intermediate files that are updatedin a chain of pattern rules.Example 1) %.dtb.o <- %.dtb.S <- %.dtb <- %.dtsExample 2) %.o <- %.c <- %.c_shippedA couple of makefiles mark such targets as .PRECIOUS to prevent Makefrom deleting them, but the correct way is to use .SECONDARY. .SECONDARY Prerequisites of this special target are treated as intermediate files but are never automatically deleted. .PRECIOUS When make is interrupted during execution, it may delete the target file it is updating if the file was modified since make started. If you mark the file as precious, make will never delete the file if interrupted.Both can avoid deletion of intermediate files, but the difference isthe behavior when Make is interrupted; .SECONDARY deletes the target,but .PRECIOUS does not.The use of .PRECIOUS is relatively rare since we do not want to keeppartially constructed (possibly corrupted) targets.Another difference is that .PRECIOUS works with pattern rules whereas.SECONDARY does not. .PRECIOUS: $(obj)/%.lex.cworks, but .SECONDARY: $(obj)/%.lex.chas no effect. However, for the reason above, I do not want to use.PRECIOUS which could cause obscure build breakage.The targets specified as .SECONDARY must be explicit. $(targets)contains all targets that need to include .*.cmd files. So, theintermediates you want to keep are mostly in there. Therefore, mark$(targets) as .SECONDARY. It means primary targets are also markedas .SECONDARY, but I do not see any drawback for this.I replaced some .SECONDARY / .PRECIOUS markers with 'targets'. Thiswill make Kbuild search for non-existing .*.cmd files, but this isnot a noticeable performance issue.Signed-off-by: Masahiro Yamada Acked-by: Frank Rowand Acked-by: Ingo Molnar List of files: /linux-6.15/drivers/of/unittest-data/Makefile

a7f92419 - kbuild: add %.dtb.S and %.dtb to 'targets' automatically

Fri, 23 Mar 2018 13:04:34 +0000

kbuild: add %.dtb.S and %.dtb to 'targets' automaticallyAnother common pattern that consists of chained commands is to compilea DTB as binary data into the kernel image or a module. It is used inseveral places in the source tree. Support it in the core Makefile.$(call if_changed,dt_S_dtb) is more suitable than $(call cmd,dt_S_dtb)in case cmd_dt_S_dtb is changed in the future.Signed-off-by: Masahiro Yamada Acked-by: Frank Rowand List of files: /linux-6.15/drivers/of/unittest-data/Makefile

39a751a4 - of: change overlay apply input data from unflattened to FDT

Mon, 12 Feb 2018 08:19:42 +0000

of: change overlay apply input data from unflattened to FDTMove duplicating and unflattening of an overlay flattened devicetree(FDT) into the overlay application code. To accomplish this,of_overlay_apply() is replaced by of_overlay_fdt_apply().The copy of the FDT (aka "duplicate FDT") now belongs to devicetreecode, which is thus responsible for freeing the duplicate FDT. Thecaller of of_overlay_fdt_apply() remains responsible for freeing theoriginal FDT.The unflattened devicetree now belongs to devicetree code, which isthus responsible for freeing the unflattened devicetree.These ownership changes prevent early freeing of the duplicated FDTor the unflattened devicetree, which could result in use after freeerrors.of_overlay_fdt_apply() is a private function for the anticipatedoverlay loader.Update unittest.c to use of_overlay_fdt_apply() instead ofof_overlay_apply().Move overlay fragments from artificial locations indrivers/of/unittest-data/tests-overlay.dtsi into one devicetreesource file per overlay. This led to changes indrivers/of/unitest-data/Makefile and drivers/of/unitest.c. - Add overlay directives to the overlay devicetree source files so that dtc will compile them as true overlays into one FDT data chunk per overlay. - Set CFLAGS for drivers/of/unittest-data/testcases.dts so that symbols will be generated for overlay resolution of overlays that are no longer artificially contained in testcases.dts - Unflatten and apply each unittest overlay FDT using of_overlay_fdt_apply(). - Enable the of_resolve_phandles() check for whether the unflattened overlay is detached. This check was previously disabled because the overlays from tests-overlay.dtsi were not unflattened into detached trees. - Other changes to unittest.c infrastructure to manage multiple test FDTs built into the kernel image (access by name instead of arbitrary number). - of_unittest_overlay_high_level(): previously unused code to add properties from the overlay_base devicetree to the live tree was triggered by the restructuring of tests-overlay.dtsi and thus testcases.dts. This exposed two bugs: (1) the need to dup a property before adding it, and (2) property 'name' is auto-generated in the unflatten code and thus will be a duplicate in the __symbols__ node - do not treat this duplicate as an error.Signed-off-by: Frank Rowand List of files: /linux-6.15/drivers/of/unittest-data/Makefile

bd6dc70b - of: unittest: refactor Makefile

Fri, 05 Jan 2018 11:55:30 +0000

of: unittest: refactor MakefileSome cleanups: - use obj-$(CONFIG_OF_OVERLAY) instead of ifdef ... endif - compute targets from obj-ySigned-off-by: Masahiro Yamada Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

c0075838 - of: unittest: disable interrupts_property warning

Thu, 16 Nov 2017 17:54:17 +0000

of: unittest: disable interrupts_property warningThe testcases.dts has purposely bad data which now generates a dtc warning:drivers/of/unittest-data/testcases.dtb: Warning (interrupts_property): interrupts size is (4), expected multiple of 8 in /testcase-data/testcase-device2Disable this warning for now. The proper solution is to split the unittests into good and bad data.Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

b2441318 - License cleanup: add SPDX GPL-2.0 license identifier to files with no license

Wed, 01 Nov 2017 14:07:57 +0000

License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseMany source files in the tree are missing licensing information, whichmakes it harder for compliance tools to determine the correct license.By default all files without license information are under the defaultlicense of the kernel, which is GPL version 2.Update the files which contain no license information with the 'GPL-2.0'SPDX license identifier. The SPDX identifier is a legally bindingshorthand, which can be used instead of the full boiler plate text.This patch is based on work done by Thomas Gleixner and Kate Stewart andPhilippe Ombredanne.How this work was done:Patches were generated and checked against linux-4.14-rc6 for a subset ofthe use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information,Further patches will be generated in subsequent months to fix up caseswhere non-standard license headers were used, and references to licensehad to be inferred by heuristics based on keywords.The analysis to determine which SPDX License Identifier to be applied toa file was done in a spreadsheet of side by side results from of theoutput of two independent scanners (ScanCode & Windriver) producing SPDXtag:value files created by Philippe Ombredanne. Philippe prepared thebase worksheet, and did an initial spot review of a few 1000 files.The 4.13 kernel was the starting point of the analysis with 60,537 filesassessed. Kate Stewart did a file by file comparison of the scannerresults in the spreadsheet to determine which SPDX license identifier(s)to be applied to the file. She confirmed any determination that was notimmediately clear with lawyers working with the Linux Foundation.Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines).All documentation files were explicitly excluded.The following heuristics were used to determine which SPDX licenseidentifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time.In total, over 70 hours of logged manual review was done on thespreadsheet to determine the SPDX license identifiers to apply to thesource files by Kate, Philippe, Thomas and, in some cases, confirmationby lawyers working with the Linux Foundation.Kate also obtained a third independent scan of the 4.13 code base fromFOSSology, and compared selected files where the other two scannersdisagreed against that SPDX file, to see if there was new insights. TheWindriver scanner is based on an older version of FOSSology in part, sothey are related.Thomas did random spot checks in about 500 files from the spreadsheetsfor the uapi headers and agreed with SPDX license identifier in thefiles he inspected. For the non-uapi files Thomas did random spot checksin about 15000 files.In initial set of patches against 4.14-rc6, 3 files were found to havecopy/paste license identifier errors, and have been fixed to reflect thecorrect identifier.Additionally Philippe spent 10 hours this week doing a detailed manualinspection and review of the 12,461 patched files from the initial patchversion early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correctThis produced a worksheet with 20 files needing minor correction. Thisworksheet was then exported into 3 different .csv files for thedifferent types of files to be modified.These .csv files were then reviewed by Greg. Thomas wrote a script toparse the csv files and add the proper SPDX tag to the file, in theformat that the file expected. This script was further refined by Gregbased on the output to detect more types of files automatically and todistinguish between header and source .c files (which need differentcomment types.) Finally Greg ran the script using the .csv files togenerate the patches.Reviewed-by: Kate Stewart Reviewed-by: Philippe Ombredanne Reviewed-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/of/unittest-data/Makefile

60a0004c - of: overlay: add overlay unittest data for node names and symbols

Wed, 19 Jul 2017 16:25:20 +0000

of: overlay: add overlay unittest data for node names and symbolsAdd nodes and properties to overlay_base and overlay dts files totest for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live treeThe following console messages will appear near the end of unittestuntil the code errors are corrected: OF: Duplicate name in fairway-1, renamed to "ride@100#1" ### dt-test ### FAIL of_unittest_overlay_high_level():2296 Adding overlay 'overlay_bad_symbol' failed ### dt-test ### end of unittest - 190 passed, 1 failedSigned-off-by: Frank Rowand Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

81d0848f - of: Add unit tests for applying overlays

Wed, 26 Apr 2017 00:09:54 +0000

of: Add unit tests for applying overlaysExisting overlay unit tests examine individual pieces of the overlaycode. The new tests target the entire process of applying an overlay.Signed-off-by: Frank Rowand Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile

f0570d91 - dt: OF_UNITTEST make dependency broken

Fri, 13 Mar 2015 19:21:46 +0000

dt: OF_UNITTEST make dependency brokenIf CONFIG_OF_UNITTEST=y then a kernel image make will always cause .version tobe incremented, even if there are not source changes. This is caused bya lack of dependency tracking and checking fordrivers/of/unittest-data/testcases.dtb.o.Signed-off-by: Frank Rowand Signed-off-by: Rob Herring List of files: /linux-6.15/drivers/of/unittest-data/Makefile