Changes in Kconfig

ac38b7ef - nvmet-tcp: select CONFIG_TLS from CONFIG_NVME_TARGET_TCP_TLS

Tue, 29 Apr 2025 22:23:47 +0000

nvmet-tcp: select CONFIG_TLS from CONFIG_NVME_TARGET_TCP_TLSEnsure that TLS support is enabled in the kernel whenCONFIG_NVME_TARGET_TCP_TLS is enabled. Without this the code compiles,but does not actually work unless something else enables CONFIG_TLS.Fixes: 675b453e0241 ("nvmet-tcp: enable TLS handshake upcall")Signed-off-by: Alistair Francis Reviewed-by: Hannes Reinecke Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

0faa0fe6 - nvmet: New NVMe PCI endpoint function target driver

Sat, 04 Jan 2025 04:59:50 +0000

nvmet: New NVMe PCI endpoint function target driverImplement a PCI target driver using the PCI endpoint framework. Thisrequires hardware with a PCI controller capable of executing in endpointmode.The PCI endpoint framework is used to set up a PCI endpoint functionand its BAR compatible with a NVMe PCI controller. The framework is alsoused to map local memory to the PCI address space to execute MMIOaccesses for retrieving NVMe commands from submission queues and postingcompletion entries to completion queues. If supported, DMA is used forcommand retreival and command data transfers, based on the PCI addresssegments indicated by the command using either PRPs or SGLs.The NVMe target driver relies on the NVMe target core code to executeall commands isssued by the host. The PCI target driver is mainlyresponsible for the following: - Initialization and teardown of the endpoint device and its backend PCI target controller. The PCI target controller is created using a subsystem and a port defined through configfs. The port used must be initialized with the "pci" transport type. The target controller is allocated and initialized when the PCI endpoint is started by binding it to the endpoint PCI device (nvmet_pci_epf_epc_init() function). - Manage the endpoint controller state according to the PCI link state and the actions of the host (e.g. checking the CC.EN register) and propagate these actions to the PCI target controller. Polling of the controller enable/disable is done using a delayed work scheduled every 5ms (nvmet_pci_epf_poll_cc() function). This work is started whenever the PCI link comes up (nvmet_pci_epf_link_up() notifier function) and stopped when the PCI link comes down (nvmet_pci_epf_link_down() notifier function). nvmet_pci_epf_poll_cc() enables and disables the PCI controller using the functions nvmet_pci_epf_enable_ctrl() and nvmet_pci_epf_disable_ctrl(). The controller admin queue is created using nvmet_pci_epf_create_cq(), which calls nvmet_cq_create(), and nvmet_pci_epf_create_sq() which uses nvmet_sq_create(). nvmet_pci_epf_disable_ctrl() always resets the PCI controller to its initial state so that nvmet_pci_epf_enable_ctrl() can be called again. This ensures correct operation if, for instance, the host reboots causing the PCI link to be temporarily down. - Manage the controller admin and I/O submission queues using local memory. Commands are obtained from submission queues using a work item that constantly polls the doorbells of all submissions queues (nvmet_pci_epf_poll_sqs() function). This work is started whenever the controller is enabled (nvmet_pci_epf_enable_ctrl() function) and stopped when the controller is disabled (nvmet_pci_epf_disable_ctrl() function). When new commands are submitted by the host, DMA transfers are used to retrieve the commands. - Initiate the execution of all admin and I/O commands using the target core code, by calling a requests execute() function. All commands are individually handled using a per-command work item (nvmet_pci_epf_iod_work() function). A command overall execution includes: initializing a struct nvmet_req request for the command, using nvmet_req_transfer_len() to get a command data transfer length, parse the command PRPs or SGLs to get the PCI address segments of the command data buffer, retrieve data from the host (if the command is a write command), call req->execute() to execute the command and transfer data to the host (for read commands). - Handle the completions of commands as notified by the ->queue_response() operation of the PCI target controller (nvmet_pci_epf_queue_response() function). Completed commands are added to a list of completed command for their CQ. Each CQ list of completed command is processed using a work item (nvmet_pci_epf_cq_work() function) which posts entries for the completed commands in the CQ memory and raise an IRQ to the host to signal the completion. IRQ coalescing is supported as mandated by the NVMe base specification for PCI controllers. Of note is that completion entries are transmitted to the host using MMIO, after mapping the completion queue memory to the host PCI address space. Unlike for retrieving commands from SQs, DMA is not used as it degrades performance due to the transfer serialization needed (which delays completion entries transmission).The configuration of a NVMe PCI endpoint controller is done usingconfigfs. First the NVMe PCI target controller configuration must bedone to set up a subsystem and a port with the "pci" addr_trtypeattribute. The subsystem can be setup using a file or block devicebacked namespace or using a passthrough NVMe device. After this, thePCI endpoint can be configured and bound to the PCI endpoint controllerto start the NVMe endpoint controller.In order to not overcomplicate this initial implementation of anendpoint PCI target controller driver, protection information is notfor now supported. If the PCI controller port and namespace areconfigured with protection information support, an error will bereturned when the controller is created and initialized when theendpoint function is started. Protection information support will beadded in a follow-up patch series.Using a Rock5B board (Rockchip RK3588 SoC, PCI Gen3x4 endpointcontroller) with a target PCI controller setup with 4 I/O queues and anull_blk block device as a namespace, the maximum performance using fiowas measured at 131 KIOPS for random 4K reads and up to 2.8 GB/Sthroughput. Some data points are:Rnd read, 4KB, QD=1, 1 job : IOPS=16.9k, BW=66.2MiB/s (69.4MB/s)Rnd read, 4KB, QD=32, 1 job : IOPS=78.5k, BW=307MiB/s (322MB/s)Rnd read, 4KB, QD=32, 4 jobs: IOPS=131k, BW=511MiB/s (536MB/s)Seq read, 512KB, QD=32, 1 job : IOPS=5381, BW=2691MiB/s (2821MB/s)The NVMe PCI endpoint target driver is not intended for production use.It is a tool for learning NVMe, exploring existing features and testingimplementations of new NVMe features.Co-developed-by: Rick Wertenbroek Signed-off-by: Damien Le Moal Reviewed-by: Christoph Hellwig Reviewed-by: Manivannan Sadhasivam Tested-by: Manivannan Sadhasivam Reviewed-by: Krzysztof Wilczyński Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

649fd414 - nvmet: add debugfs support

Mon, 27 May 2024 05:15:19 +0000

nvmet: add debugfs supportAdd a debugfs hierarchy to display the configured subsystemsand the controllers attached to the subsystems.Suggested-by: Redouane BOUFENGHOUR Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Signed-off-by: Daniel Wagner Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

e9f5f44a - block: remove the blk_integrity_profile structure

Thu, 13 Jun 2024 08:48:15 +0000

block: remove the blk_integrity_profile structureBlock layer integrity configuration is a bit complex right now, as itindirects through operation vectors for a simple two-dimensionalconfiguration: a) the checksum type of none, ip checksum, crc, crc64 b) the presence or absence of a reference tagRemove the integrity profile, and instead add a separate csum_type flagwhich replaces the existing ip-checksum field and a new flag thatindicates the presence of the reference tag.This removes up to two layers of indirect calls, remove the need tooffload the no-op verification of non-PI metadata to a workqueue andgenerally simplifies the code. The downside is that block/t10-pi.c nowhas to be built into the kernel when CONFIG_BLK_DEV_INTEGRITY issupported. Given that both nvme and SCSI require t10-pi.ko, it is loadedfor all usual configurations that enabled CONFIG_BLK_DEV_INTEGRITYalready, though.Signed-off-by: Christoph Hellwig Reviewed-by: Kanchan Joshi Reviewed-by: Hannes Reinecke Reviewed-by: Martin K. Petersen Link: https://lore.kernel.org/r/20240613084839.1044015-6-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/nvme/target/Kconfig

29ac4b2f - nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptions

Wed, 29 Nov 2023 04:49:51 +0000

nvme: improve NVME_HOST_AUTH and NVME_TARGET_AUTH config descriptionsCurrently two similar config options NVME_HOST_AUTH and NVME_TARGET_AUTHhave almost same descriptions. It is confusing to choose them inmenuconfig. Improve the descriptions to distinguish them.Signed-off-by: Shin'ichiro Kawasaki Reviewed-by: Sagi Grimberg Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

65e2a74c - nvme: target: fix Kconfig select statements

Wed, 22 Nov 2023 22:47:18 +0000

nvme: target: fix Kconfig select statementsWhen the NVME target code is built-in but its TCP frontend is a loadablemodule, enabling keyring support causes a link failure:x86_64-linux-ld: vmlinux.o: in function `nvmet_ports_make':configfs.c:(.text+0x100a211): undefined reference to `nvme_keyring_id'The problem is that CONFIG_NVME_TARGET_TCP_TLS is a 'bool' symbol thatdepends on the tristate CONFIG_NVME_TARGET_TCP, so any 'select' fromit inherits the state of the tristate symbol rather than the intendedCONFIG_NVME_TARGET one that contains the actual call.The same thing is true for CONFIG_KEYS, which itself is required forNVME_KEYRING.Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20231122224719.4042108-3-arnd@kernel.orgSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/nvme/target/Kconfig

6affe08a - nvme: common: make keyring and auth separate modules

Thu, 26 Oct 2023 13:08:03 +0000

nvme: common: make keyring and auth separate modulesWhen only the keyring module is included but auth is not, modpostcomplains about the lack of a module license tag:ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.oAddress this by making both modules buildable standalone,removing the now unnecessary CONFIG_NVME_COMMON symbolin the process.Also, now that NVME_KEYRING config symbol can be either a module orbuilt-in, the stubs need to check for '#if IS_ENABLED' rather than asimple '#ifdef'.Fixes: 9d77eb5277849 ("nvme-keyring: register '.nvme' keyring")Signed-off-by: Arnd Bergmann Signed-off-by: Hannes Reinecke Signed-off-by: Christoph Hellwig Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

d6800634 - nvme: rework NVME_AUTH Kconfig selection

Thu, 12 Oct 2023 12:22:48 +0000

nvme: rework NVME_AUTH Kconfig selectionHaving a single Kconfig symbol NVME_AUTH conflates the selectionof the authentication functions from nvme/common and nvme/host,causing kbuild robot to complain when building the nvme targetonly. So introduce a Kconfig symbol NVME_HOST_AUTH for the nvmehost bits and use NVME_AUTH for the common functions only.And move the CRYPTO selection into nvme/common to make iteasier to read.Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202310120733.TlPOVeJm-lkp@intel.com/Signed-off-by: Hannes Reinecke Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

675b453e - nvmet-tcp: enable TLS handshake upcall

Thu, 24 Aug 2023 14:39:23 +0000

nvmet-tcp: enable TLS handshake upcallTLS handshake is handled in userspace with the netlink tls handshakeprotocol.The patch adds a function to start the TLS handshake upcall for anyincoming network connections if the TCP TSAS sectype is set to 'tls1.3'.A config option NVME_TARGET_TCP_TLS selects whether the TLS handshakeupcall should be compiled in. The patch also adds reference countingto struct nvmet_tcp_queue to ensure the queue is always valid when thethe TLS handshake completes.Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Signed-off-by: Keith Busch List of files: /linux-6.15/drivers/nvme/target/Kconfig

4cf42ec3 - nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS

Wed, 20 Jul 2022 11:37:17 +0000

nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPSCommit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")intends to select 'Support for RFC 7919 FFDHE group parameters' for usingFFDHE groups for NVMe In-Band Authentication.It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intendedCRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.Correct the select to the intended config option.Signed-off-by: Lukas Bulwahn Reviewed-by: Hannes Reinecke Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/nvme/target/Kconfig

7a277c37 - nvmet-auth: Diffie-Hellman key exchange support

Mon, 27 Jun 2022 09:52:06 +0000

nvmet-auth: Diffie-Hellman key exchange supportImplement Diffie-Hellman key exchange using FFDHE groups for NVMeIn-Band Authentication.This patch adds a new host configfs attribute 'dhchap_dhgroup' toselect the FFDHE group to use.Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/nvme/target/Kconfig

db1312dd - nvmet: implement basic In-Band Authentication

Mon, 27 Jun 2022 09:52:05 +0000

nvmet: implement basic In-Band AuthenticationImplement NVMe-oF In-Band authentication according to NVMe TPAR 8006.This patch adds three additional configfs entries 'dhchap_key','dhchap_ctrl_key', and 'dhchap_hash' to the 'host' configfs directory.The 'dhchap_key' and 'dhchap_ctrl_key' entries need to be in the ASCIIformat as specified in NVMe Base Specification v2.0 section 8.13.5.8'Secret representation'.'dhchap_hash' defaults to 'hmac(sha256)', and can be written to toswitch to a different HMAC algorithm.Signed-off-by: Hannes Reinecke Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/nvme/target/Kconfig

0866200e - nvme: Have NVME_FABRICS select NVME_CORE instead of transport drivers

Tue, 25 May 2021 15:59:46 +0000

nvme: Have NVME_FABRICS select NVME_CORE instead of transport driversTransport drivers need both core and fabrics modules, instead ofselecting both, have the selection transitive such that NVME_FABRICSselects NVME_CORE and transport drivers select NVME_FABRICS.Suggested-by: Keith Busch Signed-off-by: Sagi Grimberg Reviewed-by: Chaitanya Kulkarni Reviewed-by: James Smart Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

9f20599c - nvmet: fix a spelling mistake "incuding" -> "including" in Kconfig

Thu, 26 Nov 2020 22:40:29 +0000

nvmet: fix a spelling mistake "incuding" -> "including" in KconfigThere is a spelling mistake in the Kconfig help text. Fix it.Signed-off-by: Colin Ian King Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

d9174c1a - nvmet: introduce the passthru Kconfig option

Fri, 24 Jul 2020 17:25:20 +0000

nvmet: introduce the passthru Kconfig optionThis patch updates KConfig file for the NVMeOF target where we add newoption so that user can selectively enable/disable passthru code.Signed-off-by: Chaitanya Kulkarni [logang@deltatee.com: fixed some of the wording in the help message]Signed-off-by: Logan Gunthorpe Reviewed-by: Keith Busch Reviewed-by: Sagi Grimberg Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

d2d1c454 - nvmet: add metadata characteristics for a namespace

Tue, 19 May 2020 14:05:57 +0000

nvmet: add metadata characteristics for a namespaceFill those namespace fields from the block device format for addingmetadata (T10-PI) over fabric support with block devices.Signed-off-by: Israel Rukshin Signed-off-by: Max Gurtovoy Reviewed-by: Martin K. Petersen Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/nvme/target/Kconfig

a5dffbb6 - nvmet: include

Wed, 24 Apr 2019 10:34:39 +0000

nvmet: include Build breaks: drivers/nvme/target/core.c: In function 'nvmet_req_alloc_sgl': drivers/nvme/target/core.c:939:12: error: implicit declaration of \function 'sgl_alloc'; did you mean 'bio_alloc'? \[-Werror=implicit-function-declaration] req->sg = sgl_alloc(req->transfer_len, GFP_KERNEL, &req->sg_cnt); ^~~~~~~~~ bio_alloc drivers/nvme/target/core.c:939:10: warning: assignment makes pointer \from integer without a cast [-Wint-conversion] req->sg = sgl_alloc(req->transfer_len, GFP_KERNEL, &req->sg_cnt); ^ drivers/nvme/target/core.c: In function 'nvmet_req_free_sgl': drivers/nvme/target/core.c:952:3: error: implicit declaration of \function 'sgl_free'; did you mean 'ida_free'? [-Werror=implicit-function-declaration] sgl_free(req->sg); ^~~~~~~~ ida_freeCause: 1. missing include to 2. SGL_ALLOC needs to be enabledTherefore adding the missing include, as well as Kconfig dependency.Signed-off-by: Enrico Weigelt, metux IT consult Reviewed-by: Sagi Grimberg Reviewed-by: Minwoo Im Reviewed-by: Chaitanya Kulkarni Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

872d26a3 - nvmet-tcp: add NVMe over TCP target driver

Tue, 04 Dec 2018 01:52:15 +0000

nvmet-tcp: add NVMe over TCP target driverThis patch implements the TCP transport driver for the NVMe over Fabricstarget stack. This allows exporting NVMe over Fabrics functionality overgood old TCP/IP.The driver implements the TP 8000 of how nvme over fabrics capsules anddata are encapsulated in nvme-tcp pdus and exchaged on top of a TCP bytestream. nvme-tcp header and data digest are supported as well.Signed-off-by: Sagi Grimberg Signed-off-by: Roy Shterman Signed-off-by: Solganik Alexander Signed-off-by: Christoph Hellwig List of files: /linux-6.15/drivers/nvme/target/Kconfig

533d1dae - IB: Revert "remove redundant INFINIBAND kconfig dependencies"

Fri, 25 May 2018 21:29:59 +0000

IB: Revert "remove redundant INFINIBAND kconfig dependencies"Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn dependson INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to alink error when another driver using it is built-in. TheINFINIBAND_ADDR_TRANS dependency is insufficient here as this isa 'bool' symbol that does not force anything to be a module in turn.fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect'net/9p/trans_rdma.o: In function `rdma_request':trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect'net/9p/trans_rdma.o: In function `rdma_destroy_trans':trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp'trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd'Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig dependencies")Signed-off-by: Arnd Bergmann Acked-by: Greg Thelen Signed-off-by: Jason Gunthorpe List of files: /linux-6.15/drivers/nvme/target/Kconfig