Changes in micrel.c

8c619eb2 - net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylink

Sun, 04 May 2025 08:14:34 +0000

net: phy: micrel: remove KSZ9477 EEE quirks now handled by phylinkThe KSZ9477 PHY driver contained workarounds for broken EEE capabilityadvertisements by manually masking supported EEE modes and forciblydisabling EEE if MICREL_NO_EEE was set.With proper MAC-side EEE handling implemented via phylink, these quirksare no longer necessary. Remove MICREL_NO_EEE handling and the use ofksz9477_get_features().This simplifies the PHY driver and avoids duplicated EEE management logic.Signed-off-by: Oleksij Rempel Cc: stable@vger.kernel.org # v6.14+Link: https://patch.msgid.link/20250504081434.424489-3-o.rempel@pengutronix.deSigned-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/phy/micrel.c

fe4bf60f - net: phy: micrel: Add loopback support

Wed, 12 Mar 2025 20:30:08 +0000

net: phy: micrel: Add loopback supportThe KSZ9031 PHYs requires full duplex for loopback mode. Add PHYspecific set_loopback() to ensure this.Signed-off-by: Gerhard Engleder Reviewed-by: Maxime Chevallier Link: https://patch.msgid.link/20250312203010.47429-4-gerhard@engleder-embedded.comSigned-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/phy/micrel.c

890fe684 - net: phy: micrel: use new phy_package_shared getters

Mon, 03 Mar 2025 20:16:43 +0000

net: phy: micrel: use new phy_package_shared gettersUse the new getters for members of struct phy_package_shared.Signed-off-by: Heiner Kallweit Link: https://patch.msgid.link/18e5d29e-fb96-4771-92e4-689e0c992177@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

b01b59a4 - net: phy: Constify struct mdio_device_id

Sun, 12 Jan 2025 14:14:50 +0000

net: phy: Constify struct mdio_device_id'struct mdio_device_id' is not modified in these drivers.Constifying these structures moves some data to a read-only section, soincrease overall security.On a x86_64, with allmodconfig, as an example:Before:====== text data bss dec hex filename 27014 12792 0 39806 9b7e drivers/net/phy/broadcom.oAfter:===== text data bss dec hex filename 27206 12600 0 39806 9b7e drivers/net/phy/broadcom.oSigned-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/403c381b7d9156b67ad68ffc44b8eee70c5e86a9.1736691226.git.christophe.jaillet@wanadoo.frSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

25cc469d - net: phy: micrel: use helper phy_disable_eee

Tue, 07 Jan 2025 20:13:44 +0000

net: phy: micrel: use helper phy_disable_eeeUse helper phy_disable_eee() instead of setting phylib-internal bitmapeee_broken_modes directly.Signed-off-by: Heiner Kallweit Link: https://patch.msgid.link/5e19eebe-121e-4a41-b36d-a35631279dd8@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

25c6a5ab - net: phy: micrel: Dynamically control external clock of KSZ PHY

Tue, 17 Dec 2024 06:35:00 +0000

net: phy: micrel: Dynamically control external clock of KSZ PHYOn the i.MX6ULL-14x14-EVK board, enet1_ref and enet2_ref are used as theclock sources for two external KSZ PHYs. However, after closing the twoFEC ports, the clk_enable_count of the enet1_ref and enet2_ref clocks isnot 0. The root cause is that since the commit 985329462723 ("net: phy:micrel: use devm_clk_get_optional_enabled for the rmii-ref clock"), theexternal clock of KSZ PHY has been enabled when the PHY driver probes,and it can only be disabled when the PHY driver is removed. This causesthe clock to continue working when the system is suspended or the networkport is down.Although Heiko explained in the commit message that the patch was becausesome clock suppliers need to enable the clock to get the valid clock rate, it seems that the simple fix is to disable the clock after getting theclock rate to solve the current problem. This is indeed true, but we needto admit that Heiko's patch has been applied for more than a year, and wecannot guarantee whether there are platforms that only enable rmii-ref inthe KSZ PHY driver during this period. If this is the case, disablingrmii-ref will cause RMII on these platforms to not work.Secondly, commit 99ac4cbcc2a5 ("net: phy: micrel: allow usage of genericethernet-phy clock") just simply enables the generic clock permanently,which seems like the generic clock may only be enabled in the PHY driver.If we simply disable the generic clock, RMII may not work. If we keep itas it is, the platform using the generic clock will have the same problemas the i.MX6ULL platform.To solve this problem, the clock is enabled when phy_driver::resume() iscalled, and the clock is disabled when phy_driver::suspend() is called.Since phy_driver::resume() and phy_driver::suspend() are not called inpairs, an additional clk_enable flag is added. When phy_driver::suspend()is called, the clock is disabled only if clk_enable is true. Conversely,when phy_driver::resume() is called, the clock is enabled if clk_enableis false.The changes that introduced the problem were only a few lines, while thecurrent fix is about a hundred lines, which seems out of proportion, butit is necessary because kszphy_probe() is used by multiple KSZ PHYs andwe need to fix all of them.Fixes: 985329462723 ("net: phy: micrel: use devm_clk_get_optional_enabled for the rmii-ref clock")Fixes: 99ac4cbcc2a5 ("net: phy: micrel: allow usage of generic ethernet-phy clock")Signed-off-by: Wei Fang Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Link: https://patch.msgid.link/20241217063500.1424011-1-wei.fang@nxp.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

721aa69e - net: phy: convert eee_broken_modes to a linkmode bitmap

Fri, 08 Nov 2024 06:54:47 +0000

net: phy: convert eee_broken_modes to a linkmode bitmapeee_broken_modes has a eee_cap1 register layout currently. This doen'tallow to flag e.g. 2.5Gbps or 5Gbps BaseT EEE as broken. To overcomethis limitation switch eee_broken_modes to a linkmode bitmap.Signed-off-by: Heiner Kallweit Link: https://patch.msgid.link/dfe0c9ff-84b0-4328-86d7-e917ebc084a1@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

1441df3a - net: phy: use ethtool string helpers

Tue, 29 Oct 2024 23:46:41 +0000

net: phy: use ethtool string helpersThese are the preferred way to copy ethtool strings.Avoids incrementing pointers all over the place.Signed-off-by: Rosen Penev Link: https://patch.msgid.link/20241029234641.11448-1-rosenp@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

84383b5e - net: phy: micrel: Fix the KSZ9131 MDI-X status issue

Thu, 25 Jul 2024 07:11:25 +0000

net: phy: micrel: Fix the KSZ9131 MDI-X status issueThe MDIX status is not accurately reflecting the current state after the linkpartner has manually altered its MDIX configuration while operating in forcedmode.Access information about Auto mdix completion and pair selection from theKSZ9131's Auto/MDI/MDI-X status registerFixes: b64e6a8794d9 ("net: phy: micrel: Add PHY Auto/MDI/MDI-X set driver for KSZ9131")Signed-off-by: Raju Lakkaraju Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20240725071125.13960-1-Raju.Lakkaraju@microchip.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

2111375b - net: Add struct kernel_ethtool_ts_info

Tue, 09 Jul 2024 13:53:38 +0000

net: Add struct kernel_ethtool_ts_infoIn prevision to add new UAPI for hwtstamp we will be limited to the structethtool_ts_info that is currently passed in fixed binary format through theETHTOOL_GET_TS_INFO ethtool ioctl. It would be good if new kernel codealready started operating on an extensible kernel variant of thatstructure, similar in concept to struct kernel_hwtstamp_config vs structhwtstamp_config.Since struct ethtool_ts_info is in include/uapi/linux/ethtool.h, herewe introduce the kernel-only structure in include/linux/ethtool.h.The manual copy is then made in the function called by ETHTOOL_GET_TS_INFO.Acked-by: Shannon Nelson Acked-by: Alexandra Winter Signed-off-by: Kory Maincent Link: https://patch.msgid.link/20240709-feature_ptp_netnext-v17-6-b5317f50df2a@bootlin.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

2dd35600 - net: Change the API of PHY default timestamp to MAC

Tue, 09 Jul 2024 13:53:36 +0000

net: Change the API of PHY default timestamp to MACChange the API to select MAC default time stamping instead of the PHY.Indeed the PHY is closer to the wire therefore theoretically it has lessdelay than the MAC timestamping but the reality is different. Due to lowertime stamping clock frequency, latency in the MDIO bus and no PHC hardwaresynchronization between different PHY, the PHY PTP is often less precisethan the MAC. The exception is for PHY designed specially for PTP case butthese devices are not very widespread. For not breaking the compatibilitydefault_timestamp flag has been introduced in phy_device that is set bythe phy driver to know we are using the old API behavior.Reviewed-by: Rahul Rameshbabu Signed-off-by: Kory Maincent Link: https://patch.msgid.link/20240709-feature_ptp_netnext-v17-4-b5317f50df2a@bootlin.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

54a4e5c1 - net: phy: micrel: add Microchip KSZ 9477 to the device table

Fri, 21 Jun 2024 14:43:20 +0000

net: phy: micrel: add Microchip KSZ 9477 to the device tablePHY_ID_KSZ9477 was supported but not added to the device table passed toMODULE_DEVICE_TABLE.Fixes: fc3973a1fa09 ("phy: micrel: add Microchip KSZ 9477 Switch PHY support")Signed-off-by: Enguerrand de Ribaucourt Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

0a8d3f2e - net: phy: Micrel KSZ8061: fix errata solution not taking effect problem

Fri, 31 May 2024 01:38:01 +0000

net: phy: Micrel KSZ8061: fix errata solution not taking effect problemKSZ8061 needs to write to a MMD register at driver initialization to fixan errata. This worked in 5.0 kernel but not in newer kernels. Theissue is the main phylib code no longer resets PHY at the very beginning.Calling phy resuming code later will reset the chip if it is alreadypowered down at the beginning. This wipes out the MMD register write.Solution is to implement a phy resume function for KSZ8061 to take careof this problem.Fixes: 232ba3a51cc2 ("net: phy: Micrel KSZ8061: link failure after cable connect")Signed-off-by: Tristram Ha Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

6149db49 - net: phy: micrel: fix KSZ9477 PHY issues after suspend/resume

Wed, 29 May 2024 02:20:23 +0000

net: phy: micrel: fix KSZ9477 PHY issues after suspend/resumeWhen the PHY is powered up after powered down most of the registers arereset, so the PHY setup code needs to be done again. In addition theinterrupt register will need to be setup again so that link statusindication works again.Fixes: 26dd2974c5b5 ("net: phy: micrel: Move KSZ9477 errata fixes to PHY driver")Signed-off-by: Tristram Ha Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

4fb67904 - net: micrel: Fix lan8841_config_intr after getting out of sleep mode

Fri, 24 May 2024 08:53:50 +0000

net: micrel: Fix lan8841_config_intr after getting out of sleep modeWhen the interrupt is enabled, the function lan8841_config_intr tries toclear any pending interrupts by reading the interrupt status, thenchecks the return value for errors and then continue to enable theinterrupt. It has been seen that once the system gets out of sleep mode,the interrupt status has the value 0x400 meaning that the PHY detectedthat the link was in low power. That is correct value but the problem isthat the check is wrong. We try to check for errors but we return anerror also in this case which is not an error. Therefore fix this byreturning only when there is an error.Fixes: a8f1a19d27ef ("net: micrel: Add support for lan8841 PHY")Signed-off-by: Horatiu Vultur Reviewed-by: Suman Ghosh Reviewed-by: Andrew Lunn Reviewed-by: Russell King (Oracle) Link: https://lore.kernel.org/r/20240524085350.359812-1-horatiu.vultur@microchip.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/micrel.c

128d54fb - net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061

Tue, 21 May 2024 06:54:06 +0000

net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061Following a similar reinstate for the KSZ8081 and KSZ9031.Older kernels would use the genphy_soft_reset if the PHY did not implementa .soft_reset.The KSZ8061 errata described here:https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdfand worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")is back again without this soft reset.Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")Tested-by: Karim Ben Houcine Signed-off-by: Mathieu Othacehe Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

aea27a92 - net: micrel: Fix receiving the timestamp in the frame for lan8841

Mon, 13 May 2024 19:21:57 +0000

net: micrel: Fix receiving the timestamp in the frame for lan8841The blamed commit started to use the ptp workqueue to get the secondpart of the timestamp. And when the port was set down, then thisworkqueue is stopped. But if the config option NETWORK_PHY_TIMESTAMPINGis not enabled, then the ptp_clock is not initialized so then it wouldcrash when it would try to access the delayed work.So then basically by setting up and then down the port, it would crash.The fix consists in checking if the ptp_clock is initialized and onlythen cancel the delayed work.Fixes: cc7554954848 ("net: micrel: Change to receive timestamp in the frame for lan8841")Signed-off-by: Horatiu Vultur Reviewed-by: Simon Horman Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

b3f1a08f - net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814

Fri, 26 Apr 2024 14:02:24 +0000

net: phy: micrel: Add support for PTP_PF_EXTTS for lan8814Extend the PTP programmable gpios to implement also PTP_PF_EXTTSfunction. The pins can be configured to capture both of risingand falling edge. Once the event is seen, then an interrupt isgenerated and the LTC is saved in the registers.On lan8814 only GPIO 3 can be configured for this.This was tested using:ts2phc -m -l 7 -s generic -f ts2phc.cfgWhere the configuration was the following: --- [global] ts2phc.pin_index 3 [eth0] ---Reviewed-by: Vadim Fedorenko Signed-off-by: Horatiu Vultur Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/micrel.c

9e63941b - net: phy: micrel: lan8814: Add support for PTP_PF_PEROUT

Mon, 08 Apr 2024 06:44:32 +0000

net: phy: micrel: lan8814: Add support for PTP_PF_PEROUTLan8814 has 24 GPIOs but only 2 GPIOs (GPIO 0 and GPIO 1) can beconfigured to generate period signals. And there are 2 events (EVENT_Aand EVENT_B) but these events are hardcoded to the GPIO 0 and GPIO 1.These events are used to generate period signals. It is possible toconfigure the length, the start time and the period of the signal byconfiguring the event.These events are generated by comparing the target time with the PHCtime. In case the PHC time is changed to a value bigger than the targettime + reload time, then it would generate only 1 event and then itwould stop because target time + reload time is smaller than PHC time.Therefore it is required to change also the target time every time whenthe PHC is changed. The same will apply also when the PHC time ischanged to a smaller value.This was tested using:testptp -i 1 -L 1,2testptp -i 1 -p 1000000000 -w 200000000Acked-by: Richard Cochran Reviewed-by: Divya Koppera Signed-off-by: Horatiu Vultur Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/phy/micrel.c

9f6b3a49 - net: phy: micrel: lan8814: Enable LTC at probe time

Mon, 08 Apr 2024 06:44:31 +0000

net: phy: micrel: lan8814: Enable LTC at probe timeThe LTC for lan8814 was enabled only if timestamping was enabled,otherwise it would be stopped. Meaning that LTC will not increase byitself. This might break other features that don't required timestampinglike generating 1PPS. Therefore enable the LTC at probe time.Acked-by: Richard Cochran Signed-off-by: Horatiu Vultur Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/phy/micrel.c