Changes in lxt.c

b01b59a4 - net: phy: Constify struct mdio_device_id

Sun, 12 Jan 2025 14:14:50 +0000

net: phy: Constify struct mdio_device_id'struct mdio_device_id' is not modified in these drivers.Constifying these structures moves some data to a read-only section, soincrease overall security.On a x86_64, with allmodconfig, as an example:Before:====== text data bss dec hex filename 27014 12792 0 39806 9b7e drivers/net/phy/broadcom.oAfter:===== text data bss dec hex filename 27206 12600 0 39806 9b7e drivers/net/phy/broadcom.oSigned-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/403c381b7d9156b67ad68ffc44b8eee70c5e86a9.1736691226.git.christophe.jaillet@wanadoo.frSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/lxt.c

1953feb0 - net: phy: correct format of block comments

Wed, 16 Jun 2021 10:01:20 +0000

net: phy: correct format of block commentsBlock comments should not use a trailing */ on a separate line and everyline of a block comment should start with an '*'.Signed-off-by: Wenpeng Liang Signed-off-by: Weihang Li Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

4217a64e - net: phy: introduce phydev->port

Tue, 09 Feb 2021 16:38:52 +0000

net: phy: introduce phydev->portAt the moment, PORT_MII is reported in the ethtool ops. This is oddbecause it is an interface between the MAC and the PHY and no externalport. Some network card drivers will overwrite the port to twisted pairor fiber, though. Even worse, the MDI/MDIX setting is only used byethtool if the port is twisted pair.Set the port to PORT_TP by default because most PHY drivers are copperones. If there is fibre support and it is enabled, the PHY driver willset it to PORT_FIBRE.This will change reporting PORT_MII to either PORT_TP or PORT_FIBRE;except for the genphy fallback driver.Suggested-by: Andrew Lunn Signed-off-by: Michael Walle Reviewed-by: Florian Fainelli Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

9a12dd6f - net: phy: lxt: remove the use of .ack_interrupt()

Fri, 13 Nov 2020 16:52:16 +0000

net: phy: lxt: remove the use of .ack_interrupt()In preparation of removing the .ack_interrupt() callback, we must replaceits occurrences (aka phy_clear_interrupt), from the 2 places where it iscalled from (phy_enable_interrupts and phy_disable_interrupts), withequivalent functionality.This means that clearing interrupts now becomes something that the PHYdriver is responsible of doing, before enabling interrupts and afterclearing them. Make this driver follow the new contract.Cc: Christophe Leroy Signed-off-by: Ioana Ciornei Signed-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/lxt.c

01c4a00b - net: phy: lxt: implement generic .handle_interrupt() callback

Fri, 13 Nov 2020 16:52:15 +0000

net: phy: lxt: implement generic .handle_interrupt() callbackIn an attempt to actually support shared IRQs in phylib, we now move theresponsibility of triggering the phylib state machine or just returningIRQ_NONE, based on the IRQ status register, to the PHY driver. Having3 different IRQ handling callbacks (.handle_interrupt(),.did_interrupt() and .ack_interrupt() ) is confusing so let the PHYdriver implement directly an IRQ handler like any other device driver.Make this driver follow the new convention.Cc: Christophe Leroy Signed-off-by: Ioana Ciornei Signed-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/lxt.c

0efc286a - net: phy: provide and use genphy_read_status_fixed()

Tue, 17 Dec 2019 13:39:16 +0000

net: phy: provide and use genphy_read_status_fixed()There are two drivers and generic code which contain exactly the samecode to read the status of a PHY operating without autonegotiationenabled. Rather than duplicate this code, provide a helper to readthis information.Signed-off-by: Russell King Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

af006240 - net: phy: use phy_resolve_aneg_pause()

Tue, 17 Dec 2019 13:39:06 +0000

net: phy: use phy_resolve_aneg_pause()Several drivers code their own version of this, working from the LPAregister, after setting the ethtool link partner advertisement bitmask.Use the generic function instead.Signed-off-by: Russell King Reviewed-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

5556fdb0 - net: phy: lxt: Add suspend/resume support to LXT971 and LXT973.

Thu, 23 May 2019 08:55:32 +0000

net: phy: lxt: Add suspend/resume support to LXT971 and LXT973.All LXT PHYs implement the standard "power down" bit 11 ofBMCR, so this patch adds support using the genericgenphy_{suspend,resume} functions added bycommit 0f0ca340e57b ("phy: power management support").LXT970 is left aside because all registers get cleared upon"power down" exit.Reviewed-by: Heiner Kallweit Signed-off-by: Christophe Leroy Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

dcdecdcf - net: phy: switch drivers to use dynamic feature detection

Fri, 12 Apr 2019 18:47:03 +0000

net: phy: switch drivers to use dynamic feature detectionRecently genphy_read_abilities() has been added that dynamically detectsclause 22 PHY abilities. I *think* this detection should work with allsupported PHY's, at least for the ones with basic features sets, i.e.PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting thesefeatures explicitly and rely on phylib feature detection.I don't have access to most of these PHY's, therefore I'd appreciateregression testing.v2:- make the feature constant a comment so that readers know which features are supported by the respective PHYSigned-off-by: Heiner Kallweit Tested-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

a2443fd1 - net: phy: Convert some PHY and MDIO driver files to SPDX headers

Mon, 21 Jan 2019 18:05:50 +0000

net: phy: Convert some PHY and MDIO driver files to SPDX headersWhere the license text and the MODULE_LICENSE() value agree, convertto using an SPDX header, removing the license text.Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

c0ec3c27 - net: phy: Convert u32 phydev->lp_advertising to linkmode

Sat, 10 Nov 2018 22:43:34 +0000

net: phy: Convert u32 phydev->lp_advertising to linkmodeConvert phy drivers to report the link partner advertised modes usinga linkmode bitmap. This allows them to report the higher speeds whichdon't fit in a u32.Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

a4307c0e - net: phy: remove flag PHY_HAS_INTERRUPT from driver configs

Fri, 09 Nov 2018 17:17:22 +0000

net: phy: remove flag PHY_HAS_INTERRUPT from driver configsNow that flag PHY_HAS_INTERRUPT has been replaced with a check forcallbacks config_intr and ack_interrupt, we can remove setting thisflag from all driver configs.Last but not least remove flag PHY_HAS_INTERRUPT completely.Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

80274aba - net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

Thu, 30 Nov 2017 22:47:52 +0000

net: phy: remove generic settings for callbacks config_aneg and read_status from driversRemove generic settings for callbacks config_aneg and read_statusfrom drivers.Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

ca83697c - net: phy: lxt: Export link partner advertising

Mon, 19 Jun 2017 14:00:22 +0000

net: phy: lxt: Export link partner advertisingProvide link partner advertising information.Removed testing for gigabit modes, which is useless for a fast ethernet phy.Signed-off-by: Thomas Bogendoerfer Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

7c0f6ba6 - Replace with globally

Sat, 24 Dec 2016 19:46:01 +0000

Replace with globallyThis was entirely automated, using the script by Al: PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*' sed -i -e "s!$PATT!#include !" \ $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)to do the replacement at the end of the merge window.Requested-by: Al Viro Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/net/phy/lxt.c

c8396d84 - lxt: simplify lxt970_config_init()

Fri, 13 May 2016 23:09:07 +0000

lxt: simplify lxt970_config_init()This function declares the 'err' local variable for no good reason, get ridof it.Signed-off-by: Sergei Shtylyov Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

04e6233d - lxt: simplify lxt97[01]_config_intr()

Fri, 13 May 2016 23:08:02 +0000

lxt: simplify lxt97[01]_config_intr()Both these functions declare the 'err' local variables for no good reason,get rid of them.Signed-off-by: Sergei Shtylyov Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

be01da72 - phy: Centralize setting driver module owner

Wed, 06 Jan 2016 19:11:22 +0000

phy: Centralize setting driver module ownerRather than have each driver set the driver owner field, do it once inthe core code. This will also help with later changes, when the devicestructure will move.Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

50fd7150 - net: phy: replace phy_drivers_register calls

Tue, 11 Nov 2014 18:45:59 +0000

net: phy: replace phy_drivers_register callsReplace module init/exit which only calls phy_drivers_register withmodule_phy_driver macro.Tested using Micrel driver, and otherwise compile-tested only.Signed-off-by: Johan Hovold Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c

5df47d5e - net: phy: lxt: fix checkpath errors

Wed, 18 Dec 2013 05:38:09 +0000

net: phy: lxt: fix checkpath errorscheckpath spotted a few errors in this file, fix them.Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/lxt.c