Changes in bcm63xx.c

b01b59a4 - net: phy: Constify struct mdio_device_id

Sun, 12 Jan 2025 14:14:50 +0000

net: phy: Constify struct mdio_device_id'struct mdio_device_id' is not modified in these drivers.Constifying these structures moves some data to a read-only section, soincrease overall security.On a x86_64, with allmodconfig, as an example:Before:====== text data bss dec hex filename 27014 12792 0 39806 9b7e drivers/net/phy/broadcom.oAfter:===== text data bss dec hex filename 27206 12600 0 39806 9b7e drivers/net/phy/broadcom.oSigned-off-by: Christophe JAILLET Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/403c381b7d9156b67ad68ffc44b8eee70c5e86a9.1736691226.git.christophe.jaillet@wanadoo.frSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

15772e4d - net: phy: broadcom: remove use of ack_interrupt()

Sun, 01 Nov 2020 12:51:07 +0000

net: phy: broadcom: remove use of ack_interrupt()In preparation of removing the .ack_interrupt() callback, we must replaceits occurrences (aka phy_clear_interrupt), from the 2 places where it iscalled from (phy_enable_interrupts and phy_disable_interrupts), withequivalent functionality.This means that clearing interrupts now becomes something that the PHYdriver is responsible of doing, before enabling interrupts and afterclearing them. Make this driver follow the new contract.Cc: Michael Walle Cc: Florian Fainelli Signed-off-by: Ioana Ciornei Signed-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

4567d5c3 - net: phy: broadcom: implement generic .handle_interrupt() callback

Sun, 01 Nov 2020 12:51:06 +0000

net: phy: broadcom: implement generic .handle_interrupt() callbackIn an attempt to actually support shared IRQs in phylib, we now move theresponsibility of triggering the phylib state machine or just returningIRQ_NONE, based on the IRQ status register, to the PHY driver. Having3 different IRQ handling callbacks (.handle_interrupt(),.did_interrupt() and .ack_interrupt() ) is confusing so let the PHYdriver implement directly an IRQ handler like any other device driver.Make this driver follow the new convention.Cc: Florian Fainelli Signed-off-by: Ioana Ciornei Tested-by: Michael Walle Signed-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

43de81b0 - net: phy: bcm63xx: fix OOPS due to missing driver name

Mon, 02 Mar 2020 19:46:57 +0000

net: phy: bcm63xx: fix OOPS due to missing driver name719655a14971 ("net: phy: Replace phy driver features u32 with link_modebitmap") was a bit over-eager and also removed the second phy driver'sname, resulting in a nasty OOPS on registration:[ 1.319854] CPU 0 Unable to handle kernel paging request at virtual address 00000000, epc == 804dd50c, ra == 804dd4f0[ 1.330859] Oops[#1]:[ 1.333138] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.4.22 #0[ 1.339217] $ 0 : 00000000 00000001 87ca7f00 805c1874[ 1.344590] $ 4 : 00000000 00000047 00585000 8701f800[ 1.349965] $ 8 : 8701f800 804f4a5c 00000003 64726976[ 1.355341] $12 : 00000001 00000000 00000000 00000114[ 1.360718] $16 : 87ca7f80 00000000 00000000 80639fe4[ 1.366093] $20 : 00000002 00000000 806441d0 80b90000[ 1.371470] $24 : 00000000 00000000[ 1.376847] $28 : 87c1e000 87c1fda0 80b90000 804dd4f0[ 1.382224] Hi : d1c8f8da[ 1.385180] Lo : 5518a480[ 1.388182] epc : 804dd50c kset_find_obj+0x3c/0x114[ 1.393345] ra : 804dd4f0 kset_find_obj+0x20/0x114[ 1.398530] Status: 10008703 KERNEL EXL IE[ 1.402833] Cause : 00800008 (ExcCode 02)[ 1.406952] BadVA : 00000000[ 1.409913] PrId : 0002a075 (Broadcom BMIPS4350)[ 1.414745] Modules linked in:[ 1.417895] Process swapper/0 (pid: 1, threadinfo=(ptrval), task=(ptrval), tls=00000000)[ 1.426214] Stack : 87cec000 80630000 80639370 80640658 80640000 80049af4 80639fe4 8063a0d8[ 1.434816] 8063a0d8 802ef078 00000002 00000000 806441d0 80b90000 8063a0d8 802ef114[ 1.443417] 87cea0de 87c1fde0 00000000 804de488 87cea000 8063a0d8 8063a0d8 80334e48[ 1.452018] 80640000 8063984c 80639bf4 00000000 8065de48 00000001 8063a0d8 80334ed0[ 1.460620] 806441d0 80b90000 80b90000 802ef164 8065dd70 80620000 80b90000 8065de58[ 1.469222] ...[ 1.471734] Call Trace:[ 1.474255] [<804dd50c>] kset_find_obj+0x3c/0x114[ 1.479141] [<802ef078>] driver_find+0x1c/0x44[ 1.483665] [<802ef114>] driver_register+0x74/0x148[ 1.488719] [<80334e48>] phy_driver_register+0x9c/0xd0[ 1.493968] [<80334ed0>] phy_drivers_register+0x54/0xe8[ 1.499345] [<8001061c>] do_one_initcall+0x7c/0x1f4[ 1.504374] [<80644ed8>] kernel_init_freeable+0x1d4/0x2b4[ 1.509940] [<804f4e24>] kernel_init+0x10/0xf8[ 1.514502] [<80018e68>] ret_from_kernel_thread+0x14/0x1c[ 1.520040] Code: 1060000c 02202025 90650000 <90810000> 24630001 14250004 24840001 14a0fffb 90650000[ 1.530061][ 1.531698] ---[ end trace d52f1717cd29bdc8 ]---Fix it by readding the name.Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")Signed-off-by: Jonas Gorski Acked-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

dcdecdcf - net: phy: switch drivers to use dynamic feature detection

Fri, 12 Apr 2019 18:47:03 +0000

net: phy: switch drivers to use dynamic feature detectionRecently genphy_read_abilities() has been added that dynamically detectsclause 22 PHY abilities. I *think* this detection should work with allsupported PHY's, at least for the ones with basic features sets, i.e.PHY_BASIC_FEATURES and PHY_GBIT_FEATURES. So let's remove setting thesefeatures explicitly and rely on phylib feature detection.I don't have access to most of these PHY's, therefore I'd appreciateregression testing.v2:- make the feature constant a comment so that readers know which features are supported by the respective PHYSigned-off-by: Heiner Kallweit Tested-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

a2443fd1 - net: phy: Convert some PHY and MDIO driver files to SPDX headers

Mon, 21 Jan 2019 18:05:50 +0000

net: phy: Convert some PHY and MDIO driver files to SPDX headersWhere the license text and the MODULE_LICENSE() value agree, convertto using an SPDX header, removing the license text.Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

3c1bcc86 - net: ethernet: Convert phydev advertize and supported from u32 to link mode

Sat, 10 Nov 2018 22:43:33 +0000

net: ethernet: Convert phydev advertize and supported from u32 to link modeThere are a few MAC/PHYs combinations which now support > 1Gbps. Thesemay need to make use of link modes with bits > 31. Thus theirsupported PHY features or advertised features cannot be implementedusing the current bitmap in a u32. Convert to using a linkmode bitmap,which can support all the currently devices link modes, and is futureproof as more modes are added.Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

a4307c0e - net: phy: remove flag PHY_HAS_INTERRUPT from driver configs

Fri, 09 Nov 2018 17:17:22 +0000

net: phy: remove flag PHY_HAS_INTERRUPT from driver configsNow that flag PHY_HAS_INTERRUPT has been replaced with a check forcallbacks config_intr and ack_interrupt, we can remove setting thisflag from all driver configs.Last but not least remove flag PHY_HAS_INTERRUPT completely.Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

719655a1 - net: phy: Replace phy driver features u32 with link_mode bitmap

Sat, 29 Sep 2018 21:04:16 +0000

net: phy: Replace phy driver features u32 with link_mode bitmapThis is one step in allowing phylib to make use of link_mode bitmaps,instead of u32 for supported and advertised features. Convert the phydrivers to use bitmaps to indicates the features they support.Build bitmap equivalents of the u32 values at runtime, and have thedrivers point to the appropriate bitmap. These bitmaps are shared, andwe don't want a driver to modify them. So mark them __ro_after_init.Within phylib, the features bitmap is currently turned back into au32. This will be removed once the whole of phylib, and the driversare converted to use bitmaps.Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

80274aba - net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

Thu, 30 Nov 2017 22:47:52 +0000

net: phy: remove generic settings for callbacks config_aneg and read_status from driversRemove generic settings for callbacks config_aneg and read_statusfrom drivers.Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

cd33b3e0 - net: phy: bcm63xx: Utilize correct config_intr function

Wed, 18 Jan 2017 00:26:55 +0000

net: phy: bcm63xx: Utilize correct config_intr functionCommit a1cba5613edf ("net: phy: Add Broadcom phy library for commoninterfaces") make the BCM63xx PHY driver utilize bcm_phy_config_intr()which would appear to do the right thing, except that it does not writeto the MII_BCM63XX_IR register but to MII_BCM54XX_ECR which isdifferent.This would be causing invalid link parameters and events from beinggenerated by the PHY interrupt.Fixes: a1cba5613edf ("net: phy: Add Broadcom phy library for common interfaces")Signed-off-by: Daniel Gonzalez Cabanelas Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

be01da72 - phy: Centralize setting driver module owner

Wed, 06 Jan 2016 19:11:22 +0000

phy: Centralize setting driver module ownerRather than have each driver set the driver owner field, do it once inthe core code. This will also help with later changes, when the devicestructure will move.Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

a1cba561 - net: phy: Add Broadcom phy library for common interfaces

Tue, 06 Oct 2015 19:25:48 +0000

net: phy: Add Broadcom phy library for common interfacesThis patch adds the Broadcom phy library to consolidate commoninterfaces shared by Broadcom phy's.Moved the common interfaces to the 'bcm-phy-lib.c' and updatedthe Broadcom PHY drivers to use the new APIs.Signed-off-by: Arun Parameswaran Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

50fd7150 - net: phy: replace phy_drivers_register calls

Tue, 11 Nov 2014 18:45:59 +0000

net: phy: replace phy_drivers_register callsReplace module init/exit which only calls phy_drivers_register withmodule_phy_driver macro.Tested using Micrel driver, and otherwise compile-tested only.Signed-off-by: Johan Hovold Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

50ab731e - phy: bcm63xx: report Broadcom BCM63xx PHYs as internal

Thu, 23 May 2013 01:11:13 +0000

phy: bcm63xx: report Broadcom BCM63xx PHYs as internalThe Broadcom BCM63xx PHY driver is for the SoC internal PHYs, flag theseas internal PHY devices.Signed-off-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

d5bf9071 - phylib: Support registering a bunch of drivers

Wed, 04 Jul 2012 05:44:34 +0000

phylib: Support registering a bunch of driversIf registering of one of them fails, all already registered driversof this module will be unregistered.Use the new register/unregister functions in all driversregistering more than one driver.amd.c, realtek.c: Simplify: directly return registration result.Tested with broadcom.cAll others compile-tested.Signed-off-by: Christian Hohnstaedt Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

a25cc43e - net:phy:bcm63xx: remove unnecessary code

Mon, 02 Apr 2012 06:24:55 +0000

net:phy:bcm63xx: remove unnecessary codeCompile tested.remove unnecessary code that matches this coccinelle pattern ret = phy_write(x, y , z) if (ret < 0) return ret; return 0;As phy_write returns error code, we dont need to do not need extra checkbefore returning.Signed-off-by: Srinivas Kandagatla Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

cf93c945 - net/phy: fix many "defined but unused" warnings

Sun, 03 Oct 2010 23:43:32 +0000

net/phy: fix many "defined but unused" warningsMODULE_DEVICE_TABLE only expands to something if it's compiledfor a module. So when building-in support for the phys, themdio_device_id tables are unused. Marking them with __maybe_unusedfixes the following warnings: drivers/net/phy/bcm63xx.c:134: warning: 'bcm63xx_tbl' defined but not used drivers/net/phy/broadcom.c:933: warning: 'broadcom_tbl' defined but not used drivers/net/phy/cicada.c:162: warning: 'cicada_tbl' defined but not used drivers/net/phy/davicom.c:222: warning: 'davicom_tbl' defined but not used drivers/net/phy/et1011c.c:114: warning: 'et1011c_tbl' defined but not used drivers/net/phy/icplus.c:137: warning: 'icplus_tbl' defined but not used drivers/net/phy/lxt.c:226: warning: 'lxt_tbl' defined but not used drivers/net/phy/marvell.c:724: warning: 'marvell_tbl' defined but not used drivers/net/phy/micrel.c:234: warning: 'micrel_tbl' defined but not used drivers/net/phy/national.c:154: warning: 'ns_tbl' defined but not used drivers/net/phy/qsemi.c:141: warning: 'qs6612_tbl' defined but not used drivers/net/phy/realtek.c:82: warning: 'realtek_tbl' defined but not used drivers/net/phy/smsc.c:257: warning: 'smsc_tbl' defined but not used drivers/net/phy/ste10Xp.c:135: warning: 'ste10Xp_tbl' defined but not used drivers/net/phy/vitesse.c:195: warning: 'vitesse_tbl' defined but not usedSigned-off-by: Uwe Kleine-König Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

0de8655a - PHY: fix typo in bcm63xx PHY driver table

Fri, 09 Apr 2010 01:04:45 +0000

PHY: fix typo in bcm63xx PHY driver tableSigned-off-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c

4e4f10f6 - phylib: Add module table to all existing phy drivers

Fri, 02 Apr 2010 01:05:56 +0000

phylib: Add module table to all existing phy driversSigned-off-by: David Woodhouse Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/phy/bcm63xx.c