Changes in ipa_smp2p.c

88412277 - net: ipa: sort all includes

Tue, 16 Apr 2024 23:10:18 +0000

net: ipa: sort all includesEstablish the rule that header files are always included in sorted(POSIX local) order. Standard and private headers are separated bya blank line.Similarly, sort all forward-declarations for structures.Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

8c044024 - net: ipa: remove unneeded standard includes

Tue, 16 Apr 2024 23:10:13 +0000

net: ipa: remove unneeded standard includesSome IPA header files include one or more other standard headerfiles despite not directly needing anything defined in the includedfiles. Remove these unnecessary includes.Signed-off-by: Alex Elder Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

5245f4fd - net: ipa: don't save the platform device

Fri, 01 Mar 2024 17:02:42 +0000

net: ipa: don't save the platform deviceThe IPA platform device is now only used as the structure containingthe IPA device structure. Replace the platform device pointer witha pointer to the device structure.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

81d65f34 - net: ipa: pass a platform device to ipa_smp2p_init()

Fri, 01 Mar 2024 17:02:41 +0000

net: ipa: pass a platform device to ipa_smp2p_init()Rather than using the platform device pointer field in the IPApointer, pass a platform device pointer to ipa_smp2p_init(). Usethat pointer throughout that function.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

59622a8f - net: ipa: pass a platform device to ipa_smp2p_irq_init()

Fri, 01 Mar 2024 17:02:40 +0000

net: ipa: pass a platform device to ipa_smp2p_irq_init()Rather than using the platform device pointer field in the IPApointer, pass a platform device pointer to ipa_smp2p_irq_init().Use that pointer throughout that function (without assuming it'sthe same as the IPA platform device pointer).Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

c0ef3df8 - PM: runtime: Simplify pm_runtime_get_if_active() usage

Tue, 30 Jan 2024 11:28:05 +0000

PM: runtime: Simplify pm_runtime_get_if_active() usageThere are two ways to opportunistically increment a device's runtime PMusage count, calling either pm_runtime_get_if_active() orpm_runtime_get_if_in_use(). The former has an argument to tell whether toignore the usage count or not, and the latter simply calls the former withign_usage_count set to false. The other users that want to ignore theusage_count will have to explicitly set that argument to true which is abit cumbersome.To make this function more practical to use, remove the ign_usage_countargument from the function. The main implementation is in a staticfunction called pm_runtime_get_conditional() and implementations ofpm_runtime_get_if_active() and pm_runtime_get_if_in_use() are moved toruntime.c.Signed-off-by: Sakari Ailus Reviewed-by: Alex Elder Reviewed-by: Laurent Pinchart Acked-by: Takashi Iwai # sound/Reviewed-by: Jacek Lawrynowicz # drivers/accel/ivpu/Acked-by: Rodrigo Vivi # drivers/gpu/drm/i915/Reviewed-by: Rodrigo Vivi Acked-by: Bjorn Helgaas # drivers/pci/Signed-off-by: Rafael J. Wysocki List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

a4388da5 - net: ipa: update copyrights

Fri, 30 Sep 2022 22:45:49 +0000

net: ipa: update copyrightsSome source files state copyright dates that are earlier than thelast modification of the file. Change the copyright year to 2022 inall such cases.Signed-off-by: Alex Elder Link: https://lore.kernel.org/r/20220930224549.3503434-1-elder@linaro.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

8afc7e47 - net: ipa: separate disabling setup from modem stop

Tue, 23 Nov 2021 00:15:55 +0000

net: ipa: separate disabling setup from modem stopThe IPA setup_complete flag is set at the end of ipa_setup(), whenthe setup phase of initialization has completed successfully. Thisoccurs as part of driver probe processing, or (if "modem-init" isspecified in the DTS file) it is triggered by the "ipa-setup-ready"SMP2P interrupt generated by the modem.In the latter case, it's possible for driver shutdown (or remove) tobegin while setup processing is underway, and this can't be allowed.The problem is that the setup_complete flag is not adequate to signalthat setup is underway.If setup_complete is set, it will never be un-set, so that case isnot a problem. But if setup_complete is false, there's a chancesetup is underway.Because setup is triggered by an interrupt on a "modem-init" system,there is a simple way to ensure the value of setup_complete is safeto read. The threaded handler--if it is executing--will complete aspart of a request to disable the "ipa-modem-ready" interrupt. Thismeans that ipa_setup() (which is called from the handler) will runto completion if it was underway, or will never be called otherwise.The request to disable the "ipa-setup-ready" interrupt is currentlymade within ipa_modem_stop(). Instead, disable the interruptoutside that function in the two places it's called. In the case ofipa_remove(), this ensures the setup_complete flag is safe to readbefore we read it.Rename ipa_smp2p_disable() to be ipa_smp2p_irq_disable_setup(), to bemore specific about its effect.Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

33a15310 - net: ipa: directly disable ipa-setup-ready interrupt

Tue, 23 Nov 2021 00:15:54 +0000

net: ipa: directly disable ipa-setup-ready interruptWe currently maintain a "disabled" Boolean flag to determine whetherthe "ipa-setup-ready" SMP2P IRQ handler does anything. That flagmust be accessed under protection of a mutex.Instead, disable the SMP2P interrupt when requested, which preventsthe interrupt handler from ever being called. More importantly, itsynchronizes a thread disabling the interrupt with the completion ofthe interrupt handler in case they run concurrently.Use the IPA setup_complete flag rather than the disabled flag in thehandler to determine whether to ignore any interrupts arriving afterthe first.Rename the "disabled" flag to be "setup_disabled", to be specificabout its purpose.Fixes: 530f9216a953 ("soc: qcom: ipa: AP/modem communications")Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

7aa0e8b8 - net: ipa: rename ipa_clock_* symbols

Fri, 20 Aug 2021 16:01:28 +0000

net: ipa: rename ipa_clock_* symbolsRename a number of functions to clarify that there is no longer anotion of an "IPA clock," but rather that the functions are moregenerally related to IPA power management. ipa_clock_enable() -> ipa_power_enable() ipa_clock_disable() -> ipa_power_disable() ipa_clock_rate() -> ipa_core_clock_rate() ipa_clock_init() -> ipa_power_init() ipa_clock_exit() -> ipa_power_exit()Rename the ipa_clock structure to be ipa_power. Rename allvariables and fields using that structure type "power" ratherthan "clock".Rename the ipa_clock_data structure to be ipa_power_data, and morebroadly, just substitute "power" for "clock" in places thatpreviously represented things related to the "IPA clock".Update comments throughout.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

1aac309d - net: ipa: use autosuspend

Fri, 20 Aug 2021 16:01:27 +0000

net: ipa: use autosuspendUse runtime power management autosuspend.Up until this point, we only suspended the IPA hardware for systemsuspend; now we'll suspend it aggressively using runtime powermanagement, setting the initial autosuspend delay to half a secondof inactivity.Replace pm_runtime_put() calls with pm_runtime_put_autosuspend(),call pm_runtime_mark_last_busy() before each of those. In placeswhere we're shutting things down, or decrementing power referencesfor errors, use pm_runtime_put_noidle() instead.Finally, remove ipa_runtime_idle(), so the ->runtime_suspendcallback will occur if idle.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

c43adc75 - net: ipa: don't use ipa_clock_get() in "ipa_smp2p.c"

Thu, 19 Aug 2021 22:19:24 +0000

net: ipa: don't use ipa_clock_get() in "ipa_smp2p.c"If the "modem-init" Device Tree property is present for a platform,the modem performs early IPA hardware initialization, and signalsthis is complete with an "ipa-setup-ready" SMP2P interrupt. Thistriggers a call to ipa_setup(), which requires the hardware to bepowered.Replace the call to ipa_clock_get() in this case with a call topm_runtime_get_sync(). And replace the corresponding calls toipa_clock_put() with calls to pm_runtime_put() instead.There is a chance we get an error when taking this power reference.This is an unlikely scenario, where system suspend is initiated justbefore the modem signals it has finished initializing the IPAhardware. For now we'll just accept that this could occur, andreport it if it does.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

0d08026a - net: ipa: kill ipa_clock_get_additional()

Tue, 10 Aug 2021 19:27:04 +0000

net: ipa: kill ipa_clock_get_additional()Now that ipa_clock_get_additional() is a trivial wrapper aroundpm_runtime_get_if_active(), just open-code it in its only callerand delete the function.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

7ebd168c - net: ipa: have ipa_clock_get() return a value

Tue, 10 Aug 2021 19:26:58 +0000

net: ipa: have ipa_clock_get() return a valueWe currently assume no errors occur when enabling or disabling theIPA core clock and interconnects. And although this commit exposeserrors that could occur, we generally assume this won't happen inpractice.This commit changes ipa_clock_get() and ipa_clock_put() so eachreturns a value. The values returned are meant to mimic what theruntime power management functions return, so we can set up errorhandling here before we make the switch. Have ipa_clock_get()increment the reference count even if it returns an error, to matchthe behavior of pm_runtime_get().More details follow.When taking a reference in ipa_clock_get(), return 0 for the firstreference, 1 for subsequent references, or a negative error code ifan error occurs. Note that if ipa_clock_get() returns an error, wemust not touch hardware; in some cases such errors now cause entireblocks of code to be skipped.When dropping a reference in ipa_clock_put(), we return 0 or anerror code. The error would come from ipa_clock_disable(), whichnow returns what ipa_interconnect_disable() returns (either 0 or anegative error code). For now, callers ignore the return value;if an error occurs, a message will have already been logged, andlittle more can actually be done to improve the situation.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

cf8dfe6a - net: ipa: get another clock for ipa_setup()

Tue, 27 Jul 2021 21:19:30 +0000

net: ipa: get another clock for ipa_setup()Two places call ipa_setup(). The first, ipa_probe(), holds an IPAclock reference when calling ipa_setup() (if the AP is responsiblefor IPA firmware loading). But if the modem is loading IPAfirmware, ipa_smp2p_modem_setup_ready_isr() calls ipa_setup() afterthe modem has signaled the hardware is ready. This can happen atany time, and there is no guarantee the hardware is active.Have ipa_smp2p_modem_setup() take an IPA clock reference before itcalls ipa_setup(), and release it once setup is complete.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

f39650de - kernel.h: split out panic and oops helpers

Thu, 01 Jul 2021 01:54:59 +0000

kernel.h: split out panic and oops helperskernel.h is being used as a dump for all kinds of stuff for a long time.Here is the attempt to start cleaning it up by splitting out panic andoops helpers.There are several purposes of doing this:- dropping dependency in bug.h- dropping a loop by moving out panic_notifier.h- unload kernel.h from something which has its own domainAt the same time convert users tree-wide to use new headers, although forthe time being include new header back to kernel.h to avoid twistedindirected includes for existing users.[akpm@linux-foundation.org: thread_info.h needs limits.h][andriy.shevchenko@linux.intel.com: ia64 fix] Link: https://lkml.kernel.org/r/20210520130557.55277-1-andriy.shevchenko@linux.intel.comLink: https://lkml.kernel.org/r/20210511074137.33666-1-andriy.shevchenko@linux.intel.comSigned-off-by: Andy Shevchenko Reviewed-by: Bjorn Andersson Co-developed-by: Andrew Morton Acked-by: Mike Rapoport Acked-by: Corey Minyard Acked-by: Christian Brauner Acked-by: Arnd Bergmann Acked-by: Kees Cook Acked-by: Wei Liu Acked-by: Rasmus Villemoes Signed-off-by: Andrew Morton Acked-by: Sebastian Reichel Acked-by: Luis Chamberlain Acked-by: Stephen Boyd Acked-by: Thomas Bogendoerfer Acked-by: Helge Deller # pariscSigned-off-by: Linus Torvalds List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

950fd045 - soc: qcom: ipa: Remove superfluous error message around platform_get_irq()

Thu, 10 Jun 2021 14:01:18 +0000

soc: qcom: ipa: Remove superfluous error message around platform_get_irq()The platform_get_irq() prints error message telling that interrupt ismissing,hence there is no need to duplicated that message in thedrivers.Signed-off-by: Tan Zhongjun Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

16bb1b50 - drivers: ipa: fix typos for ipa_smp2p structure doc

Thu, 14 May 2020 11:02:22 +0000

drivers: ipa: fix typos for ipa_smp2p structure docRemove the duplicate "mutex", and change "Motex" to "Mutex". Also Irecommend it's easier for understanding to make the "ready-interrupt"a bundle for it is a parallel description as "shutdown" which is appendedafter the slash.Signed-off-by: Wang Wenhu Cc: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c

530f9216 - soc: qcom: ipa: AP/modem communications

Fri, 06 Mar 2020 04:28:28 +0000

soc: qcom: ipa: AP/modem communicationsThis patch implements two forms of out-of-band communication betweenthe AP and modem. - QMI is a mechanism that allows clients running on the AP interact with services running on the modem (and vice-versa). The AP IPA driver uses QMI to communicate with the corresponding IPA driver resident on the modem, to agree on parameters used with the IPA hardware and to ensure both sides are ready before entering operational mode. - SMP2P is a more primitive mechanism available for the modem and AP to communicate with each other. It provides a means for either the AP or modem to interrupt the other, and furthermore, to provide 32 bits worth of information. The IPA driver uses SMP2P to tell the modem what the state of the IPA clock was in the event of a crash. This allows the modem to safely access the IPA hardware (or avoid doing so) when a crash occurs, for example, to access information within the IPA hardware.Signed-off-by: Alex Elder Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ipa/ipa_smp2p.c