Changes in Kconfig

e1d27d29 - net: xilinx: axienet: Enable adaptive IRQ coalescing with DIM

Thu, 06 Feb 2025 20:10:36 +0000

net: xilinx: axienet: Enable adaptive IRQ coalescing with DIMThe default RX IRQ coalescing settings of one IRQ per packet can representa significant CPU load. However, increasing the coalescing unilaterallycan result in undesirable latency under low load. Adaptive IRQcoalescing with DIM offers a way to adjust the coalescing settings basedon load.This device only supports "CQE" mode [1], where each packet resets thetimer. Therefore, an interrupt is fired either when we receivecoalesce_count_rx packets or when the interface is idle forcoalesce_usec_rx. With this in mind, consider the following scenarios:Link saturated Here we want to set coalesce_count_rx to a large value, in order to coalesce more packets and reduce CPU load. coalesce_usec_rx should be set to at least the time for one packet. Otherwise the link will be "idle" and we will get an interrupt for each packet anyway.Bursts of packets Each burst should be coalesced into a single interrupt, although it may be prudent to reduce coalesce_count_rx for better latency. coalesce_usec_rx should be set to at least the time for one packet so bursts are coalesced. However, additional time beyond the packet time will just increase latency at the end of a burst.Sporadic packets Due to low load, we can set coalesce_count_rx to 1 in order to reduce latency to the minimum. coalesce_usec_rx does not matter in this case.Based on this analysis, I expected the CQE profiles to look somethinglike usec = 0, pkts = 1 // Low load usec = 16, pkts = 4 usec = 16, pkts = 16 usec = 16, pkts = 64 usec = 16, pkts = 256 // High loadWhere usec is set to 16 to be a few us greater than the 12.3 us packettime of a 1500 MTU packet at 1 GBit/s. However, the CQE profile isinstead usec = 2, pkts = 256 // Low load usec = 8, pkts = 128 usec = 16, pkts = 64 usec = 32, pkts = 64 usec = 64, pkts = 64 // High loadI found this very surprising. The number of coalesced packets*decreases* as load increases. But as load increases we have moreopportunities to coalesce packets without affecting latency as much.Additionally, the profile *increases* the usec as the load increases.But as load increases, the gaps between packets will tend to becomesmaller, making it possible to *decrease* usec for better latency at theend of a "burst".I consider the default CQE profile unsuitable for this NIC. Therefore,we use the first profile outlined in this commit instead.coalesce_usec_rx is set to 16 by default, but the user can customize it.This may be necessary if they are using jumbo frames. I think adjustingthe profile times based on the link speed/mtu would be good improvementfor generic DIM.In addition to the above profile problems, I noticed the followingadditional issues with DIM while testing:- DIM tends to "wander" when at low load, since the performance gradient is pretty flat. If you only have 10p/ms anyway then adjusting the coalescing settings will not affect throughput very much.- DIM takes a long time to adjust back to low indices when load is decreased following a period of high load. This is because it only re-evaluates its settings once every 64 interrupts. However, at low load 64 interrupts can be several seconds.Finally: performance. This patch increases receive throughput withiperf3 from 840 Mbits/sec to 938 Mbits/sec, decreases interrupts from69920/sec to 316/sec, and decreases CPU utilization (4x Cortex-A53) from43% to 9%.[1] Who names this stuff?Signed-off-by: Sean Anderson Reviewed by: Shannon Nelson Link: https://patch.msgid.link/20250206201036.1516800-5-sean.anderson@linux.devSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

6a91b846 - net: axienet: Introduce dmaengine support

Wed, 15 Nov 2023 18:56:53 +0000

net: axienet: Introduce dmaengine supportAdd dmaengine framework to communicate with the xilinx DMAenginedriver(AXIDMA).Axi ethernet driver uses separate channels for transmit and receive.Add support for these channels to handle TX and RX with skb andappropriate callbacks. Also add axi ethernet core interrupt fordmaengine framework support.The dmaengine framework was extended for metadata API support.However it still needs further enhancements to make it well suited forethernet usecases. The ethernet features i.e ethtool set/get of DMA IPproperties, ndo_poll_controller,(mentioned in TODO) are not supportedand it requires follow-up discussions.dmaengine support has a dependency on xilinx_dma as it usesxilinx_vdma_channel_set_config() API to reset the DMA IPwhich internally reset MAC prior to accessing MDIO.Benchmark with netperf:xilinx-zcu102-20232:~$ netperf -H 192.168.10.20 -t TCP_STREAMMIGRATED TCP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INETto 192.168.10.20 () port 0 AF_INETRecv Send SendSocket Socket Message ElapsedSize Size Size Time Throughputbytes bytes bytes secs. 10^6bits/sec131072 16384 16384 10.02 886.69xilinx-zcu102-20232:~$ netperf -H 192.168.10.20 -t UDP_STREAMMIGRATED UDP STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INETto 192.168.10.20 () port 0 AF_INETSocket Message Elapsed MessagesSize Size Time Okay Errors Throughputbytes bytes secs # # 10^6bits/sec212992 65507 10.00 15851 0 830.66212992 10.00 15851 830.66Signed-off-by: Radhey Shyam Pandey Link: https://lore.kernel.org/r/1700074613-1977070-4-git-send-email-radhey.shyam.pandey@amd.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

8aba73ef - net: ethernet: xilinx: cleanup comments

Thu, 17 Feb 2022 16:05:18 +0000

net: ethernet: xilinx: cleanup commentsRemove the second 'the'.Replacements:endiannes to endiannessareconnected to are connectedMamagement to Managementundoccumented to undocumentedXilink to Xilinxstrucutre to structureChange kernel-doc comment style to c style for/* Management ...Signed-off-by: Tom Rix Reviewed-by: Michal Simek Acked-by: Randy Dunlap Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

46fd4471 - net: xilinx: drivers need/depend on HAS_IOMEM

Sat, 17 Apr 2021 06:55:54 +0000

net: xilinx: drivers need/depend on HAS_IOMEMkernel test robot reports build errors in 3 Xilinx ethernet drivers.They all use ioremap functions that are only available when HAS_IOMEMis set/enabled. If it is not enabled, they all have build errors,so make these 3 drivers depend on HAS_IOMEM.ld: drivers/net/ethernet/xilinx/xilinx_emaclite.o: in function `xemaclite_of_probe':xilinx_emaclite.c:(.text+0x9fc): undefined reference to `devm_ioremap_resource'ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':xilinx_axienet_main.c:(.text+0x942): undefined reference to `devm_ioremap_resource'ld: drivers/net/ethernet/xilinx/ll_temac_main.o: in function `temac_probe':ll_temac_main.c:(.text+0x1283): undefined reference to `devm_platform_ioremap_resource_byname'ld: ll_temac_main.c:(.text+0x13ad): undefined reference to `devm_of_iomap'ld: ll_temac_main.c:(.text+0x162e): undefined reference to `devm_platform_ioremap_resource'Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Radhey Shyam Pandey Cc: Gary Guo Cc: Zhang Changzhong Cc: Andre Przywara Cc: stable@vger.kernel.orgCc: Daniel Borkmann Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.orgSigned-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

18af77c5 - drivers: net: xilinx_emaclite: remove arch limitation

Tue, 16 Feb 2021 22:33:42 +0000

drivers: net: xilinx_emaclite: remove arch limitationThe changes made in eccd540 is enough for xilinx_emaclite to runwithout problem on 64-bit systems. I have tested it on a XilinxFPGA with RV64 softcore. The architecture limitation in Kconfigseems no longer necessary.A small change is included to print address with %lx instead ofcasting to int and print with %x.Signed-off-by: Gary Guo Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

03dfd157 - drivers: net: xilinx_emaclite: Add COMPILE_TEST support

Tue, 10 Nov 2020 02:40:24 +0000

drivers: net: xilinx_emaclite: Add COMPILE_TEST supportTo improve build testing of this driver, add COMPILE_TEST support.Acked-by: Michal Simek Signed-off-by: Andrew Lunn Signed-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

e8b6c54f - net: xilinx: temac: Relax Kconfig dependencies

Tue, 24 Mar 2020 13:23:34 +0000

net: xilinx: temac: Relax Kconfig dependenciesSimilar to axienet, the temac driver is now architecture agnostic, andcan be at least compiled for several architectures.Especially the fact that this is a soft IP for implementing in FPGAsmakes the current restriction rather pointless, as it could literallyappear on any architecture, as long as an FPGA is connected to the bus.The driver hasn't been actually tried on any hardware, it is just adrive-by patch when doing the same for axienet (a similar patch foraxienet is already merged).This (temac and axienet) have been compile-tested for:alpha hppa64 microblaze mips64 powerpc powerpc64 riscv64 s390 sparc64(using kernel.org cross compilers).Signed-off-by: Andre Przywara Reviewed-by: Radhey Shyam Pandey Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

d7eaf962 - net: axienet: In kconfig remove arch dependency for axi_emac

Wed, 13 Nov 2019 05:21:23 +0000

net: axienet: In kconfig remove arch dependency for axi_emacTo enable xilinx axi_emac driver support on zynqmp ultrascale platform(ARCH64) there are two choices, mention ARCH64 as a dependency listand other is to check if this ARCH dependency list is really needed.Later approach seems more reasonable, so remove the obsolete ARCHdependency list for the axi_emac driver.Sanity test done for microblaze, zynq and zynqmp ultrascale platform.Signed-off-by: Radhey Shyam Pandey Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

f5203a3d - net: axienet: convert to phylink API

Thu, 06 Jun 2019 22:28:24 +0000

net: axienet: convert to phylink APIConvert this driver to use the phylink API rather than the legacy PHYAPI. This allows for better support for SFP modules connected using a1000BaseX or SGMII interface.Signed-off-by: Robert Hancock Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

2190cd19 - net: axienet: add X86 and ARM as supported platforms

Thu, 06 Jun 2019 22:28:08 +0000

net: axienet: add X86 and ARM as supported platformsThis driver should now build on (at least) X86 and ARM platforms, so addthem as supported platforms for the driver in Kconfig.Signed-off-by: Robert Hancock Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

2c02c37e - net: ll_temac: Allow use on x86 platforms

Tue, 30 Apr 2019 07:17:53 +0000

net: ll_temac: Allow use on x86 platformsWith little-endian and 64-bit support in place, the ll_temac driver cannow be used on x86 and x86_64 platforms.And while at it, enable COMPILE_TEST also.Signed-off-by: Esben Haabendal Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

d84aec42 - net: ll_temac: Fix support for 64-bit platforms

Tue, 30 Apr 2019 07:17:50 +0000

net: ll_temac: Fix support for 64-bit platformsThe use of buffer descriptor APP4 field (32-bit) for storing skb pointerobviously does not work on 64-bit platforms.As APP3 is also unused, we can use that to store the other half of 64-bitpointer values.Contrary to what is hinted at in commit message of commit 15bfe05c8d63("net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit")there are no other pointers stored in cdmac_bd.Signed-off-by: Esben Haabendal Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

15bfe05c - net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

Wed, 29 Nov 2017 10:01:09 +0000

net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bitOn 64-bit (e.g. powerpc64/allmodconfig): drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done': drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] dev_kfree_skb_irq((struct sk_buff *)cur_p->app4); ^cdmac_bd.app4 is u32, so it is too small to hold a kernel pointer.Note that several other fields in struct cdmac_bd are also too small tohold physical addresses on 64-bit platforms.Signed-off-by: Geert Uytterhoeven Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

74f13c80 - net: ethernet: xilinx: Enable emaclite for MIPS

Mon, 05 Sep 2016 12:07:54 +0000

net: ethernet: xilinx: Enable emaclite for MIPSThe MIPS based xilfpga platform uses this driver.Enable it for MIPSSigned-off-by: Zubair Lutfullah Kakakhel Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

138b15ed - drivers/net: remove all references to obsolete Ethernet-HOWTO

Sun, 21 Jun 2015 20:28:02 +0000

drivers/net: remove all references to obsolete Ethernet-HOWTOThis howto made sense in the 1990s when users had to manually configureISA cards with jumpers or vendor utilities, but with the implementationof PCI it became increasingly less and less relevant, to the point whereit has been well over a decade since I last updated it. And there isno value in anyone else taking over updating it either.However the references to it continue to spread as boiler plate textfrom one Kconfig file into the next. We are not doing end users anyfavours by pointing them at this old document, so lets kill it withfire, once and for all, to hopefully stop any further spread.No code is changed in this commit, just Kconfig help text.Signed-off-by: Paul Gortmaker Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

1156ee88 - net: emaclite: Enable emaclite for Xilinx Arm Zynq platform

Thu, 30 May 2013 00:28:07 +0000

net: emaclite: Enable emaclite for Xilinx Arm Zynq platformEnable emaclite for Xilinx ARM Zynq platform.Signed-off-by: Michal Simek Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

94b144a7 - net: ethernet: xilinx: Do not use axienet on PPC

Thu, 10 Jan 2013 06:58:42 +0000

net: ethernet: xilinx: Do not use axienet on PPCAxi ethernet can't be used on PPC because it islittle endian IP and PPC is big endian.This system can't be designed.Signed-off-by: Michal Simek Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig

8a3b7a25 - drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver

Thu, 19 Jan 2012 00:39:31 +0000

drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driverThis driver adds support for Xilinx 10/100/1000 AXI Ethernet.It can be used, for instance, on Xilinx boards with a Microblazearchitecture like the ML605.The patch is against the latest net-next tree and checkpatch clean.Signed-off-by: Ariane Keller Signed-off-by: Daniel Borkmann Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/xilinx/Kconfig