Changes in rmnet_map_command.c

9d131d04 - net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros

Mon, 15 Mar 2021 21:51:48 +0000

net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macrosThe following macros, defined in "rmnet_map.h", assume a socketbuffer is provided as an argument without any real indication thisis the case. RMNET_MAP_GET_MUX_ID() RMNET_MAP_GET_CD_BIT() RMNET_MAP_GET_PAD() RMNET_MAP_GET_CMD_START() RMNET_MAP_GET_LENGTH()What they hide is pretty trivial accessing of fields in a structure,and it's much clearer to see this if we do these accesses directly.So rather than using these accessor macros, assign a localvariable of the map header pointer type to the socket buffer datapointer, and derereference that pointer variable.In "rmnet_map_data.c", use sizeof(object) rather than sizeof(type)in one spot. Also, there's no need to byte swap 0; it's all zerosirrespective of endianness.Signed-off-by: Alex Elder Reviewed-by: Bjorn Andersson Reviewed-by: Alexander Duyck Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

97fb5e8d - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284

Wed, 29 May 2019 14:17:58 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 and only version 2 as published by the free software foundation this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more detailsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 294 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190529141900.825281744@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

315c9e83 - net: qualcomm: rmnet: Remove set but not used variable 'cmd'

Thu, 29 Nov 2018 02:36:32 +0000

net: qualcomm: rmnet: Remove set but not used variable 'cmd'Fixes gcc '-Wunused-but-set-variable' warning:drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c: In function 'rmnet_map_do_flow_control':drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:23:36: warning: variable 'cmd' set but not used [-Wunused-but-set-variable] struct rmnet_map_control_command *cmd;'cmd' not used anymore now, should also be removed.Signed-off-by: YueHaibing Acked-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

62e3a931 - net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'

Wed, 28 Nov 2018 12:31:42 +0000

net: qualcomm: rmnet: remove set but not used variables 'ip_family, fc_seq, qos_id'Fixes gcc '-Wunused-but-set-variable' warning:drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:26:6: warning: variable 'ip_family' set but not used [-Wunused-but-set-variable]drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:27:6: warning: variable 'fc_seq' set but not used [-Wunused-but-set-variable]drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c:28:6: warning: variable 'qos_id' set but not used [-Wunused-but-set-variable]It never used since introduction in commitceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")Signed-off-by: YueHaibing Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

3602207c - net: qualcomm: rmnet: Fix use after free while sending command ack

Tue, 05 Jun 2018 01:43:38 +0000

net: qualcomm: rmnet: Fix use after free while sending command ackWhen sending an ack to a command packet, the skb is still referencedafter it is sent to the real device. Since the real device couldfree the skb, the device pointer would be invalid.Also, remove an unnecessary variable.Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial implementation")Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

721ce0f6 - net: qualcomm: rmnet: Remove redundant command check

Wed, 16 May 2018 00:52:02 +0000

net: qualcomm: rmnet: Remove redundant command checkThe command packet size is already checked once inrmnet_map_deaggregate() for the header, packet and trailer size, sothis additional check is not needed.Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

14452ca3 - net: qualcomm: rmnet: Export mux_id and flags to netlink

Thu, 22 Mar 2018 01:48:14 +0000

net: qualcomm: rmnet: Export mux_id and flags to netlinkDefine new netlink attributes for rmnet mux_id and flags. Theseflags / mux_id were earlier using vlan flags / id respectively.The flag bits are also moved to uapi and are renamed withprefix RMNET_FLAG_*.Also add the rmnet policy to handle the new netlink attributes.Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

9dcaec04 - net: qualcomm: rmnet: Update copyright year to 2018

Thu, 22 Mar 2018 01:48:12 +0000

net: qualcomm: rmnet: Update copyright year to 2018Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

f57bbaae - net: qualcomm: rmnet: Fix possible null dereference in command processing

Fri, 16 Feb 2018 22:56:39 +0000

net: qualcomm: rmnet: Fix possible null dereference in command processingIf a command packet with invalid mux id is received, the packet wouldnot have a valid endpoint. This invalid endpoint maybe dereferencedleading to a crash. Identified by manual code inspection.Fixes: 3352e6c45760 ("net: qualcomm: rmnet: Convert the muxed endpoint to hlist")Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

23c76eb7 - net: qualcomm: rmnet: Handle command packets with checksum trailer

Sun, 07 Jan 2018 18:36:38 +0000

net: qualcomm: rmnet: Handle command packets with checksum trailerWhen using the MAPv4 packet format in conjunction with MAP commands,a dummy DL checksum trailer will be appended to the packet. Beforethis packet is sent out as an ACK, the DL checksum trailer needs to beremoved.Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

2ffbbf0f - net: qualcomm: rmnet: Fix the return value of rmnet_rx_handler()

Thu, 26 Oct 2017 17:06:46 +0000

net: qualcomm: rmnet: Fix the return value of rmnet_rx_handler()Since packet is always consumed by rmnet_rx_handler(), we alwaysreturn RX_HANDLER_CONSUMED. There is no need to pass on thisvalue through multiple functions.Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

3352e6c4 - net: qualcomm: rmnet: Convert the muxed endpoint to hlist

Thu, 12 Oct 2017 00:43:57 +0000

net: qualcomm: rmnet: Convert the muxed endpoint to hlistRather than using a static array, use a hlist to store the muxedendpoints and use the mux id to query the rmnet_device.This is useful as usually very few mux ids are used.Signed-off-by: Subash Abhinov Kasiviswanathan Cc: Dan Williams Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

b665f4f8 - net: qualcomm: rmnet: Rename real_dev_info to port

Sun, 03 Sep 2017 05:30:46 +0000

net: qualcomm: rmnet: Rename real_dev_info to portMake it similar to drivers like ipvlan / macvlan so it is easier to read.Signed-off-by: Subash Abhinov Kasiviswanathan Cc: Dan Williams Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

ceed73a2 - drivers: net: ethernet: qualcomm: rmnet: Initial implementation

Wed, 30 Aug 2017 04:44:18 +0000

drivers: net: ethernet: qualcomm: rmnet: Initial implementationRmNet driver provides a transport agnostic MAP (multiplexing andaggregation protocol) support in embedded module. Module providesvirtual network devices which can be attached to any IP-modephysical device. This will be used to provide all MAP functionalityon future hardware in a single consistent location.Signed-off-by: Subash Abhinov Kasiviswanathan Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c