Changes in Kconfig

d3296a9d - eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency

Wed, 16 Oct 2024 06:22:58 +0000

eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependencyfbnic fails to link as built-in when PTP support is in a loadablemodule:aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'Add the appropriate dependency to enforce this.Fixes: 6a2b3ede9543 ("eth: fbnic: add RX packets timestamping support")Signed-off-by: Arnd Bergmann Reviewed-by: Vadim Fedorenko Message-ID: <20241016062303.2551686-1-arnd@kernel.org>Signed-off-by: Andrew Lunn List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

9a95b7a8 - eth: fbnic: select DEVLINK and PAGE_POOL

Fri, 02 Aug 2024 15:43:17 +0000

eth: fbnic: select DEVLINK and PAGE_POOLBuild bot reports undefined references to devlink functions.And local testing revealed undefined references to page_pool functions.Based on a patch by Jakub Kicinski Fixes: 1a9d48892ea5 ("eth: fbnic: Allocate core device specific structures and devlink interface")Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202408011219.hiPmwwAs-lkp@intel.com/Signed-off-by: Simon Horman Link: https://patch.msgid.link/20240802-fbnic-select-v2-1-41f82a3e0178@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

69794365 - fbnic: Change kconfig prompt from S390=n to !S390

Thu, 25 Jul 2024 17:03:54 +0000

fbnic: Change kconfig prompt from S390=n to !S390In testing the recent kernel I found that the fbnic driver couldn't beenabled on x86_64 builds. A bit of digging showed that the fbnic driver wasthe only one to check for S390 to be n, all others had checked for !S390.Since it is a boolean and not a tristate I am not sure it will be N. Sojust update it to use the !S390 flag.A quick check via "make menuconfig" verified that after making this changethere was an option to select the fbnic driver.Fixes 0e03c643dc93 ("eth: fbnic: fix s390 build.")Signed-off-by: Alexander Duyck Reviewed-by: Joe Damato Link: https://patch.msgid.link/172192698293.1903337.4255690118685300353.stgit@ahduyck-xeon-server.home.arpaSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

43598361 - eth: fbnic: don't build the driver when skb has more than 21 frags

Wed, 17 Jul 2024 16:15:59 +0000

eth: fbnic: don't build the driver when skb has more than 21 fragsSimilarly to commit 0e03c643dc93 ("eth: fbnic: fix s390 build."),the driver won't build if skb_shared_info has more than 25 fragsassuming a 64B cache line and 21 frags assuming a 128B cache line. (512 - 48 - 64) / 16 = 25 (512 - 48 - 128) / 16 = 21Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")Signed-off-by: Jakub Kicinski Link: https://patch.msgid.link/20240717161600.1291544-1-kuba@kernel.orgSigned-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

0e03c643 - eth: fbnic: fix s390 build.

Wed, 17 Jul 2024 11:25:06 +0000

eth: fbnic: fix s390 build.Building the fbnic nn s390, yield a build bug:In function ‘fbnic_config_drop_mode_rcq’, inlined from ‘fbnic_enable’ at drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:1836:4:././include/linux/compiler_types.h:510:45: error: call to ‘__compiletime_assert_919’ declared with attribute error: FIELD_PREP: value too large for the fieldThe relevant mask is 9 bits wide, and the related value is the cachelinealigned size of struct skb_shared_info.On s390 the cacheline size is 256 bytes, and skb_shared_info minimumsize on 64 bits system is 320 bytes.Avoid building the driver for such arch.Reported-by: kernel test robot Link: https://lore.kernel.org/202407170432.dYJQOWVz-lkp@intel.com/Reported-by: Nathan Chancellor Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")Signed-off-by: Paolo Abeni Link: https://patch.msgid.link/5dfefd3e90e77828f38e68854b171a5b8b8c6ede.1721215379.git.pabeni@redhat.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

69684376 - eth: fbnic: Add link detection

Fri, 12 Jul 2024 15:49:58 +0000

eth: fbnic: Add link detectionAdd basic support for detecting the link and reporting it at the netdevlayer. For now we will just use the values reporeted by the firmware as thelink configuration and assume that is the current configuration of the MACand PCS.With this we start the stubbing out of the phylink interface that will beused to provide the configuration interface for ethtool in a future patchset.The phylink interface isn't an exact fit. As such we are currently workingaround several issues in this patch set that we plan to address in thefuture such as:1. Support for FEC2. Support for multiple lanes to handle 50GbaseR2 vs 50GbaseR13. Support for BMCCC: Russell King CC: Andrew Lunn Signed-off-by: Alexander Duyck Link: https://patch.msgid.link/172079939835.1778861.5964790909718481811.stgit@ahduyck-xeon-server.home.arpaSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig

546dd90b - eth: fbnic: Add scaffolding for Meta's NIC driver

Fri, 12 Jul 2024 15:49:16 +0000

eth: fbnic: Add scaffolding for Meta's NIC driverCreate a bare-bones PCI driver for Meta's NIC.Subsequent changes will flesh it out.Signed-off-by: Alexander Duyck Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/172079935646.1778861.9710282776096050607.stgit@ahduyck-xeon-server.home.arpaSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/meta/Kconfig