Changes in Kconfig

d734223b - iavf: add initial framework for registering PTP clock

Wed, 06 Nov 2024 17:37:23 +0000

iavf: add initial framework for registering PTP clockAdd the iavf_ptp.c file and fill it in with a skeleton framework toallow registering the PTP clock device.Add implementation of helper functions to check if a PTP capabilityis supported and handle change in PTP capabilities.Enabling virtual clock would be possible, though it would probablyperform poorly due to the lack of direct time access.Signed-off-by: Jacob Keller Reviewed-by: Sai Krishna Reviewed-by: Simon Horman Co-developed-by: Ahmed Zaki Signed-off-by: Ahmed Zaki Tested-by: Rafal Romanowski Co-developed-by: Mateusz Polchlopek Signed-off-by: Mateusz Polchlopek Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

f0030752 - ice: Implement PTP support for E830 devices

Mon, 30 Sep 2024 12:12:44 +0000

ice: Implement PTP support for E830 devicesAdd specific functions and definitions for E830 devices to enablePTP support.E830 devices support direct write to GLTSYN_ registers without shadowregisters and 64 bit read of PHC time.Enable PTM for E830 device, which is required for cross timestamp andand dependency on PCIE_PTM for ICE_HWTS.Check X86_FEATURE_ART for E830 as it may not be present in the CPU.Cc: Anna-Maria Behnsen Cc: Frederic Weisbecker Cc: Thomas Gleixner Reviewed-by: Przemek Kitszel Co-developed-by: Jacob Keller Signed-off-by: Jacob Keller Co-developed-by: Milena Olech Signed-off-by: Milena Olech Co-developed-by: Paul Greenwalt Signed-off-by: Paul Greenwalt Signed-off-by: Michal Michalik Co-developed-by: Karol Kolacinski Signed-off-by: Karol Kolacinski Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel)Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

dc4305be - ice: use for Tx and Rx queue context data

Tue, 10 Dec 2024 20:27:16 +0000

ice: use for Tx and Rx queue context dataThe ice driver needs to write the Tx and Rx queue context when programmingTx and Rx queues. This is currently done using some bespoke custom logicvia the ice_set_ctx() and its helper functions, along with bit positiondefinitions in the ice_tlan_ctx_info and ice_rlan_ctx_info structures.This logic does work, but is problematic for several reasons:1) ice_set_ctx requires a helper function for each byte size being packed, as it uses a separate function to pack u8, u16, u32, and u64 fields. This requires 4 functions which contain near-duplicate logic with the types changed out.2) The logic in the ice_pack_ctx_word, ice_pack_ctx_dword, and ice_pack_ctx_qword does not handle values which straddle alignment boundaries very well. This requires that several fields in the ice_tlan_ctx_info and ice_rlan_ctx_info be a size larger than their bit size should require.3) Future support for live migration will require adding unpacking functions to take the packed hardware context and unpack it into the ice_rlan_ctx and ice_tlan_ctx structures. Implementing this would require implementing ice_get_ctx, and its associated helper functions, which essentially doubles the amount of code required.The Linux kernel has had a packing library that can handle this logic sincecommit 554aae35007e ("lib: Add support for generic packing operations").The library was recently extended with support for packing or unpacking anarray of fields, with a similar structure as the ice_ctx_ele structure.Replace the ice-specific ice_set_ctx() logic with the recently addedpack_fields and packed_field_s infrastructure from For API simplicity, the Tx and Rx queue context are programmed usingseparate ice_pack_txq_ctx() and ice_pack_rxq_ctx(). This avoids needing toexport the packed_field_s arrays. The functions can pointers to theappropriate ice_txq_ctx_buf_t and ice_rxq_ctx_buf_t types, ensuring thatonly buffers of the appropriate size are passed.Signed-off-by: Jacob Keller Reviewed-by: Vladimir Oltean Link: https://patch.msgid.link/20241210-packing-pack-fields-and-ice-implementation-v10-7-ee56a47479ac@intel.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

ef490bbb - iavf: Add net_shaper_ops support

Wed, 09 Oct 2024 08:10:00 +0000

iavf: Add net_shaper_ops supportImplement net_shaper_ops support for IAVF. This enables configurationof rate limiting on per queue basis. Customer intends to enforcebandwidth limit on Tx traffic steered to the queue by configuringrate limits on the queue.To set rate limiting for a queue, update shaper object of given queuesin driver and send VIRTCHNL_OP_CONFIG_QUEUE_BW to PF to update HWconfiguration.Deleting shaper configured for queue is nothing but configuring shaperwith bw_max 0. The PF restores the default rate limiting configwhen bw_max is zero.Reviewed-by: Jiri Pirko Signed-off-by: Sudheer Mogilappagari Signed-off-by: Paolo Abeni Link: https://patch.msgid.link/5a882cb51998c4c2c3d21fed521498eba1c8f079.1728460186.git.pabeni@redhat.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

f771314d - idpf: compile singleq code only under default-n CONFIG_IDPF_SINGLEQ

Thu, 20 Jun 2024 13:53:42 +0000

idpf: compile singleq code only under default-n CONFIG_IDPF_SINGLEQCurrently, all HW supporting idpf supports the singleq model, but noneof it advertises it by default, as splitq is supported and preferredfor multiple reasons. Still, this almost dead code often times addshotpath branches and redundant cacheline accesses.While it can't currently be removed, add CONFIG_IDPF_SINGLEQ and buildthe singleq code only when it's enabled manually. This corresponds to-10 Kb of object code size and a good bunch of hotpath checks.idpf_is_queue_model_split() works as a gate and compiles out to `true`when the config option is disabled.Reviewed-by: Przemek Kitszel Signed-off-by: Alexander Lobakin Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

306ec721 - net: intel: introduce {, Intel} Ethernet common library

Thu, 18 Apr 2024 11:36:07 +0000

net: intel: introduce {, Intel} Ethernet common libraryNot a secret there's a ton of code duplication between two and more Intelethernet modules.Before introducing new changes, which would need to be copied over again,start decoupling the already existing duplicate functionality into a newmodule, which will be shared between several Intel Ethernet drivers.Add the lookup table which converts 8/10-bit hardware packet type intoa parsed bitfield structure for easy checking packet format parameters,such as payload level, IP version, etc. This is currently used by i40e,ice and iavf and it's all the same in all three drivers.The only difference introduced in this implementation is that instead ofdefining a 256 (or 1024 in case of ice) element array, add unlikely()condition to limit the input to 154 (current maximum non-reserved packettype). There's no reason to waste 600 (or even 3600) bytes only to nothurt very unlikely exception packets.The hash computation function now takes payload level directly as apkt_hash_type. There's a couple cases when non-IP ptypes are marked asL3 payload and in the previous versions their hash level would be 2, not3. But skb_set_hash() only sees difference between L4 and non-L4, thusthis won't change anything at all.The module is behind the hidden Kconfig symbol, which the drivers willselect when needed. The exports are behind 'LIBIE' namespace to limitthe scope of the functions.Not that non-HW-specific symbols will live in yet another module,libeth. This is done to easily distinguish pretty generic code readyfor reusing by any other vendor and/or for moving the layer up fromthe code useful in Intel's 1-100G drivers only.Signed-off-by: Alexander Lobakin Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

a29689e6 - net: handle HAS_IOPORT dependencies

Fri, 05 Apr 2024 11:18:31 +0000

net: handle HAS_IOPORT dependenciesIn a future patch HAS_IOPORT=n will disable inb()/outb() and friends atcompile time. We thus need to add HAS_IOPORT as dependency forthose drivers requiring them. For the DEFXX driver the use of I/Oports is optional and we only need to fence specific code paths. It alsoturns out that with HAS_IOPORT handled explicitly HAMRADIO does not needthe !S390 dependency and successfully builds the bpqether driver.Acked-by: Marc Kleine-Budde Acked-by: Jakub Kicinski Acked-by: Maciej W. Rozycki Co-developed-by: Arnd Bergmann Signed-off-by: Arnd Bergmann Signed-off-by: Niklas Schnelle Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

30654f0e - igc: fix LEDS_CLASS dependency

Fri, 01 Mar 2024 18:48:04 +0000

igc: fix LEDS_CLASS dependencyWhen IGC is built-in but LEDS_CLASS is a loadable module, there isa link failure:x86_64-linux-ld: drivers/net/ethernet/intel/igc/igc_leds.o: in function `igc_led_setup':igc_leds.c:(.text+0x75c): undefined reference to `devm_led_classdev_register_ext'Add another dependency that prevents this combination.Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226")Signed-off-by: Arnd Bergmann Reviewed-by: Kurt Kanzenbach Signed-off-by: Tony Nguyen Link: https://lore.kernel.org/r/20240301184806.2634508-4-anthony.l.nguyen@intel.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

ea578703 - igc: Add support for LEDs on i225/i226

Tue, 13 Feb 2024 18:41:37 +0000

igc: Add support for LEDs on i225/i226Add support for LEDs on i225/i226. The LEDs can be controlled via sysfsfrom user space using the netdev trigger. The LEDs are named asigc-- to be easily identified.Offloading link speed and activity are supported. Other modes are simulatedin software by using on/off. Tested on Intel i225.Signed-off-by: Kurt Kanzenbach Reviewed-by: Andrew Lunn Tested-by: Naama Meir Signed-off-by: Tony Nguyen Link: https://lore.kernel.org/r/20240213184138.1483968-1-anthony.l.nguyen@intel.comSigned-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

4da71a77 - ice: read internal temperature sensor

Fri, 01 Dec 2023 18:08:39 +0000

ice: read internal temperature sensorSince 4.30 firmware exposes internal thermal sensor reading via adminqueue commands. Expose those readouts via hwmon API when supported.Datasheet:Get Sensor Reading Command (Opcode: 0x0632)+--------------------+--------+--------------------+-------------------------+| Name | Bytes | Value | Remarks |+--------------------+--------+--------------------+-------------------------+| Flags | 1-0 | | || Opcode | 2-3 | 0x0632 | Command opcode || Datalen | 4-5 | 0 | No external buffer. || Return value | 6-7 | | Return value. || Cookie High | 8-11 | Cookie | || Cookie Low | 12-15 | Cookie | || Sensor | 16 | | 0x00: Internal temp || | | | 0x01-0xFF: Reserved. || Format | 17 | Requested response | Only 0x00 is supported. || | | format | 0x01-0xFF: Reserved. || Reserved | 18-23 | | || Data Address high | 24-27 | Response buffer | || | | address | || Data Address low | 28-31 | Response buffer | || | | address | |+--------------------+--------+--------------------+-------------------------+Get Sensor Reading Response (Opcode: 0x0632)+--------------------+--------+--------------------+-------------------------+| Name | Bytes | Value | Remarks |+--------------------+--------+--------------------+-------------------------+| Flags | 1-0 | | || Opcode | 2-3 | 0x0632 | Command opcode || Datalen | 4-5 | 0 | No external buffer || Return value | 6-7 | | Return value. || | | | EINVAL: Invalid || | | | parameters || | | | ENOENT: Unsupported || | | | sensor || | | | EIO: Sensor access || | | | error || Cookie High | 8-11 | Cookie | || Cookie Low | 12-15 | Cookie | || Sensor Reading | 16-23 | | Format of the reading || | | | is dependent on request || Data Address high | 24-27 | Response buffer | || | | address | || Data Address low | 28-31 | Response buffer | || | | address | |+--------------------+--------+--------------------+-------------------------+Sensor Reading for Sensor 0x00 (Internal Chip Temperature):+--------------------+--------+--------------------+-------------------------+| Name | Bytes | Value | Remarks |+--------------------+--------+--------------------+-------------------------+| Thermal Sensor | 0 | | Reading in degrees || reading | | | Celsius. Signed int8 || Warning High | 1 | | Warning High threshold || threshold | | | in degrees Celsius. || | | | Unsigned int8. || | | | 0xFF when unsupported || Critical High | 2 | | Critical High threshold || threshold | | | in degrees Celsius. || | | | Unsigned int8. || | | | 0xFF when unsupported || Fatal High | 3 | | Fatal High threshold || threshold | | | in degrees Celsius. || | | | Unsigned int8. || | | | 0xFF when unsupported || Reserved | 4-7 | | |+--------------------+--------+--------------------+-------------------------+Driver provides current reading from HW as well as device specificthresholds for thermal alarm (Warning, Critical, Fatal) events.$ sensorsOutput=========================================================ice-pci-b100Adapter: PCI adaptertemp1: +62.0°C (high = +95.0°C, crit = +105.0°C) (emerg = +115.0°C)Tested on Intel Corporation Ethernet Controller E810-C for SFPCo-developed-by: Marcin Domagala Signed-off-by: Marcin Domagala Co-developed-by: Eric Joyner Signed-off-by: Eric Joyner Reviewed-by: Marcin Szycik Reviewed-by: Przemek Kitszel Signed-off-by: Konrad Knitter Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel)Signed-off-by: Tony Nguyen Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

9e479d64 - i40e: Add initial devlink support

Fri, 13 Oct 2023 17:07:51 +0000

i40e: Add initial devlink supportAdd an initial support for devlink interface to i40e driver.Similarly to ice driver the implementation doe not enable devlinkto manage device-wide configuration and devlink instance is createdfor each physical function of PCIe device.Signed-off-by: Ivan Vecera Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

d7999f5e - ice: implement dpll interface to control cgu

Wed, 13 Sep 2023 20:49:41 +0000

ice: implement dpll interface to control cguControl over clock generation unit is required for further developmentof Synchronous Ethernet feature. Interface provides ability to obtaincurrent state of a dpll, its sources and outputs which are pins, andallows their configuration.Co-developed-by: Milena Olech Signed-off-by: Milena Olech Co-developed-by: Michal Michalik Signed-off-by: Michal Michalik Signed-off-by: Arkadiusz Kubalewski Signed-off-by: Vadim Fedorenko Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

a251eee6 - idpf: add SRIOV support and other ndo_ops

Tue, 08 Aug 2023 00:34:16 +0000

idpf: add SRIOV support and other ndo_opsAdd support for SRIOV: send the requested number of VFsto the device Control Plane, via the virtchnl messageand then enable the VFs using 'pci_enable_sriov'.Add other ndo ops supported by the driver such as features_check,set_rx_mode, validate_addr, set_mac_address, change_mtu, get_stats64,set_features, and tx_timeout. Initialize the statistics task whichrequests the queue related statistics to the CP. Add loopbackand promiscuous mode support and the respective virtchnl messages.Finally, add documentation and build support for the driver.Signed-off-by: Joshua Hay Co-developed-by: Alan Brady Signed-off-by: Alan Brady Co-developed-by: Madhu Chittim Signed-off-by: Madhu Chittim Co-developed-by: Phani Burra Signed-off-by: Phani Burra Reviewed-by: Sridhar Samudrala Reviewed-by: Willem de Bruijn Co-developed-by: Pavan Kumar Linga Signed-off-by: Pavan Kumar Linga Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

e485f3a6 - ixgb: Remove ixgb driver

Fri, 17 Mar 2023 20:09:03 +0000

ixgb: Remove ixgb driverThere are likely no users of this driver as the hardware has beendiscontinued since 2010. Remove the driver and all references to itin documentation.Suggested-by: Jakub Kicinski Signed-off-by: Tony Nguyen Acked-by: Jesse Brandeburg Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

cf871006 - ice: remove unnecessary CONFIG_ICE_GNSS

Fri, 24 Feb 2023 21:32:41 +0000

ice: remove unnecessary CONFIG_ICE_GNSSCONFIG_ICE_GNSS was added by commit c7ef8221ca7d ("ice: use GNSS subsysteminstead of TTY") as a way to allow the ice driver to optionally supportGNSS features without forcing a dependency on CONFIG_GNSS.The original implementation of that commit at [1] used IS_REACHABLE. Thiswas rejected by Olek at [2] with the suggested implementation ofCONFIG_ICE_GNSS.Eventually after merging, Linus reported a .config which hadCONFIG_ICE_GNSS = y when both GNSS = n and ICE = n. This confused him andhe felt that the config option was not useful, and commented about it at[3].CONFIG_ICE_GNSS is defined to y whenever GNSS = ICE. This results in itbeing set in cases where both options are not enabled.The goal of CONFIG_ICE_GNSS is to ensure that the GNSS support in the icedriver is enabled when GNSS is enabled.The complaint from Olek about the original IS_REACHABLE was due to therequired IS_REACHABLE checks throughout the ice driver code and the factthat ice_gnss.c was compiled regardless of GNSS support.This can be fixed in the Makefile by using ice-$(CONFIG_GNSS) += ice_gnss.oIn this case, if GNSS = m and ICE = y, we can result in some confusingbehavior where GNSS support is not enabled because its not built in. See[4].To disallow this, have CONFIG_ICE depend on GNSS || GNSS = n. This ensuresthat we cannot enable CONFIG_ICE as builtin while GNSS is a module.Drop CONFIG_ICE_GNSS, and replace the IS_ENABLED checks for it withchecks for GNSS. Update the Makefile to add the ice_gnss.o object based onCONFIG_GNSS.This works to ensure that GNSS support can optionally be enabled, doesn'thave an unnnecessary extra config option, and has Kbuild enforce thedependency such that you can't accidentally enable GNSS as a module and ICEas a builtin.[1] https://lore.kernel.org/intel-wired-lan/20221019095603.44825-1-arkadiusz.kubalewski@intel.com/[2] https://lore.kernel.org/intel-wired-lan/20221028165706.96849-1-alexandr.lobakin@intel.com/[3] https://lore.kernel.org/all/CAHk-=wi_410KZqHwF-WL5U7QYxnpHHHNP-3xL=g_y89XnKc-uw@mail.gmail.com/[4] https://lore.kernel.org/netdev/20230223161309.0e439c5f@kernel.org/Reported-by: Linus Torvalds Signed-off-by: Jacob Keller Fixes: c7ef8221ca7d ("ice: use GNSS subsystem instead of TTY")Cc: Arkadiusz Kubalewski Cc: Alexander Lobakin Cc: Jakub Kicinski Cc: Anthony Nguyen Acked-by: Jakub Kicinski Signed-off-by: Tony Nguyen Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

c7ef8221 - ice: use GNSS subsystem instead of TTY

Thu, 19 Jan 2023 00:58:36 +0000

ice: use GNSS subsystem instead of TTYPreviously support for GNSS was implemented as a TTY driver, it allowedto access GNSS receiver on /dev/ttyGNSS_.Use generic GNSS subsystem API instead of implementing own TTY driver.The receiver is accessible on /dev/gnss. In case of multiple receiversin the OS, correct device can be found by enumerating either:- /sys/class/net//device/gnss/- /sys/class/gnss/gnss/device/Using GNSS subsystem is superior to implementing own TTY driver, as theGNSS subsystem was designed solely for this purpose. It also implementsTTY driver but in a common and defined way.From user perspective, there is no difference in communicating with adevice, except new path to the device shall be used. The device willprovide same information to the userspace as the old one, and can be usedin the same way, i.e.:old # gpsmon /dev/ttyGNSS_2100_0new # gpsmon /dev/gnss0There is no other impact on userspace tools.User expecting onboard GNSS receiver support is required to enableCONFIG_GNSS=y/m in kernel config.Reviewed-by: Alexander Lobakin Signed-off-by: Karol Kolacinski Signed-off-by: Michal Michalik Signed-off-by: Arkadiusz Kubalewski Tested-by: Gurucharan G (A Contingent worker at Intel)Signed-off-by: Tony Nguyen Acked-by: Greg Kroah-Hartman Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

13a64f0b - ice: support crosstimestamping on E822 devices if supported

Wed, 13 Oct 2021 16:00:08 +0000

ice: support crosstimestamping on E822 devices if supportedE822 devices on supported platforms can generate a cross timestampbetween the platform ART and the device time. This process allows forvery precise measurement of the difference between the PTP hardwareclock and the platform time.This is only supported if we know the TSC frequency relative to ART, sowe do not enable this unless the boot CPU has a known TSC frequency (asrequired by convert_art_ns_to_tsc).Because PCIe PTM support is not available on all platforms, introduceCONFIG_ICE_HWTS and make it depend on X86 where we know the supportexists.Signed-off-by: Jacob Keller Tested-by: Gurucharan G Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

3ea9bd5d - ice: support basic E-Switch mode control

Fri, 20 Aug 2021 00:08:48 +0000

ice: support basic E-Switch mode controlWrite set and get eswitch mode functions used by devlinkops. Use new pf struct member eswitch_mode to track currenteswitch mode in driver.Changing eswitch mode is only allowed when there are noVFs created.Create new file for eswitch related code.Add config flag ICE_SWITCHDEV to allow user to choose ifswitchdev support should be enabled or disabled.Use case examples:- show current eswitch mode ('legacy' is the default one)[root@localhost]# devlink dev eswitch show pci/0000:03:00.1pci/0000:03:00.1: mode legacy- move to 'switchdev' mode[root@localhost]# devlink dev eswitch set pci/0000:03:00.1 modeswitchdev[root@localhost]# devlink dev eswitch show pci/0000:03:00.1pci/0000:03:00.1: mode switchdev- create 2 VFs[root@localhost]# echo 2 > /sys/class/net/ens4f1/device/sriov_numvfs- unsuccessful attempt to change eswitch mode while VFs are created[root@localhost]# devlink dev eswitch set pci/0000:03:00.1 mode legacydevlink answers: Operation not supported- destroy VFs[root@localhost]# echo 0 > /sys/class/net/ens4f1/device/sriov_numvfs- restore 'legacy' mode[root@localhost]# devlink dev eswitch set pci/0000:03:00.1 mode legacy[root@localhost]# devlink dev eswitch show pci/0000:03:00.1pci/0000:03:00.1: mode legacyCo-developed-by: Grzegorz Nitka Signed-off-by: Grzegorz Nitka Signed-off-by: Michal Swiatkowski Tested-by: Sandeep Penigalapati Signed-off-by: Tony Nguyen List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

87758511 - igc: fix build errors for PTP

Fri, 17 Sep 2021 21:05:47 +0000

igc: fix build errors for PTPWhen IGC=y and PTP_1588_CLOCK=m, the ptp_*() interface family isnot available to the igc driver. Make this driver depend onPTP_1588_CLOCK_OPTIONAL so that it will build without errors.Various igc commits have used ptp_*() functions without checkingthat PTP_1588_CLOCK is enabled. Fix all of these here.Fixes these build errors:ld: drivers/net/ethernet/intel/igc/igc_main.o: in function `igc_msix_other':igc_main.c:(.text+0x6494): undefined reference to `ptp_clock_event'ld: igc_main.c:(.text+0x64ef): undefined reference to `ptp_clock_event'ld: igc_main.c:(.text+0x6559): undefined reference to `ptp_clock_event'ld: drivers/net/ethernet/intel/igc/igc_ethtool.o: in function `igc_ethtool_get_ts_info':igc_ethtool.c:(.text+0xc7a): undefined reference to `ptp_clock_index'ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_feature_enable_i225':igc_ptp.c:(.text+0x330): undefined reference to `ptp_find_pin'ld: igc_ptp.c:(.text+0x36f): undefined reference to `ptp_find_pin'ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_init':igc_ptp.c:(.text+0x11cd): undefined reference to `ptp_clock_register'ld: drivers/net/ethernet/intel/igc/igc_ptp.o: in function `igc_ptp_stop':igc_ptp.c:(.text+0x12dd): undefined reference to `ptp_clock_unregister'ld: drivers/platform/x86/dell/dell-wmi-privacy.o: in function `dell_privacy_wmi_probe':Fixes: 64433e5bf40ab ("igc: Enable internal i225 PPS")Fixes: 60dbede0c4f3d ("igc: Add support for ethtool GET_TS_INFO command")Fixes: 87938851b6efb ("igc: enable auxiliary PHC functions for the i225")Fixes: 5f2958052c582 ("igc: Add basic skeleton for PTP")Signed-off-by: Randy Dunlap Cc: Ederson de Souza Cc: Tony Nguyen Cc: Vinicius Costa Gomes Cc: Jeff Kirsher Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Jesse Brandeburg Cc: intel-wired-lan@lists.osuosl.orgAcked-by: Vinicius Costa Gomes Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig

e5f31552 - ethernet: fix PTP_1588_CLOCK dependencies

Thu, 12 Aug 2021 18:33:58 +0000

ethernet: fix PTP_1588_CLOCK dependenciesThe 'imply' keyword does not do what most people think it does, it onlypolitely asks Kconfig to turn on another symbol, but does not preventit from being disabled manually or built as a loadable module when theuser is built-in. In the ICE driver, the latter now causes a link failure:aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':This is a recurring problem in many drivers, and we have discussedit several times befores, without reaching a consensus. I'm providinga link to the previous email thread for reference, which discussessome related problems.To solve the dependency issue better than the 'imply' keyword, introduce aseparate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any drivercan depend on if it is able to use PTP support when available, but worksfine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers arethen prevented from being built-in, the same way as with a 'depends onPTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,but that can be rather confusing when you first see it.Since this should cover the dependencies correctly, the IS_REACHABLE()hack in the header is no longer needed now, and can be turned backinto a normal IS_ENABLED() check. Any driver that gets the dependencywrong will now cause a link time failure rather than being unable to usePTP support when that is in a loadable module.However, the two recently added ptp_get_vclocks_index() andptp_convert_timestamp() interfaces are only called from builtin code withethtool and socket timestamps, so keep the current behavior by stubbingthose out completely when PTP is in a loadable module. This should beaddressed properly in a follow-up.As Richard suggested, we may want to actually turn PTP support into a'bool' option later on, preventing it from being a loadable modulealtogether, which would be one way to solve the problem with the ethtoolinterface.Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810 devices")Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/Acked-by: Shannon Nelson Acked-by: Jacob Keller Acked-by: Richard Cochran Reviewed-by: Vladimir Oltean Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/intel/Kconfig