Changes in Kconfig

e5f31552 - ethernet: fix PTP_1588_CLOCK dependencies

Thu, 12 Aug 2021 18:33:58 +0000

ethernet: fix PTP_1588_CLOCK dependenciesThe 'imply' keyword does not do what most people think it does, it onlypolitely asks Kconfig to turn on another symbol, but does not preventit from being disabled manually or built as a loadable module when theuser is built-in. In the ICE driver, the latter now causes a link failure:aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':This is a recurring problem in many drivers, and we have discussedit several times befores, without reaching a consensus. I'm providinga link to the previous email thread for reference, which discussessome related problems.To solve the dependency issue better than the 'imply' keyword, introduce aseparate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any drivercan depend on if it is able to use PTP support when available, but worksfine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers arethen prevented from being built-in, the same way as with a 'depends onPTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,but that can be rather confusing when you first see it.Since this should cover the dependencies correctly, the IS_REACHABLE()hack in the header is no longer needed now, and can be turned backinto a normal IS_ENABLED() check. Any driver that gets the dependencywrong will now cause a link time failure rather than being unable to usePTP support when that is in a loadable module.However, the two recently added ptp_get_vclocks_index() andptp_convert_timestamp() interfaces are only called from builtin code withethtool and socket timestamps, so keep the current behavior by stubbingthose out completely when PTP is in a loadable module. This should beaddressed properly in a follow-up.As Richard suggested, we may want to actually turn PTP support into a'bool' option later on, preventing it from being a loadable modulealtogether, which would be one way to solve the problem with the ethtoolinterface.Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810 devices")Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/Acked-by: Shannon Nelson Acked-by: Jacob Keller Acked-by: Richard Cochran Reviewed-by: Vladimir Oltean Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

659fbdcf - cxgb4: Fix build failure when CONFIG_TLS=m

Fri, 20 Nov 2020 19:25:28 +0000

cxgb4: Fix build failure when CONFIG_TLS=mAfter commit 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough")whenever CONFIG_TLS=m and CONFIG_CHELSIO_T4=y, the following buildfailure occurs:ld: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o: in function`cxgb_select_queue':cxgb4_main.c:(.text+0x2dac): undefined reference to `tls_validate_xmit_skb'Fix this by ensuring that if TLS is set to be a module, CHELSIO_T4 willalso be compiled as a module. As otherwise the cxgb4 driver will not beable to access TLS' symbols.Fixes: 9d2e5e9eeb59 ("cxgb4/ch_ktls: decrypted bit is not enough")Signed-off-by: Tom Seewald Link: https://lore.kernel.org/r/20201120192528.615-1-tseewald@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

44fd1c1f - chelsio/chtls: separate chelsio tls driver from crypto driver

Wed, 19 Aug 2020 14:01:20 +0000

chelsio/chtls: separate chelsio tls driver from crypto driverchelsio inline tls driver(chtls) is mostly overlaps with NIC driversbut currenty it is part of crypto driver, so move it out to appropriatedirectory for better maintenance.Signed-off-by: Vinay Kumar Yadav Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

132db935 - docs: networking: reorganize driver documentation again

Fri, 26 Jun 2020 17:27:24 +0000

docs: networking: reorganize driver documentation againOrganize driver documentation by device type. Most documentshave fairly verbose yet uninformative names, so let usersfirst select a well defined device type, and then search fora particular driver.While at it rename the section from Vendor drivers toHardware drivers. This seems more accurate, besides peoplesometimes refer to out-of-tree drivers as vendor drivers.Signed-off-by: Jakub Kicinski Acked-by: Jeff Kirsher Acked-by: Shannon Nelson Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

c839ce55 - docs: networking: device drivers: convert chelsio/cxgb.txt to ReST

Fri, 01 May 2020 14:44:38 +0000

docs: networking: device drivers: convert chelsio/cxgb.txt to ReST- add SPDX header;- use copyright symbol;- adjust titles and chapters, adding proper markups;- comment out text-only TOC from html/pdf output;- mark code blocks and literals as such;- add notes markups;- mark tables as such;- mark lists as such;- adjust identation, whitespaces and blank lines where needed;- add to networking/index.rst.Signed-off-by: Mauro Carvalho Chehab Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

b255e500 - net: documentation: build a directory structure for drivers

Tue, 04 Dec 2018 01:43:28 +0000

net: documentation: build a directory structure for driversDocumentation/networking/ is full of cryptically named files withdriver documentation. This makes finding interesting informationat a glance really hard. Move all those files into a directorycalled device_drivers (since not all drivers are for device) andfix up references.RFC v0.1 -> RFC v1: - also add .txt suffix to the files which are missing it (Quentin)Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet Acked-by: David Ahern Acked-by: Henrik Austad Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

ebcd210e - cxgb4: fix thermal zone build error

Thu, 15 Nov 2018 10:06:21 +0000

cxgb4: fix thermal zone build errorwith CONFIG_THERMAL=m and cxgb4 as built-in build fails, and'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")'tries to fix it but when cxgb4i is made built-in build fails again,use IS_REACHABLE instead of IS_ENABLED to fix the issue.Fixes: e70a57fa59bb (cxgb4: fix thermal configuration dependencies)Reported-by: Randy Dunlap Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

e70a57fa - cxgb4: fix thermal configuration dependencies

Thu, 11 Oct 2018 08:57:57 +0000

cxgb4: fix thermal configuration dependenciesWith CONFIG_THERMAL=m, we get a build error:drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.c: In function 'cxgb4_thermal_get_trip_type':drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.c:48:11: error: 'struct adapter' has no member named 'ch_thermal'Once that is fixed by using IS_ENABLED() checks, we get a link erroragainst the thermal subsystem when cxgb4 is built-in:drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.o: In function `cxgb4_thermal_init':cxgb4_thermal.c:(.text+0x180): undefined reference to `thermal_zone_device_register'drivers/net/ethernet/chelsio/cxgb4/cxgb4_thermal.o: In function `cxgb4_thermal_remove':cxgb4_thermal.c:(.text+0x1e0): undefined reference to `thermal_zone_device_unregister'Finally, since CONFIG_THERMAL can be =m, the Makefile fails to pick up theextra file into built-in.a, and we get another link failure against thecxgb4_thermal_init/cxgb4_thermal_remove files, so the Makefile has tobe adapted as well to work for both CONFIG_THERMAL=y and =m.Fixes: b18719157762 ("cxgb4: Add thermal zone support")Signed-off-by: Arnd Bergmann Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

a1cf9c9f - cxgb4: enable ZLIB_DEFLATE when building cxgb4

Wed, 24 Jan 2018 08:01:04 +0000

cxgb4: enable ZLIB_DEFLATE when building cxgb4Fixes:drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:39:5: error:redefinition of 'cudbg_compress_buff' int cudbg_compress_buff(struct cudbg_init *pdbg_init, ^~~~~~~~~~~~~~~~~~~ In file included fromdrivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.c:23:0: drivers/net/ethernet/chelsio/cxgb4/cudbg_zlib.h:45:19: note: previousdefinition of 'cudbg_compress_buff' was here static inline int cudbg_compress_buff(struct cudbg_init *pdbg_init, ^~~~~~~~~~~~~~~~~~~Fixes: 91c1953de387 ("cxgb4: use zlib deflate to compress firmware dump")Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

b8b9d81b - libcxgb: add library module for Chelsio drivers

Thu, 21 Jul 2016 17:27:14 +0000

libcxgb: add library module for Chelsio driversAdd common library module(libcxgb.ko) forChelsio drivers to remove duplicate code.Code for iSCSI DDP Page Pod Manager is movedfrom cxgb4.ko to libcxgb.ko. Earlier only cxgbit.kowas using this code, now cxgb3i and cxgb4i willalso use common Page Pod manager code.In future this module will have common connectionmanagement and hardware specific code that can beshared by multiple Chelsio drivers.Signed-off-by: Varun Prakash Reviewed-by: Steve Wise Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

2994a751 - cxgb4: update Kconfig and Makefile

Sun, 14 Feb 2016 17:39:52 +0000

cxgb4: update Kconfig and Makefileupdate Kconfig and Makefile for enabling iSCSIDDP page pod manager.Signed-off-by: Varun Prakash Acked-by: Hariprasad Shenai Signed-off-by: Nicholas Bellinger List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

b8759e91 - cxgb4/cxgb4vf: update Kconfig file to include T6 adapter

Tue, 08 Dec 2015 04:39:12 +0000

cxgb4/cxgb4vf: update Kconfig file to include T6 adapterSigned-off-by: Hariprasad Shenai Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

138b15ed - drivers/net: remove all references to obsolete Ethernet-HOWTO

Sun, 21 Jun 2015 20:28:02 +0000

drivers/net: remove all references to obsolete Ethernet-HOWTOThis howto made sense in the 1990s when users had to manually configureISA cards with jumpers or vendor utilities, but with the implementationof PCI it became increasingly less and less relevant, to the point whereit has been well over a decade since I last updated it. And there isno value in anyone else taking over updating it either.However the references to it continue to spread as boiler plate textfrom one Kconfig file into the next. We are not doing end users anyfavours by pointing them at this old document, so lets kill it withfire, once and for all, to hopefully stop any further spread.No code is changed in this commit, just Kconfig help text.Signed-off-by: Paul Gortmaker Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

241e9247 - cxgb4: update Kconfig and Makefile for FCoE support

Tue, 24 Mar 2015 13:44:47 +0000

cxgb4: update Kconfig and Makefile for FCoE supportSigned-off-by: Varun Prakash Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

1bb60376 - cxgb4 : Fix build failure in cxgb4 when ipv6 is disabled/not in-built

Wed, 15 Oct 2014 03:07:22 +0000

cxgb4 : Fix build failure in cxgb4 when ipv6 is disabled/not in-builtcxgb4 ipv6 does not guard against ipv6 being disabled, or the standardipv6 module vs inbuilt tri-state issue. This was fixed for cxgb4i & iw_cxgb4but missed for cxgb4.Signed-off-by: Anish Bhatt Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

19f43d1a - cxgb4 : Makefile & Kconfig changes for DCBx support

Fri, 20 Jun 2014 04:37:14 +0000

cxgb4 : Makefile & Kconfig changes for DCBx supportSigned-off-by: Anish Bhatt Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

535cdf3c - cxgb4: Update Kconfig to include Chelsio T5 adapter

Fri, 25 Apr 2014 12:30:12 +0000

cxgb4: Update Kconfig to include Chelsio T5 adapterSigned-off-by: Hariprasad Shenai Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig

9e3262e2 - cxgb3: Restore dependency on INET

Wed, 28 Nov 2012 20:03:03 +0000

cxgb3: Restore dependency on INETCommit ff33c0e1885cda44dd14c79f70df4706f83582a0 ('net: Remove bogusdependencies on INET') wrongly removed this dependency. cxgb3 usesthe arp_send() function defined in net/ipv4/arp.c.Reported-by: kbuild test robot Signed-off-by: Ben Hutchings Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/chelsio/Kconfig