Changes in Kconfig

e5f31552 - ethernet: fix PTP_1588_CLOCK dependencies

Thu, 12 Aug 2021 18:33:58 +0000

ethernet: fix PTP_1588_CLOCK dependenciesThe 'imply' keyword does not do what most people think it does, it onlypolitely asks Kconfig to turn on another symbol, but does not preventit from being disabled manually or built as a loadable module when theuser is built-in. In the ICE driver, the latter now causes a link failure:aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':This is a recurring problem in many drivers, and we have discussedit several times befores, without reaching a consensus. I'm providinga link to the previous email thread for reference, which discussessome related problems.To solve the dependency issue better than the 'imply' keyword, introduce aseparate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any drivercan depend on if it is able to use PTP support when available, but worksfine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers arethen prevented from being built-in, the same way as with a 'depends onPTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,but that can be rather confusing when you first see it.Since this should cover the dependencies correctly, the IS_REACHABLE()hack in the header is no longer needed now, and can be turned backinto a normal IS_ENABLED() check. Any driver that gets the dependencywrong will now cause a link time failure rather than being unable to usePTP support when that is in a loadable module.However, the two recently added ptp_get_vclocks_index() andptp_convert_timestamp() interfaces are only called from builtin code withethtool and socket timestamps, so keep the current behavior by stubbingthose out completely when PTP is in a loadable module. This should beaddressed properly in a follow-up.As Richard suggested, we may want to actually turn PTP support into a'bool' option later on, preventing it from being a loadable modulealtogether, which would be one way to solve the problem with the ethtoolinterface.Fixes: 06c16d89d2cb ("ice: register 1588 PTP clock device object for E810 devices")Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/Acked-by: Shannon Nelson Acked-by: Jacob Keller Acked-by: Richard Cochran Reviewed-by: Vladimir Oltean Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

0b32e91f - ethernet: select CONFIG_CRC32 as needed

Thu, 03 Dec 2020 23:20:37 +0000

ethernet: select CONFIG_CRC32 as neededA number of ethernet drivers require crc32 functionality to beavaialable in the kernel, causing a link error otherwise:arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast':et131x.c:(.text+0x5918): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/cadence/macb_main.o: in function `macb_start_xmit':macb_main.c:(.text+0x4b88): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/faraday/ftgmac100.o: in function `ftgmac100_set_rx_mode':ftgmac100.c:(.text+0x2b38): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fec_main.o: in function `set_multicast_list':fec_main.c:(.text+0x6120): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o: in function `dtsec_add_hash_mac_address':fman_dtsec.c:(.text+0x830): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/freescale/fman/fman_dtsec.o:fman_dtsec.c:(.text+0xb68): more undefined references to `crc32_le' followarm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_hwinfo.o: in function `nfp_hwinfo_read':nfp_hwinfo.c:(.text+0x250): undefined reference to `crc32_be'arm-linux-gnueabi-ld: nfp_hwinfo.c:(.text+0x288): undefined reference to `crc32_be'arm-linux-gnueabi-ld: drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.o: in function `nfp_resource_acquire':nfp_resource.c:(.text+0x144): undefined reference to `crc32_be'arm-linux-gnueabi-ld: nfp_resource.c:(.text+0x158): undefined reference to `crc32_be'arm-linux-gnueabi-ld: drivers/net/ethernet/nxp/lpc_eth.o: in function `lpc_eth_set_multicast_list':lpc_eth.c:(.text+0x1934): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_do':rocker_ofdpa.c:(.text+0x2e08): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_flow_tbl_del':rocker_ofdpa.c:(.text+0x3074): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/rocker/rocker_ofdpa.o: in function `ofdpa_port_fdb':arm-linux-gnueabi-ld: drivers/net/ethernet/mellanox/mlx5/core/steering/dr_ste.o: in function `mlx5dr_ste_calc_hash_index':dr_ste.c:(.text+0x354): undefined reference to `crc32_le'arm-linux-gnueabi-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_netdev_set_multicast':lan743x_main.c:(.text+0x5dc4): undefined reference to `crc32_le'Add the missing 'select CRC32' entries in Kconfig for each of them.Signed-off-by: Arnd Bergmann Acked-by: Nicolas Ferre Acked-by: Madalin Bucur Acked-by: Mark Einon Acked-by: Simon Horman Link: https://lore.kernel.org/r/20201203232114.1485603-1-arnd@kernel.orgSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

b6d49cab - net: Make PTP-specific drivers depend on PTP_1588_CLOCK

Wed, 29 Apr 2020 07:59:00 +0000

net: Make PTP-specific drivers depend on PTP_1588_CLOCKCommit d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") changedall PTP-capable Ethernet drivers from `select PTP_1588_CLOCK` to `implyPTP_1588_CLOCK`, "in order to break the hard dependency between the PTPclock subsystem and ethernet drivers capable of being clock providers."As a result it is possible to build PTP-capable Ethernet drivers withoutthe PTP subsystem by deselecting PTP_1588_CLOCK. Drivers are required tohandle the missing dependency gracefully.Some PTP-capable Ethernet drivers (e.g., TI_CPSW) factor their PTP codeout into separate drivers (e.g., TI_CPTS_MOD). The above commit alsochanged these PTP-specific drivers to `imply PTP_1588_CLOCK`, making itpossible to build them without the PTP subsystem. But as GrygoriiStrashko noted in [1]:On Wed, Apr 22, 2020 at 02:16:11PM +0300, Grygorii Strashko wrote:> Another question is that CPTS completely nonfunctional in this case and> it was never expected that somebody will even try to use/run such> configuration (except for random build purposes).In my view, enabling a PTP-specific driver without the PTP subsystem isa configuration error made possible by the above commit. Kconfig shouldnot allow users to create a configuration with missing dependencies thatresults in "completely nonfunctional" drivers.I audited all network drivers that call ptp_clock_register() but merely`imply PTP_1588_CLOCK` and found five PTP-specific drivers that arelikely nonfunctional without PTP_1588_CLOCK: NET_DSA_MV88E6XXX_PTP NET_DSA_SJA1105_PTP MACB_USE_HWSTAMP CAVIUM_PTP TI_CPTS_MODNote how these symbols all reference PTP or timestamping in their name;this is a clue that they depend on PTP_1588_CLOCK.Change them from `imply PTP_1588_CLOCK` [2] to `depends on PTP_1588_CLOCK`.I'm not using `select PTP_1588_CLOCK` here because PTP_1588_CLOCK hasits own dependencies, which `select` would not transitively apply.Additionally, remove the `select NET_PTP_CLASSIFY` from CPTS_TI_MOD;PTP_1588_CLOCK already selects that.[1]: https://lore.kernel.org/lkml/c04458ed-29ee-1797-3a11-7f3f560553e6@ti.com/[2]: NET_DSA_SJA1105_PTP had never declared any type of dependency onPTP_1588_CLOCK (`imply` or otherwise); adding a `depends on PTP_1588_CLOCK`here seems appropriate.Cc: Arnd Bergmann Cc: Richard Cochran Cc: Nicolas Pitre Cc: Grygorii Strashko Cc: Geert Uytterhoeven Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional")Signed-off-by: Clay McClure Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

7897b071 - net: macb: convert to phylink

Wed, 13 Nov 2019 09:00:06 +0000

net: macb: convert to phylinkThis patch converts the MACB Ethernet driver to the Phylink framework.The MAC configuration is moved to the Phylink ops and Phylink helpersare now used in the ethtools functions. This helps to access the flowcontrol and pauseparam logic and this will be helpful in the future forboards using this controller with SFP cages.Tested-by: Alexandre Belloni Signed-off-by: Antoine Tenart Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

302a7cad - net: macb: Kconfig: Rename Atmel to Cadence

Tue, 25 Jun 2019 08:48:28 +0000

net: macb: Kconfig: Rename Atmel to CadenceThe help text makes it look like NET_VENDOR_CADENCE enables support forAtmel devices, when in reality it's a driver written by Atmel thatsupports Cadence devices. This may confuse users that have this deviceon a non-Atmel SoC.The fix is just s/Atmel/Cadence/, but I did go and re-wrap the Kconfighelp text as that change caused it to go over 80 characters.Signed-off-by: Palmer Dabbelt Acked-by: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

c536a9aa - net: macb: Kconfig: Make MACB depend on COMMON_CLK

Tue, 25 Jun 2019 08:48:27 +0000

net: macb: Kconfig: Make MACB depend on COMMON_CLKcommit c218ad559020 ("macb: Add support for SiFive FU540-C000") added adependency on the common clock framework to the macb driver, but didn'texpress that dependency in Kconfig. As a result macb now fails tocompile on systems without COMMON_CLK, which specifically causes a buildfailure on powerpc allyesconfig.This patch adds the dependency, which results in the macb driver nolonger being selectable on systems without the common clock framework.All known systems that have this device already support the common clockframework, so this should not cause trouble for any uses. Supportingboth the FU540-C000 and systems without COMMON_CLK is quite ugly.I've build tested this on powerpc allyesconfig and RISC-V defconfig(which selects MACB), but I have not even booted the resulting kernels.Fixes: c218ad559020 ("macb: Add support for SiFive FU540-C000")Signed-off-by: Palmer Dabbelt Acked-by: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

0df5f81c - net: ethernet: Add missing VENDOR to Cadence and Packet Engines symbols

Wed, 04 Jul 2018 11:50:12 +0000

net: ethernet: Add missing VENDOR to Cadence and Packet Engines symbolsThe vendor guard Kconfig symbols for Cadence and Packet Engines use a"NET_" prefix, while all other vendor guards use a "NET_VENDOR_"prefix. Hence make them consistent with the rest, and add the missingtrailing "S" for Packet Engines while at it.As these options don't directly affect the kernel build, and default to"y", this change has no impact on kernels built with existing(def)configs.Signed-off-by: Geert Uytterhoeven Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

7b429614 - net: macb: Add support for PTP timestamps in DMA descriptors

Thu, 29 Jun 2017 06:12:51 +0000

net: macb: Add support for PTP timestamps in DMA descriptorsThis patch adds support for PTP timestamps inDMA buffer descriptors. It checks capability at runtimeand uses appropriate buffer descriptor.Signed-off-by: Rafal Ozieblo Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

83a77e9e - net: macb: Added PCI wrapper for Platform Driver.

Wed, 14 Dec 2016 06:39:15 +0000

net: macb: Added PCI wrapper for Platform Driver.There are hardware PCI implementations of Cadence GEM networkcontroller. This patch will allow to use such hardware with reuse ofexisting Platform Driver.Signed-off-by: Bartosz Folta Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

138b15ed - drivers/net: remove all references to obsolete Ethernet-HOWTO

Sun, 21 Jun 2015 20:28:02 +0000

drivers/net: remove all references to obsolete Ethernet-HOWTOThis howto made sense in the 1990s when users had to manually configureISA cards with jumpers or vendor utilities, but with the implementationof PCI it became increasingly less and less relevant, to the point whereit has been well over a decade since I last updated it. And there isno value in anyone else taking over updating it either.However the references to it continue to spread as boiler plate textfrom one Kconfig file into the next. We are not doing end users anyfavours by pointing them at this old document, so lets kill it withfire, once and for all, to hopefully stop any further spread.No code is changed in this commit, just Kconfig help text.Signed-off-by: Paul Gortmaker Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

421d9df0 - net/macb: merge at91_ether driver into macb driver

Sat, 07 Mar 2015 06:23:32 +0000

net/macb: merge at91_ether driver into macb drivermacb and at91_ether drivers can be compiled as modules, but the at91_etherdriver use some functions and variables defined in the macb one, thuscreating a dependency on the macb driver.Since these drivers are sharing the same logic we can easily mergeat91_ether into macb.In order to factorize common probing logic we've added an ->init() functionto struct macb_config (the structure associated with the compatiblestring), and moved macb specific init code from macb_probe to macb_init.Signed-off-by: Cyrille Pitchen Signed-off-by: Boris Brezillon Tested-by: Alexandre Belloni Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

28811a8c - net: cadence: Remove Kconfig dependency on ARCH

Tue, 03 Mar 2015 14:43:00 +0000

net: cadence: Remove Kconfig dependency on ARCHRemove Kconfig dependency and enable driver forall ARCHs.Signed-off-by: Michal Simek Acked-by: Sören Brinkmann Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

0f6538c2 - net: macb: Remove obsolete comment from Kconfig

Fri, 05 Dec 2014 13:03:53 +0000

net: macb: Remove obsolete comment from KconfigThe Kconfig file says that Gigabit mode is not supported, but it has beensupported since commit 140b7552fdff04bbceeb842f0e04f0b4015fe97b ("net/macb:Add support for Gigabit Ethernet mode").Signed-off-by: James Byrne Acked-by: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

ee72f18b - ARM: at91/Kconfig: remove ARCH_AT91RM9200 option for drivers

Fri, 21 Nov 2014 15:34:08 +0000

ARM: at91/Kconfig: remove ARCH_AT91RM9200 option for driversThe precise selection is useless, so we simply remove these dependencies.Signed-off-by: Nicolas Ferre Acked-by: Boris BREZILLON List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

8ea2b17c - net: cadence: Fix architecture dependencies

Wed, 23 Apr 2014 08:40:12 +0000

net: cadence: Fix architecture dependenciesI was told that the Cadence macb driver is also useful on Microblaze.Signed-off-by: Jean Delvare Cc: Nicolas Ferre Cc: David S. Miller Cc: Michal Simek Cc: Mark Brown Acked-by: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

ea05df4e - net: cadence: Add architecture dependencies

Mon, 14 Apr 2014 13:38:49 +0000

net: cadence: Add architecture dependenciesThe Cadence ethernet chipsets are only used on specific ARMarchitectures. Add Kconfig dependencies so that drivers for thesechipsets are only buildable on the relevant architectures.Signed-off-by: Jean Delvare Cc: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

0244ad00 - Remove GENERIC_HARDIRQ config option

Fri, 30 Aug 2013 07:39:53 +0000

Remove GENERIC_HARDIRQ config optionAfter the last architecture switched to generic hard irqs the configoptions HAVE_GENERIC_HARDIRQS & GENERIC_HARDIRQS and the related codefor !CONFIG_GENERIC_HARDIRQS can be removed.Signed-off-by: Martin Schwidefsky List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig

d6cf7a86 - at91_ether: Do not select NET_CORE

Tue, 18 Jun 2013 02:27:29 +0000

at91_ether: Do not select NET_COREThis has no dependency on any of the drivers under NET_CORE.Signed-off-by: Ben Hutchings Acked-by: Nicolas Ferre Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/cadence/Kconfig