Changes in debugfs.c

8b82f656 - pds_core: fix memory leak in pdsc_debugfs_add_qcq()

Wed, 09 Apr 2025 05:44:48 +0000

pds_core: fix memory leak in pdsc_debugfs_add_qcq()The memory allocated for intr_ctrl_regset, which is passed todebugfs_create_regset32() may not be cleaned up when the driver isremoved. Fix that by using device managed allocation for it.Fixes: 45d76f492938 ("pds_core: set up device and adminq")Signed-off-by: Abdun Nihaal Reviewed-by: Michal Swiatkowski Reviewed-by: Shannon Nelson Link: https://patch.msgid.link/20250409054450.48606-1-abdun.nihaal@gmail.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

8ed6e712 - pds_core: Remove redundant null pointer checks

Tue, 03 Sep 2024 14:33:43 +0000

pds_core: Remove redundant null pointer checksSince the debugfs_create_dir() never returns a null pointer, checkingthe return value for a null pointer is redundant, and using IS_ERR issafe enough.Signed-off-by: Li Zetao Link: https://patch.msgid.link/20240903143343.2004652-1-lizetao1@huawei.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

247c4ed0 - pds_core: Fix up some minor issues

Fri, 02 Feb 2024 19:59:10 +0000

pds_core: Fix up some minor issuesRunning xmastree.py against the driver found someRCT issues, so fix them.Also, if allocating pdsc->intr_info in pdsc_dev_init()fails the driver still tries to free pdsc->intr_info.Fix this by just returning -ENOMEM since there'snothing to free at this point of failure.Signed-off-by: Brett Creeley Reviewed-by: Shannon Nelson Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

02daffa9 - pds_core: Don't assign interrupt index/bound_intr to notifyq

Fri, 02 Feb 2024 19:59:08 +0000

pds_core: Don't assign interrupt index/bound_intr to notifyqThe notifyq rides on the adminq's interrupt, so there'sno need to setup and/or access the notifyq's interruptindex or bound_intr. The driver sets the bound_intrusing qcq->intx = -1 for the notifyq, but luckilynothing accesses that field for notifyq. Instead ofexpecting that remains the case, just clean upthe notifyq's interrupt index and bound_intr fields.Signed-off-by: Brett Creeley Reviewed-by: Shannon Nelson Reviewed-by: Przemek Kitszel Signed-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

bc90fbe0 - pds_core: Rework teardown/setup flow to be more common

Mon, 29 Jan 2024 23:40:35 +0000

pds_core: Rework teardown/setup flow to be more commonCurrently the teardown/setup flow for driver probe/remove is quitea bit different from the reset flows in pdsc_fw_down()/pdsc_fw_up().One key piece that's missing are the calls to pci_alloc_irq_vectors()and pci_free_irq_vectors(). The pcie reset case is callingpci_free_irq_vectors() on reset_prepare, but not calling thecorresponding pci_alloc_irq_vectors() on reset_done. This is causingunexpected/unwanted interrupt behavior due to the adminq interruptbeing accidentally put into legacy interrupt mode. Also, thepci_alloc_irq_vectors()/pci_free_irq_vectors() functions are beingcalled directly in probe/remove respectively.Fix this inconsistency by making the following changes: 1. Always call pdsc_dev_init() in pdsc_setup(), which calls pci_alloc_irq_vectors() and get rid of the now unused pds_dev_reinit(). 2. Always free/clear the pdsc->intr_info in pdsc_teardown() since this structure will get re-alloced in pdsc_setup(). 3. Move the calls of pci_free_irq_vectors() to pdsc_teardown() since pci_alloc_irq_vectors() will always be called in pdsc_setup()->pdsc_dev_init() for both the probe/remove and reset flows. 4. Make sure to only create the debugfs "identity" entry when it doesn't already exist, which it will in the reset case because it's already been created in the initial call to pdsc_dev_init().Fixes: ffa55858330f ("pds_core: implement pci reset handlers")Signed-off-by: Brett Creeley Reviewed-by: Shannon Nelson Link: https://lore.kernel.org/r/20240129234035.69802-7-brett.creeley@amd.comSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

65e0185a - pds_core: set up the VIF definitions and defaults

Wed, 19 Apr 2023 17:04:21 +0000

pds_core: set up the VIF definitions and defaultsThe Virtual Interfaces (VIFs) supported by the DSC'sconfiguration (vDPA, Eth, RDMA, etc) are reported in thedev_ident struct and made visible in debugfs. At this pointonly vDPA is supported in this driver so we only setupdevices for that feature.Signed-off-by: Shannon Nelson Acked-by: Jakub Kicinski Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

45d76f49 - pds_core: set up device and adminq

Wed, 19 Apr 2023 17:04:18 +0000

pds_core: set up device and adminqSet up the basic adminq and notifyq queue structures. These areused mostly by the client drivers for feature configuration.These are essentially the same adminq and notifyq as in theionic driver.Part of this includes querying for device identity and FWinformation, so we can make that available to devlink dev info. $ devlink dev info pci/0000:b5:00.0 pci/0000:b5:00.0: driver pds_core serial_number FLM18420073 versions: fixed: asic.id 0x0 asic.rev 0x0 running: fw 1.51.0-73 stored: fw.goldfw 1.15.9-C-22 fw.mainfwa 1.60.0-73 fw.mainfwb 1.60.0-57Signed-off-by: Shannon Nelson Acked-by: Jakub Kicinski Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

523847df - pds_core: add devcmd device interfaces

Wed, 19 Apr 2023 17:04:15 +0000

pds_core: add devcmd device interfacesThe devcmd interface is the basic connection to the device through thePCI BAR for low level identification and command services. This doesthe early device initialization and finds the identity data, and addsdevcmd routines to be used by later driver bits.Signed-off-by: Shannon Nelson Acked-by: Jakub Kicinski Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c

55435ea7 - pds_core: initial framework for pds_core PF driver

Wed, 19 Apr 2023 17:04:14 +0000

pds_core: initial framework for pds_core PF driverThis is the initial PCI driver framework for the new pds_core devicedriver and its family of devices. This does the very basics ofregistering for the new PF PCI device 1dd8:100c, setting up debugfsentries, and registering with devlink.Signed-off-by: Shannon Nelson Acked-by: Jakub Kicinski Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/ethernet/amd/pds_core/debugfs.c