Changes in Kconfig

c34424eb - net: dsa: rtl8366rb: don't prompt users for LED control

Fri, 28 Feb 2025 00:45:34 +0000

net: dsa: rtl8366rb: don't prompt users for LED controlMake NET_DSA_REALTEK_RTL8366RB_LEDS a hidden symbol.It seems very unlikely user would want to intentionallydisable it.Signed-off-by: Jakub Kicinski Link: https://patch.msgid.link/20250228004534.3428681-1-kuba@kernel.orgSigned-off-by: Paolo Abeni List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

f15176b8 - net: dsa: rtl8366rb: Fix compilation problem

Thu, 20 Feb 2025 18:48:15 +0000

net: dsa: rtl8366rb: Fix compilation problemWhen the kernel is compiled without LED framework support thertl8366rb fails to build like this:rtl8366rb.o: in function `rtl8366rb_setup_led':rtl8366rb.c:953:(.text.unlikely.rtl8366rb_setup_led+0xe8): undefined reference to `led_init_default_state_get'rtl8366rb.c:980:(.text.unlikely.rtl8366rb_setup_led+0x240): undefined reference to `devm_led_classdev_register_ext'As this is constantly coming up in different randconfig builds,bite the bullet and create a separate file for the offendingcode, split out a header with all stuff needed both in thecore driver and the leds code.Add a new bool Kconfig option for the LED compile target, suchthat it depends on LEDS_CLASS=y || LEDS_CLASS=RTL8366RBwhich make LED support always available when LEDS_CLASS iscompiled into the kernel and enforce that if the LEDS_CLASSis a module, then the RTL8366RB driver needs to be a moduleas well so that modprobe can resolve the dependencies.Fixes: 32d617005475 ("net: dsa: realtek: add LED drivers for rtl8366rb")Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502070525.xMUImayb-lkp@intel.com/Signed-off-by: Linus Walleij Reviewed-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

98b75c1c - net: dsa: realtek: merge rtl83xx and interface modules into realtek_dsa

Fri, 09 Feb 2024 05:03:42 +0000

net: dsa: realtek: merge rtl83xx and interface modules into realtek_dsaSince rtl83xx and realtek-{smi,mdio} are always loaded together,we can optimize resource usage by consolidating them into a singlemodule.Signed-off-by: Luiz Angelo Daros de Luca Reviewed-by: Vladimir Oltean Reviewed-by: Florian Fainelli Reviewed-by: Linus Walleij Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

bce254b8 - net: dsa: realtek: convert variants into real drivers

Fri, 09 Feb 2024 05:03:39 +0000

net: dsa: realtek: convert variants into real driversPreviously, the interface modules realtek-smi and realtek-mdio served asa platform and an MDIO driver, respectively. Each interface moduleredundantly specified the same compatible strings for both variants andreferenced symbols from the variants.Now, each variant module has been transformed into a unified driverserving both as a platform and an MDIO driver. This modificationreverses the relationship between the interface and variant modules,with the variant module now utilizing symbols from the interfacemodules.Signed-off-by: Luiz Angelo Daros de Luca Reviewed-by: Vladimir Oltean Reviewed-by: Linus Walleij Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

2511e0c8 - net: dsa: realtek: fix Kconfig to assure consistent driver linkage

Tue, 12 Apr 2022 15:55:27 +0000

net: dsa: realtek: fix Kconfig to assure consistent driver linkageThe kernel test robot reported a build failure:or1k-linux-ld: drivers/net/dsa/realtek/realtek-smi.o:(.rodata+0x16c): undefined reference to `rtl8366rb_variant'... with the following build configuration:CONFIG_NET_DSA_REALTEK=yCONFIG_NET_DSA_REALTEK_SMI=yCONFIG_NET_DSA_REALTEK_RTL8365MB=yCONFIG_NET_DSA_REALTEK_RTL8366RB=mThe problem here is that the realtek-smi interface driver gets built-in,while the rtl8366rb switch subdriver gets built as a module, hence thesymbol rtl8366rb_variant is not reachable when defining the OF devicetable in the interface driver.The Kconfig dependencies don't help in this scenario because they justsay that the subdriver(s) depend on at least one interface driver. Infact, the subdrivers don't depend on the interface drivers at all, andcan even be built even in their absence. Somewhat strangely, theinterface drivers can also be built in the absence of any subdriver,BUT, if a subdriver IS enabled, then it must be reachable according tothe linkage of the interface driver: effectively what the IS_REACHABLE()macro achieves. If it is not reachable, the above kind of linker errorwill be observed.Rather than papering over the above build error by simply usingIS_REACHABLE(), we can do a little better and admit that it is actuallythe interface drivers that have a dependency on the subdrivers. So thispatch does exactly that. Specifically, we ensure that:1. The interface drivers' Kconfig symbols must have a value no greater than the value of any subdriver Kconfig symbols.2. The subdrivers should by default enable both interface drivers, since most users probably want at least one of them; those interface drivers can be explicitly disabled however.What this doesn't do is prevent a user from building only a subdriver,without any interface driver. To that end, add an additional line ofhelp in the menu to guide users in the right direction.Link: https://lore.kernel.org/all/202204110757.XIafvVnj-lkp@intel.com/Reported-by: kernel test robot Fixes: aac94001067d ("net: dsa: realtek: add new mdio interface for drivers")Signed-off-by: Alvin Šipraga Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

109d8994 - net: dsa: realtek: make interface drivers depend on OF

Wed, 23 Mar 2022 12:42:25 +0000

net: dsa: realtek: make interface drivers depend on OFThe kernel test robot reported build warnings with a randconfig thatbuilt realtek-{smi,mdio} without CONFIG_OF set. Since both interfacedrivers are using OF and will not probe without, add the correspondingdependency to Kconfig.Link: https://lore.kernel.org/all/202203231233.Xx73Y40o-lkp@intel.com/Link: https://lore.kernel.org/all/202203231439.ycl0jg50-lkp@intel.com/Fixes: aac94001067d ("net: dsa: realtek: add new mdio interface for drivers")Fixes: 765c39a4fafe ("net: dsa: realtek: convert subdrivers into modules")Signed-off-by: Alvin Šipraga Reviewed-by: Andrew Lunn Acked-by: Luiz Angelo Daros de Luca Link: https://lore.kernel.org/r/20220323124225.91763-1-alvin@pqrs.dkSigned-off-by: Jakub Kicinski List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

3115ff3c - net: dsa: realtek: don't default Kconfigs to y

Fri, 04 Feb 2022 15:59:27 +0000

net: dsa: realtek: don't default Kconfigs to yWe generally default the vendor to y and the drivers itselfto n. NET_DSA_REALTEK, however, selects a whole bunch of things,so it's not a pure "vendor selection" knob. Let's default it allto n.Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli Acked-by: Arınç ÜNAL Reviewed-by: Linus Walleij Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

d40f607c - net: dsa: realtek: rtl8365mb: add RTL8367S support

Fri, 28 Jan 2022 06:05:06 +0000

net: dsa: realtek: rtl8365mb: add RTL8367S supportRealtek's RTL8367S, a 5+2 port 10/100/1000M Ethernet switch.It shares the same driver family (RTL8367C) with other modelsas the RTL8365MB-VC. Its compatible string is "realtek,rtl8367s".It was tested only with MDIO interface (realtek-mdio), although it mightwork out-of-the-box with SMI interface (using realtek-smi).This patch was based on an unpublished patch from Alvin Šipraga.Signed-off-by: Luiz Angelo Daros de Luca Tested-by: Arınç ÜNAL Reviewed-by: Alvin Šipraga Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

aac94001 - net: dsa: realtek: add new mdio interface for drivers

Fri, 28 Jan 2022 06:05:02 +0000

net: dsa: realtek: add new mdio interface for driversThis driver is a mdio_driver instead of a platform driver (likerealtek-smi).ds_ops was duplicated for smi and mdio usage as mdio interfaces usesphy_{read,write} in ds_ops and the presence of phy_read is incompatiblewith external slave_mii_bus allocation.Signed-off-by: Luiz Angelo Daros de Luca Tested-by: Arınç ÜNAL Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

765c39a4 - net: dsa: realtek: convert subdrivers into modules

Fri, 28 Jan 2022 06:05:01 +0000

net: dsa: realtek: convert subdrivers into modulesPreparing for multiple interfaces support, the driversmust be independent of realtek-smi.Signed-off-by: Luiz Angelo Daros de Luca Tested-by: Arınç ÜNAL Reviewed-by: Linus Walleij Reviewed-by: Alvin Šipraga Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig

319a70a5 - net: dsa: realtek-smi: move to subdirectory

Fri, 28 Jan 2022 06:04:58 +0000

net: dsa: realtek-smi: move to subdirectorySigned-off-by: Luiz Angelo Daros de Luca Tested-by: Arınç ÜNAL Reviewed-by: Alvin Šipraga Reviewed-by: Linus Walleij Reviewed-by: Florian Fainelli Reviewed-by: Vladimir Oltean Signed-off-by: David S. Miller List of files: /linux-6.15/drivers/net/dsa/realtek/Kconfig