Changes in speedtest.c

197173db - treewide: use get_random_bytes() when possible

Wed, 05 Oct 2022 15:49:46 +0000

treewide: use get_random_bytes() when possibleThe prandom_bytes() function has been a deprecated inline wrapper aroundget_random_bytes() for several releases now, and compiles down to theexact same code. Replace the deprecated wrapper with a direct call tothe real function. This was done as a basic find and replace.Reviewed-by: Greg Kroah-Hartman Reviewed-by: Kees Cook Reviewed-by: Yury Norov Reviewed-by: Christophe Leroy # powerpcAcked-by: Jakub Kicinski Signed-off-by: Jason A. Donenfeld List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

ceef4cf9 - mtd: tests: Fix eraseblock read speed miscalculation for lower partition sizes

Tue, 08 Feb 2022 10:39:05 +0000

mtd: tests: Fix eraseblock read speed miscalculation for lower partition sizesWhile calculating speed during mtd_speedtest, the time interval(i.e., start - finish) is rounded off to the nearest milliseconds byignoring the fractional part. This leads to miscalculation of speed.The miscalculation is more visible while running speed test on smallpartition sizes(i.e., when partition size is equal to eraseblock size ortwice the eraseblock size) at higher spi frequencies.For e.g., while calculating eraseblock read speed for a mtd partition withsize equal to the eraseblock size(i.e., 64KiB) the eraseblock read timeinterval comes out to be 966490 nanosecond. This is then converted tomillisecond(i.e., 0.966 msec.). The integer part (i.e., 0 msec) of thevalue is considered and the fractional part (i.e., 0.966) is ignored,forcalculating the eraseblock read speed. So the reported eraseblock readspeed is 0 KiB/s, which is incorrect.There are two approaches to fix this issue.First approach will be to keep the time interval in millisecond. and roundup the integer value, with this approach the 0.966msec time interval in theabove example will be rounded up to 1msec and this value is used forcalculating the speed. Downside of this approach is that the reported speedis still not accurate.Second approach will be to convert the time interval to microsecondsinstead of milliseconds, with this approach the 966490 nanosecond timeinterval in the above example will be converted t0 966.490usec and thisvalue is used for calculating the speed. As compared to the currentimplementation and the suggested First approach, this approach will reporta more accurate speed. Downside of this approach is that, in future if themtd size is too large then the u64 variable, that holds the number ofbytes, might overflow.In this patch we have gone with the second approach as this reports a moreaccurate speed. With this approach the eraseblock read speed in the aboveexample comes out to be 132505 KiB/s when the spi clock is configured at150Mhz.Signed-off-by: Amit Kumar Mahapatra Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20220208103905.13354-1-amit.kumar-mahapatra@xilinx.com List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

4cd10358 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 326

Wed, 29 May 2019 23:57:41 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 326Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program see the file copying if not write to the free software foundation 59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 9 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Kate Stewart Reviewed-by: Alexios Zavras Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190530000435.832876118@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

8f347c42 - mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

Mon, 12 Feb 2018 21:03:10 +0000

mtd: Unconditionally update ->fail_addr and ->addr in part_erase()->fail_addr and ->addr can be updated no matter the result ofparent->_erase(), we just need to remove the code doing the same thingin mtd_erase_callback() to avoid adjusting those fields twice.Note that this can be done because all MTD users have been converted tonot pass an erase_info->callback() and are thus only taking the->addr_fail and ->addr fields into account after part_erase() hasreturned.While we're at it, get rid of the erase_info->mtd field which was onlyneeded to let mtd_erase_callback() get the partition device back.Signed-off-by: Boris Brezillon Reviewed-by: Richard Weinberger List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

884cfd90 - mtd: Stop assuming mtd_erase() is asynchronous

Mon, 12 Feb 2018 21:03:09 +0000

mtd: Stop assuming mtd_erase() is asynchronousNone of the mtd->_erase() implementations work in an asynchronous manner,so let's simplify MTD users that call mtd_erase(). All they need to dois check the value returned by mtd_erase() and assume that != 0 meansfailure.Signed-off-by: Boris Brezillon Reviewed-by: Richard Weinberger List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

af30c0a0 - mtd: tests: Replace timeval with ktime_t

Thu, 22 Oct 2015 14:59:54 +0000

mtd: tests: Replace timeval with ktime_tChanges the 32-bit time type timeval to the 64-bit time typektime_t, since 32-bit systems using struct timeval will break in theyear 2038. Correspondingly change do_gettimeofday() to ktime_get()since ktime_get returns a ktime_t, but do_gettimeofday returns astruct timeval.Here, ktime_get() is used instead of ktime_get_real()since ktime_get() uses monotonic clock.Signed-off-by: Shraddha Barke Reviewed-by: Arnd Bergmann Signed-off-by: Brian Norris List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

2a6a28e7 - mtd: Make MTD tests cancelable

Sun, 29 Mar 2015 19:52:06 +0000

mtd: Make MTD tests cancelableI always go nuts when I start an MTD test on a slow device and have towait forever until it finishes. From the debug output I already knowwhat the issue is but I have to wait or reset the board hard. Resettingis often not an option (remote access, you don't want lose the currentstate, etc...).The solution is easy, check for pending signals at key positions in thecode. Using that one can even stop a test by pressing CTRL-C asinsmod/modprobe have SIGINT pending.Signed-off-by: Richard Weinberger Signed-off-by: Brian Norris List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

b9da8bae - mtd: tests: fix more potential integer overflows

Sat, 28 Feb 2015 10:02:26 +0000

mtd: tests: fix more potential integer overflowsCaught by Coverity (CID #200625 and others)Signed-off-by: Brian Norris Cc: Akinobu Mita List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

1001ff7a - mtd: tests: fix integer overflow issues

Tue, 22 Jul 2014 02:07:12 +0000

mtd: tests: fix integer overflow issuesThese multiplications are done with 32-bit arithmetic, then converted to64-bit. We should widen the integers first to prevent overflow. Thiscould be a problem for large (>4GB) MTD's.Detected by Coverity.Signed-off-by: Brian Norris Cc: Akinobu Mita List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

8a9f4aa3 - mtd: tests: incorporate error message for mtdtest_write()

Thu, 15 Aug 2013 13:55:09 +0000

mtd: tests: incorporate error message for mtdtest_write()All callers of mtdtest_write() print the same error message on failure.This incorporates the error message to mtdtest_write() and removes themfrom the callers.Signed-off-by: Akinobu Mita Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

abc173ad - mtd: tests: incorporate error message for mtdtest_read()

Thu, 15 Aug 2013 13:55:08 +0000

mtd: tests: incorporate error message for mtdtest_read()All callers of mtdtest_read() print the same error message on failure.This incorporates the error message to mtdtest_read() and removes themfrom the callers.Signed-off-by: Akinobu Mita Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

59b0816d - mtd: mtd_speedtest: use mtd_test helpers

Sat, 03 Aug 2013 09:52:12 +0000

mtd: mtd_speedtest: use mtd_test helpersUse mtdtest_write(), mtdtest_read(), mtdtest_scan_for_bad_eraseblocks(),mtdtest_erase_good_eraseblocks() in mtd_test helpers.Signed-off-by: Akinobu Mita Cc: Brian Norris Cc: Vikram Narayanan Cc: Adrian Hunter Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse List of files: /linux-6.15/drivers/mtd/tests/speedtest.c

a995c792 - mtd: tests: rename sources in order to link a helper object

Sat, 03 Aug 2013 09:52:08 +0000

mtd: tests: rename sources in order to link a helper objectEach mtd test module have a single source whose name is the same asthe module name. In order to link a single object including helperfunctions to every test module, this rename these sources to thedifferent names.Signed-off-by: Akinobu Mita Cc: Brian Norris Cc: Vikram Narayanan Cc: Adrian Hunter Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse List of files: /linux-6.15/drivers/mtd/tests/speedtest.c