Changes in pwrseq_simple.c

aac4be93 - mmc: pwrseq_simple: use gpiod_multi_set_value_cansleep

Mon, 10 Feb 2025 22:33:37 +0000

mmc: pwrseq_simple: use gpiod_multi_set_value_cansleepReduce verbosity by using gpiod_multi_set_value_cansleep() instead ofgpiod_set_array_value_cansleep().Acked-by: Ulf Hansson Reviewed-by: Linus Walleij Signed-off-by: David Lechner Link: https://lore.kernel.org/r/20250210-gpio-set-array-helper-v3-11-d6a673674da8@baylibre.comSigned-off-by: Bartosz Golaszewski List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

3f31337c - mmc: pwrseq_simple: Handle !RESET_CONTROLLER properly

Fri, 08 Nov 2024 13:06:47 +0000

mmc: pwrseq_simple: Handle !RESET_CONTROLLER properlyThe recent introduction of reset control in pwrseq_simple introduceda regression for platforms without RESET_CONTROLLER support, becausedevm_reset_control_get_optional_shared() would return NULL and make allresets no-ops. Instead of enforcing this dependency, rely on this behaviorto determine reset support. As a benefit we can get the rid of theuse_reset flag.Fixes: 73bf4b7381f7 ("mmc: pwrseq_simple: add support for one reset control")Signed-off-by: Stefan Wahren Reviewed-by: Florian Fainelli Message-ID: <20241108130647.8281-1-wahrenst@gmx.net>Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

73bf4b73 - mmc: pwrseq_simple: add support for one reset control

Thu, 17 Oct 2024 13:19:57 +0000

mmc: pwrseq_simple: add support for one reset controlReset controls being refcounted, they allow to share gpios acrossdrivers. Right now, reset framework and reset-gpio driver supports onlyone reset gpio, so add support for one single reset control. If morethan one reset gpio is configured in the device tree, then fallback toclassic gpio control.Signed-off-by: Catalin Popescu Message-ID: <20241017131957.1171323-1-catalin.popescu@leica-geosystems.com>Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

078e548a - mmc: Switch back to struct platform_driver::remove()

Fri, 27 Sep 2024 14:58:33 +0000

mmc: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/mmc to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20240927145832.754697-2-u.kleine-koenig@baylibre.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

8eb57fd0 - mmc: add missing MODULE_DESCRIPTION() macros

Tue, 11 Jun 2024 15:50:42 +0000

mmc: add missing MODULE_DESCRIPTION() macrosmake allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/host/of_mmc_spi.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/host/tmio_mmc_core.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/host/renesas_sdhi_core.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/core/mmc_core.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/core/pwrseq_simple.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/core/pwrseq_sd8787.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/core/pwrseq_emmc.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/mmc/core/sdio_uart.oAdd the missing invocations of the MODULE_DESCRIPTION() macro.Reviewed-by: Wolfram Sang # for TMIO and SDHISigned-off-by: Jeff Johnson Reviewed-by: Dragan Simic Link: https://lore.kernel.org/r/20240611-md-drivers-mmc-v2-1-2ef2cbcdc061@quicinc.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

7f6b0361 - mmc: pwrseq_simple: Convert to platform remove callback returning void

Thu, 27 Jul 2023 07:00:42 +0000

mmc: pwrseq_simple: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Link: https://lore.kernel.org/r/20230727070051.17778-53-frank.li@vivo.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

b0197e47 - mmc: pwrseq_simple: include deferred probe reasons

Wed, 28 Dec 2022 14:23:54 +0000

mmc: pwrseq_simple: include deferred probe reasonsThis adds a reason to /sys/kernel/debug/devices_deferred, which makesit easier to debug deferred probes such as [0].0. https://lore.kernel.org/all/20221228140708.26431-1-tom@tom-fitzhenry.me.uk/Signed-off-by: Tom Fitzhenry Link: https://lore.kernel.org/r/20221228142354.28454-1-tom@tom-fitzhenry.me.ukSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

28df1433 - mmc: pwrseq: Use bitmap_free() to free bitmap

Sun, 26 Dec 2021 14:15:36 +0000

mmc: pwrseq: Use bitmap_free() to free bitmapkfree() and bitmap_free() are the same. But using the later is moreconsistent when freeing memory allocated with bitmap_alloc().Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/07a8e48db446888bd77f16b88568e80904f52103.1640528089.git.christophe.jaillet@wanadoo.frSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

af873fce - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194

Tue, 28 May 2019 16:57:21 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 194Based on 1 normalized pattern(s): license terms gnu general public license gpl version 2extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 161 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Reviewed-by: Steve Winslow Reviewed-by: Richard Fontana Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190528170027.447718015@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

9c9f1dde - mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmap

Fri, 12 Oct 2018 19:09:01 +0000

mmc: pwrseq_simple: Fix incorrect handling of GPIO bitmapCommit b9762bebc633 ("gpiolib: Pass bitmaps, not integer arrays, toget/set array") changed the way GPIO values are passed togpiod_get/set_array_value() and friends. The new code introduced intommc_pwrseq_simple_set_gpios_value() incorrectly interpretes the 'value'argument as a bitmap of GPIO values and assigns it directly to the'values' bitmap variable passed to gpiod_set_array_value_cansleep()instead of filling that bitmap with bits equal to the 'value' argument.As a result, only member 0 of the array is handled correctly.Moreover, wrong assumption is taken about the 'values' bitmap size notexceding the number of bits of the 'value' argument type.Fix it.Signed-off-by: Janusz Krzysztofik Tested-by: Marek Szyprowski Acked-by: Ulf Hansson Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

77588c14 - gpiolib: Pass array info to get/set array functions

Wed, 05 Sep 2018 21:50:07 +0000

gpiolib: Pass array info to get/set array functionsIn order to make use of array info obtained from gpiod_get_array() andspeed up processing of arrays matching single GPIO chip layout, thatinformation must be passed to get/set array functions. Extend thefunctions' API with that additional parameter and update all users.Pass NULL if a user builds an array itself from single GPIOs.Cc: Jonathan Corbet Cc: Miguel Ojeda Sandonis Cc: Geert Uytterhoeven Cc: Sebastien Bourdelin Cc: Lukas Wunner Cc: Peter Korsgaard Cc: Peter Rosin Cc: Andrew Lunn Cc: Florian Fainelli Cc: "David S. Miller" Cc: Rojhalat Ibrahim Cc: Dominik Brodowski Cc: Russell King Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Cc: Lars-Peter Clausen Cc: Michael Hennerich Cc: Jonathan Cameron Cc: Hartmut Knaack Cc: Peter Meerwald-Stadler Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Yegor Yefremov Cc: Uwe Kleine-König Signed-off-by: Janusz Krzysztofik Acked-by: Ulf Hansson Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

b9762beb - gpiolib: Pass bitmaps, not integer arrays, to get/set array

Wed, 05 Sep 2018 21:50:05 +0000

gpiolib: Pass bitmaps, not integer arrays, to get/set arrayMost users of get/set array functions iterate consecutive bits of data,usually a single integer, while processing array of results obtainedfrom, or building an array of values to be passed to those functions.Save time wasted on those iterations by changing the functions' API toaccept bitmaps.All current users are updated as well.More benefits from the change are expected as soon as planned supportfor accepting/passing those bitmaps directly from/to respective GPIOchip callbacks if applicable is implemented.Cc: Jonathan Corbet Cc: Miguel Ojeda Sandonis Cc: Sebastien Bourdelin Cc: Lukas Wunner Cc: Peter Korsgaard Cc: Peter Rosin Cc: Andrew Lunn Cc: Florian Fainelli Cc: "David S. Miller" Cc: Rojhalat Ibrahim Cc: Dominik Brodowski Cc: Russell King Cc: Kishon Vijay Abraham I Cc: Tony Lindgren Cc: Lars-Peter Clausen Cc: Michael Hennerich Cc: Jonathan Cameron Cc: Hartmut Knaack Cc: Peter Meerwald-Stadler Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Yegor Yefremov Cc: Uwe Kleine-König Signed-off-by: Janusz Krzysztofik Acked-by: Ulf Hansson Reviewed-by: Geert Uytterhoeven Tested-by: Geert Uytterhoeven Signed-off-by: Linus Walleij List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

486e6661 - mmc: pwrseq: Use kmalloc_array instead of stack VLA

Mon, 26 Mar 2018 06:33:14 +0000

mmc: pwrseq: Use kmalloc_array instead of stack VLAThe use of stack Variable Length Arrays needs to be avoided, as theycan be a vector for stack exhaustion, which can be both a runtime bug(kernel Oops) or a security flaw (overwriting memory beyond thestack). Also, in general, as code evolves it is easy to lose track ofhow big a VLA can get. Thus, we can end up having runtime failuresthat are hard to debug. As part of the directive[1] to remove all VLAsfrom the kernel, and build with -Wvla.Currently driver is using a VLA declared using the number of descriptors. Thisarray is used to store integer values and is later used as an argument to`gpiod_set_array_value_cansleep()` This can be avoided by using`kmalloc_array()` to allocate memory for the array of integer values. Memory isfree'd before return from function.>From the code it appears that it is safe to sleep so we can use GFP_KERNEL(based _cansleep() suffix of function `gpiod_set_array_value_cansleep()`.It can be expected that this patch will result in a small increase in overheaddue to the use of `kmalloc_array()`[1] https://lkml.org/lkml/2018/3/7/621Signed-off-by: Tobin C. Harding Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

e9256e14 - mmc: pwrseq_simple: Parse DTS for the power-off-delay-us property

Sat, 06 May 2017 09:43:05 +0000

mmc: pwrseq_simple: Parse DTS for the power-off-delay-us propertyIf the optional power-off-delay-us property is found, insert thecorresponding delay after asserting the GPIO during power off. This enablesa graceful shutdown sequence for some devices.Cc: linux-mmc@vger.kernel.orgSigned-off-by: Ulf Hansson Acked-by: Arnd Bergmann List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

721e0497 - mmc: pwrseq-simple: Add an optional post-power-on-delay

Sun, 07 Aug 2016 19:02:38 +0000

mmc: pwrseq-simple: Add an optional post-power-on-delaySome devices need a while to boot their firmware after providing clks /de-asserting resets before they are ready to receive sdio commands.This commits adds a post-power-on-delay-ms devicetree property tommc-pwrseq-simple for use with such devices.Signed-off-by: Hans de Goede Acked-by: Rob Herring Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

d97a1e5d - mmc: pwrseq: convert to proper platform device

Thu, 14 Apr 2016 13:02:16 +0000

mmc: pwrseq: convert to proper platform devicesimple-pwrseq and emmc-pwrseq drivers rely on platform_devicestructure from of_find_device_by_node(), this works mostly. But, as thereis no driver associated with this devices, cases like default/init pinctrlsetup would never be performed by pwrseq. This becomes problem when thegpios used in pwrseq require pinctrl setup.Currently most of the common pinctrl setup is done indrivers/base/pinctrl.c by pinctrl_bind_pins().There are two ways to solve this issue on either convert pwrseq driversto a proper platform drivers or copy the exact code frompcintrl_bind_pins(). I prefer converting pwrseq to proper drivers so thatother cases like setting up clks/parents from dt would also be possible.Signed-off-by: Srinivas Kandagatla Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

5b96fea7 - mmc: pwrseq_simple: add to_pwrseq_simple() macro

Thu, 14 Apr 2016 13:02:14 +0000

mmc: pwrseq_simple: add to_pwrseq_simple() macroThis patch adds to_pwrseq_simple() macro to make the code more readable.Signed-off-by: Srinivas Kandagatla Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

62c03ca3 - mmc: core: pwrseq_simple: remove unused header file

Wed, 06 Jan 2016 03:34:10 +0000

mmc: core: pwrseq_simple: remove unused header fileSigned-off-by: Peter Chen Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

64a67d47 - mmc: pwrseq_simple: Make reset-gpios optional to match doc

Wed, 20 Jan 2016 15:08:03 +0000

mmc: pwrseq_simple: Make reset-gpios optional to match docThe DT binding doc says reset-gpios is an optional property but the codecurrently bails out if it is omitted.This is a regression since it breaks previously working device trees.Fix it by restoring the original documented behaviour.Fixes: ce037275861e ("mmc: pwrseq_simple: use GPIO descriptors array API")Tested-by: Tony Lindgren Signed-off-by: Martin Fuzzey Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c

ffedbd22 - mmc: pwrseq: constify mmc_pwrseq_ops structures

Sat, 14 Nov 2015 17:05:20 +0000

mmc: pwrseq: constify mmc_pwrseq_ops structuresThe mmc_pwrseq_ops structures are never modified, so declare them as const.Done with the help of Coccinelle.Signed-off-by: Julia Lawall Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/pwrseq_simple.c