Changes in block.c

869d3747 - mmc: core: Use GFP_NOIO in ACMD22

Mon, 21 Oct 2024 15:32:27 +0000

mmc: core: Use GFP_NOIO in ACMD22While reviewing the SDUC series, Adrian made a comment concerning thememory allocation code in mmc_sd_num_wr_blocks() - see [1].Prevent memory allocations from triggering I/O operations while ACMD22is in progress.[1] https://lore.kernel.org/linux-mmc/3016fd71-885b-4ef9-97ed-46b4b0cb0e35@intel.com/Suggested-by: Adrian Hunter Reviewed-by: Adrian Hunter Fixes: 051913dada04 ("mmc_block: do not DMA to stack")Signed-off-by: Avri Altman Cc: stable@vger.kernel.orgMessage-ID: <20241021153227.493970-1-avri.altman@wdc.com>Signed-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

3ec7cb11 - mmc: block: attach partitions fwnode if found in mmc-card

Wed, 02 Oct 2024 22:11:44 +0000

mmc: block: attach partitions fwnode if found in mmc-cardAttach partitions fwnode if found in mmc-card and register disk with it.This permits block partition to reference the node and register apartition table defined in DT for the special case for embedded devicethat doesn't have a partition table flashed but have an hardcodedpartition table passed from the system.JEDEC BOOT partition boot0/boot1 are supported but in DT we refer withthe JEDEC name of boot1 and boot2 to better adhere to documentation.Also JEDEC GP partition gp0/1/2/3 are supported but in DT we refer withthe JEDEC name of gp1/2/3/4 to better adhere to documentration.Signed-off-by: Christian Marangi Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241002221306.4403-5-ansuelsmth@gmail.comSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/mmc/core/block.c

449f34a3 - mmc: core: Adjust ACMD22 to SDUC

Sun, 06 Oct 2024 05:11:45 +0000

mmc: core: Adjust ACMD22 to SDUCACMD22 is used to verify the previously write operation. Normally, itreturns the number of written sectors as u32. SDUC, however, returns itas u64. This is not a superfluous requirement, because SDUC writes mayexceeds 2TB. For Linux mmc however, the previously write operationcould not be more than the block layer limits, thus we make room for au64 and cast the returning value to u32.Reviewed-by: Adrian Hunter Signed-off-by: Avri Altman Link: https://lore.kernel.org/r/20241006051148.160278-8-avri.altman@wdc.comSigned-off-by: Ulf Hansson [Stephen Rothwell: Fix build error when moving to new rc from Linus's tree]Signed-off-by: Stephen Rothwell List of files: /linux-6.15/drivers/mmc/core/block.c

9b9c665a - mmc: core: Allow mmc erase to carry large addresses

Sun, 06 Oct 2024 05:11:43 +0000

mmc: core: Allow mmc erase to carry large addressesPreparing for SDUC, Allow the erase address to be larger beyond a 32 bitaddress.Tested-by: Ricky WU Reviewed-by: Adrian Hunter Signed-off-by: Avri Altman Link: https://lore.kernel.org/r/20241006051148.160278-6-avri.altman@wdc.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

403a0293 - mmc: core: Add open-ended Ext memory addressing

Sun, 06 Oct 2024 05:11:42 +0000

mmc: core: Add open-ended Ext memory addressingFor open-ended read/write - just send CMD22 before issuing the command.Reviewed-by: Adrian Hunter Signed-off-by: Avri Altman Link: https://lore.kernel.org/r/20241006051148.160278-5-avri.altman@wdc.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

93387385 - mmc: core: Don't use close-ended rw for SDUC

Sun, 06 Oct 2024 05:11:41 +0000

mmc: core: Don't use close-ended rw for SDUCThe SDUC spec expects CMD22 to get squeezed between CMD23 and theread/write command, e.g. CMD23->CMD22->CMD18 and CMD23->CMD22->CMD25.At this early stage of adoption, we want to avoid an amid stream offixes & quirks of bogus hw, that tends to apply extra logic specificallyaround auto-cmd12 & auto-cmd23.Let's leave close-ended out for now, and re-consider this should thosecards become ubiquitous, if any.It also means that BLK_FEAT_FUA will not be used for I/O, but instead wewill rely on BLK_FEAT_WRITE_CACHE.Reviewed-by: Adrian Hunter Signed-off-by: Avri Altman Link: https://lore.kernel.org/r/20241006051148.160278-4-avri.altman@wdc.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

cb787f4a - [tree-wide] finally take no_llseek out

Fri, 27 Sep 2024 01:56:11 +0000

[tree-wide] finally take no_llseek outno_llseek had been defined to NULL two years ago, in commit 868941b14441("fs: remove no_llseek")To quote that commit, At -rc1 we'll need do a mechanical removal of no_llseek - git grep -l -w no_llseek | grep -v porting.rst | while read i; do sed -i '/\/d' $i done would do it.Unfortunately, that hadn't been done. Linus, could you do that now, sothat we could finally put that thing to rest? All instances are of theform .llseek = no_llseek,so it's obviously safe.Signed-off-by: Al Viro Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/mmc/core/block.c

6f25e5de - mmc: core: Convert simple_stroul to kstroul

Sun, 01 Sep 2024 18:22:44 +0000

mmc: core: Convert simple_stroul to kstroulsimple_strtoul() is obsolete and lacks proper error handling, making itunsafe for converting strings to unsigned long values. Replace it withkstrtoul(), which provides robust error checking and better safety.This change improves the reliability of the string-to-integer conversionand aligns with current kernel coding standards. Error handling is addedto catch conversion failures, returning -EINVAL when input is invalid.Issue reported by checkpatch:- WARNING: simple_strtoul is obsolete, use kstrtoul insteadSigned-off-by: Riyan Dhiman Link: https://lore.kernel.org/r/20240901182244.45543-1-riyandhiman14@gmail.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

d2253bfa - mmc: core: Calculate size from pointer

Sun, 01 Sep 2024 17:33:09 +0000

mmc: core: Calculate size from pointerCalculate the size from pointer instead ofstruct to adhere to linux kernel coding style.Issue reported by checkpatch.This commit has no functional changes.Signed-off-by: Riyan Dhiman Link: https://lore.kernel.org/r/20240901173309.7124-1-riyandhiman14@gmail.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

7852028a - mmc: block: register RPMB partition with the RPMB subsystem

Wed, 14 Aug 2024 15:35:56 +0000

mmc: block: register RPMB partition with the RPMB subsystemRegister eMMC RPMB partition with the RPMB subsystem and providean implementation for the RPMB access operations abstractingthe actual multi step process.Add a callback to extract the needed device information at registrationto avoid accessing the struct mmc_card at a later stage as we're notholding a reference counter for this struct.Taking the needed reference to md->disk in mmc_blk_alloc_rpmb_part()instead of in mmc_rpmb_chrdev_open(). This is needed by theroute_frames() function pointer in struct rpmb_ops.Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Signed-off-by: Jens Wiklander Tested-by: Manuel Traut Reviewed-by: Linus Walleij Reviewed-by: Ulf Hansson Link: https://lore.kernel.org/r/20240814153558.708365-3-jens.wiklander@linaro.orgSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

1122c0c1 - block: move cache control settings out of queue->flags

Mon, 17 Jun 2024 06:04:40 +0000

block: move cache control settings out of queue->flagsMove the cache control settings into the queue_limits so that the flagscan be set atomically with the device queue frozen.Add new features and flags field for the driver set flags, and internal(usually sysfs-controlled) flags in the block layer. Note that we'lleventually remove enough field from queue_limits to bring it back to theprevious size.The disable flag is inverted compared to the previous meaning, whichmeans it now survives a rescan, similar to the max_sectors andmax_discard_sectors user limits.The FLUSH and FUA flags are now inherited by blk_stack_limits, whichsimplified the code in dm a lot, but also causes a slight behaviorchange in that dm-switch and dm-unstripe now advertise a write cachedespite setting num_flush_bios to 0. The I/O path will handle thisgracefully, but as far as I can tell the lack of num_flush_biosand thus flush support is a pre-existing data integrity bug in thosetargets that really needs fixing, after which a non-zero num_flush_biosshould be required in dm for targets that map to underlying devices.Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-14-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/mmc/core/block.c

4c7a022c - mmc: core: Convert sprintf/snprintf to sysfs_emit

Thu, 14 Mar 2024 09:15:12 +0000

mmc: core: Convert sprintf/snprintf to sysfs_emitPer filesystems/sysfs.rst, show() should only use sysfs_emit()or sysfs_emit_at() when formatting the value to be returned to user space.coccinelle complains that there are still a couple of functions that usesnprintf(). Convert them to sysfs_emit().sprintf() will be converted as weel if they have.Generally, this patch is generated bymake coccicheck M= MODE=patch \COCCI=scripts/coccinelle/api/device_attr_show.cocciNo functional change intendedSigned-off-by: Li Zhijian Link: https://lore.kernel.org/r/20240314091512.1323650-1-lizhijian@fujitsu.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

cf55a7ac - mmc: core: Avoid negative index with array access

Wed, 13 Mar 2024 13:37:44 +0000

mmc: core: Avoid negative index with array accessCommit 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu") assignsprev_idata = idatas[i - 1], but doesn't check that the iterator i isgreater than zero. Let's fix this by adding a check.Fixes: 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu")Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/Cc: stable@vger.kernel.orgSigned-off-by: Mikko Rapeli Reviewed-by: Avri Altman Tested-by: Francesco Dolcini Link: https://lore.kernel.org/r/20240313133744.2405325-2-mikko.rapeli@linaro.orgSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

0cdfe5b0 - mmc: core: Initialize mmc_blk_ioc_data

Wed, 13 Mar 2024 13:37:43 +0000

mmc: core: Initialize mmc_blk_ioc_dataCommit 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu") addsflags uint to struct mmc_blk_ioc_data, but it does not get initialized forRPMB ioctls which now fails.Let's fix this by always initializing the struct and flags to zero.Fixes: 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu")Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218587Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/Cc: stable@vger.kernel.orgSigned-off-by: Mikko Rapeli Reviewed-by: Avri Altman Acked-by: Adrian Hunter Tested-by: Francesco Dolcini Link: https://lore.kernel.org/r/20240313133744.2405325-1-mikko.rapeli@linaro.orgSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

4af59a8d - mmc: core: Fix switch on gp3 partition

Wed, 06 Mar 2024 01:44:38 +0000

mmc: core: Fix switch on gp3 partitionCommit e7794c14fd73 ("mmc: rpmb: fixes pause retune on all RPMBpartitions.") added a mask check for 'part_type', but the mask used waswrong leading to the code intended for rpmb also being executed for GP3.On some MMCs (but not all) this would make gp3 partition inaccessible:armadillo:~# head -c 1 < /dev/mmcblk2gp3head: standard input: I/O errorarmadillo:~# dmesg -c[ 422.976583] mmc2: running CQE recovery[ 423.058182] mmc2: running CQE recovery[ 423.137607] mmc2: running CQE recovery[ 423.137802] blk_update_request: I/O error, dev mmcblk2gp3, sector 0 op 0x0:(READ) flags 0x80700 phys_seg 4 prio class 0[ 423.237125] mmc2: running CQE recovery[ 423.318206] mmc2: running CQE recovery[ 423.397680] mmc2: running CQE recovery[ 423.397837] blk_update_request: I/O error, dev mmcblk2gp3, sector 0 op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0[ 423.408287] Buffer I/O error on dev mmcblk2gp3, logical block 0, async page readthe part_type values of interest here are defined as follow:main 0boot0 1boot1 2rpmb 3gp0 4gp1 5gp2 6gp3 7so mask with EXT_CSD_PART_CONFIG_ACC_MASK (7) to correctly identify rpmbFixes: e7794c14fd73 ("mmc: rpmb: fixes pause retune on all RPMB partitions.")Cc: stable@vger.kernel.orgCc: Jorge Ramirez-Ortiz Signed-off-by: Dominique Martinet Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20240306-mmc-partswitch-v1-1-bf116985d950@codewreck.orgSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

6bf26a0e - mmc: core: make mmc_rpmb_bus_type const

Sat, 03 Feb 2024 19:02:00 +0000

mmc: core: make mmc_rpmb_bus_type constNow that the driver core can properly handle constant struct bus_type,move the mmc_rpmb_bus_type variable to be a constant structure as well,placing it into read-only memory which can not be modified at runtime.Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere Reviewed-by: Greg Kroah-Hartman Link: https://lore.kernel.org/r/20240203-bus_cleanup-mmc-v1-1-ad054dce8dc3@marliere.netSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

18cbe816 - mmc: core: Remove usage of the deprecated ida_simple_xx() API

Sun, 14 Jan 2024 15:01:57 +0000

mmc: core: Remove usage of the deprecated ida_simple_xx() APIida_alloc() and ida_free() should be preferred to the deprecatedida_simple_get() and ida_simple_remove().Note that the upper limit of ida_simple_get() is exclusive, but the one ofida_alloc_range()/ida_alloc_max() is inclusive. So a -1 has been added whenneeded.Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/583c57d0ae09f9d3a1e1a7b80c1e39ada17954b7.1705244502.git.christophe.jaillet@wanadoo.frSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

e7794c14 - mmc: rpmb: fixes pause retune on all RPMB partitions.

Fri, 01 Dec 2023 15:31:43 +0000

mmc: rpmb: fixes pause retune on all RPMB partitions.When RPMB was converted to a character device, it added support formultiple RPMB partitions (Commit 97548575bef3 ("mmc: block: Convert RPMB toa character device").One of the changes in this commit was transforming the variable target_partdefined in __mmc_blk_ioctl_cmd into a bitmask. This inadvertently regressedthe validation check done in mmc_blk_part_switch_pre() andmmc_blk_part_switch_post(), so let's fix it.Fixes: 97548575bef3 ("mmc: block: Convert RPMB to a character device")Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Linus Walleij Cc: Link: https://lore.kernel.org/r/20231201153143.1449753-1-jorge@foundries.ioSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

4d0c8d0a - mmc: core: Use mrq.sbc in close-ended ffu

Wed, 29 Nov 2023 09:25:35 +0000

mmc: core: Use mrq.sbc in close-ended ffuField Firmware Update (ffu) may use close-ended or open ended sequence.Each such sequence is comprised of a write commands enclosed between 2switch commands - to and from ffu mode. So for the close-ended case, itwill be: cmd6->cmd23-cmd25-cmd6.Some host controllers however, get confused when multi-block rw is sentwithout sbc, and may generate auto-cmd12 which breaks the ffu sequence.I encountered this issue while testing fwupd (github.com/fwupd/fwupd)on HP Chromebook x2, a qualcomm based QC-7c, code name - strongbad.Instead of a quirk, or hooking the request function of the msm ops,it would be better to fix the ioctl handling and make it use mrq.sbcinstead of issuing SET_BLOCK_COUNT separately.Signed-off-by: Avri Altman Acked-by: Adrian Hunter Cc: stable@vger.kernel.orgLink: https://lore.kernel.org/r/20231129092535.3278-1-avri.altman@wdc.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c

174925d3 - mmc: block: Do not lose cache flush during CQE error recovery

Fri, 03 Nov 2023 08:47:15 +0000

mmc: block: Do not lose cache flush during CQE error recoveryDuring CQE error recovery, error-free data commands get requeued if thereis any data left to transfer, but non-data commands are completed eventhough they have not been processed. Requeue them instead.Note the only non-data command is cache flush, which would have resulted ina cache flush being lost if it was queued at the time of CQE recovery.Fixes: 1e8e55b67030 ("mmc: block: Add CQE support")Cc: stable@vger.kernel.orgSigned-off-by: Adrian Hunter Reviewed-by: Avri Altman Link: https://lore.kernel.org/r/20231103084720.6886-2-adrian.hunter@intel.comSigned-off-by: Ulf Hansson List of files: /linux-6.15/drivers/mmc/core/block.c