Changes in xilinx_sdfec.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

2743e96f - misc: xilinx_sdfec: Convert to platform remove callback returning void

Wed, 21 Feb 2024 09:53:54 +0000

misc: xilinx_sdfec: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Acked-by: Arnd Bergmann Link: https://lore.kernel.org/r/705b89c3cd7c0a42ce3f482f202204f5e3377aa2.1708508896.git.u.kleine-koenig@pengutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

d9c58aeb - misc: Explicitly include correct DT includes

Tue, 18 Jul 2023 14:31:01 +0000

misc: Explicitly include correct DT includesThe DT of_device.h and of_platform.h date back to the separateof_platform_bus_type before it as merged into the regular platform bus.As part of that merge prepping Arm DT support 13 years ago, they"temporarily" include each other. They also include platform_device.hand of.h. As a result, there's a pretty much random mix of those includefiles used throughout the tree. In order to detangle these headers andreplace the implicit includes with struct declarations, users need toexplicitly include the correct includes.Acked-by: Andrew Donnellan # cxlSigned-off-by: Rob Herring Link: https://lore.kernel.org/r/20230718143102.1065481-1-robh@kernel.orgSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

190d1f22 - misc/xilinx_sdfec: Convert to devm_platform_ioremap_resource()

Fri, 07 Jul 2023 02:42:22 +0000

misc/xilinx_sdfec: Convert to devm_platform_ioremap_resource()Use devm_platform_ioremap_resource() to simplify code.Signed-off-by: Yangtao Li Reviewed-by: Michal Simek Link: https://lore.kernel.org/r/20230707024224.78907-2-frank.li@vivo.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

f5070bf0 - misc/xilinx_sdfec: remove redundant _{open, release} function

Sat, 22 Apr 2023 19:59:33 +0000

misc/xilinx_sdfec: remove redundant _{open, release} functionThe functions are redundant as they are empty and performed by the miscdriver.Signed-off-by: Bo Svangård Acked-by: Michal Simek Link: https://lore.kernel.org/r/20230422195933.523874-1-bo.svangard@sylog.seSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

eb3b3c93 - misc/xilinx_sdfec: Replace kmap() with kmap_local_page()

Thu, 01 Sep 2022 15:44:08 +0000

misc/xilinx_sdfec: Replace kmap() with kmap_local_page()kmap() is being deprecated in favor of kmap_local_page().There are two main problems with kmap(): (1) It comes with an overhead asthe mapping space is restricted and protected by a global lock forsynchronization and (2) it also requires global TLB invalidation when thekmap’s pool wraps and it might block when the mapping space is fullyutilized until a slot becomes available.With kmap_local_page() the mappings are per thread, CPU local, can takepage faults, and can be called from any context (including interrupts).It is faster than kmap() in kernels with HIGHMEM enabled. Furthermore,the tasks can be preempted and, when they are scheduled to run again, thekernel virtual addresses are restored and still valid.Since its use in xilinx_sdfec.c is safe, replace kmap()i / kunmap() withkmap_local_page() / kunmap_local().Cc: "Venkataramanan, Anirudh" Suggested-by: Ira Weiny Signed-off-by: Fabio M. De Francesco Link: https://lore.kernel.org/r/20220901154408.23984-3-fmdefrancesco@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

e01b08d7 - misc/xilinx_sdfec: Call kunmap() on pages mapped with kmap()

Thu, 01 Sep 2022 15:44:07 +0000

misc/xilinx_sdfec: Call kunmap() on pages mapped with kmap()Pages in an array are mapped in a loop but, after the code is done withthe virtual addresses, these pages are never unmapped.Therefore, call kunmap() to unmap pages[i].Cc: "Venkataramanan, Anirudh" Cc: Ira Weiny Signed-off-by: Fabio M. De Francesco Link: https://lore.kernel.org/r/20220901154408.23984-2-fmdefrancesco@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

78429edf - misc: xilinx-sdfec: Drop unnecessary NULL check after container_of

Fri, 21 May 2021 20:04:57 +0000

misc: xilinx-sdfec: Drop unnecessary NULL check after container_ofcontainer_of() only returns NULL if the passed pointer is NULL _and_ ifthe embedded element is the first element of the structure. Even if thatis the case, testing against it is misleading and possibly dangerousbecause the position of the embedded element may change. In this case,the check is unnecessary since it is known that file->private_data isnever NULL for an open file, and container_of() will therefore alsonever be NULL. Drop the check.Acked-by: Dragan Cvetic Signed-off-by: Guenter Roeck Link: https://lore.kernel.org/r/20210521200457.2112041-1-linux@roeck-us.netSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

c78c95f9 - misc: xilinx-sdfec: remove check for ioctl cmd and argument.

Sun, 01 Nov 2020 17:09:49 +0000

misc: xilinx-sdfec: remove check for ioctl cmd and argument.if (_IOC_TYPE(cmd) != PP_IOCTL) return -ENOTTY;Invalid ioctl command check normally performs by “default” case.if (_IOC_DIR(cmd) != _IOC_NONE) { argp = (void __user *)arg; if (!argp) return -EINVAL; }And for checking ioctl arguments, copy_from_user()/copy_to_user()checks are enough.Reviewed-by: Arnd Bergmann Signed-off-by: Harshal Chaudhari Link: https://lore.kernel.org/r/20201101170949.18616-1-harshalchau04@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

3f7566f4 - misc: xilinx_sdfec: add compat_ptr_ioctl()

Mon, 26 Oct 2020 15:58:01 +0000

misc: xilinx_sdfec: add compat_ptr_ioctl()Driver has a trivial helper function to convertthe pointer argument and then call the native ioctl handler.But now we have a generic implementation for that, so we can use it.Signed-off-by: Harshal Chaudhari Link: https://lore.kernel.org/r/20201026155801.16053-1-harshalchau04@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

03358b0f - misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

Wed, 27 May 2020 01:26:28 +0000

misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()This code was using get_user_pages*(), in approximately a "Case 1"scenario (Direct IO), using the categorization from [1]. That meansthat it's time to convert the get_user_pages*() + put_page() calls topin_user_pages*() + unpin_user_pages() calls.There is some helpful background in [2]: basically, this is a smallpart of fixing a long-standing disconnect between pinning pages, andfile systems' use of those pages.[1] Documentation/core-api/pin_user_pages.rst[2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Michal Simek Cc: linux-arm-kernel@lists.infradead.orgSigned-off-by: John Hubbard Link: https://lore.kernel.org/r/20200527012628.1100649-4-jhubbard@nvidia.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

d25594d7 - misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()

Wed, 27 May 2020 01:26:27 +0000

misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()Return 0 for success, rather than the value of an incrementing"reg" index. The reg value was never actually used, so thissimplifies the caller slightly.Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Michal Simek Cc: linux-arm-kernel@lists.infradead.orgSigned-off-by: John Hubbard Link: https://lore.kernel.org/r/20200527012628.1100649-3-jhubbard@nvidia.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

57343d51 - misc: xilinx-sdfec: improve get_user_pages_fast() error handling

Wed, 27 May 2020 01:26:26 +0000

misc: xilinx-sdfec: improve get_user_pages_fast() error handlingThis fixes the case of get_user_pages_fast() returning a -errno.The result needs to be stored in a signed integer. And for safesigned/unsigned comparisons, it's best to keep everything signed.And get_user_pages_fast() also expects a signed value for numberof pages to pin.Therefore, change most relevant variables, from u32 to int. Leave"n" unsigned, for convenience in checking for overflow. And providea WARN_ON_ONCE() and early return, if overflow occurs.Also, as long as we're tidying up: rename the page array from page,to pages, in order to match the conventions used in most other callsites.Fixes: 20ec628e8007e ("misc: xilinx_sdfec: Add ability to configure LDPC")Cc: Derek Kiernan Cc: Dragan Cvetic Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Michal Simek Cc: linux-arm-kernel@lists.infradead.orgSigned-off-by: John Hubbard Link: https://lore.kernel.org/r/20200527012628.1100649-2-jhubbard@nvidia.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

286adb4c - misc: xilinx-sdfec: convert to module_platform_driver()

Sun, 10 May 2020 16:43:08 +0000

misc: xilinx-sdfec: convert to module_platform_driver()The driver init and exit function don't do anything besides registeringand unregistering the platform driver, so the module_platform_driver()macro could just be used instead of having separate functions.Signed-off-by: Harshal Chaudhari Acked-by: Dragan Cvetic Link: https://lore.kernel.org/r/20200510164308.31358-1-harshalchau04@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

15665c06 - misc: xilinx_sdfec: Use memdup_user() as a cleanup

Wed, 22 Apr 2020 02:58:50 +0000

misc: xilinx_sdfec: Use memdup_user() as a cleanupFix coccicheck warning which recommends to use memdup_user().This patch fixes the following coccicheck warnings:drivers/misc/xilinx_sdfec.c:652:8-15: WARNING opportunity for memdup_userReported-by: Hulk Robot Signed-off-by: Zou Wei Link: https://lore.kernel.org/r/1587524330-119776-1-git-send-email-zou_wei@huawei.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

fa4e7fc1 - misc: xilinx_sdfec: fix xsdfec_poll()'s return type

Mon, 09 Dec 2019 21:36:55 +0000

misc: xilinx_sdfec: fix xsdfec_poll()'s return typexsdfec_poll() is defined as returning 'unsigned int' but the.poll method is declared as returning '__poll_t', a bitwise type.Fix this by using the proper return type and using the EPOLLconstants instead of the POLL ones, as required for __poll_t.CC: Derek Kiernan CC: Dragan Cvetic Signed-off-by: Luc Van Oostenryck Acked-by: Dragan Cvetic Link: https://lore.kernel.org/r/20191209213655.57985-1-luc.vanoostenryck@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

a6b07e89 - misc: xilinx_sdfec: add missing __user annotation

Mon, 09 Dec 2019 21:37:19 +0000

misc: xilinx_sdfec: add missing __user annotationThe second arg of xsdfec_set_order() is a 'void __user *'and this pointer is then used in get_user() which expecta __user pointer.But get_user() can't be used with a void pointer, it apointer to the effective type. This is done here by castingthe argument to a pointer to the effective type but the__user is missing in the cast.Fix this by adding the missing __user in the cast.CC: Derek Kiernan CC: Dragan Cvetic Signed-off-by: Luc Van Oostenryck Acked-by: Dragan Cvetic Link: https://lore.kernel.org/r/20191209213719.58037-1-luc.vanoostenryck@gmail.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

3b420aeb - misc: xilinx_sdfec: fix spelling mistake: "Schdule" -> "Schedule"

Mon, 19 Aug 2019 09:41:37 +0000

misc: xilinx_sdfec: fix spelling mistake: "Schdule" -> "Schedule"There is a spelling mistake in a dev_dbg message, fix it.Signed-off-by: Colin Ian King Reviewed-by: Dragan Cvetic Link: https://lore.kernel.org/r/20190819094137.390-1-colin.king@canonical.comSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

6123f1fe - misc: xilinx_sdfec: Prevent integer overflow in xsdfec_table_write()

Wed, 21 Aug 2019 07:11:22 +0000

misc: xilinx_sdfec: Prevent integer overflow in xsdfec_table_write()The checking here needs to handle integer overflows because "offset" and"len" come from the user.Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC")Signed-off-by: Dan Carpenter Reviewed-by: Michal Simek Reviewed-by: Dragan Cvetic Link: https://lore.kernel.org/r/20190821071122.GD26957@mwandaSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c

56a635c0 - misc: xilinx_sdfec: Prevent a divide by zero in xsdfec_reg0_write()

Wed, 21 Aug 2019 07:09:53 +0000

misc: xilinx_sdfec: Prevent a divide by zero in xsdfec_reg0_write()The "psize" value comes from the user so we need to verify that it'snon-zero before we check if "n % psize" or it will crash.Fixes: 20ec628e8007 ("misc: xilinx_sdfec: Add ability to configure LDPC")Signed-off-by: Dan Carpenter Reviewed-by: Michal Simek Link: https://lore.kernel.org/r/20190821070953.GC26957@mwandaSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/misc/xilinx_sdfec.c