Changes in ipaq-micro.c

9675c059 - mfd: ipaq-micro/tps65010: Use str_enable_disable-like helpers

Tue, 14 Jan 2025 19:25:38 +0000

mfd: ipaq-micro/tps65010: Use str_enable_disable-like helpersReplace ternary (condition ? "enable" : "disable") syntax with helpersfrom string_choices.h because:1. Simple function call with one argument is easier to read. Ternary operator has three arguments and with wrapping might lead to quite long code.2. Is slightly shorter thus also easier to read.3. It brings uniformity in the text - same string.4. Allows deduping by the linker, which results in a smaller binary file.Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20250114192538.911970-1-krzysztof.kozlowski@linaro.orgSigned-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

3d1c3272 - mfd: ipaq-micro: Add missing break for the default case

Wed, 16 Oct 2024 13:00:23 +0000

mfd: ipaq-micro: Add missing break for the default caseEven default case should have a break statement to make code robustagainst changes (e.g., adding a case after the default one).Add missing break for the default case.Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20241016130023.872277-1-andriy.shevchenko@linux.intel.comSigned-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

87ea8c7e - mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()

Thu, 17 Aug 2023 11:45:05 +0000

mfd: ipaq-micro: Remove unused variable i in micro_rx_msg()There is a warning reported by kernel test robot:drivers/mfd/ipaq-micro.c:81:6: warning: unused variable ‘i’ [-Wunused-variable]Since the commit 92d82d76c842 ("mfd: ipaq-micro: Use %*ph for printinghexdump of a small buffer"), the variable 'i' is unused. Remove it tosilence the warning.Reported-by: kernelci.org bot Closes: https://lore.kernel.org/all/64c8aeac.170a0220.e3234.2745@mx.google.com/Signed-off-by: Li Zetao Link: https://lore.kernel.org/r/20230817114505.1810920-1-lizetao1@huawei.comSigned-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

8325ec08 - mfd: ipaq-micro: Use %*ph for printing hexdump of a small buffer

Mon, 03 Jul 2023 14:09:22 +0000

mfd: ipaq-micro: Use %*ph for printing hexdump of a small bufferThe kernel already has a helper to print a hexdump of a smallbuffer via pointer extension. Use that instead of open codedvariant.In long term it helps to kill pr_cont() or at least narrow downits use.Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230703140923.2840-1-andriy.shevchenko@linux.intel.comSigned-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

4239bff3 - mfd: ipaq-micro: Use devm_platform_get_and_ioremap_resource()

Wed, 08 Feb 2023 09:33:54 +0000

mfd: ipaq-micro: Use devm_platform_get_and_ioremap_resource()Convert platform_get_resource(), devm_ioremap_resource() to a singlecall to devm_platform_get_and_ioremap_resource(), as this is exactlywhat this function does.Signed-off-by: Ye Xingchen Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/202302081733542304522@zte.com.cn List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

3b49ae38 - mfd: ipaq-micro: Fix error check return value of platform_get_irq()

Tue, 12 Apr 2022 08:53:05 +0000

mfd: ipaq-micro: Fix error check return value of platform_get_irq()platform_get_irq() return negative value on failure, so null check ofirq is incorrect. Fix it by comparing whether it is less than zero.Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")Reported-by: Zeal Robot Signed-off-by: Lv Ruyi Reviewed-by: Linus Walleij Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220412085305.2533030-1-lv.ruyi@zte.com.cn List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

f20781e5 - mfd: ipaq-micro: Use devm_platform_ioremap_resource() in micro_probe()

Wed, 18 Sep 2019 11:40:30 +0000

mfd: ipaq-micro: Use devm_platform_ioremap_resource() in micro_probe()Simplify this function implementation by using a known wrapper function.This issue was detected by using the Coccinelle software.Signed-off-by: Markus Elfring Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

6ae0cc90 - mfd: ipaq-micro: Dump debugging hexdumps

Mon, 15 May 2017 09:44:05 +0000

mfd: ipaq-micro: Dump debugging hexdumpsThese hexdumps get printed no matter if CONFIG_DEBUG is set ornot. Just get rid of them.Signed-off-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

119d53d4 - mfd: ipaq-micro: Delete redundant return value check of platform_get_resource()

Sat, 25 Mar 2017 18:26:47 +0000

mfd: ipaq-micro: Delete redundant return value check of platform_get_resource()devm_ioremap_resource does checks on the resource. No need toduplicate this in the driver.Signed-off-by: Belén Sarabia Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

dcdf1173 - mfd: ipaq-micro: Use __maybe_unused to hide pm functions

Wed, 02 Mar 2016 15:58:57 +0000

mfd: ipaq-micro: Use __maybe_unused to hide pm functionsThe ipaq-micro driver uses SET_SYSTEM_SLEEP_PM_OPS() toremove the reference to its resume function, but doesnot use an #ifdef around the definition, so we geta build warning:drivers/mfd/ipaq-micro.c:379:12: error: 'micro_resume' defined but not used [-Werror=unused-function]This adds a __maybe_unused annotation so the compiler knowsit can silently drop it instead of warning.Signed-off-by: Arnd Bergmann Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

035faf4b - mfd: ipaq-micro: Convert to built-in platform driver

Wed, 22 Jul 2015 07:55:43 +0000

mfd: ipaq-micro: Convert to built-in platform driverSignal that this is a built-in driver and call its probe functionimmediately on init. Suppress binding attributes and delete the.remove() function since it is never unloaded. Tag probe() andfunctions only called from probe() with __init. Delete all modulemacros since this is a pure built-in.Signed-off-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

31115336 - mfd: ipaq-micro: Convert prints to debug prints

Wed, 22 Jul 2015 07:55:42 +0000

mfd: ipaq-micro: Convert prints to debug printsThere is a special function for debug prints rather than theusual hexdump function, let's use it.Signed-off-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

7d60bfc9 - mfd: ipaq-micro: Clean up development cruft

Wed, 22 Jul 2015 07:55:41 +0000

mfd: ipaq-micro: Clean up development cruftClean out a misspelled "HW" (MW) and remove commented-outcodeline.Signed-off-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

9336fe91 - mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch

Mon, 21 Jul 2014 15:08:55 +0000

mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatchThis is part of an effort to clean-up the MFD subsystem.ERROR: space required before the open parenthesis '('+ if(!micro->msg)WARNING: unnecessary whitespace before a quoted newline+ dev_dbg(micro->dev, "key message ignored, no handle \n");WARNING: unnecessary whitespace before a quoted newline+ dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");WARNING: space prohibited before semicolon+ rx->id = (ch & 0xf0) >> 4 ;total: 1 errors, 3 warnings, 482 lines checkedSigned-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

165b1cb1 - mfd: ipaq-micro: Make mfd_cell array const

Tue, 13 May 2014 10:58:40 +0000

mfd: ipaq-micro: Make mfd_cell array constmfd_add_devices() expects array of struct mfd_cell to be const.Signed-off-by: Krzysztof Kozlowski Acked-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

63c348cb - mfd: ipaq-micro: Use devm_ioremap_resource()

Wed, 14 May 2014 03:17:14 +0000

mfd: ipaq-micro: Use devm_ioremap_resource()Use devm_ioremap_resource() because devm_request_and_ioremap() isobsoleted by devm_ioremap_resource().Signed-off-by: Jingoo Han Acked-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c

dcc21cc0 - mfd: Add driver for Atmel Microcontroller on iPaq h3xxx

Thu, 03 Apr 2014 15:45:15 +0000

mfd: Add driver for Atmel Microcontroller on iPaq h3xxxThis adds a driver for the Atmel Microcontroller found on theiPAQ h3xxx series. This device handles some keys, thetouchscreen, and the battery monitoring.This is a port of a driver from handhelds.org 2.6.21 kernel,written by Alessandro Gardich based on Andrew Christiansoriginal HAL-driver. It has been heavily cleaned andconverted to mfd-core by Dmitry Artamonow and rewrittenagain for the v3.x series kernels by Linus Walleij,bringing back some of the functionality lost from Andrew'soriginal driver.Acked-by: Greg Kroah-Hartman Signed-off-by: Alessandro Gardich Signed-off-by: Dmitry Artamonow Signed-off-by: Linus Walleij Signed-off-by: Lee Jones List of files: /linux-6.15/drivers/mfd/ipaq-micro.c