Changes in mptbase.c

dec52397 - scsi: mptfusion: Simplify the alloc*_workqueue() invocations

Thu, 22 Aug 2024 19:59:06 +0000

scsi: mptfusion: Simplify the alloc*_workqueue() invocationsLet alloc*_workqueue() format the workqueue names instead of callingsnprintf() explicitly.Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20240822195944.654691-3-bvanassche@acm.orgSigned-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

dbe37c71 - scsi: message: fusion: Replace all non-returning strlcpy() with strscpy()

Tue, 30 May 2023 16:02:48 +0000

scsi: message: fusion: Replace all non-returning strlcpy() with strscpy()strlcpy() reads the entire source buffer first. This read may exceed thedestination size limit. This is both inefficient and can lead to linearread overflows if a source string is not NUL-terminated [1]. In an effortto remove strlcpy() completely [2], replace strlcpy() here with strscpy().No return values were used, so direct replacement is safe.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy[2] https://github.com/KSPP/linux/issues/89Signed-off-by: Azeem Shaikh Link: https://lore.kernel.org/r/20230530160248.411637-1-azeemshaikh38@gmail.comReviewed-by: Kees Cook Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

6e36a56a - scsi: message: fusion: Mark mpt_halt_firmware() __noreturn

Wed, 12 Apr 2023 23:49:40 +0000

scsi: message: fusion: Mark mpt_halt_firmware() __noreturnmpt_halt_firmware() doesn't return. Mark it as such.Fixes the following warnings: vmlinux.o: warning: objtool: mptscsih_abort+0x7f4: unreachable instruction vmlinux.o: warning: objtool: mptctl_timeout_expired+0x310: unreachable instructionReported-by: kernel test robot Reported-by: Mark Rutland Debugged-by: Peter Zijlstra Signed-off-by: Josh Poimboeuf Signed-off-by: Peter Zijlstra (Intel) Link: https://lore.kernel.org/r/d8129817423422355bf30e90dadc6764261b53e0.1681342859.git.jpoimboe@kernel.org List of files: /linux-6.15/drivers/message/fusion/mptbase.c

61144d83 - scsi: message: fusion: Remove redundant variable dmp

Fri, 18 Mar 2022 00:39:27 +0000

scsi: message: fusion: Remove redundant variable dmpVariable dmp is being assigned a value that is never read, the variable isredundant and can be removed.Cleans up clang scan build warning:drivers/message/fusion/mptbase.c:6667:39: warning: Althoughthe value stored to 'dmp' is used in the enclosing expression,the value is never actually read from 'dmp' [deadcode.DeadStores]Link: https://lore.kernel.org/r/20220318003927.81471-1-colin.i.king@gmail.comReviewed-by: Nick Desaulniers Signed-off-by: Colin Ian King Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

5c5e6b6f - scsi: message: fusion: mptbase: Use dma_alloc_coherent()

Thu, 06 Jan 2022 21:54:19 +0000

scsi: message: fusion: mptbase: Use dma_alloc_coherent()In [1], Christoph Hellwig has proposed to remove the wrappers ininclude/linux/pci-dma-compat.h.Some reasons why this API should be removed have been given by JuliaLawall in [2].In all these places where some memory is allocated GFP_KERNEL can be usedbecause they already call mpt_config() which has an explicit might_sleep().[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/Link: https://lore.kernel.org/r/3bea2452deb8cc8be65982e87efa4c6861caa01c.1641500561.git.christophe.jaillet@wanadoo.frReviewed-by: Christoph Hellwig Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

2d506072 - scsi: message: fusion: Use dma_alloc_coherent() in mpt_alloc_fw_memory()

Thu, 06 Jan 2022 21:54:13 +0000

scsi: message: fusion: Use dma_alloc_coherent() in mpt_alloc_fw_memory()In [1], Christoph Hellwig has proposed to remove the wrappers ininclude/linux/pci-dma-compat.h.Some reasons why this API should be removed have been given by Julia Lawallin [2].mpt_alloc_fw_memory() should still use GFP_ATOMIC, because it can be calledfrom mpt_do_upload() which might sleep.[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/Link: https://lore.kernel.org/r/db3db9db219005b75659561d08117d312d0cfb13.1641500561.git.christophe.jaillet@wanadoo.frReviewed-by: Christoph Hellwig Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

b114dda6 - scsi: message: fusion: Remove usage of the deprecated "pci-dma-compat.h" API

Thu, 06 Jan 2022 21:54:05 +0000

scsi: message: fusion: Remove usage of the deprecated "pci-dma-compat.h" APIIn [1], Christoph Hellwig has proposed to remove the wrappers ininclude/linux/pci-dma-compat.h.Some reasons why this API should be removed have been given by Julia Lawallin [2].A coccinelle script has been used to perform the needed transformation. Itcan be found in [3].In this patch, all functions but pci_alloc_consistent() are handled.pci_alloc_consistent() needs more attention and explanation.[1]: https://lore.kernel.org/kernel-janitors/20200421081257.GA131897@infradead.org/[2]: https://lore.kernel.org/kernel-janitors/alpine.DEB.2.22.394.2007120902170.2424@hadrien/[3]: https://lore.kernel.org/kernel-janitors/20200716192821.321233-1-christophe.jaillet@wanadoo.fr/Link: https://lore.kernel.org/r/e38e897fbd3314718315b0e357c824e3f01775d6.1641500561.git.christophe.jaillet@wanadoo.frReviewed-by: Christoph Hellwig Signed-off-by: Christophe JAILLET Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

c27fd25d - scsi: mptfusion: Remove redundant variable r

Sun, 05 Dec 2021 22:59:01 +0000

scsi: mptfusion: Remove redundant variable rVariable r is being assigned a value that is never read. The assignment isredundant and so is the variable, so remove these. Remove unnecessary the{} braces in the if statement too.Link: https://lore.kernel.org/r/20211205225901.54362-1-colin.i.king@gmail.comSigned-off-by: Colin Ian King Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

a534ff3f - scsi: message: fusion: Remove unused mpt_pci driver .probe() 'id' parameter

Mon, 04 Oct 2021 12:59:32 +0000

scsi: message: fusion: Remove unused mpt_pci driver .probe() 'id' parameterThe only two drivers don't make use of the id parameter, so drop it. Thisis a step toward removing pci_dev->driver.Link: https://lore.kernel.org/r/20211004125935.2300113-9-u.kleine-koenig@pengutronix.deSigned-off-by: Uwe Kleine-König Signed-off-by: Bjorn Helgaas Reviewed-by: Christoph Hellwig Acked-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

96f3903c - scsi: message: fusion: Remove redundant assignment to rc

Wed, 12 May 2021 10:12:07 +0000

scsi: message: fusion: Remove redundant assignment to rcVariable rc is set to '-1', but this value is never read as it isoverwritten later. Hence it is a redundant assignment and can be removed.Clean up the following clang-analyzer warning:drivers/message/fusion/mptbase.c:6996:2: warning: Value stored to 'rc'is never read [clang-analyzer-deadcode.DeadStores].Link: https://lore.kernel.org/r/1620814327-25427-1-git-send-email-jiapeng.chong@linux.alibaba.comReported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

c436b41a - scsi: message: fusion: Remove unused local variable 'status'

Thu, 08 Apr 2021 09:06:20 +0000

scsi: message: fusion: Remove unused local variable 'status'Fix the following gcc warning:drivers/message/fusion/mptbase.c:3087:9: warning: variable ‘status’ setbut not used [-Wunused-but-set-variable].Link: https://lore.kernel.org/r/1617872780-126448-1-git-send-email-jiapeng.chong@linux.alibaba.comReported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

690209d5 - scsi: message: fusion: Remove unnecessary cast

Fri, 12 Mar 2021 02:18:03 +0000

scsi: message: fusion: Remove unnecessary castFix the following coccicheck warning:WARNING: casting value returned by memory allocation function is useless.Link: https://lore.kernel.org/r/1615515483-777-1-git-send-email-wangqing@vivo.comSigned-off-by: Wang Qing Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

b8a51443 - scsi: message: fusion: Remove in_interrupt() usage in mpt_config()

Thu, 26 Nov 2020 13:29:51 +0000

scsi: message: fusion: Remove in_interrupt() usage in mpt_config()in_interrupt() is referenced all over the place in these drivers. Most ofthese references are comments which are outdated and wrong.Aside of that in_interrupt() is deprecated as it does not provide what thename suggests. It covers more than hard/soft interrupt servicing contextand is semantically ill defined.>From reading the mpt_config() code and the history this is clearly a debugmechanism and should probably be replaced by might_sleep() or completelyremoved because such checks are already in the subsequent functions.Remove the in_interrupt() references and replace the usage in mpt_config()with might_sleep().Link: https://lore.kernel.org/r/20201126132952.2287996-14-bigeasy@linutronix.deCc: Sathya Prakash Cc: Sreekanth Reddy Cc: Suganath Prabu Subramani Cc: MPT-FusionLinux.pdl@broadcom.comReviewed-by: Daniel Wagner Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

b9dd44fd - scsi: message: fusion: Remove unneeded break

Mon, 19 Oct 2020 19:19:50 +0000

scsi: message: fusion: Remove unneeded breakA break is not needed if it is preceded by a return.Link: https://lore.kernel.org/r/20201019191950.10244-1-trix@redhat.comSigned-off-by: Tom Rix Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

df561f66 - treewide: Use fallthrough pseudo-keyword

Sun, 23 Aug 2020 22:36:59 +0000

treewide: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva List of files: /linux-6.15/drivers/message/fusion/mptbase.c

311950f8 - scsi: mptfusion: Don't use GFP_ATOMIC for larger DMA allocations

Wed, 24 Jun 2020 16:57:24 +0000

scsi: mptfusion: Don't use GFP_ATOMIC for larger DMA allocationsThe mpt fusion driver still uses the legacy PCI DMA API which hardcodesatomic allocations. This caused the driver to fail to load on some powerpcVMs with incoherent DMA and small memory sizes. Switch to use the modernDMA API and sleeping allocations for large allocations instead. This isnot a full cleanup of the PCI DMA API usage yet, but just enough to fix theregression caused by reducing the default atomic pool size.Link: https://lore.kernel.org/r/20200624165724.1818496-1-hch@lst.deFixes: 3ee06a6d532f ("dma-pool: fix too large DMA pools on medium memory size systems")Reported-by: Guenter Roeck Tested-by: Guenter Roeck Signed-off-by: Christoph Hellwig Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

4e2dec66 - scsi: docs: fusion: get rid of a doc build warning

Wed, 08 Apr 2020 15:46:15 +0000

scsi: docs: fusion: get rid of a doc build warningUse a table for the enum list, to avoid this warning: ./drivers/message/fusion/mptbase.c:5058: WARNING: Definition list ends without a blank line; unexpected unindent.Link: https://lore.kernel.org/r/9ca049c2d25689c56448afddf4f0d1e619fa87f7.1586359676.git.mchehab+huawei@kernel.orgSigned-off-by: Mauro Carvalho Chehab Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

b3b2a9f6 - scsi: message: fusion: Use kmemdup instead of memcpy and kmalloc

Wed, 22 May 2019 16:01:49 +0000

scsi: message: fusion: Use kmemdup instead of memcpy and kmallocReplace kmalloc + memcpy with kmemdup.This was reported by coccinelle.Signed-off-by: Bharath Vedartham Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

b47b8618 - scsi: mptfusion: mark expected switch fall-through

Mon, 11 Feb 2019 22:45:30 +0000

scsi: mptfusion: mark expected switch fall-throughIn preparation to enabling -Wimplicit-fallthrough, mark switch cases wherewe are expecting to fall through.This patch fixes the following warning:drivers/message/fusion/mptbase.c: In function mptbase_reply :drivers/message/fusion/mptbase.c:643:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (event != MPI_EVENT_EVENT_CHANGE) ^drivers/message/fusion/mptbase.c:646:2: note: here case MPI_FUNCTION_CONFIG: ^~~~Warning level 3 was used: -Wimplicit-fallthrough=3Notice that, in this particular case, the code comment is modified inaccordance with what GCC is expecting to find.This patch is part of the ongoing efforts to enable-Wimplicit-fallthrough.Signed-off-by: Gustavo A. R. Silva Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c

90ded4e2 - scsi: mptfusion: Remove unnecessary parentheses

Sat, 15 Sep 2018 06:36:45 +0000

scsi: mptfusion: Remove unnecessary parenthesesClang warns when multiple pairs of parentheses are used for a singleconditional statement.drivers/message/fusion/mptbase.c:338:11: warning: equality comparisonwith extraneous parentheses [-Wparentheses-equality] if ((ioc == NULL)) ~~~~^~~~~~~drivers/message/fusion/mptbase.c:338:11: note: remove extraneousparentheses around the comparison to silence this warning if ((ioc == NULL)) ~ ^ ~drivers/message/fusion/mptbase.c:338:11: note: use '=' to turn thisequality comparison into an assignment if ((ioc == NULL)) ^~ =drivers/message/fusion/mptbase.c:342:12: warning: equality comparisonwith extraneous parentheses [-Wparentheses-equality] if ((pdev == NULL)) ~~~~~^~~~~~~drivers/message/fusion/mptbase.c:342:12: note: remove extraneousparentheses around the comparison to silence this warning if ((pdev == NULL)) ~ ^ ~drivers/message/fusion/mptbase.c:342:12: note: use '=' to turn thisequality comparison into an assignment if ((pdev == NULL)) ^~ =2 warnings generated.Remove them and while we're at it, simplify the NULL checks as '!var' isused more than 'var == NULL'.Reported-by: Nick Desaulniers Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers Signed-off-by: Martin K. Petersen List of files: /linux-6.15/drivers/message/fusion/mptbase.c