Changes in dm-table.c

f1aff4bc - dm: fix copying after src array boundaries

Tue, 06 May 2025 11:31:50 +0000

dm: fix copying after src array boundariesThe blammed commit copied to argv the size of the reallocated argv,instead of the size of the old_argv, thus reading and copying frompast the old_argv allocated memory.Following BUG_ON was hit:[ 3.038929][ T1] kernel BUG at lib/string_helpers.c:1040![ 3.039147][ T1] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP...[ 3.056489][ T1] Call trace:[ 3.056591][ T1] __fortify_panic+0x10/0x18 (P)[ 3.056773][ T1] dm_split_args+0x20c/0x210[ 3.056942][ T1] dm_table_add_target+0x13c/0x360[ 3.057132][ T1] table_load+0x110/0x3ac[ 3.057292][ T1] dm_ctl_ioctl+0x424/0x56c[ 3.057457][ T1] __arm64_sys_ioctl+0xa8/0xec[ 3.057634][ T1] invoke_syscall+0x58/0x10c[ 3.057804][ T1] el0_svc_common+0xa8/0xdc[ 3.057970][ T1] do_el0_svc+0x1c/0x28[ 3.058123][ T1] el0_svc+0x50/0xac[ 3.058266][ T1] el0t_64_sync_handler+0x60/0xc4[ 3.058452][ T1] el0t_64_sync+0x1b0/0x1b4[ 3.058620][ T1] Code: f800865e a9bf7bfd 910003fd 941f48aa (d4210000)[ 3.058897][ T1] ---[ end trace 0000000000000000 ]---[ 3.059083][ T1] Kernel panic - not syncing: Oops - BUG: Fatal exceptionFix it by copying the size of src, and not the size of dst, as it was.Fixes: 5a2a6c428190 ("dm: always update the array size in realloc_argv on success")Cc: stable@vger.kernel.orgSigned-off-by: Tudor Ambarus Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

650266ac - dm: add missing unlock on in dm_keyslot_evict()

Wed, 30 Apr 2025 08:05:54 +0000

dm: add missing unlock on in dm_keyslot_evict()We need to call dm_put_live_table() even if dm_get_live_table() returnsNULL.Fixes: 9355a9eb21a5 ("dm: support key eviction from keyslot managers of underlying devices")Cc: stable@vger.kernel.org # v5.12+Signed-off-by: Dan Carpenter Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

5a2a6c42 - dm: always update the array size in realloc_argv on success

Tue, 15 Apr 2025 04:17:16 +0000

dm: always update the array size in realloc_argv on successrealloc_argv() was only updating the array size if it was called withold_argv already allocated. The first time it was called to create anargv array, it would allocate the array but return the array size aszero. dm_split_args() would think that it couldn't store any argumentsin the array and would call realloc_argv() again, causing it toreallocate the initial slots (this time using GPF_KERNEL) and finallyreturn a size. Aside from being wasteful, this could cause deadlocks ontargets that need to process messages without starting new IO. Instead,realloc_argv should always update the allocated array size on success.Fixes: a0651926553c ("dm table: don't copy from a NULL pointer in realloc_argv()")Cc: stable@vger.kernel.orgSigned-off-by: Benjamin Marzinski Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

7bd47be1 - dm table: Fix W=1 build warning when mempool_needs_integrity is unused

Mon, 07 Apr 2025 07:21:26 +0000

dm table: Fix W=1 build warning when mempool_needs_integrity is unusedThe mempool_needs_integrity is unused. This, in particular, preventskernel builds with Clang, `make W=1` and CONFIG_WERROR=y:drivers/md/dm-table.c:1052:7: error: variable 'mempool_needs_integrity' set but not used [-Werror,-Wunused-but-set-variable] 1052 | bool mempool_needs_integrity = t->integrity_supported; | ^Fix this by removing the leftover.Fixes: 105ca2a2c2ff ("block: split struct bio_integrity_payload")Signed-off-by: Andy Shevchenko Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

45fc7285 - dm: restrict dm device size to 2^63-512 bytes

Fri, 14 Mar 2025 12:51:32 +0000

dm: restrict dm device size to 2^63-512 bytesThe devices with size >= 2^63 bytes can't be used reliably by userspacebecause the type off_t is a signed 64-bit integer.Therefore, we limit the maximum size of a device mapper device to2^63-512 bytes.Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

105ca2a2 - block: split struct bio_integrity_payload

Tue, 25 Feb 2025 15:44:33 +0000

block: split struct bio_integrity_payloadMany of the fields in struct bio_integrity_payload are only needed forthe default integrity buffer in the block layer, and the variablesized array at the end of the structure makes it very hard to embedinto caller allocated structures.Reduce struct bio_integrity_payload to the minimal structure needed incommon code and create two separate containing structures for theautomatically generated payload and the caller allocated payload.The latter is a simple wrapper for struct bio_integrity_payload andthe bvecs, while the former contains the additional fields moved outof struct bio_integrity_payload.Always use a dedicated mempool for automatic integrity metadatainstead of depending on bio_set that is submitter controlled and thusoften doesn't have the mempool initialized and stop using mempools forthe submitter buffers as they aren't in the NOIO I/O submission pathwhere we need to guarantee forward progress.Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Reviewed-by: Hannes Reinecke Tested-by: Anuj Gupta Reviewed-by: Anuj Gupta Reviewed-by: Kanchan Joshi Link: https://lore.kernel.org/r/20250225154449.422989-4-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

ebc41765 - blk-crypto: add basic hardware-wrapped key support

Tue, 04 Feb 2025 06:00:35 +0000

blk-crypto: add basic hardware-wrapped key supportTo prevent keys from being compromised if an attacker acquires readaccess to kernel memory, some inline encryption hardware can accept keyswhich are wrapped by a per-boot hardware-internal key. This avoidsneeding to keep the raw keys in kernel memory, without limiting thenumber of keys that can be used. Such hardware also supports deriving a"software secret" for cryptographic tasks that can't be handled byinline encryption; this is needed for fscrypt to work properly.To support this hardware, allow struct blk_crypto_key to represent ahardware-wrapped key as an alternative to a raw key, and make driversset flags in struct blk_crypto_profile to indicate which types of keysthey support. Also add the ->derive_sw_secret() low-level operation,which drivers supporting wrapped keys must implement.For more information, see the detailed documentation which this patchadds to Documentation/block/inline-encryption.rst.Signed-off-by: Eric Biggers Tested-by: Bartosz Golaszewski # sm8650Link: https://lore.kernel.org/r/20250204060041.409950-2-ebiggers@kernel.orgSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

3194e364 - dm-table: atomic writes support

Thu, 16 Jan 2025 17:02:56 +0000

dm-table: atomic writes supportSupport stacking atomic write limits for DM devices.All the pre-existing code in blk_stack_atomic_writes_limits() already takescare of finding the aggregrate limits from the bottom devices.Feature flag DM_TARGET_ATOMIC_WRITES is introduced so that atomic writescan be enabled on personalities selectively. This is to ensure that atomicwrites are only enabled when verified to be working properly (for aspecific personality). In addition, it just may not make sense to enableatomic writes on some personalities (so this flag also helps there).Signed-off-by: John Garry Reviewed-by: Mike Snitzer Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

ad926611 - dm: Remove unused dm_table_bio_based

Thu, 03 Oct 2024 01:15:51 +0000

dm: Remove unused dm_table_bio_baseddm_table_bio_based() is unused since commit29dec90a0f1d ("dm: fix bio_set allocation")Remove it.Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

61706974 - dm: introduce the target flag mempool_needs_integrity

Wed, 10 Jul 2024 18:53:12 +0000

dm: introduce the target flag mempool_needs_integrityThis commit introduces the dm target flag mempool_needs_integrity. Whenthe flag is set, device mapper will call bioset_integrity_create on it'sbio sets. The target can then call bio_integrity_alloc on the biosallocated from the table's mempool.Signed-off-by: Mikulas Patocka Signed-off-by: Mike Snitzer List of files: /linux-6.15/drivers/md/dm-table.c

a21f9edb - dm: factor out helper function from dm_get_device

Thu, 04 Jul 2024 14:17:15 +0000

dm: factor out helper function from dm_get_deviceFactor out a helper function, dm_devt_from_path(), from dm_get_device()for use in dm targets.Signed-off-by: Benjamin Marzinski Signed-off-by: Mikulas Patocka List of files: /linux-6.15/drivers/md/dm-table.c

aaa53168 - dm: optimize flushes

Tue, 28 May 2024 11:32:34 +0000

dm: optimize flushesDevice mapper sends flush bios to all the targets and the targets send itto the underlying device. That may be inefficient, for example if a tablecontains 10 linear targets pointing to the same physical device, thendevice mapper would send 10 flush bios to that device - despite the factthat only one bio would be sufficient.This commit optimizes the flush behavior. It introduces a per-targetvariable flush_bypasses_map - it is set when the target supports flushoptimization - currently, the dm-linear and dm-stripe targets support it.When all the targets in a table have flush_bypasses_map,flush_bypasses_map on the table is set. __send_empty_flush tests if thetable has flush_bypasses_map - and if it has, no flush bios are sent tothe targets via the "map" method and the list dm_table->devices isiterated and the flush bios are sent to each member of the list.Signed-off-by: Mikulas Patocka Reviewed-by: Mike Snitzer Suggested-by: Yang Yang List of files: /linux-6.15/drivers/md/dm-table.c

4cac3d3a - block: remove the discard_alignment flag

Wed, 19 Jun 2024 15:45:37 +0000

block: remove the discard_alignment flagqueue_limits.discard_alignment is never read except in the placeswhere it is stacked into another limit.Signed-off-by: Christoph Hellwig Reviewed-by: Martin K. Petersen Reviewed-by: Johannes Thumshirn Link: https://lore.kernel.org/r/20240619154623.450048-6-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

b1fc937a - block: move the zoned flag into the features field

Mon, 17 Jun 2024 06:04:49 +0000

block: move the zoned flag into the features fieldMove the zoned flags into the features field to reclaim a littlebit of space.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-23-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

8023e144 - block: move the poll flag to queue_limits

Mon, 17 Jun 2024 06:04:48 +0000

block: move the poll flag to queue_limitsMove the poll flag into the queue_limits feature field so that it canbe set atomically with the queue frozen.Stacking drivers are simplified in that they now can simply set theflag, and blk_stack_limits will clear it when the features is notsupported by any of the underlying devices.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-22-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

f467fee4 - block: move the dax flag to queue_limits

Mon, 17 Jun 2024 06:04:47 +0000

block: move the dax flag to queue_limitsMove the dax flag into the queue_limits feature field so that it can beset atomically with the queue frozen.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-21-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

f76af42f - block: move the nowait flag to queue_limits

Mon, 17 Jun 2024 06:04:46 +0000

block: move the nowait flag to queue_limitsMove the nowait flag into the queue_limits feature field so that it canbe set atomically with the queue frozen.Stacking drivers are simplified in that they now can simply set theflag, and blk_stack_limits will clear it when the features is notsupported by any of the underlying devices.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-20-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

1a02f3a7 - block: move the stable_writes flag to queue_limits

Mon, 17 Jun 2024 06:04:44 +0000

block: move the stable_writes flag to queue_limitsMove the stable_writes flag into the queue_limits feature field so thatit can be set atomically with the queue frozen.The flag is now inherited by blk_stack_limits, which greatly simplifiesthe code in dm, and fixed md which previously did not pass on the flagset on lower devices.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-18-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

cdb24979 - block: move the io_stat flag setting to queue_limits

Mon, 17 Jun 2024 06:04:43 +0000

block: move the io_stat flag setting to queue_limitsMove the io_stat flag into the queue_limits feature field so that it canbe set atomically with the queue frozen.Simplify md and dm to set the flag unconditionally instead of avoidingsetting a simple flag for cases where it already is set by other means,which is a bit pointless.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-17-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c

39a9f1c3 - block: move the add_random flag to queue_limits

Mon, 17 Jun 2024 06:04:42 +0000

block: move the add_random flag to queue_limitsMove the add_random flag into the queue_limits feature field so that itcan be set atomically with the queue frozen.Note that this also removes code from dm to clear the flag based onthe underlying devices, which can't be reached as dm devices willalways start out without the flag set.Signed-off-by: Christoph Hellwig Reviewed-by: Damien Le Moal Reviewed-by: Hannes Reinecke Link: https://lore.kernel.org/r/20240617060532.127975-16-hch@lst.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/dm-table.c