Changes in util.c

b4299560 - bcache: fix typo

Fri, 24 May 2024 15:29:44 +0000

bcache: fix typoReplace 'utiility' with 'utility'.Link: https://lkml.kernel.org/r/20240524152958.919343-3-visitorckw@gmail.comSigned-off-by: Kuan-Wei Chiu Reviewed-by: Ian Rogers Reviewed-by: Randy Dunlap Cc: Adrian Hunter Cc: Alexander Shishkin Cc: Arnaldo Carvalho de Melo Cc: Bagas Sanjaya Cc: Brian Foster Cc: Ching-Chun (Jim) Huang Cc: Coly Li Cc: Ingo Molnar Cc: Jiri Olsa Cc: Kent Overstreet Cc: Mark Rutland Cc: Matthew Sakai Cc: Namhyung Kim Cc: Peter Zijlstra Signed-off-by: Andrew Morton List of files: /linux-6.15/drivers/md/bcache/util.c

df561f66 - treewide: Use fallthrough pseudo-keyword

Sun, 23 Aug 2020 22:36:59 +0000

treewide: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva List of files: /linux-6.15/drivers/md/bcache/util.c

2e1f4f4d - bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()

Fri, 15 Feb 2019 11:13:18 +0000

bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages()bch_bio_alloc_pages() is always called on one new bio, so it is safeto access the bvec table directly. Given it is the only kind of thiscase, open code the bvec table access since bio_for_each_segment_all()will be changed to support for iterating over multipage bvec.Acked-by: Coly Li Reviewed-by: Omar Sandoval Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

d2359963 - bcache: use routines from lib/crc64.c for CRC64 calculation

Wed, 22 Aug 2018 04:57:15 +0000

bcache: use routines from lib/crc64.c for CRC64 calculationNow we have crc64 calculation in lib/crc64.c, it is unnecessary forbcache to use its own version. This patch changes bcache code to usecrc64 routines in lib/crc64.c.Link: http://lkml.kernel.org/r/20180718165545.1622-3-colyli@suse.deSigned-off-by: Coly Li Reviewed-by: Hannes Reinecke Reviewed-by: Andy Shevchenko Cc: Michael Lyle Cc: Kent Overstreet Cc: Thomas Gleixner Cc: Kate Stewart Cc: Randy Dunlap Cc: Eric Biggers Cc: Greg Kroah-Hartman Cc: Noah Massey Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/md/bcache/util.c

87418ef9 - bcache: add missing SPDX header

Sat, 11 Aug 2018 05:19:58 +0000

bcache: add missing SPDX headerThe SPDX header is missing fro closure.c, super.c and util.c, thispatch adds SPDX header for GPL-2.0 into these files.Signed-off-by: Coly Li Reviewed-by: Shenghui Wang Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

1fae7cf0 - bcache: style fix to add a blank line after declarations

Sat, 11 Aug 2018 05:19:45 +0000

bcache: style fix to add a blank line after declarationsSigned-off-by: Coly Li Reviewed-by: Shenghui Wang Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

ea8c5356 - bcache: set max writeback rate when I/O request is idle

Thu, 09 Aug 2018 07:48:49 +0000

bcache: set max writeback rate when I/O request is idleCommit b1092c9af9ed ("bcache: allow quick writeback when backing idle")allows the writeback rate to be faster if there is no I/O request on abcache device. It works well if there is only one bcache device attachedto the cache set. If there are many bcache devices attached to a cacheset, it may introduce performance regression because multiple fasterwriteback threads of the idle bcache devices will compete the btree levellocks with the bcache device who have I/O requests coming.This patch fixes the above issue by only permitting fast writebac whenall bcache devices attached on the cache set are idle. And if one of thebcache devices has new I/O request coming, minimized all writebackthroughput immediately and let PI controller __update_writeback_rate()to decide the upcoming writeback rate for each bcache device.Also when all bcache devices are idle, limited wrieback rate to a smallnumber is wast of thoughput, especially when backing devices are slowernon-rotation devices (e.g. SATA SSD). This patch sets a max writebackrate for each backing device if the whole cache set is idle. A fasterwriteback rate in idle time means new I/Os may have more available spacefor dirty data, and people may observe a better write performance then.Please note bcache may change its cache mode in run time, and this patchstill works if the cache mode is switched from writeback mode and thereis still dirty data on cache.Fixes: Commit b1092c9af9ed ("bcache: allow quick writeback when backing idle")Cc: stable@vger.kernel.org #4.16+Signed-off-by: Coly Li Tested-by: Kai Krakow Tested-by: Stefan Priebe Cc: Michael Lyle Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

ecb37ce9 - bcache: Move couple of functions to sysfs.c

Mon, 28 May 2018 07:37:43 +0000

bcache: Move couple of functions to sysfs.cThere is couple of functions that are used exclusively in sysfs.c.Move it to there and make them static.Besides above, it will allow further clean up.No functional change intended.Signed-off-by: Andy Shevchenko Signed-off-by: Coly Li Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

47344e33 - bcache: Fix kernel-doc warnings

Mon, 19 Mar 2018 00:36:29 +0000

bcache: Fix kernel-doc warningsAvoid that building with W=1 triggers warnings about the kernel-docheaders.Signed-off-by: Bart Van Assche Reviewed-by: Michael Lyle Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

9dfbdec7 - bcache: Annotate switch fall-through

Mon, 19 Mar 2018 00:36:28 +0000

bcache: Annotate switch fall-throughThis patch avoids that building with W=1 triggers complaints aboutswitch fall-throughs.Signed-off-by: Bart Van Assche Reviewed-by: Michael Lyle Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

25d8be77 - block: move bio_alloc_pages() to bcache

Mon, 18 Dec 2017 12:22:10 +0000

block: move bio_alloc_pages() to bcachebcache is the only user of bio_alloc_pages(), so move this function intobcache, and avoid it being misused in the future.Also rename it to bch_bio_allo_pages() since it is bcache only.Signed-off-by: Ming Lei Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

c2421edf - bcache: comment on direct access to bvec table

Mon, 18 Dec 2017 12:22:09 +0000

bcache: comment on direct access to bvec tableAll direct access to bvec table are safe even after multipage bvec issupported.Cc: linux-bcache@vger.kernel.orgAcked-by: Coly Li Signed-off-by: Ming Lei Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

9ce762e8 - bcache: writeback rate clamping: make 32 bit safe

Mon, 16 Oct 2017 17:34:47 +0000

bcache: writeback rate clamping: make 32 bit safeSorry this got through to linux-block, was detected by the kbuilds testrobot. NSEC_PER_SEC is a long constant; 2.5 * 10^9 doesn't fit in asigned long constant.Fixes: e41166c5c44e ("bcache: writeback rate shouldn't artifically clamp")Reviewed-by: Coly Li Signed-off-by: Michael Lyle Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

ae82ddbf - bcache: smooth writeback rate control

Fri, 13 Oct 2017 23:35:37 +0000

bcache: smooth writeback rate controlThis works in conjunction with the new PI controller. Currently, inreal-world workloads, the rate controller attempts to write back 1sector per second. In practice, these minimum-rate writebacks arebetween 4k and 60k in test scenarios, since bcache aggregates andattempts to do contiguous writes and because filesystems on top ofbcachefs typically write 4k or more.Previously, bcache used to guarantee to write at least once per second.This means that the actual writeback rate would exceed the configuredamount by a factor of 8-120 or more.This patch adjusts to be willing to sleep up to 2.5 seconds, and totarget writing 4k/second. On the smallest writes, it will sleep 1second like before, but many times it will sleep longer and load thebacking device less. This keeps the loading on the cache and backingdevice related to writeback more consistent when writing back at lowrates.Signed-off-by: Michael Lyle Reviewed-by: Coly Li Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

9276717b - bcache: fix bch_hprint crash and improve output

Wed, 06 Sep 2017 06:26:02 +0000

bcache: fix bch_hprint crash and improve outputMost importantly, solve a crash where %llu was used to format signednumbers. This would cause a buffer overflow when reading sysfswriteback_rate_debug, as only 20 bytes were allocated for this and%llu writes 20 characters plus a null.Always use the units mechanism rather than having different outputpaths for simplicity.Also, correct problems with display output where 1.10 was a largernumber than 1.09, by multiplying by 10 and then dividing by 1024 insteadof dividing by 100. (Remainders of >= 1000 would print as .10).Minor changes: Always display the decimal point instead of trying toomit it based on number of digits shown. Decide what units to usebased on 1000 as a threshold, not 1024 (in other words, always printat most 3 digits before the decimal point).Signed-off-by: Michael Lyle Reported-by: Dmitry Yu Okunev Acked-by: Kent Overstreet Reviewed-by: Coly Li Cc: stable@vger.kernel.orgSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/util.c

e6017571 - sched/headers: Prepare for new header dependencies before moving code to

Wed, 01 Feb 2017 15:36:40 +0000

sched/headers: Prepare for new header dependencies before moving code to We are going to split out of , whichwill have to be picked up from other headers and .c files.Create a trivial placeholder file that justmaps to to make this patch obviously correct andbisectable.Include the new header in the files that are going to need it.Acked-by: Linus Torvalds Cc: Mike Galbraith Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.orgSigned-off-by: Ingo Molnar List of files: /linux-6.15/drivers/md/bcache/util.c

93bbf583 - md: more open-coded offset_in_page()

Sat, 02 Jan 2016 18:30:54 +0000

md: more open-coded offset_in_page()Signed-off-by: Al Viro List of files: /linux-6.15/drivers/md/bcache/util.c

16749c23 - bcache: New writeback PD controller

Mon, 11 Nov 2013 21:58:34 +0000

bcache: New writeback PD controllerThe old writeback PD controller could get into states where it had throttled allthe way down and take way too long to recover - it was too complicated to reallyunderstand what it was doing.This rewrites a good chunk of it to hopefully be simpler and make more sense,and it also pays more attention to units which should make the behaviour a biteasier to understand.Signed-off-by: Kent Overstreet List of files: /linux-6.15/drivers/md/bcache/util.c

4f024f37 - block: Abstract out bvec iterator

Fri, 11 Oct 2013 22:44:27 +0000

block: Abstract out bvec iteratorImmutable biovecs are going to require an explicit iterator. Toimplement immutable bvecs, a later patch is going to add a bi_bvec_donemember to this struct; for now, this patch effectively just renamesthings.Signed-off-by: Kent Overstreet Cc: Jens Axboe Cc: Geert Uytterhoeven Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "Ed L. Cashin" Cc: Nick Piggin Cc: Lars Ellenberg Cc: Jiri Kosina Cc: Matthew Wilcox Cc: Geoff Levand Cc: Yehuda Sadeh Cc: Sage Weil Cc: Alex Elder Cc: ceph-devel@vger.kernel.orgCc: Joshua Morris Cc: Philip Kelleher Cc: Rusty Russell Cc: "Michael S. Tsirkin" Cc: Konrad Rzeszutek Wilk Cc: Jeremy Fitzhardinge Cc: Neil Brown Cc: Alasdair Kergon Cc: Mike Snitzer Cc: dm-devel@redhat.comCc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux390@de.ibm.comCc: Boaz Harrosh Cc: Benny Halevy Cc: "James E.J. Bottomley" Cc: Greg Kroah-Hartman Cc: "Nicholas A. Bellinger" Cc: Alexander Viro Cc: Chris Mason Cc: "Theodore Ts'o" Cc: Andreas Dilger Cc: Jaegeuk Kim Cc: Steven Whitehouse Cc: Dave Kleikamp Cc: Joern Engel Cc: Prasad Joshi Cc: Trond Myklebust Cc: KONISHI Ryusuke Cc: Mark Fasheh Cc: Joel Becker Cc: Ben Myers Cc: xfs@oss.sgi.comCc: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Len Brown Cc: Pavel Machek Cc: "Rafael J. Wysocki" Cc: Herton Ronaldo Krzesinski Cc: Ben Hutchings Cc: Andrew Morton Cc: Guo Chao Cc: Tejun Heo Cc: Asai Thambi S P Cc: Selvan Mani Cc: Sam Bradshaw Cc: Wei Yongjun Cc: "Roger Pau Monné" Cc: Jan Beulich Cc: Stefano Stabellini Cc: Ian Campbell Cc: Sebastian Ott Cc: Christian Borntraeger Cc: Minchan Kim Cc: Jiang Liu Cc: Nitin Gupta Cc: Jerome Marchand Cc: Joe Perches Cc: Peng Tao Cc: Andy Adamson Cc: fanchaoting Cc: Jie Liu Cc: Sunil Mushran Cc: "Martin K. Petersen" Cc: Namjae Jeon Cc: Pankaj Kumar Cc: Dan Magenheimer Cc: Mel Gorman 6 List of files: /linux-6.15/drivers/md/bcache/util.c

65d22e91 - bcache: Move spinlock into struct time_stats

Wed, 31 Jul 2013 07:03:54 +0000

bcache: Move spinlock into struct time_statsMinor cleanup.Signed-off-by: Kent Overstreet List of files: /linux-6.15/drivers/md/bcache/util.c