Changes in features.h

cf2197ca - bcache: move uapi header bcache.h to bcache code directory

Fri, 29 Oct 2021 06:09:29 +0000

bcache: move uapi header bcache.h to bcache code directoryThe header file include/uapi/linux/bcache.h is not really a user spaceAPI heaer. This file defines the ondisk format of bcache internal metadata but no one includes it from user space, bcache-tools has its owncopy of this header with minor modification.Therefore, this patch moves include/uapi/linux/bcache.h to bcache codedirectory as drivers/md/bcache/bcache_ondisk.h.Suggested-by: Arnd Bergmann Suggested-by: Christoph Hellwig Signed-off-by: Coly Li Link: https://lore.kernel.org/r/20211029060930.119923-2-colyli@suse.deSigned-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

0df28cad - bcache: only check feature sets when sb->version >= BCACHE_SB_VERSION_CDEV_WITH_FEATURES

Thu, 28 Jan 2021 10:48:47 +0000

bcache: only check feature sets when sb->version >= BCACHE_SB_VERSION_CDEV_WITH_FEATURESFor super block version < BCACHE_SB_VERSION_CDEV_WITH_FEATURES, itdoesn't make sense to check the feature sets. This patch checkssuper block version in bch_has_feature_* routines, if the versiondoesn't have feature sets yet, returns 0 (false) to the caller.Fixes: 5342fd425502 ("bcache: set bcache device into read-only mode for BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET")Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")Cc: stable@vger.kernel.org # 5.9+Reported-and-tested-by: Bockholdt Arne Signed-off-by: Coly Li Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

b16671e8 - bcache: introduce BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE for large bucket

Mon, 04 Jan 2021 07:41:21 +0000

bcache: introduce BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE for large bucketWhen large bucket feature was added, BCH_FEATURE_INCOMPAT_LARGE_BUCKETwas introduced into the incompat feature set. It used bucket_size_hi(which was added at the tail of struct cache_sb_disk) to extend current16bit bucket size to 32bit with existing bucket_size in structcache_sb_disk.This is not a good idea, there are two obvious problems,- Bucket size is always value power of 2, if store log2(bucket size) in existing bucket_size of struct cache_sb_disk, it is unnecessary to add bucket_size_hi.- Macro csum_set() assumes d[SB_JOURNAL_BUCKETS] is the last member in struct cache_sb_disk, bucket_size_hi was added after d[] which makes csum_set calculate an unexpected super block checksum.To fix the above problems, this patch introduces a new incompat featurebit BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE, when this bit is set, itmeans bucket_size in struct cache_sb_disk stores the order of power-of-2bucket size value. When user specifies a bucket size larger than 32768sectors, BCH_FEATURE_INCOMPAT_LOG_LARGE_BUCKET_SIZE will be set toincompat feature set, and bucket_size stores log2(bucket size) morethan store the real bucket size value.The obsoleted BCH_FEATURE_INCOMPAT_LARGE_BUCKET won't be used anymore,it is renamed to BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET and still onlyrecognized by kernel driver for legacy compatible purpose. The previousbucket_size_hi is renmaed to obso_bucket_size_hi in struct cache_sb_diskand not used in bcache-tools anymore.For cache device created with BCH_FEATURE_INCOMPAT_LARGE_BUCKET feature,bcache-tools and kernel driver still recognize the feature string anddisplay it as "obso_large_bucket".With this change, the unnecessary extra space extend of bcache on-disksuper block can be avoided, and csum_set() may generate expected checksum as well.Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")Signed-off-by: Coly Li Cc: stable@vger.kernel.org # 5.9+Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

1dfc0686 - bcache: check unsupported feature sets for bcache register

Mon, 04 Jan 2021 07:41:20 +0000

bcache: check unsupported feature sets for bcache registerThis patch adds the check for features which is incompatible forcurrent supported feature sets.Now if the bcache device created by bcache-tools has features thatcurrent kernel doesn't support, read_super() will fail with errormessoage. E.g. if an unsupported incompatible feature detected,bcache register will fail with dmesg "bcache: register_bcache() error :Unsupported incompatible feature found".Fixes: d721a43ff69c ("bcache: increase super block version for cache device and backing device")Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")Signed-off-by: Coly Li Cc: stable@vger.kernel.org # 5.9+Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

f7b4943d - bcache: fix typo from SUUP to SUPP in features.h

Mon, 04 Jan 2021 07:41:19 +0000

bcache: fix typo from SUUP to SUPP in features.hThis patch fixes the following typos,from BCH_FEATURE_COMPAT_SUUP to BCH_FEATURE_COMPAT_SUPPfrom BCH_FEATURE_INCOMPAT_SUUP to BCH_FEATURE_INCOMPAT_SUPPfrom BCH_FEATURE_INCOMPAT_SUUP to BCH_FEATURE_RO_COMPAT_SUPPFixes: d721a43ff69c ("bcache: increase super block version for cache device and backing device")Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")Signed-off-by: Coly Li Cc: stable@vger.kernel.org # 5.9+Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

092bd54d - bcache: add sysfs file to display feature sets information of cache set

Sat, 25 Jul 2020 12:00:36 +0000

bcache: add sysfs file to display feature sets information of cache setThe following three sysfs files are created to display according featureset information of bcache: /sys/fs/bcache//internal/feature_compat /sys/fs/bcache//internal/feature_ro_compat /sys/fs/bcache//internal/feature_incompatis added by this patch, to display feature sets information of the cacheset.Now only an incompat feature 'large_bucket' added in bcache, the sysfsfile content is: [large_bucket]string large_bucket means the running bcache drive supports incompatfeature 'large_bucket', the wrapping [] means the 'large_bucket' featureis currently enabled on this cache set.This patch is ready to display compat and ro_compat features, in futureonce bcache code implements such feature sets, the according featurestrings will be displayed in their sysfs files too.Signed-off-by: Coly Li Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

ffa47032 - bcache: add bucket_size_hi into struct cache_sb_disk for large bucket

Sat, 25 Jul 2020 12:00:35 +0000

bcache: add bucket_size_hi into struct cache_sb_disk for large bucketThe large bucket feature is to extend bucket_size from 16bit to 32bit.When create cache device on zoned device (e.g. zoned NVMe SSD), makinga single bucket cover one or more zones of the zoned device is thesimplest way to support zoned device as cache by bcache.But current maximum bucket size is 16MB and a typical zone size of zoneddevice is 256MB, this is the major motiviation to extend bucket size toa larger bit width.This patch is the basic and first change to support large bucket size,the major changes it makes are,- Add BCH_FEATURE_INCOMPAT_LARGE_BUCKET for the large bucket feature, INCOMPAT means it introduces incompatible on-disk format change.- Add BCH_FEATURE_INCOMPAT_FUNCS(large_bucket, LARGE_BUCKET) routines.- Adds __le16 bucket_size_hi into struct cache_sb_disk at offset 0x8d0 for the on-disk super block format.- For the in-memory super block struct cache_sb, member bucket_size is extended from __u16 to __32.- Add get_bucket_size() to combine the bucket_size and bucket_size_hi from struct cache_sb_disk into an unsigned int value.Since we already have large bucket size helpers meta_bucket_pages(),meta_bucket_bytes() and alloc_meta_bucket_pages(), they make sure whenbucket size > 8MB, the memory allocation for bcache meta data bucketwon't fail no matter how large the bucket size extended. So these metadata buckets are handled properly when the bucket size width increasefrom 16bit to 32bit, we don't need to worry about them.Signed-off-by: Coly Li Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h

d721a43f - bcache: increase super block version for cache device and backing device

Sat, 25 Jul 2020 12:00:27 +0000

bcache: increase super block version for cache device and backing deviceThe new added super block version BCACHE_SB_VERSION_BDEV_WITH_FEATURES(5) BCACHE_SB_VERSION_CDEV_WITH_FEATURES value (6), is for the featureset bits.Devices have super block version equal to the new version will havethree new members for feature set bits in the on-disk super block, __le64 feature_compat; __le64 feature_incompat; __le64 feature_ro_compat;They are used for further new features which may introduce on-diskformat change, and avoid unncessary super block version increase.The very basic features handling code skeleton is also initialized inthis patch.Signed-off-by: Coly Li Reviewed-by: Hannes Reinecke Signed-off-by: Jens Axboe List of files: /linux-6.15/drivers/md/bcache/features.h