Changes in acecad.c

2960d4c8 - Input: tablet - use sizeof(*pointer) instead of sizeof(type)

Mon, 03 Jun 2024 04:30:48 +0000

Input: tablet - use sizeof(*pointer) instead of sizeof(type)It is preferred to use sizeof(*pointer) instead of sizeof(type)due to the type of the variable can change and one needs notchange the former (unlike the latter). This patch has no effecton runtime behavior.Signed-off-by: Erick Archer Link: https://lore.kernel.org/r/AS8PR02MB7237B05083487507CFAF96B08BFE2@AS8PR02MB7237.eurprd02.prod.outlook.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

2d09ac95 - input: drop empty comment blocks

Thu, 29 Sep 2022 19:11:36 +0000

input: drop empty comment blocksCommit 1a59d1b8e05e ("treewide: Replace GPLv2 boilerplate/reference withSPDX - rule 156") has left some empty comment blocks.Remove them to save a few lines of code.Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/26a2b905b259bfffaf2de5b26f2007b8606970ed.1664478665.git.christophe.jaillet@wanadoo.frSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

a9f08ad7 - Input: move from strlcpy with unused retval to strscpy

Thu, 18 Aug 2022 22:05:06 +0000

Input: move from strlcpy with unused retval to strscpyFollow the advice of the below link and prefer 'strscpy' in thissubsystem. Conversion is 1:1 because the return value is not used.Generated by a coccinelle script.Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20220818210022.6865-1-wsa+renesas@sang-engineering.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

948bf187 - Input: remove third argument of usb_maxpacket()

Thu, 17 Mar 2022 03:55:08 +0000

Input: remove third argument of usb_maxpacket()The third argument of usb_maxpacket(): in_out has been deprecatedbecause it could be derived from the second argument (e.g. usingusb_pipeout(pipe)).N.B. function usb_maxpacket() was made variadic to accommodate thetransition from the old prototype with three arguments to the new onewith only two arguments (so that no renaming is needed). The variadicargument is to be removed once all users of usb_maxpacket() getmigrated.CC: Ville Syrjala CC: Dmitry Torokhov CC: Henk Vergonet Signed-off-by: Vincent Mailhol Link: https://lore.kernel.org/r/20220317035514.6378-4-mailhol.vincent@wanadoo.frSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

1a59d1b8 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156

Mon, 27 May 2019 06:55:05 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version this program is distributed in the hope that it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more details you should have received a copy of the gnu general public license along with this program if not write to the free software foundation inc 59 temple place suite 330 boston ma 02111 1307 usaextracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-laterhas been chosen to replace the boilerplate/reference in 1334 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Richard Fontana Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190527070033.113240726@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

698c03b4 - Input: inline macros for MODULE_LICENSE, etc

Wed, 17 Jan 2018 00:56:54 +0000

Input: inline macros for MODULE_LICENSE, etcInline macro for MODULE_LICENSE to make the license information easy tofind, eg with grep. Inline the other module-related macros at the sametime.A simplified version of the semantic patch for the MODULE_LICENSEcase is as follows: (http://coccinelle.lip6.fr/)// @s@identifier i; expression e;@@@@declarer name MODULE_LICENSE;identifier s.i;expression s.e;@@MODULE_LICENSE(- i+ e );// Signed-off-by: Julia Lawall [dtor: added a couple of drivers missed by the script, removed a few unused DRIVER_VERSION macros]Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

9f1d1ea3 - Input: remove unneeded DRIVER_LICENSE #defines

Wed, 17 Jan 2018 00:36:48 +0000

Input: remove unneeded DRIVER_LICENSE #definesThere is no need to #define the license of the driver, just put it inthe MODULE_LICENSE() line directly as a text string.This allows tools that check that the module license matches the sourcecode license to work properly, as there is no need to unwind theunneeded dereference. For some of these drivers, the #define is just afew lines above the MODULE_LICENSE() line, which is extra pointless.Reported-by: Philippe Ombredanne Signed-off-by: Greg Kroah-Hartman Reviewed-by: Philippe Ombredanne Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

803088fa - Input: acecad - constify usb_device_idi and fix space before '[' error

Tue, 08 Aug 2017 02:44:49 +0000

Input: acecad - constify usb_device_idi and fix space before '[' errorusb_device_id are not supposed to change at runtime. All functionsworking with usb_device_id provided by work withconst usb_device_id. So mark the non-const structs as const.Fix checkpatch.pl error:ERROR: space prohibited before open square bracket '['.Signed-off-by: Arvind Yadav Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

7edf2c9c - Input: acecad - stop saving struct usb_device

Thu, 31 Mar 2016 17:59:41 +0000

Input: acecad - stop saving struct usb_deviceThe device can now easily be derived from the interface.Stop leaving a private copy.Signed-off-by: Oliver Neukum Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

bf9a9f8e - Input: delete non-required instances of include

Mon, 06 Jan 2014 18:27:05 +0000

Input: delete non-required instances of include None of these files are actually using any __init type directivesand hence don't need to include . Most are just aleft over from __devinit and __cpuinit removal, or simply due tocode getting copied from one driver to the next.Signed-off-by: Paul Gortmaker Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

334698d4 - USB: input: acecad.c: fix up dev_* messages

Fri, 04 May 2012 22:33:04 +0000

USB: input: acecad.c: fix up dev_* messagesPreviously I had made the struct device point to the input device, butafter talking with Dmitry, he said that the USB device would make moresense for this driver to point to. So converted it to use that instead.CC: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

eeba1ae1 - USB: acecad.c: remove dbg() usage

Wed, 02 May 2012 04:33:09 +0000

USB: acecad.c: remove dbg() usagedbg() was a very old USB-specific macro that should no longerbe used. This patch removes it from being used in the driverand uses dev_dbg() instead.CC: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

b30662c4 - USB: input: acecad.c: fix up dev_err() usage

Wed, 02 May 2012 00:56:51 +0000

USB: input: acecad.c: fix up dev_err() usageWe should always reference the input device for dev_err(), not the USBdevice. Fix up the places where I got this wrong.Reported-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

b59c82bd - USB: acecad.c: remove err() usage

Wed, 25 Apr 2012 21:48:34 +0000

USB: acecad.c: remove err() usageerr() was a very old USB-specific macro that I thought hadgone away. This patch removes it from being used in thedriver and uses dev_err() instead.CC: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

08642e7c - USB: convert drivers/input/* to use module_usb_driver()

Fri, 18 Nov 2011 17:48:31 +0000

USB: convert drivers/input/* to use module_usb_driver()This converts the drivers in drivers/input/* to use themodule_usb_driver() macro which makes the code smaller and a bitsimpler.Added bonus is that it removes some unneeded kernel log messages aboutdrivers loading and/or unloading.Cc: Dmitry Torokhov Cc: Ville Syrjala Cc: Henk Vergonet Cc: Alessandro Rubini Cc: Henrik Rydberg Cc: "Magnus Hörlin" Cc: Chris Moeller Cc: Christoph Fritz Cc: Lucas De Marchi Cc: Jesper Juhl Cc: Edwin van Vliet Cc: Ping Cheng Cc: Eduard Hasenleithner Cc: Alexander Strakh Cc: Glenn Sommer Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

a4503199 - Input: acecad - fix a memory leak in usb_acecad_probe error path

Thu, 11 Nov 2010 07:05:07 +0000

Input: acecad - fix a memory leak in usb_acecad_probe error pathAdd a missing usb_free_urb() in usb_acecad_probe() error path.Signed-off-by: Axel Lin Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

997ea58e - USB: rename usb_buffer_alloc() and usb_buffer_free() users

Mon, 12 Apr 2010 11:17:25 +0000

USB: rename usb_buffer_alloc() and usb_buffer_free() usersFor more clearance what the functions actually do, usb_buffer_alloc() is renamed to usb_alloc_coherent() usb_buffer_free() is renamed to usb_free_coherent()They should only be used in code which really needs DMA coherency.All call sites have been changed accordingly, except for stagingdrivers.Signed-off-by: Daniel Mack Cc: Alan Stern Cc: Pedro Ribeiro Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/tablet/acecad.c

893d1cdd - Input: acecad - don't advertise mouse events

Wed, 21 Apr 2010 05:30:25 +0000

Input: acecad - don't advertise mouse eventsThe device does not emit events for left/right/middle mouse buttonsso it should not mark them as supported in capabilities bitmaps.Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

b426571c - Input: acecad - fix some formatting issues

Wed, 21 Apr 2010 05:30:22 +0000

Input: acecad - fix some formatting issuesAlso switch to using input_set_abd_params() helper.Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c

5492f6f8 - Input: acecad - simplify usb_acecad_disconnect()

Wed, 21 Apr 2010 05:20:37 +0000

Input: acecad - simplify usb_acecad_disconnect()There is no need to check whether acecad structure is attached to theinterface; if it isn't and we are called we have much bigger problems.Also no need to call usb_kill_urb() in usb_acecad_disconnect() sinceit is being called in usb_acecad_close().Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/tablet/acecad.c