Changes in hyperv-keyboard.c

79d01971 - Input: hyperv-keyboard - use guard notation when acquiring spinlock

Thu, 05 Sep 2024 04:17:16 +0000

Input: hyperv-keyboard - use guard notation when acquiring spinlockUsing guard notation makes the code more compact and error handlingmore robust by ensuring that locks are released in all code pathswhen control leaves critical section.Link: https://lore.kernel.org/r/20240905041732.2034348-12-dmitry.torokhov@gmail.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

06b449d7 - Input: serio - use sizeof(*pointer) instead of sizeof(type)

Fri, 07 Jun 2024 17:04:23 +0000

Input: serio - use sizeof(*pointer) instead of sizeof(type)It is preferred to use sizeof(*pointer) instead of sizeof(type)due to the type of the variable can change and one needs notchange the former (unlike the latter). This patch has no effecton runtime behavior.Signed-off-by: Erick Archer Link: https://lore.kernel.org/r/AS8PR02MB7237D3D898CCC9C50C18DE078BFB2@AS8PR02MB7237.eurprd02.prod.outlook.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

96ec2939 - Drivers: hv: Make remove callback of hyperv driver void returned

Thu, 05 Jan 2023 14:51:23 +0000

Drivers: hv: Make remove callback of hyperv driver void returnedSince commit fc7a6209d571 ("bus: Make remove callback returnvoid") forces bus_type::remove be void-returned, it doesn'tmake much sense for any bus based driver implementing removecallbalk to return non-void to its caller.As such, change the remove function for Hyper-V VMBus baseddrivers to return void.Signed-off-by: Dawei Li Link: https://lore.kernel.org/r/TYCP286MB2323A93C55526E4DF239D3ACCAFA9@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COMSigned-off-by: Wei Liu List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

a9f08ad7 - Input: move from strlcpy with unused retval to strscpy

Thu, 18 Aug 2022 22:05:06 +0000

Input: move from strlcpy with unused retval to strscpyFollow the advice of the below link and prefer 'strscpy' in thissubsystem. Conversion is 1:1 because the return value is not used.Generated by a coccinelle script.Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20220818210022.6865-1-wsa+renesas@sang-engineering.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

50597970 - Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizes

Wed, 16 Sep 2020 03:48:14 +0000

Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizesFor a Hyper-V vmbus, the size of the ringbuffer has two requirements:1) it has to take one PAGE_SIZE for the header2) it has to be PAGE_SIZE aligned so that double-mapping can workVMBUS_RING_SIZE() could calculate a correct ringbuffer size whichfulfills both requirements, therefore use it to make sure vmbus workwhen PAGE_SIZE != HV_HYP_PAGE_SIZE (4K).Note that since the argument for VMBUS_RING_SIZE() is the size ofpayload (data part), so it will be minus 4k (the size of header whenPAGE_SIZE = 4k) than the original value to keep the ringbuffer totalsize unchanged when PAGE_SIZE = 4k.Signed-off-by: Boqun Feng Cc: Michael Kelley Cc: Dmitry Torokhov Acked-by: Dmitry Torokhov Reviewed-by: Michael Kelley Link: https://lore.kernel.org/r/20200916034817.30282-9-boqun.feng@gmail.comSigned-off-by: Wei Liu List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

e2379b30 - Input: hyperv-keyboard: Add the support of hibernation

Mon, 06 Jan 2020 22:40:44 +0000

Input: hyperv-keyboard: Add the support of hibernationAdd suspend() and resume() functions so the Hyper-V virtual keyboardcan participate in VM hibernation.Note that the keyboard is a "wakeup" device that could abort an in-progresshibernation if there is keyboard event. No attempt is made to suppress thisbehavior. If desired, a sysadmin can disable the keyboard as a wakeup deviceusing standard mechanisms such as:echo disabled > /sys/bus/vmbus/drivers/hyperv_keyboard/XXX/power/wakeup(where XXX is the device's GUID)Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui Signed-off-by: Sasha Levin List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

d09bc836 - Input: hyperv-keyboard: Use in-place iterator API in the channel callback

Tue, 20 Aug 2019 03:01:23 +0000

Input: hyperv-keyboard: Use in-place iterator API in the channel callbackSimplify the ring buffer handling with the in-place API.Also avoid the dynamic allocation and the memory leak in the channelcallback function.Signed-off-by: Dexuan Cui Acked-by: Dmitry Torokhov Signed-off-by: Sasha Levin List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

88f28e95 - Input: hyperv-keyboard - remove dependencies on PAGE_SIZE for ring buffer

Sun, 14 Jul 2019 23:27:18 +0000

Input: hyperv-keyboard - remove dependencies on PAGE_SIZE for ring bufferDefine the ring buffer size as a constant expression because it shouldnot depend on the guest page size.Signed-off-by: Maya Nakamura Reviewed-by: Michael Kelley Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

2025cf9e - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288

Wed, 29 May 2019 14:18:02 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms and conditions of the gnu general public license version 2 as published by the free software foundation this program is distributed in the hope it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more detailsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 263 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190529141901.208660670@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

9d1c2f06 - Input: hyperv-keyboard - add module description

Tue, 23 Apr 2019 03:37:07 +0000

Input: hyperv-keyboard - add module descriptionSigned-off-by: Joseph Salisbury Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

10f91c73 - Input: hyper-v - fix wakeup from suspend-to-idle

Thu, 15 Nov 2018 19:05:10 +0000

Input: hyper-v - fix wakeup from suspend-to-idleIt makes little sense but still possible to put Hyper-V guests intosuspend-to-idle state. To wake them up two wakeup sources were registeredin the past: hyperv-keyboard and hid-hyperv. However, sincecommit eed4d47efe95 ("ACPI / sleep: Ignore spurious SCI wakeups fromsuspend-to-idle") pm_wakeup_event() from these devices is ignored. Switchto pm_wakeup_hard_event() API as these devices are actually the onlypossible way to wakeup Hyper-V guests.Fixes: eed4d47efe95 (ACPI / sleep: Ignore spurious SCI wakeups from suspend-to-idle)Reviewed-by: Rafael J. Wysocki Acked-by: K. Y. Srinivasan Acked-by: Jiri Kosina Signed-off-by: Vitaly Kuznetsov Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

af0a5646 - use the new async probing feature for the hyperv drivers

Tue, 05 Jun 2018 20:37:49 +0000

use the new async probing feature for the hyperv driversRecent kernels support asynchronous probing; most hyperv driverscan be probed async easily so set the required flag for this.Signed-off-by: Arjan van de Ven Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

f20b161f - Input: serio - drop unnecessary calls to device_init_wakeup

Sun, 22 Jan 2017 07:49:38 +0000

Input: serio - drop unnecessary calls to device_init_wakeupCalling device_init_wakeup in the remove function is unnecessary since thedevice is going away, and thus won't be able to cause any wakeups under anycircumstances. Besides, the driver cleanup code already handles thenecessary cleanup.Similarly, disabling wakeup in the probe error path is unnecessary, as isdisabling wakeup in the probe function in the first place.Signed-off-by: Guenter Roeck Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

2048157a - Drivers: hv: vmbus: fix the building warning with hyperv-keyboard

Mon, 21 Dec 2015 20:21:22 +0000

Drivers: hv: vmbus: fix the building warning with hyperv-keyboardWith the recent change af3ff643ea91ba64dd8d0b1cbed54d44512f96cd(Drivers: hv: vmbus: Use uuid_le type consistently), we always get thiswarning: CC [M] drivers/input/serio/hyperv-keyboard.odrivers/input/serio/hyperv-keyboard.c:427:2: warning: missing braces around initializer [-Wmissing-braces] { HV_KBD_GUID, }, ^drivers/input/serio/hyperv-keyboard.c:427:2: warning: (near initialization for .id_table[0].guid.b.) [-Wmissing-braces]The patch fixes the warning.Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

62238f3a - Input: hyperv-keyboard - register as a wakeup source

Wed, 06 Aug 2014 20:33:54 +0000

Input: hyperv-keyboard - register as a wakeup sourceWith this patch, we can press a key to wake up the VM after the VM executes"echo freeze > /sys/power/state".Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

c3c4d994 - Input: hyperv-keyboard - pass through 0xE1 prefix

Sun, 12 Jan 2014 19:09:14 +0000

Input: hyperv-keyboard - pass through 0xE1 prefixPass through the 0xE1 prefix so atkbd can properly parse the scancodedata.Signed-off-by: K. Y. Srinivasan Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c

aed06b9c - Input: add a driver to support Hyper-V synthetic keyboard

Wed, 18 Sep 2013 19:50:42 +0000

Input: add a driver to support Hyper-V synthetic keyboardAdd a new driver to support synthetic keyboard. On the next generationHyper-V guest firmware, many legacy devices will not be emulated and thisdriver will be required.I would like to thank Vojtech Pavlik for helping me with thedetails of the AT keyboard driver. I would also like to thankDan Carpenter andDmitry Torokhov for their detailed review of thisdriver.Signed-off-by: K. Y. Srinivasan Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/serio/hyperv-keyboard.c