Changes in hgpk.c

dc2f1423 - Input: mouse - use sizeof(*pointer) instead of sizeof(type)

Mon, 03 Jun 2024 04:30:36 +0000

Input: mouse - use sizeof(*pointer) instead of sizeof(type)It is preferred to use sizeof(*pointer) instead of sizeof(type)due to the type of the variable can change and one needs notchange the former (unlike the latter). This patch has no effecton runtime behavior.Signed-off-by: Erick Archer Link: https://lore.kernel.org/r/AS8PR02MB7237FB736DBF67A58798FDF38BFE2@AS8PR02MB7237.eurprd02.prod.outlook.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

e7ed42a4 - Input: hgpk - fix repeated word in a comment

Thu, 08 Sep 2022 19:37:09 +0000

Input: hgpk - fix repeated word in a commentDelete the redundant word 'to'.Signed-off-by: wangjianli Link: https://lore.kernel.org/r/20220908131043.37099-1-wangjianli@cdjrlc.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

a9f08ad7 - Input: move from strlcpy with unused retval to strscpy

Thu, 18 Aug 2022 22:05:06 +0000

Input: move from strlcpy with unused retval to strscpyFollow the advice of the below link and prefer 'strscpy' in thissubsystem. Conversion is 1:1 because the return value is not used.Generated by a coccinelle script.Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20220818210022.6865-1-wsa+renesas@sang-engineering.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

6f49c4f5 - Input: Use fallthrough pseudo-keyword

Tue, 07 Jul 2020 18:24:55 +0000

Input: Use fallthrough pseudo-keywordReplace the existing /* fall through */ comments and its variants withthe new pseudo-keyword macro fallthrough[1]. Also, remove unnecessaryfall-through markings when it is the case.[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-throughSigned-off-by: Gustavo A. R. Silva Link: https://lore.kernel.org/r/20200707180857.GA30600@embeddedorSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/mouse/hgpk.c

ad56814f - Input: mouse - use local variables consistently

Sun, 22 Jan 2017 07:44:46 +0000

Input: mouse - use local variables consistentlyIf a function declares a variable to access a structure element,use it consistently.Signed-off-by: Guenter Roeck Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

fb4f552e - Input: hgpk - use %*ph to dump small buffer

Thu, 13 Sep 2012 04:49:26 +0000

Input: hgpk - use %*ph to dump small bufferSigned-off-by: Andy Shevchenko Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

c35c0e7d - Input: psmouse - use psmouse_[de]activate() from sentelic and hgpk drivers

Fri, 24 Feb 2012 08:51:37 +0000

Input: psmouse - use psmouse_[de]activate() from sentelic and hgpk driversMake use of psmouse_activate() and psmouse_deactivate() from psmouse-base.cSigned-off-by: Andres Salomon Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

76496e7a - Input: convert obsolete strict_strtox to kstrtox

Wed, 09 Nov 2011 18:20:14 +0000

Input: convert obsolete strict_strtox to kstrtoxWith commit 67d0a0754455f89ef3946946159d8ec9e45ce33a we mark strict_strtoxas obsolete. Convert all remaining such uses in drivers/input/.Also change long to appropriate types, and return error conditionsfrom kstrtox separately, as Dmitry sugguests.Signed-off-by: JJ Ding Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

b5d21704 - Input: psmouse - switch to using dev_*() for messages

Tue, 11 Oct 2011 01:27:03 +0000

Input: psmouse - switch to using dev_*() for messagesThis will ensure our reporting is consistent with the rest of the systemand we do not refer to obsolete source file names.Reviewed-by: Wanlong Gao Reviewed-by: JJ Ding Reviewed-by: Daniel Kurtz Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

ab3d0abe - Input: psmouse - hgpk.c needs module.h

Sat, 30 Jul 2011 18:53:47 +0000

Input: psmouse - hgpk.c needs module.hhgpk.c uses interfaces from linux/module.h, so it should include that file.This fixes build errors.Signed-off-by: Randy Dunlap Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

20a4c261 - Input: hgpk - fix powersave mode

Mon, 15 Nov 2010 09:33:24 +0000

Input: hgpk - fix powersave modeRecent testing of this codepath showed that it wasn't working,perhaps due to changes within the input layer. This fixes it.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

34caed20 - Input: hgpk - recalibration tweaks

Mon, 15 Nov 2010 09:33:22 +0000

Input: hgpk - recalibration tweaksDisable the recalibration guard where new recalibrations are triggeredif we detect a packet too soon after calibrating - we found that thisresults in erroneous recalibrations, and if the recalibration failedthen the rest of our badness-detection code will request another.Add a module option disabling all of the recalibration code, in casean OLPC deployment thinks all of the workarounds we have are doingmore damage than good and wants to experiment with them all disabled.Based on work by Paul Fox.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

67f56bb0 - Input: hgpk - detect simple mode overflows

Mon, 15 Nov 2010 09:28:54 +0000

Input: hgpk - detect simple mode overflowsBased on work by Paul Fox.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

a309cdc7 - Input: hgpk - extend jumpiness detection

Fri, 12 Nov 2010 06:20:03 +0000

Input: hgpk - extend jumpiness detectionIn addition to forcing recalibrations upon detection of cursor jumps (andperforming them quicker than before), detect and discard errant 'jump'packets caused by a firmware bug, which are then repeated with each onebeing approximately half the delta of the one previously (as if it isaveraging out)Based on original work by Paul Fox.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

c0dc8342 - Input: hgpk - rework spew detection

Fri, 12 Nov 2010 06:20:02 +0000

Input: hgpk - rework spew detectionThe old implementation of spew detection simply tracked the overallposition delta of the cursor over every 100 packets. We found thatthis causes occasional false positives in spew detection, and alsothat the conditions of the spewy packets are perhaps more fixed thanwe once thought.Rework the spew detection to look for packets of specific smalldelta, and only recalibrating if the overall movement delta stayswithin expected bounds.Also discard duplicate packets in the advanced mode, which appearto be very common. If we don't, the spew detection kicks in fartoo early. If we get a large spew of duplicates, request arecalibration straight up.Based on earlier work by Paul Fox.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

ca94ec43 - Input: hgpk - support GlideSensor and PenTablet modes

Fri, 12 Nov 2010 06:19:57 +0000

Input: hgpk - support GlideSensor and PenTablet modesAdd a "hgpk_mode" sysfs attribute that allows selection between 3 options:Mouse (the existing option), GlideSensor and PenTablet.GlideSensor is an enhanced protocol for the regular touchpad mode thatadditionally reports pressure and uses absolute coordinates. We suspectthat it may be more reliable than mouse mode in some environments.PenTablet mode puts the touchpad into resistive mode, you must then usea stylus as an input. We suspect this is the most reliable way to drivethe touchpad.The GlideSensor and PenTablet devices expose themselves with theintention of being combined with the synaptics X11 input driver.Based on earlier work by Paul Fox.Signed-off-by: Daniel Drake Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

a62f0d27 - Input: psmouse - small formatting changes to better follow coding style

Wed, 19 May 2010 17:39:17 +0000

Input: psmouse - small formatting changes to better follow coding styleSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c

5a0e3ad6 - include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

Wed, 24 Mar 2010 08:04:11 +0000

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.hpercpu.h is included by sched.h and module.h and thus ends up beingincluded when building most .c files. percpu.h includes slab.h whichin turn includes gfp.h making everything defined by the two filesuniversally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare forthis change by updating users of gfp and slab facilities include thoseheaders directly instead of assuming availability. As this conversionneeds to touch large number of source files, the following script isused as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.pyThe script does the followings.* Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file.The conversion was done in the following steps.1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files.2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files.3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary.6. percpu.h was updated not to include slab.h.7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step6, I'm fairly confident about the coverage of this conversion patch.If there is a breakage, it's likely to be something in one of the archheaders which should be easily discoverable easily on most builds ofthe specific arch.Signed-off-by: Tejun Heo Guess-its-ok-by: Christoph Lameter Cc: Ingo Molnar Cc: Lee Schermerhorn List of files: /linux-6.15/drivers/input/mouse/hgpk.c

3032458e - Input: psmouse - remove unused 'autocal' parameter from hgpk protocol

Wed, 06 Jan 2010 08:33:07 +0000

Input: psmouse - remove unused 'autocal' parameter from hgpk protocolSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/hgpk.c