Changes in amimouse.c

2c19d015 - Input: switch back to struct platform_driver::remove()

Tue, 08 Oct 2024 09:00:10 +0000

Input: switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/input/ to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.While touching these files, make indention of the struct initializerconsistent in a few drivers.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20241008090009.462836-2-u.kleine-koenig@baylibre.comSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

0537c8ee - Input: amimouse - mark driver struct with __refdata to prevent section mismatch

Tue, 30 Apr 2024 18:46:32 +0000

Input: amimouse - mark driver struct with __refdata to prevent section mismatchAs described in the added code comment, a reference to .exit.text is okfor drivers registered via module_platform_driver_probe(). Make thisexplicit to prevent the following section mismatch warning WARNING: modpost: drivers/input/mouse/amimouse: section mismatch in reference: amimouse_driver+0x8 (section: .data) -> amimouse_remove (section: .exit.text)that triggers on an allmodconfig W=1 build.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.deSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

42b8ff47 - Input: amimouse - convert to platform remove callback returning void

Fri, 01 Dec 2023 13:37:48 +0000

Input: amimouse - convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20231201133747.1099286-2-u.kleine-koenig@pengutronix.deSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

d2912cb1 - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

Tue, 04 Jun 2019 08:11:33 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500Based on 2 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation this program is free software you can redistribute it and or modify it under the terms of the gnu general public license version 2 as published by the free software foundation #extracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 4122 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Enrico Weigelt Reviewed-by: Kate Stewart Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/mouse/amimouse.c

7c0f6ba6 - Replace with globally

Sat, 24 Dec 2016 19:46:01 +0000

Replace with globallyThis was entirely automated, using the script by Al: PATT='^[[:blank:]]*#[[:blank:]]*include[[:blank:]]*' sed -i -e "s!$PATT!#include !" \ $(git grep -l "$PATT"|grep -v ^include/linux/uaccess.h)to do the replacement at the end of the merge window.Requested-by: Al Viro Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/input/mouse/amimouse.c

128562fb - input: mouse: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:20:40 +0000

input: mouse: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/input/mouse/amimouse.c

66b0f52c - Input: amimouse - remove redundant platform_set_drvdata()

Mon, 06 May 2013 03:00:22 +0000

Input: amimouse - remove redundant platform_set_drvdata()Commit 0998d06310 (device-core: Ensure drvdata = NULL when nodriver is bound) removes the need to set driver data field toNULL.Signed-off-by: Sachin Kamat Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

e492fe27 - Input: amimouse - use module_platform_driver_probe macro

Mon, 18 Mar 2013 04:28:00 +0000

Input: amimouse - use module_platform_driver_probe macromodule_platform_driver_probe() eliminates the boilerplate and simplifiesthe code.Signed-off-by: Sachin Kamat Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

9ffc93f2 - Remove all #inclusions of asm/system.h

Wed, 28 Mar 2012 17:30:03 +0000

Remove all #inclusions of asm/system.hRemove all #inclusions of asm/system.h preparatory to splitting and killingit. Performed with the following command:perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`Signed-off-by: David Howells List of files: /linux-6.15/drivers/input/mouse/amimouse.c

d3d25808 - Input: revert some over-zealous conversions to module_platform_driver()

Tue, 10 Jan 2012 23:08:01 +0000

Input: revert some over-zealous conversions to module_platform_driver()Recent conversion to module_platform_driver() went a bit too far andconverted not only drivers that used platform_driver_register() butalso ones using platform_driver_probe(), breaking them in process.Reported-by: Geert Uytterhoeven Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

4fcdeac5 - Input: mouse - use macro module_platform_driver()

Tue, 29 Nov 2011 19:08:41 +0000

Input: mouse - use macro module_platform_driver()Commit 940ab88962bc1aff3273a8356d64577a6e386736 introduced a new macro tosave some platform_driver boilerplate code. Use it.Signed-off-by: JJ Ding Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

314c926f - m68k: amiga - Mouse platform device conversion

Sun, 05 Apr 2009 11:11:28 +0000

m68k: amiga - Mouse platform device conversionSigned-off-by: Geert Uytterhoeven List of files: /linux-6.15/drivers/input/mouse/amimouse.c

7b19ada2 - get rid of input BIT* duplicate defines

Fri, 19 Oct 2007 06:40:32 +0000

get rid of input BIT* duplicate definesget rid of input BIT* duplicate definesuse newly global defined macros for input layer. Also remove includes ofinput.h from non-input sources only for BIT macro definiton. Define themacro temporarily in local manner, all those local definitons will beremoved further in this patchset (to not break bisecting).BIT macro will be globally defined (1<Cc: Acked-by: Jiri Kosina Cc: Acked-by: Marcel Holtmann Cc: Acked-by: Mauro Carvalho Chehab Cc: Cc: Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/input/mouse/amimouse.c

72155615 - Input: mice - handle errors when registering input devices

Mon, 06 Nov 2006 03:40:19 +0000

Input: mice - handle errors when registering input devicesSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

7d12e780 - IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

Thu, 05 Oct 2006 13:55:46 +0000

IRQ: Maintain regs pointer globally rather than passing to IRQ handlersMaintain a per-CPU global "struct pt_regs *" variable which can be used insteadof passing regs around manually through all ~1800 interrupt handlers in theLinux kernel.The regs pointer is used in few places, but it potentially costs both stackspace and code to pass it around. On the FRV arch, removing the regs parameterfrom all the genirq function results in a 20% speed up of the IRQ exit path(ie: from leaving timer_interrupt() to leaving do_IRQ()).Where appropriate, an arch may override the generic storage facility and dosomething different with the variable. On FRV, for instance, the address ismaintained in GR28 at all times inside the kernel as part of general exceptionhandling.Having looked over the code, it appears that the parameter may be handed downthrough up to twenty or so layers of functions. Consider a USB characterdevice attached to a USB hub, attached to a USB controller that posts itsinterrupts through a cascaded auxiliary interrupt controller. A characterdevice driver may want to pass regs to the sysrq handler through the inputlayer which adds another few layers of parameter passing.I've build this code with allyesconfig for x86_64 and i386. I've runtested themain part of the code on FRV and i386, though I can't test most of the drivers.I've also done partial conversion for powerpc and MIPS - these at least compilewith minimal configurations.This will affect all archs. Mostly the changes should be relatively easy.Take do_IRQ(), store the regs pointer at the beginning, saving the old one: struct pt_regs *old_regs = set_irq_regs(regs);And put the old one back at the end: set_irq_regs(old_regs);Don't pass regs through to generic_handle_irq() or __do_IRQ().In timer_interrupt(), this sort of change will be necessary: - update_process_times(user_mode(regs)); - profile_tick(CPU_PROFILING, regs); + update_process_times(user_mode(get_irq_regs())); + profile_tick(CPU_PROFILING);I'd like to move update_process_times()'s use of get_irq_regs() into itself,except that i386, alone of the archs, uses something other than user_mode().Some notes on the interrupt handling in the drivers: (*) input_dev() is now gone entirely. The regs pointer is no longer stored in the input_dev struct. (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does something different depending on whether it's been supplied with a regs pointer or not. (*) Various IRQ handler function pointers have been moved to type irq_handler_t.Signed-Off-By: David Howells (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit) List of files: /linux-6.15/drivers/input/mouse/amimouse.c

b4290a23 - [PATCH] m68k: namespace pollution fix (custom->amiga_custom)

Thu, 12 Jan 2006 09:06:12 +0000

[PATCH] m68k: namespace pollution fix (custom->amiga_custom)in amigahw.h custom renamed to amiga_custom, in drivers with few instances thesame replacement, in the rest - #define custom amiga_custom in driver itselfSigned-off-by: Al Viro Cc: Roman Zippel Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/input/mouse/amimouse.c

2e5b636b - [PATCH] drivers/input/mouse: convert to dynamic input_dev allocation

Thu, 15 Sep 2005 07:01:44 +0000

[PATCH] drivers/input/mouse: convert to dynamic input_dev allocationInput: convert drivers/input/mouse to dynamic input_dev allocationThis is required for input_dev sysfs integrationSigned-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/input/mouse/amimouse.c

3108d42d - Input: remove user counters from drivers/input/mouse since input

Sun, 29 May 2005 07:29:30 +0000

Input: remove user counters from drivers/input/mouse since input core takes care of calling open and close methods only when needed.Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/mouse/amimouse.c

1da177e4 - Linux-2.6.12-rc2

Sat, 16 Apr 2005 22:20:36 +0000

Linux-2.6.12-rc2Initial git repository build. I'm not bothering with the full history,even though we have it. We can create a separate "historical" gitarchive of that later if we want to, and in the meantime it's about3.2GB when imported into git - space that would just make the earlygit days unnecessarily complicated, when we don't have a lot of goodinfrastructure for it.Let it rip! List of files: /linux-6.15/drivers/input/mouse/amimouse.c