Changes in max8925_onkey.c

1bf94844 - Input: max8925_onkey - switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()

Mon, 02 Jan 2023 18:17:45 +0000

Input: max8925_onkey - switch to DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr()SIMPLE_DEV_PM_OPS() is deprecated as it requires explicit protectionagainst unused function warnings. The new combination of pm_sleep_ptr()and DEFINE_SIMPLE_DEV_PM_OPS() allows the compiler to see the functions,thus suppressing the warning, but still allowing the unused code to beremoved. Thus also drop the __maybe_unused markings.Signed-off-by: Jonathan Cameron Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20230102181842.718010-13-jic23@kernel.orgSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

a88638c4 - Input: max8925_onkey - don't mark comment as kernel-doc

Sat, 16 Oct 2021 05:08:50 +0000

Input: max8925_onkey - don't mark comment as kernel-docChange the comment to a normal (non-kernel-doc) comment to avoidthese kernel-doc warnings:max8925_onkey.c:2: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * MAX8925 ONKEY drivermax8925_onkey.c:2: warning: missing initial short description on line: * MAX8925 ONKEY driverFixes: 3734574cac100 ("Input: enable onkey driver of max8925")Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/r/20211002045943.9406-1-rdunlap@infradead.orgSigned-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

0bec8b7e - Input: remove dev_err() usage after platform_get_irq()

Wed, 14 Aug 2019 17:46:38 +0000

Input: remove dev_err() usage after platform_get_irq()We don't need dev_err() messages when platform_get_irq() fails now thatplatform_get_irq() prints an error message itself when something goeswrong. Let's remove these prints with a simple semantic patch.// @@expression ret;struct platform_device *E;@@ret =(platform_get_irq(E, ...)|platform_get_irq_byname(E, ...));if ( \( ret < 0 \| ret <= 0 \) ){(-if (ret != -EPROBE_DEFER)-{ ...-dev_err(...);-... }|...-dev_err(...);)...}// While we're here, remove braces on if statements that only have onestatement (manually).Signed-off-by: Stephen Boyd Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

97a652a8 - Input: misc - use __maybe_unused instead of ifdef around suspend/resume

Sun, 02 Nov 2014 07:02:46 +0000

Input: misc - use __maybe_unused instead of ifdef around suspend/resumeUse __maybe_unused instead of ifdef guards around suspend/resumefunctions, in order to increase build coverage and fix build warnings.Signed-off-by: Jingoo Han Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

776bd315 - input: misc: drop owner assignment from platform_drivers

Mon, 20 Oct 2014 14:20:40 +0000

input: misc: drop owner assignment from platform_driversA platform_driver does not need to set an owner, it will be populated by thedriver core.Signed-off-by: Wolfram Sang List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

04115e41 - Input: max8925_onkey - switch to using managed resources

Thu, 29 May 2014 07:21:56 +0000

Input: max8925_onkey - switch to using managed resourcesLet's switch the driver to use managed resources, this will simplifyerror handling and driver unbinding logic.Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

18fc6f50 - Input: max8925_onkey - remove redundant platform_set_drvdata()

Mon, 06 May 2013 02:35:43 +0000

Input: max8925_onkey - remove redundant platform_set_drvdata()Commit 0998d06310 (device-core: Ensure drvdata = NULL when nodriver is bound) removes the need to set driver data field toNULL.Signed-off-by: Sachin Kamat Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

678e8cb5 - mfd: max8925: Fix onkey driver irq base

Mon, 04 Feb 2013 15:40:44 +0000

mfd: max8925: Fix onkey driver irq baseupdate onkey driver's irq base, it should get from max8925,but not save in a private valueSigned-off-by: Qing Xu Acked-by: Dmitry Torokhov Signed-off-by: Samuel Ortiz List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

e2619cf7 - Input: remove use of __devexit

Sat, 24 Nov 2012 05:50:47 +0000

Input: remove use of __devexitCONFIG_HOTPLUG is going away as an option so __devexit is nolonger needed.Signed-off-by: Bill Pemberton Acked-by: Mark Brown Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

5298cc4c - Input: remove use of __devinit

Sat, 24 Nov 2012 05:38:25 +0000

Input: remove use of __devinitCONFIG_HOTPLUG is going away as an option so __devinit is no longerneeded.Signed-off-by: Bill Pemberton Acked-by: Mark Brown Acked-by: Javier Martinez Canillas Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

1cb0aa88 - Input: remove use of __devexit_p

Sat, 24 Nov 2012 05:27:39 +0000

Input: remove use of __devexit_pCONFIG_HOTPLUG is going away as an option so __devexit_p is no longerneeded.Signed-off-by: Bill Pemberton Acked-by: Russell King Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

104a5f3c - Input: max8925_onkey - avoid accessing input device too early

Tue, 06 Mar 2012 17:10:21 +0000

Input: max8925_onkey - avoid accessing input device too earlyInput device must be allocated (but not necessarily registered) beforerequesting IRQs, otherwise there is a chance that IRQ handler fires andtries to reference not yet allocated input device.Also it makes sense to store relative IRQ numbers in max8925_onkey_infostructure as they are needed in suspend/resume which we expect to becalled more often than probe and remove.Acked-by: Haojian Zhuang Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

adab30d7 - Input: max8925_onkey - allow to be used as a wakeup source

Tue, 06 Mar 2012 06:24:54 +0000

Input: max8925_onkey - allow to be used as a wakeup sourceImplement suspend and resume methods to set up devices as wakeup source.Signed-off-by: Kevin Liu Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

840a746b - Input: misc - use macro module_platform_driver()

Tue, 29 Nov 2011 19:08:40 +0000

Input: misc - use macro module_platform_driver()Commit 940ab88962bc1aff3273a8356d64577a6e386736 introduced a new macro tosave some platform_driver boilerplate code. Use it.Signed-off-by: JJ Ding Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

2d95ae3b - input: Monitor both onkey up and down event

Wed, 08 Sep 2010 13:44:35 +0000

input: Monitor both onkey up and down eventRemove original 3-second ONKEY event. Detect ONKEY changing event directly.So both UP and DOWN event of ONKEY in max8925 are monitered.Signed-off-by: Haojian Zhuang Cc: Dmitry Torokhov Signed-off-by: Samuel Ortiz List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c

3734574c - Input: enable onkey driver of max8925

Sat, 22 May 2010 07:57:26 +0000

Input: enable onkey driver of max8925When ONKEY is held for 3 seconds, KEY_POWER event is reported.Signed-off-by: Haojian Zhuang Signed-off-by: Dmitry Torokhov List of files: /linux-6.15/drivers/input/misc/max8925_onkey.c