Changes in Kconfig

a5a056c8 - HID: intel-thc: fix CONFIG_HID dependency

Thu, 23 Jan 2025 13:48:12 +0000

HID: intel-thc: fix CONFIG_HID dependencyIn drivers/hid/, most drivers depend on CONFIG_HID, while a couple of thedrivers in subdirectories instead depend on CONFIG_HID_SUPPORT and use'select HID'. With the newly added INTEL_THC_HID, this causes a buildwarning for a circular dependency:WARNING: unmet direct dependencies detected for HID Depends on [m]: HID_SUPPORT [=y] && INPUT [=m] Selected by [y]: - INTEL_THC_HID [=y] && HID_SUPPORT [=y] && X86_64 [=y] && PCI [=y] && ACPI [=y]WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS Depends on [m]: INPUT [=m] Selected by [y]: - HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y] - GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y] - HID_WIIMOTE [=y] && HID_SUPPORT [=y] && HID [=y] && LEDS_CLASS [=y] - ZEROPLUS_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ZEROPLUS [=y] Selected by [m]: - HID_ACRUX_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_ACRUX [=m] - HID_EMS_FF [=m] && HID_SUPPORT [=y] && HID [=y] - HID_GOOGLE_STADIA_FF [=m] && HID_SUPPORT [=y] && HID [=y] - PANTHERLORD_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_PANTHERLORD [=m]It's better to be consistent and always use 'depends on HID' for HIDdrivers. The notable exception here is USB_KBD/USB_MOUSE, which arealternative implementations that do not depend on the HID subsystem.Do this by extending the "if HID" section below, which means that a fewof the duplicate "depends on HID" and "depends on INPUT" statementscan be removed in the process.Fixes: 1b2d05384c29 ("HID: intel-thc-hid: Add basic THC driver skeleton")Signed-off-by: Arnd Bergmann Reviewed-by: Ilpo Järvinen Reviewed-by: Maximilian Luz Reviewed-by: Even Xu Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

a0769f25 - HID: i2c-hid: add more DRM dependencies

Wed, 02 Aug 2023 12:49:40 +0000

HID: i2c-hid: add more DRM dependenciesWhen a symbol is selected that has extra dependencies,anything that selects it must have the same dependencies.With the added CONFIG_DRM reference from I2C_HID_CORE,this broke a couple of drivers that now also dependon DRM:WARNING: unmet direct dependencies detected for I2C_HID_CORE Depends on [m]: HID_SUPPORT [=y] && I2C_HID [=y] && (DRM [=m] || !DRM [=m]) Selected by [y]: - I2C_HID_OF [=y] && HID_SUPPORT [=y] && I2C_HID [=y] - I2C_HID_ACPI [=y] && HID_SUPPORT [=y] && I2C_HID [=y] && ACPI [=y] - I2C_HID_OF_GOODIX [=y] && HID_SUPPORT [=y] && I2C_HID [=y] && OF [=y]x86_64-linux-ld: vmlinux.o: in function `i2c_hid_core_remove':(.text+0xfc8826): undefined reference to `drm_panel_remove_follower'x86_64-linux-ld: vmlinux.o: in function `i2c_hid_core_probe':(.text+0xfc8da0): undefined reference to `drm_is_panel_follower'Add the corresponding DRM||!DRM dependencies on each one thatis affected.Fixes: 96a37bfd232ae ("HID: i2c-hid: Support being a panel follower")Signed-off-by: Arnd Bergmann Reviewed-by: Douglas Anderson Signed-off-by: Douglas Anderson Link: https://patchwork.freedesktop.org/patch/msgid/20230802124947.1355415-1-arnd@kernel.org List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

96a37bfd - HID: i2c-hid: Support being a panel follower

Thu, 27 Jul 2023 17:16:36 +0000

HID: i2c-hid: Support being a panel followerAs talked about in the patch ("drm/panel: Add a way for other devicesto follow panel state"), we really want to keep the power states of atouchscreen and the panel it's attached to in sync with each other. Inthat spirit, add support to i2c-hid to be a panel follower. This willlet the i2c-hid driver get informed when the panel is powered on andoff. From there we can match the i2c-hid device's power state to thatof the panel.NOTE: this patch specifically _doesn't_ use pm_runtime to keep trackof / manage the power state of the i2c-hid device, even though myfirst instinct said that would be the way to go. Specific problemswith using pm_runtime():* The initial power up couldn't happen in a runtime resume function since it create sub-devices and, apparently, that's not good to do in your resume function.* Managing our power state with pm_runtime meant fighting to make the right thing happen at system suspend to prevent the system from trying to resume us only to suspend us again. While this might be able to be solved, it added complexity.Overall the code without pm_runtime() ended up being smaller andeasier to understand.Reviewed-by: Maxime Ripard Reviewed-by: Benjamin Tissoires Acked-by: Benjamin Tissoires Signed-off-by: Douglas Anderson Link: https://patchwork.freedesktop.org/patch/msgid/20230727101636.v4.9.Ib1a98309c455cd7e26b931c69993d4fba33bbe15@changeid List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

728ec8b6 - HID: i2c-hid-of: Allow using i2c-hid-of on non OF platforms

Thu, 13 Apr 2023 09:36:24 +0000

HID: i2c-hid-of: Allow using i2c-hid-of on non OF platformsThere are some x86 tablets / 2-in-1s which ship with Android as theirfactory OS image. These have pretty broken ACPI tables, relying oneverything being hardcoded in the factory kernel image.platform/x86/x86-android-tablets.c manually instantiates i2c-clients fori2c devices on these tablets to make them work with the mainline kernel.The Lenovo Yoga Book 1 (yb1-x90f/l) is such a 2-in-1. It has 2 I2C-HIDdevices its main touchscreen and a Wacom digitizer. Its main touchscreencan alternatively also be used in HiDeep's native protocol mode butfor the Wacom digitizer we really need I2C-HID.This patch allows using i2c-hid-of on non OF platforms so that it canbind to a non ACPI instantiated i2c_client on x86 for the Wacom digitizer.Note the driver already has an "i2c-over-hid" i2c_device_id (rather thenan of_device_id).Besides enabling building on non-OF platforms this also replacesthe only of_property_read_u32() call with device_property_read_u32() notethat other properties where already read using device_property_read_...().Signed-off-by: Hans de Goede Reviewed-by: Benjamin Tissoires Link: https://lore.kernel.org/r/20230413093625.71146-3-hdegoede@redhat.comSigned-off-by: Benjamin Tissoires List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

bf7660da - HID: stop drivers from selecting CONFIG_HID

Tue, 17 Jan 2023 17:20:55 +0000

HID: stop drivers from selecting CONFIG_HIDThere is a mix of drivers using either 'depends on HID' or 'select HID',which causes both circular dependencies and missed dependencies fora 'select':WARNING: unment direct dependencies for HID Depends on [m]: HID_SUPPORT [=y] && INPUT [=m] Selected by [y]: - AMD_SFH_HID [=y] && HID_SUPPORT [=y] && (X86_64 || COMPILE_TEST [=y]) && PCI [=y] Selected by [m]: - I2C_HID_CORE [=m] && HID_SUPPORT [=y]WARNING: unmet direct dependencies detected for INPUT_FF_MEMLESS Depends on [m]: INPUT [=m] Selected by [y]: - DRAGONRISE_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_DRAGONRISE [=y] - HID_MICROSOFT [=y] && HID_SUPPORT [=y] && HID [=y] - GREENASIA_FF [=y] && HID_SUPPORT [=y] && HID [=y] && HID_GREENASIA [=y] Selected by [m]: - INPUT_ARIZONA_HAPTICS [=m] && INPUT [=m] && INPUT_MISC [=y] && MFD_ARIZONA [=y] && SND_SOC [=m] - INPUT_PM8XXX_VIBRATOR [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_PM8XXX [=m] || MFD_SPMI_PMIC [=n]) - INPUT_MAX8997_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y] && MFD_MAX8997 [=y] - INPUT_GPIO_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y]) - INPUT_REGULATOR_HAPTIC [=m] && INPUT [=m] && INPUT_MISC [=y] && REGULATOR [=y] - INPUT_TWL6040_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && TWL6040_CORE [=y] - INPUT_PWM_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && PWM [=y] - INPUT_DRV260X_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y] && (GPIOLIB [=y] || COMPILE_TEST [=y]) - INPUT_DRV2665_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y] - INPUT_DRV2667_HAPTICS [=m] && INPUT_MISC [=y] && INPUT [=m] && I2C [=y] - INPUT_SC27XX_VIBRA [=m] && INPUT [=m] && INPUT_MISC [=y] && (MFD_SC27XX_PMIC [=y] || COMPILE_TEST [=y]) - HID_MAYFLASH [=m] && HID_SUPPORT [=y] && HID [=y]Avoid this by changing all HID client drivers to use 'depends on HID'.For I2C_HID, this requires a larger rework of the Kconfig description,but it hopefully becomes easier to understand without the complexI2C_HID_CORE definition.Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Reviewed-by: Greg Kroah-Hartman Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

2afac81d - HID: fix I2C_HID not selected when I2C_HID_OF_ELAN is

Thu, 03 Nov 2022 15:57:42 +0000

HID: fix I2C_HID not selected when I2C_HID_OF_ELAN isWhen I2C_HID_OF_ELAN is set, we need to turn on I2C_HID_CORE toensure we get all the HID requirements.Fixes: bd3cba00dcc6 ("HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens")Reported-by: kernel test robot Signed-off-by: Benjamin Tissoires Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

bd3cba00 - HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens

Mon, 23 May 2022 21:23:24 +0000

HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreensLike many i2c-hid touchscreen controllers, the Elan eKTH6915 has areset GPIO hooked up to it. According to the datasheet, the way we'resupposed to turn the touchscreen on is:1. Turn on the 3.3V supply.2. Turn on the IO supply. It's OK if this is hardwired to the 3.3V supply, but if it's not then it must be turned on _after_ the 3.3V supply.3. Wait >= 1 ms.4. Deassert the reset GPIO (reset GPIO is active low, so there would be a leakage path if this was deasserted _before_ the IO supply).5. Wait 300 ms.Much of the above can be handled by the generic i2c-hid-of driver, butthe "reset" GPIO is not supported by that driver. Thus we'll do thesame as we did for Goodix and add a new tiny driver that uses thei2c-hid core.NOTE: support for this new touchscreen could theorically fit into theGoodix driver. I've made it a separate driver because the Elan driversupports _two_ regulators and it's unclear exactly how that would fitin with commit 18eeef46d359 ("HID: i2c-hid: goodix: Tie the reset lineto true state of the regulator").Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Torokhov Reviewed-by: Matthias Kaehlcke Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

c1ed18c1 - HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core

Fri, 15 Jan 2021 17:06:40 +0000

HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid coreGoodix i2c-hid touchscreens are mostly i2c-hid compliant but have somespecial power sequencing requirements, including the need to drive areset line during the sequencing.Let's use the new rejiggering of i2c-hid to support this with a thinwrapper driver to support the first Goodix i2c-hid touchscreen:GT7375PSigned-off-by: Douglas Anderson Signed-off-by: Benjamin Tissoires List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

b33752c3 - HID: i2c-hid: Reorganize so ACPI and OF are separate modules

Fri, 15 Jan 2021 17:06:37 +0000

HID: i2c-hid: Reorganize so ACPI and OF are separate modulesThis patch rejiggers the i2c-hid code so that the OF (Open Firmwareaka Device Tree) and ACPI support is separated out a bit. The OF andACPI drivers are now separate modules that wrap the core module.Essentially, what we're doing here:* Make "power up" and "power down" a function that can be (optionally) implemented by a given user of the i2c-hid core.* The OF and ACPI modules are drivers on their own, so they implement probe / remove / suspend / resume / shutdown. The core code provides implementations that OF and ACPI can call into.We'll organize this so that we now have 3 modules: the old i2c-hidmodule becomes the "core" module and two new modules will depend onit, handling probing the specific device.As part of this work, we'll remove the i2c-hid "platform data"concept since it's not needed.Signed-off-by: Douglas Anderson Reviewed-by: Hans de Goede Signed-off-by: Benjamin Tissoires List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

a7f7f624 - treewide: replace '---help---' in Kconfig files with 'help'

Sat, 13 Jun 2020 16:50:22 +0000

treewide: replace '---help---' in Kconfig files with 'help'Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over'---help---'"), the number of '---help---' has been graduallydecreasing, but there are still more than 2400 instances.This commit finishes the conversion. While I touched the lines,I also fixed the indentation.There are a variety of indentation styles found. a) 4 spaces + '---help---' b) 7 spaces + '---help---' c) 8 spaces + '---help---' d) 1 space + 1 tab + '---help---' e) 1 tab + '---help---' (correct indentation) f) 1 tab + 1 space + '---help---' g) 1 tab + 2 spaces + '---help---'In order to convert all of them to 1 tab + 'help', I ran thefollowing commend: $ find . -name 'Kconfig*' | xargs sed -i 's/^[[:space:]]*---help---/\thelp/'Signed-off-by: Masahiro Yamada List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

ec8f24b7 - treewide: Add SPDX license identifier - Makefile/Kconfig

Sun, 19 May 2019 12:07:45 +0000

treewide: Add SPDX license identifier - Makefile/KconfigAdd SPDX license identifiers to all Make/Kconfig files which: - Have no license information of any formThese files fall under the project license, GPL v2 only. The resulting SPDXlicense identifier is: GPL-2.0-onlySigned-off-by: Thomas Gleixner Signed-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

8ee0c05a - HID: i2c-hid: enhance Kconfig

Tue, 04 Dec 2012 15:27:44 +0000

HID: i2c-hid: enhance KconfigThe "comment" part can never be displayed, so we can remove it.Signed-off-by: Benjamin Tissoires Reviewed-by: Jean Delvare Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig

4a200c3b - HID: i2c-hid: introduce HID over i2c specification implementation

Mon, 12 Nov 2012 14:42:59 +0000

HID: i2c-hid: introduce HID over i2c specification implementationMicrosoft published the protocol specification of HID over i2c:http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspxThis patch introduces an implementation of this protocol.This implementation does not includes the ACPI part of the specification.This will come when ACPI 5.0 devices enumeration will be available.Once the ACPI part is done, OEM will not have to declare HID over I2Cdevices in their platform specific driver.Signed-off-by: Benjamin Tissoires Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/i2c-hid/Kconfig