Changes in hid-magicmouse.c

8fa7292f - treewide: Switch/rename to timer_delete[_sync]()

Sat, 05 Apr 2025 08:17:26 +0000

treewide: Switch/rename to timer_delete[_sync]()timer_delete[_sync]() replaces del_timer[_sync](). Convert the whole treeover and remove the historical wrapper inlines.Conversion was done with coccinelle plus manual fixups where necessary.Signed-off-by: Thomas Gleixner Signed-off-by: Ingo Molnar List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

86b05bb2 - HID: magicmouse: Update device name for Apple Magic Trackpad

Mon, 02 Dec 2024 06:06:56 +0000

HID: magicmouse: Update device name for Apple Magic TrackpadUpdated the device name for Apple Magic Trackpad USB-C when connected viaBluetooth.This change ensures the correct recognition of the 2024 USB-C trackpad andimproves user experience.Signed-off-by: Qingyan Li Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

87a2f103 - HID: magicmouse: Apple Magic Trackpad 2 USB-C driver support

Mon, 11 Nov 2024 21:49:28 +0000

HID: magicmouse: Apple Magic Trackpad 2 USB-C driver supportAdds driver support for the USB-C model of Apple's Magic Trackpad 2.The 2024 USB-C model is compatible with the existing Magic Trackpad 2driver but has a different hardware ID.Link: https://bugzilla.kernel.org/show_bug.cgi?id=219470Signed-off-by: Callahan Kovacs Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

fe73965d - HID: change return type of report_fixup() to const

Sat, 03 Aug 2024 12:34:22 +0000

HID: change return type of report_fixup() to constBy allowing the drivers to return a "const *" they can constify theirstatic report arrays.This makes it clear to driver authors that the HID core will not modifythose reports and they can be reused for multiple devices.Furthermore security is slightly improved as those reports are protectedagainst accidental or malicious modifications.[bentiss: fixup hid-cougar.c and hid-multitouch.c for latest version ofthe master branch]Signed-off-by: Thomas Weißschuh Link: https://patch.msgid.link/20240803-hid-const-fixup-v2-6-f53d7a7b29d8@weissschuh.netSigned-off-by: Benjamin Tissoires List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

9d262f35 - HID: add missing MODULE_DESCRIPTION() macros

Tue, 04 Jun 2024 22:10:23 +0000

HID: add missing MODULE_DESCRIPTION() macrosmake allmodconfig && make W=1 C=1 reports:WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-a4tech.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-apple.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-aureal.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-belkin.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-betopff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-bigbenff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cherry.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-chicony.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cypress.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-dr.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-emsff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-elecom.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-elo.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-evision.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ezkey.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-vivaldi-common.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-google-hammer.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-google-stadiaff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-gyration.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-kbd.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-logitech.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-magicmouse.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-maltron.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-mf.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-megaworld.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-microsoft.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-monterey.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ntrig.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ortek.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-prodikeys.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-pl.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-petalynx.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-primax.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-razer.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-redragon.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-retrode.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-saitek.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-samsung.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-semitek.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sjoy.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sony.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-speedlink.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-steam.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-steelseries.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sunplus.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-gaff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-tmff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-tivo.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-topseed.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-twinhan.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-uclogic.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-xinmo.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-zpff.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-zydacron.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-viewsonic.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-waltop.oWARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.oAdd the missing invocations of the MODULE_DESCRIPTION() macro.Note: All HID drivers that had explicit entries in the MAINTAINERSfile were fixed individually. This patch fixes all remaining HIDdrivers that fall under the generic "HID CORE LAYER" entry in theMAINTAINERS file. Almost all descriptions were taken from the headercomment in each file.Signed-off-by: Jeff Johnson Link: https://lore.kernel.org/r/20240604-md-hid-misc-v1-1-4f9560796f3c@quicinc.comSigned-off-by: Benjamin Tissoires List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

b0a1fe46 - HID: magicmouse: fix kerneldoc for struct magicmouse_sc

Wed, 27 Dec 2023 11:08:45 +0000

HID: magicmouse: fix kerneldoc for struct magicmouse_scDescription for hdev, work and battery_timer of struct magicmouse_sc weremissing. Fix that.Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312261056.AmFPDIL5-lkp@intel.com/Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

bb5f0c85 - HID: magicmouse: Do not set BTN_MOUSE on double report

Sun, 09 Oct 2022 18:27:47 +0000

HID: magicmouse: Do not set BTN_MOUSE on double reportUnder certain conditions the Magic Trackpad can group 2 reports in asingle packet. The packet is split and the raw event function isinvoked recursively for each part.However, after processing each part, the BTN_MOUSE status is updated,sending multiple click events. [1]Return after processing double reports to avoid this issue.Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/811 # [1]Fixes: a462230e16ac ("HID: magicmouse: enable Magic Trackpad support")Reported-by: Nulo Signed-off-by: José Expósito Signed-off-by: Benjamin Tissoires Link: https://lore.kernel.org/r/20221009182747.90730-1-jose.exposito89@gmail.com List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

33812fc7 - HID: magicmouse: Fix an error handling path in magicmouse_probe()

Tue, 28 Dec 2021 21:09:17 +0000

HID: magicmouse: Fix an error handling path in magicmouse_probe()If the timer introduced by the commit below is started, then it must bedeleted in the error handling of the probe. Otherwise it would triggeronce the driver is no more.Fixes: 0b91b4e4dae6 ("HID: magicmouse: Report battery level over USB")Signed-off-by: Christophe JAILLET Tested-by: José Expósito Reported-by: Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

5768701e - HID: magicmouse: set Magic Trackpad 2021 name

Sun, 12 Dec 2021 18:21:00 +0000

HID: magicmouse: set Magic Trackpad 2021 nameThe Apple Magic Trackpad 2021 (3rd generation) has the same product IDas the 2nd generation. However, when connected through Bluetooth, theversion has changed from 0x107 to 0x110.The other meaningful change is that the name has dropped the generationnumber and now it is just "Apple Inc. Magic Trackpad", like the firstgeneration model.Set the device name correctly to ensure the same driver settings areloaded, whether connected via Bluetooth or USB.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

0aa45fcc - HID: magicmouse: set device name when it has been personalized

Sun, 12 Dec 2021 18:20:59 +0000

HID: magicmouse: set device name when it has been personalizedIf the Apple Magic Trackpad 2 has been connected to a Mac, the nameis automatically personalized showing its owner name. For example:"José Expósito's Trackpad".When connected through Bluetooth, the personalized name is reported,however, when connected through USB the generic name is reported.Set the device name correctly to ensure the same driver settings areloaded, whether connected via Bluetooth or USB.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

0b91b4e4 - HID: magicmouse: Report battery level over USB

Thu, 18 Nov 2021 16:52:08 +0000

HID: magicmouse: Report battery level over USBWhen connected over USB, the Apple Magic Mouse 2 and the Apple MagicTrackpad 2 register multiple interfaces, one of them is used to reportthe battery level.However, unlike when connected over Bluetooth, the battery level is notreported automatically and it is required to fetch it manually.Fix the battery report descriptor and add a timer to fetch the batterylevel.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

a1091118 - HID: magicmouse: prevent division by 0 on scroll

Sun, 14 Nov 2021 02:53:27 +0000

HID: magicmouse: prevent division by 0 on scrollIn hid_magicmouse, if the user has set scroll_speed to a value between55 and 63 and scrolls seven times in quick succession, thestep_hr variable in the magicmouse_emit_touch function becomes 0.That causes a division by zero further down in the function whenit does `step_x_hr /= step_hr`.To reproduce, create `/etc/modprobe.d/hid_magicmouse.conf` with thefollowing content:```options hid_magicmouse scroll_acceleration=1 scroll_speed=55```Then reboot, connect a Magic Mouse and scroll seven times quickly.The system will freeze for a minute, and after that `dmesg` willconfirm that a division by zero occurred.Enforce a minimum of 1 for the variable so the high resolutionstep count can never reach 0 even at maximum scroll acceleration.Fixes: d4b9f10a0eb6 ("HID: magicmouse: enable high-resolution scroll")Signed-off-by: Claudia Pellegrino Tested-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

9d60648c - HID: magicmouse: high-resolution scroll threshold

Wed, 07 Jul 2021 15:58:22 +0000

HID: magicmouse: high-resolution scroll thresholdIn order to avoid triggering involuntary high-resolution scroll eventsdue to tiny touch movement deltas, add a movement threshold.The value chosen for the threshold, about 1.5 ~ 2 mm, is similar to thethreshold used on touchpads by libinput (see libinputevdev-mt-touchpad-gestures.c) to try to keep the scroll experienceconsistent.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

d4b9f10a - HID: magicmouse: enable high-resolution scroll

Wed, 07 Jul 2021 15:58:21 +0000

HID: magicmouse: enable high-resolution scrollThe Magic Mouse, generations 1 and 2, doesn't have a physical scrollwheel, instead, the REL_WHEEL and REL_HWHEEL events are emulatedwhen sliding a finger on the surface of the mouse.However, the smooth movement of the finger is transformed into a stepbased scroll on the screen, leading to a suboptimal user experience.Emulate high-resolution scroll by sending REL_WHEEL_HI_RES andREL_HWHEEL_HI_RES events so the scroll on the screen is closer to thefinger movement.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

4b4f6cec - HID: magicmouse: fix NULL-deref on disconnect

Mon, 17 May 2021 10:04:30 +0000

HID: magicmouse: fix NULL-deref on disconnectCommit 9d7b18668956 ("HID: magicmouse: add support for Apple MagicTrackpad 2") added a sanity check for an Apple trackpad but returnedsuccess instead of -ENODEV when the check failed. This means that theremove callback will dereference the never-initialised driver datapointer when the driver is later unbound (e.g. on USB disconnect).Reported-by: syzbot+ee6f6e2e68886ca256a8@syzkaller.appspotmail.comFixes: 9d7b18668956 ("HID: magicmouse: add support for Apple Magic Trackpad 2")Cc: stable@vger.kernel.org # 4.20Cc: Claudio Mettler Cc: Marek Wyborski Cc: Sean O'Brien Signed-off-by: Johan Hovold Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

4fb12519 - HID: magicmouse: fix crash when disconnecting Magic Trackpad 2

Mon, 10 May 2021 06:22:37 +0000

HID: magicmouse: fix crash when disconnecting Magic Trackpad 2When the Apple Magic Trackpad 2 is connected over USB it registers fourhid_device report descriptors, however, the driver only handles the onewith type HID_TYPE_USBMOUSE and ignores the other three, thus, no driverdata is attached to them.When the device is disconnected, the remove callback is called for thefour hid_device report descriptors, crashing when the driver data isNULL.Check that the driver data is not NULL before using it in the removecallback.Signed-off-by: José Expósito Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

c0dc5582 - HID: magicmouse: fix reconnection of Magic Mouse 2

Tue, 30 Mar 2021 11:33:18 +0000

HID: magicmouse: fix reconnection of Magic Mouse 2It is observed that the Magic Mouse 2 would not enter multi-touch modeunless the mouse is connected before loading the module. It seems to bea quirk specific to Magic Mouse 2Retrying after 500ms fixes the problem for me. The delay can't bereduced much further --- 300ms didn't work for me. Retrying immediatelyafter receiving an event didn't work either.Signed-off-by: John Chen Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

3dcc5f7b - HID: magicmouse: fix 3 button emulation of Mouse 2

Tue, 30 Mar 2021 11:33:17 +0000

HID: magicmouse: fix 3 button emulation of Mouse 2It is observed that, with 3 button emulation, when middle button isclicked, either the left button or right button is clicked as well. Itis caused by hidinput "correctly" acting on the event, oblivious to the3 button emulation.As raw_event has taken care of everything, no further processing isneeded. However, the only way to stop at raw_event is to return an error(negative) value. Therefore, the processing is stopped at event instead.[jkosina@suse.cz: fix comment style]Signed-off-by: John Chen Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

2b0c086c - HID: magicmouse: add Apple Magic Mouse 2 support

Tue, 30 Mar 2021 11:33:16 +0000

HID: magicmouse: add Apple Magic Mouse 2 supportBluetooth device Vendor 004c (Apple) Device 0269 (Magic Mouse 2)Add support for Apple Magic Mouse 2, putting the device in multi-touchmode.Co-authored-by: Rohit Pidaparthi Co-authored-by: RicardoEPRodrigues Signed-off-by: John Chen Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c

6363d206 - HID: magicmouse: do not set up autorepeat

Sun, 24 May 2020 23:51:34 +0000

HID: magicmouse: do not set up autorepeatNeither the trackpad, nor the mouse want input core to generate autorepeatevents for their buttons, so let's reset the bit (as hid-input sets it forthese devices based on the usage vendor code).Cc: stable@vger.kernel.orgReported-by: Yariv Tested-by: Yariv Signed-off-by: Dmitry Torokhov Signed-off-by: Jiri Kosina List of files: /linux-6.15/drivers/hid/hid-magicmouse.c