Changes in ipu-pre.c

e70140ba - Get rid of 'remove_new' relic from platform driver struct

Sun, 01 Dec 2024 23:12:43 +0000

Get rid of 'remove_new' relic from platform driver structThe continual trickle of small conversion patches is grating on me, andis really not helping. Just get rid of the 'remove_new' memberfunction, which is just an alias for the plain 'remove', and had acomment to that effect: /* * .remove_new() is a relic from a prototype conversion of .remove(). * New drivers are supposed to implement .remove(). Once all drivers are * converted to not use .remove_new any more, it will be dropped. */This was just a tree-wide 'sed' script that replaced '.remove_new' with'.remove', with some care taken to turn a subsequent tab into two tabsto make things line up.I did do some minimal manual whitespace adjustment for places that usedspaces to line things up.Then I just removed the old (sic) .remove_new member function, and thisis the end result. No more unnecessary conversion noise.Signed-off-by: Linus Torvalds List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

d5316cdd - gpu: ipu-v3: pre: don't use fixed timeout when waiting for safe window

Fri, 17 May 2024 10:45:49 +0000

gpu: ipu-v3: pre: don't use fixed timeout when waiting for safe windowThe timeout when waiting for the PRE safe window is rather short, asnormally we would only need to wait a few dozen usecs for the problematicscanline region to pass and we don't want to spin too long in casesomething goes wrong. This however mixes badly with preemption, as wecan easily get scheduled away from the CPU for a longer time than ourtimeout, in which case we would hit a spurious timeout and wrongly skipthe PRE update.Instead of disabling preemption across the wait loop, potentiallyimpacting the overall system latency, use a wait loop with a fixedmax number of iterations, so time spent away from the CPU is notaccounted against the timeout budget.Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Link: https://lore.kernel.org/r/20240517104549.3648939-3-l.stach@pengutronix.deSigned-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20240517104549.3648939-3-l.stach@pengutronix.de List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

4dbc7d5d - gpu: ipu-v3: pre: add dynamic buffer layout reconfiguration

Fri, 17 May 2024 10:45:48 +0000

gpu: ipu-v3: pre: add dynamic buffer layout reconfigurationimx-drm doesn't mandate a modeset when the framebuffer modifier changes,but currently the tile prefetch and resolve (TPR) configuration of thePRE is only set up on the initial modeset.As the TPR configuration is double buffered, same as all the other PREstates, we can support dynamic reconfiguration of the buffer layout fromone frame to another. As switching between (super-)tiled and linearprefetch needs to touch the CTRL register make sure to do thereconfiguration inside the safe window.Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Link: https://lore.kernel.org/r/20240517104549.3648939-2-l.stach@pengutronix.deSigned-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20240517104549.3648939-2-l.stach@pengutronix.de List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

ee7ff5e2 - gpu: ipu-v3: pre: move state into struct

Fri, 17 May 2024 10:45:47 +0000

gpu: ipu-v3: pre: move state into structMove the variables tracking the current dynamic state into a structto separate it a bit better from the static device properties.Signed-off-by: Lucas Stach Reviewed-by: Philipp Zabel Link: https://lore.kernel.org/r/20240517104549.3648939-1-l.stach@pengutronix.deSigned-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20240517104549.3648939-1-l.stach@pengutronix.de List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

81112c6f - gpu: ipu-v3: pre: replace of_node_put() with __free

Sat, 27 Apr 2024 04:50:24 +0000

gpu: ipu-v3: pre: replace of_node_put() with __freeuse the new cleanup magic to replace of_node_put() with__free(device_node) marking to auto release when they get out of scope.Suggested-by: Julia Lawall Signed-off-by: R Sundar Reviewed-by: Philipp Zabel Link: https://lore.kernel.org/r/20240427045024.7083-1-prosunofficial@gmail.comSigned-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20240427045024.7083-1-prosunofficial@gmail.com List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

4402a5aa - gpu: ipu-v3: Convert to platform remove callback returning void

Tue, 09 Apr 2024 17:02:51 +0000

gpu: ipu-v3: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert the ipu-v3 platform drivers from always returning zeroin the remove callback to the void returning variant.Reviewed-by: Philipp Zabel Reviewed-by: Thomas Zimmermann Link: https://lore.kernel.org/r/dee3c0e1c8c6bd1027a91c65be55ac1d6ba9e099.1712681770.git.u.kleine-koenig@pengutronix.deSigned-off-by: Uwe Kleine-König List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

98935088 - gpu: ipu-v3: pre: Convert to devm_platform_ioremap_resource()

Mon, 10 Jul 2023 03:23:38 +0000

gpu: ipu-v3: pre: Convert to devm_platform_ioremap_resource()Use devm_platform_ioremap_resource() to simplify code.Signed-off-by: Yangtao Li Reviewed-by: Philipp Zabel Link: https://lore.kernel.org/r/20230710032355.72914-2-frank.li@vivo.comSigned-off-by: Philipp Zabel Link: https://patchwork.freedesktop.org/patch/msgid/20230710032355.72914-2-frank.li@vivo.com List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

2025cf9e - treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288

Wed, 29 May 2019 14:18:02 +0000

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 288Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms and conditions of the gnu general public license version 2 as published by the free software foundation this program is distributed in the hope it will be useful but without any warranty without even the implied warranty of merchantability or fitness for a particular purpose see the gnu general public license for more detailsextracted by the scancode license scanner the SPDX license identifier GPL-2.0-onlyhas been chosen to replace the boilerplate/reference in 263 file(s).Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Alexios Zavras Cc: linux-spdx@vger.kernel.orgLink: https://lkml.kernel.org/r/20190529141901.208660670@linutronix.deSigned-off-by: Greg Kroah-Hartman List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

0a29b1ab - gpu: ipu-v3: pre: add double buffer status readback

Tue, 11 Sep 2018 13:20:34 +0000

gpu: ipu-v3: pre: add double buffer status readbackThis allows the upper layers to check if a double buffer update hasbeen applied by the PRE or is still pending.Signed-off-by: Lucas Stach [p.zabel@pengutronix.de: inverted logic: done -> pending]Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

eb0200a4 - gpu: ipu-v3: pre: don't trigger update if buffer address doesn't change

Tue, 18 Dec 2018 15:46:29 +0000

gpu: ipu-v3: pre: don't trigger update if buffer address doesn't changeOn a NOP double buffer update where current buffer address is the sameas the next buffer address, the SDW_UPDATE bit clears too late. As weare now using this bit to determine when it is safe to signal flipcompletion to userspace this will delay completion of atomic commitswhere one plane doesn't change the buffer by a whole frame period.Fix this by remembering the last buffer address and just skip thedouble buffer update if it would not change the buffer address.Signed-off-by: Lucas Stach [p.zabel@pengutronix.de: initialize last_bufaddr in ipu_pre_configure]Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

e88728f4 - driver core: Rename flag AUTOREMOVE to AUTOREMOVE_CONSUMER

Wed, 27 Jun 2018 12:50:55 +0000

driver core: Rename flag AUTOREMOVE to AUTOREMOVE_CONSUMERNow that we want to add another flag to autoremove the device linkon supplier unbind, it's fair to rename the existing flag fromDL_FLAG_AUTOREMOVE to DL_FLAG_AUTOREMOVE_CONSUMER so that we canadd similar flag for supplier later.And, while we are touching device.h, fix a doc build warning.Signed-off-by: Vivek Gautam Reviewed-by: Ulf Hansson Signed-off-by: Rafael J. Wysocki List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

c795f305 - gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandle

Thu, 15 Feb 2018 14:34:55 +0000

gpu: ipu-v3: pre: fix device node leak in ipu_pre_lookup_by_phandleBefore returning, call of_node_put() for the device node returned byof_parse_phandle().Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine")Signed-off-by: Tobias Jordan Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

2f64a554 - gpu: ipu-v3: pre: add tiled prefetch support

Fri, 10 Nov 2017 16:09:58 +0000

gpu: ipu-v3: pre: add tiled prefetch supportThis configures the TPR unit, using the DRM format modifier. For now onlythe single buffer modifiers are supported, as split buffer needs moreconfiguration for the required cropping.Signed-off-by: Lucas Stach [p.zabel@pengutronix.de: rebased after ERR009624 workaround]Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

11aff4b4 - gpu: ipu-v3: pre: implement workaround for ERR009624

Mon, 18 Sep 2017 15:45:07 +0000

gpu: ipu-v3: pre: implement workaround for ERR009624The PRE has a bug where a software write to the CTRL register can blockthe setting of the ENABLE bit by the hardware in auto repeat mode. Whenthis happens the PRE will fail to handle new jobs. To work around thissoftware must not write to CTRL register when the PRE store engine isinside the unsafe window, where a hardware update to the ENABLE bitmay happen.Signed-off-by: Lucas Stach [p.zabel@pengutronix.de: rebased before PRE tiled prefetch support]Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

47c298f7 - gpu: ipu-v3: pre: only use internal clock gating

Wed, 03 May 2017 08:38:18 +0000

gpu: ipu-v3: pre: only use internal clock gatingBy setting the SFTRST bit, the PRE will be held in the lowest power statewith clocks to the internal blocks gated. When external clock gating isused (from the external clock controller, or by setting the CLKGATE bit)the PRE will sporadically fail to start.Signed-off-by: Lucas Stach Fixes: d2a34232580a ("gpu: ipu-v3: add driver for Prefetch Resolve Engine")Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c

d2a34232 - gpu: ipu-v3: add driver for Prefetch Resolve Engine

Wed, 08 Mar 2017 11:13:14 +0000

gpu: ipu-v3: add driver for Prefetch Resolve EngineThis adds support for the i.MX6 QuadPlus PRE units. Currently onlylinear prefetch into SRAM is supported, other modes of operationlike the tiled-to-linear conversion will be added later.Signed-off-by: Lucas Stach Signed-off-by: Philipp Zabel List of files: /linux-6.15/drivers/gpu/ipu-v3/ipu-pre.c