Changes in xe_device_sysfs.c

83e3d087 - drm/xe: Stop setting drvdata to NULL

Sat, 22 Feb 2025 00:10:44 +0000

drm/xe: Stop setting drvdata to NULLPCI subsystem is not supposed to call the remove() function when probefails and doesn't need a protection for that. The only places checkingfor NULL drvdata, is on 2 sysfs files and they shouldn't be needed sincethe files are removed and reads on open fds just return an error.For this protection the core driver implementation indrivers/base/dd.c:device_unbind_cleanup() already sets it to NULL, afterthe release of dev resources.Remove the setting to NULL so it's possible to obtain the xe pointerfrom callbacks like the component unbind from device_unbind_cleanup(),i.e. after xe_pci_remove() already finished.Reviewed-by: Rodrigo Vivi Reviewed-by: Jonathan Cavitt Link: https://patchwork.freedesktop.org/patch/msgid/20250222001051.3012936-5-lucas.demarchi@intel.comSigned-off-by: Lucas De Marchi List of files: /linux-6.15/drivers/gpu/drm/xe/xe_device_sysfs.c

c60f91bb - drm/xe: covert sysfs over to devm

Wed, 22 May 2024 10:21:45 +0000

drm/xe: covert sysfs over to devmHotunplugging the device seems to result in stuff like:kobject_add_internal failed for tile0 with -EEXIST, don't try toregister things with the same name in the same directory.We only remove the sysfs as part of drmm, however that is tied to thelifetime of the driver instance and not the device underneath. Attemptto fix by using devm for all of the remaining sysfs stuff related to thedevice.Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1667Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1432Signed-off-by: Matthew Auld Cc: Rodrigo Vivi Reviewed-by: Andrzej Hajda Link: https://patchwork.freedesktop.org/patch/msgid/20240522102143.128069-20-matthew.auld@intel.com List of files: /linux-6.15/drivers/gpu/drm/xe/xe_device_sysfs.c

c086bfc6 - drm/xe/pm: Capture errors and handle them

Fri, 12 Apr 2024 18:12:11 +0000

drm/xe/pm: Capture errors and handle themxe_pm_init may encounter failures for various reasons, such as a failurein initializing drmm_mutex, or when dealing with a d3cold-capable devicefor vram_threshold sysfs creation and setting default threshold.Presently, all these potential failures are disregarded.Move d3cold.lock initialization to xe_pm_init_early and cause driverabort if mutex initialization has failed.For xe_pm_init failures cleanup the driver and return error code-v2Make mutex init cleaner (Lucas)Cc: Lucas De Marchi Cc: Rodrigo Vivi Signed-off-by: Himal Prasad Ghimiray Reviewed-by: Lucas De Marchi Link: https://patchwork.freedesktop.org/patch/msgid/20240412181211.1155732-8-himal.prasad.ghimiray@intel.comSigned-off-by: Lucas De Marchi List of files: /linux-6.15/drivers/gpu/drm/xe/xe_device_sysfs.c

3f0e1465 - drm/xe: Runtime PM wake on every sysfs call

Thu, 22 Feb 2024 16:39:28 +0000

drm/xe: Runtime PM wake on every sysfs callLet's ensure our PCI device is awaken on every sysfs call.Let's increase the runtime_pm protection and start movingthat to the outer bounds.For now, for the files with small number of attr functions,let's only call the runtime pm functions directly.For the hw_engines entries with many files, let's addthe sysfs_ops wrapper.Reviewed-by: Matthew Auld Signed-off-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/20240222163937.138342-5-rodrigo.vivi@intel.com List of files: /linux-6.15/drivers/gpu/drm/xe/xe_device_sysfs.c

b2d75619 - drm/xe/pm: Add vram_d3cold_threshold Sysfs

Tue, 18 Jul 2023 08:07:01 +0000

drm/xe/pm: Add vram_d3cold_threshold SysfsAdd per pci device vram_d3cold_threshold Sysfs tocontrol the d3cold allowed knob.Adding a d3cold structure embedded in xe_device to encapsulated3cold related stuff.v2:- Check total vram before initializing default threshold. [Riana]- Add static scope to vram_d3cold_threshold DEVICE_ATTR. [Riana]v3:- Fixed cosmetics review comment. [Riana]- Fixed CI Hook failures.- Used drmm_mutex_init().v4:- Fixed kernel-doc warnings.v5:- Added doc explaining need for the device sysfs. [Rodrigo]- Removed TODO comment.Cc: Rodrigo Vivi Signed-off-by: Anshuman Gupta Reviewed-by: Riana Tauro Acked-by: Rodrigo Vivi Link: https://patchwork.freedesktop.org/patch/msgid/20230718080703.239343-4-anshuman.gupta@intel.comSigned-off-by: Rodrigo Vivi List of files: /linux-6.15/drivers/gpu/drm/xe/xe_device_sysfs.c